Commit Graph
8150 Commits
Author SHA1 Message Date
azizr12 350b6904ec Update i18n.rs 2026-10-28 07:57:57 +00:00
Claude 30abc52781 Merge storytold/photocraft main into the Fill/Stroke popover branch
Upstream's strict-Clippy refactor removed glob imports and split the
Content-Aware Fill properties into caf_props_panel: the swatch title moved
there, and the frame loop calls crate::color_picker_ui::widget_tick.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TYsCL5E2GM6hUabP9dmYAv
2026-10-28 07:55:52 +00:00
azizr12 d825abbd75 Merge branch 'storytold:main' into main 2026-10-28 07:44:07 +00:00
azizr12 36c5e7207c fix 2026-10-28 07:34:49 +00:00
Ikki Nishihara 1dc98f80f6 docs(control): associate brush mode gesture with ui.pointer
Signed-off-by: Ikki Nishihara <223786623+haranishi@users.noreply.github.com>
2026-10-28 16:24:15 +09:00
Ikki Nishihara ca17e9b627 Merge current main and preserve brush mode picker behavior
Signed-off-by: Ikki Nishihara <223786623+haranishi@users.noreply.github.com>
2026-10-28 15:55:25 +09:00
Brennan StehlingandClaude Opus 5.5 c855685c7f test: cover group and clip-base effect damage, and mask undo coverage (#9329)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:09:58 -07:00
Brennan StehlingandClaude Opus 5.5 2119158a5e perf: a pixel change damages only the tiles that changed; command rects become checked hints (#9329)
step_damage narrows a layer whose only change is in its surfaces (pixels, mask, type,
smart-object and fill caches) to the bounding box of the tiles that differ: a merge walk of
the two tile maps, pointer compares only. A mask's tiles grow by its feather, all of them by
the layer's effects and the effects of the groups around it, never past the layer's whole
extents. A frame-spanning effect whose frame moved keeps the whole extents (#4053). Undo,
redo and History jumps get it for free: undoing a 60 px dab on a full-canvas layer redraws
its tiles, not the canvas, and so does a fill or filter on a small selection.

The painting commands' own damage rects go through one door, Session::hint_damage, which
intersects them with the edit's damage. Debug and test builds count a hint that misses a
changed tile in Session::damage_misses and log it; nothing panics. refresh_type_layers reports
step_damage instead of None.

Deleted: note_damage and layers_damage (identical to step_damage after layer.setProps and
layer.translate), note_inert_insert (step_damage already steps over inert layers, #1771),
and the engine's siblings_of they used.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:09:58 -07:00
Brennan StehlingandClaude Opus 5.5 a9c26551f1 perf: add P81/P82 redraw-area rows on full-canvas layers (#9329)
Track-only rows that check they hit the whole-document-redraw path and
print the refreshed pixel count: undo of a brush dab on a 16-bit
15000x10000 full-canvas layer (reps capped at 5) and a fill of a 2 %
selection on a 24 MP full-canvas layer.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:08:30 -07:00
Brennan StehlingandClaude Opus 5.5 fc6d8b0ec2 Perf: a frame counts each command once, and every frame closes its stage record (#9328)
Only the outermost run_command writes the frame's command stage, so a nested
run (file.save -> layer.smartObjects.saveContents, actions.play -> its view
steps) isn't counted twice. ui_frame's UI moves into ui_body and finish_frame
runs after it on every path, including the screen picker's wait modal; the
pass before fonts are ready closes it too.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:08:27 -07:00
Brennan StehlingandClaude Opus 5.5 ce8f3e719e Docs: perf.slowFrames, and the stroke trace reads the shared frame stages (#9328)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:08:06 -07:00
Brennan StehlingandClaude Opus 5.5 b1ffb9a423 Control: perf lists the last slow frames and their stages as slowFrames (#9328)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:07:54 -07:00
Brennan StehlingandClaude Opus 5.5 5c94fb2074 Perf: every frame records its stages, slow ones are kept and logged; the stroke trace reads the same record (#9328)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 23:07:39 -07:00
Brennan Stehling 00522c852e Perf: P80, app frame time for a full CPU refresh of a 24 MP document (#9328)
Track-only row, the slow-frame recorder's worst case. A 24 MP photo plus
three full-canvas blended copies (Multiply, Screen, Overlay); each sample
toggles the top copy and times one harness.step(), so every frame
recomposites all 24 MP on the CPU (the photo's tiles are never uniform,
which keeps the reduced render's one-colour shortcut out of the way).
The row errors unless each frame recorded a CPU refresh covering at least
95 % of the canvas, so it can't silently take a fast path. 10 samples.
2026-10-27 23:06:56 -07:00
aiongg 1f7fc0f536 Merge pull request #6463 from osaidahmed/split-filter-adjust-crop-fx-builders
refactor: split oversized filter, adjustment, crop and effect builders
2026-10-28 01:01:25 -04:00
aiongg 2b1c6b93c3 Merge main into split-filter-adjust-crop-fx-builders
crop_ui.rs moved to tools/; the PR's builders replace main's Clippy extractions of the same code; #6723's Color Lookup save carried into the moved encoder.
2026-10-28 04:22:40 +00:00
aiongg d453c7d12b Merge pull request #9564 from brennanMKE/perf/7494-baseline-guard
xtask perf: a baseline knows how trustworthy it is (#7494)
2026-10-27 23:56:45 -04:00
Khawar Zamman Wani 4af5b3a669 Split Select and Mask's workspace closure into paint/cursor/input helpers (cognitive complexity) 2026-10-28 09:26:13 +05:30
Khawar Zamman Wani b18274f6d7 Fix imports lost in the vector_ui module split; Esc handler returns bool 2026-10-28 09:25:56 +05:30
Khawar Zamman Wani a2364b20d0 Fix imports lost when transform_tool was split into a module tree 2026-10-28 09:25:49 +05:30
Khawar Zamman Wani 8b835a103c Merge origin/main into pen-path-operations 2026-10-28 09:22:55 +05:30
Khawar Zamman Wani e729ead4b2 Merge origin/main into fix/6501-multi-layer-free-transform 2026-10-28 09:22:55 +05:30
Khawar Zamman Wani 0ce7991aaa Merge origin/main into fix/8169-huge-tiff-open 2026-10-28 09:22:54 +05:30
Khawar Zamman Wani 4e22d214dc Merge origin/main into select-mask-workspace 2026-10-28 09:22:54 +05:30
Khawar Zamman Wani eccc20d1b2 Merge origin/main into perf/cropped-selection-blurs 2026-10-28 09:22:52 +05:30
aiongg 54f7f2c374 Merge pull request #9566 from brennanMKE/perf/9328-fallback-reason
Render path: one place records why a view left the GPU (#9328)
2026-10-27 23:52:38 -04:00
aiongg b4e69af424 Merge main into perf/9328-fallback-reason 2026-10-28 03:00:01 +00:00
aiongg af0d8a5cc4 Merge main into perf/7494-baseline-guard 2026-10-28 02:56:50 +00:00
Dylan M. Taylor d5be9b8aef Merge pull request #9770 from dylanmtaylor/sonar/enforce-clippy-standards
Enforce Rust coding standards via Clippy
2026-10-27 22:55:30 -04:00
Khawar Zamman Wani fe6b95f172 fix(ci): compare padded mixer benchmark rows 2026-10-28 08:21:22 +05:30
Khawar Zamman Wani 5f03f1424b perf(paint): skip dry mixer canvas sampling 2026-10-28 08:09:49 +05:30
aiongg a9e6f73ac5 Merge remote-tracking branch 'upstream/main' into HEAD 2026-10-28 02:31:52 +00:00
aiongg 386b7b8d8e Merge pull request #9565 from brennanMKE/perf/7494-cliff-rows
Perf: cliff rows for the CPU compositor, Advanced Blending, adjustment toggles, over-budget and huge documents (#7494)
2026-10-27 22:31:34 -04:00
Khawar Zamman Wani aae87d353a perf(algo): solve Adaptive Wide Angle's mesh with a factor-once direct solve
The mesh warp's least squares was solved by CGLS, which ran its whole iteration
budget on an ill-conditioned system. The static shape and anchor terms are now
assembled once per solve and factored with a banded Cholesky, and each round adds
the constraint lines as an exact low-rank update (conjugate gradients remain as the
fallback). Csr and BandChol move from puppet.rs to photo_util.rs so both share them.
2026-10-28 07:52:44 +05:30
aiongg 594a28b335 Render path: a raised GPU Memory ends GPU Memory Full; a flipped view keeps its own slot (#9328)
A measured fit that fits ends the document's over-budget reason, so the status bar clears as
soon as GPU Memory is raised. A flipped or pixel-aspect-corrected view records its reason in
its own slot: unflipped, the document's own reason (Advanced Blending...) is back rather than
a false "back on the GPU".
2026-10-28 02:19:44 +00:00
aiongg 7008da37ab perf: baseline skips rows missing from some runs 2026-10-28 02:14:22 +00:00
Dylan M. Taylor ab9b27b80d Restore rationale comments dropped by the Clippy refactors 2026-10-28 02:13:42 +00:00
Dylan M. Taylor 163caeb86b Make the PSD size-limit test fail when a size-based PSB promotion happens 2026-10-28 02:13:42 +00:00
Dylan M. Taylor 63eb3eabe4 Drop the unused band_rows export and its dead_code allow from io 2026-10-28 02:13:42 +00:00
Dylan M. Taylor c726a14f0f Restore the Animated Zoom hold gating in canvas navigation 2026-10-28 01:49:51 +00:00
Dylan M. Taylor 1a3415608b Restore the PSD frame stroke import after the io refactor 2026-10-28 01:49:51 +00:00
Dylan M. Taylor a9fa2d4673 Refactor photocraft app startup for strict Clippy checks 2026-10-28 01:06:43 +00:00
Dylan M. Taylor 5ad52e6b85 Remove duplicated view-command and type-target code in ui-egui 2026-10-28 01:06:43 +00:00
Dylan M. Taylor f2ac9d28b7 Refactor ui-egui layer and channel panels for strict Clippy checks 2026-10-28 01:06:43 +00:00
Dylan M. Taylor 267fb55e0f Refactor ui-egui canvas and options bar for strict Clippy checks 2026-10-28 01:06:42 +00:00
Dylan M. Taylor de9636f56e Refactor ui-egui dialogs for strict Clippy checks 2026-10-28 01:06:42 +00:00
Dylan M. Taylor 1a6d8ec9e3 Refactor ui-egui control dispatch for strict Clippy checks 2026-10-28 01:06:42 +00:00
Dylan M. Taylor a703ea2781 Restore wasm builds of ui-egui after the Clippy refactor 2026-10-28 01:06:42 +00:00
Dylan M. Taylor 604da9d06b Enforce workspace Clippy standards and document lint policy 2026-10-27 23:47:07 +00:00
Dylan M. Taylor 9800f56dfb Refactor text for strict Clippy checks 2026-10-27 23:47:07 +00:00