Served script fallbacks were appended to every UI font family in the
order they arrived. A Japanese and a Simplified Chinese face both cover
Han, and egui draws a character with the first face in the stack that has
it, so a Chinese interface drew Han with the Japanese face when that one
had arrived first (fetched for a Japanese text layer, say). ui_faces now
puts the interface language's own served face first, so the stack a
language change rebuilds follows the language; and when that face arrives
after another served face, add_ui_face rebuilds the stack the same way
instead of appending. served::fallback_for_language gives the face.
This orders the served faces only; with an interface language that has
no served face (English), they stay in arrival order.
Review finding on #10006.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A served script fallback joins every egui font family, and egui panics on
a configured font it cannot parse: a host answering a font's path with an
error page, or serving a truncated file, stopped the web UI on its next
layout or font rebuild. add_ui_face now checks the face with
cjk::font_face_is_readable first, as the system-font fallbacks are
checked, and leaves an unreadable one out with a warning. The regression
test panicked in epaint's family.rs before the check.
Review finding on #10006.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
serve_fonts asks for the interface language's served script font once per
language, but the font manifest loads asynchronously: when the first frame
ran before it arrived, no fallback was registered yet, the request found
nothing, and an Arabic interface on an English browser stayed without its
font until the language changed. The manifest load now asks for the
interface language's font along with the browser languages'.
Review finding on #10006.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Its translations are part of the combined catalog; this merge records the
branch so the PR closes as merged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Its translations are part of the combined catalog; this merge records the
branch so the PR closes as merged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Adds Swedish (sv, Svenska) as an interface language. The catalog combines
the open Swedish catalogs of #5985 and #9536: each row takes the best of
their translations, with one Swedish term per concept across the UI and
the reference application's established Swedish terms where they are
unambiguous, and the strings added since are filled in. 4,537 rows, every
measured key; plural rule one|other.
Where the rows come from: 2,710 both catalogs agreed on, 979 from #5985,
655 from #9536, 193 written new; 177 of the taken rows
were edited for consistency.
The tests that used sv-SE as an unsupported locale now use sw-KE and
fi-FI, and sv-SE / sv_FI.UTF-8 are positive cases. macOS lists sv in
CFBundleLocalizations.
Fixes#10020.
Co-authored-by: kler <966132+kler@users.noreply.github.com>
Co-authored-by: davvarn <1687962+davvarn@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The web build has no system fonts and embeds no craft fonts, so an Arabic
(or Japanese, Chinese, Korean, Hindi) interface had no font for its labels:
served fonts were registered only in the document text engine. A served
script fallback now also joins the end of every egui font family, and the
font stack theme::install_fonts rebuilds on a language change includes it
again. The web shell asks for the interface language's script font, not
only the browser languages'.
Review finding on #10006.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Conflicts in perf/budgets.toml and docs/scorecard.md: both sides added perf rows (P80 here, P81 and P82 from #9942). Kept all three; scorecard regenerated with cargo xtask scorecard.
egui 0.37 lays text out with the Unicode Bidirectional Algorithm, so the
display-order rewrite #5385 added for egui 0.36 now reverses Arabic and
Hebrew layer names and the in-app title a second time. Names go to egui
as typed; the title line asks for a left-to-right paragraph so
"— PhotoCraft" stays at the right; bidi_text::elide cuts a right-to-left
name at its logical end and egui puts the "…" at the left.
Tests lay the text out with egui and compare glyph positions.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Honor CARGO_BUILD_TARGET in FreeBSD packaging for aarch64 release builds
package.sh took the arch from uname -m. The release VM is an x86_64 guest that
cross-compiles aarch64 with CARGO_BUILD_TARGET set, so an aarch64 build was
named freebsd-x86_64 and read binaries from the host target dir.
Read the arch from CARGO_BUILD_TARGET when it is set, and read binaries from
target/<triple>/release. Skip the man-page example and the --version run when
cross-building, since the aarch64 binaries cannot run on the x86_64 guest.
Unset CARGO_BUILD_TARGET keeps the old behavior.
* Reject unsupported CARGO_BUILD_TARGET and resolve host-tuple in FreeBSD packaging
Accept only x86_64-unknown-freebsd and aarch64-unknown-freebsd. Any other
target exits 2 before any build, so a non-FreeBSD target cannot be packaged
as an x86_64 FreeBSD archive.
Resolve cargo's host-tuple alias to the real host triple before choosing the
binary dir, so the path matches cargo's output.
* Skip the photocraft-cli --version run when CARGO_BUILD_TARGET is set
A target build's binary may not run on the host (aarch64 on the x86_64 VM),
and under set -e the smoke run would fail the release after the archive is
written. The native path (CARGO_BUILD_TARGET unset) still runs it.
Main now carries #9031 (Halftone) and #8923; this branch keeps only what it adds on top: the guard for a setting beside a Gallery stack's effect list, its test, and the PSD open warning for patterns that paint nothing.
CodeRabbit: removing the popover's inline eyedropper dropped the only test
of screen sampling from the shape Fill/Stroke controls. The sample now
waits in the Color Picker until OK, then sets the next shape's colours.
docs/ui-parity.md: the status line's preference count matches the
scorecard (12 of 182).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TYsCL5E2GM6hUabP9dmYAv
- nb.tsv covers every enforced key: menus, tl! literals, blend modes, brush sections, font weights, camera data and the generated preference labels (cargo xtask i18n-coverage: 1905/1905)
- Registered with the one|other plural rule; nb-NO, the macrolanguage no and Nynorsk nn-NO locales resolve to it
- License, attribution and localization docs updated
GrabCut's colour-model grids have few terminal links and short paths, where
BK beats the push/relabel solver the default dispatch picks for graphs of
4096+ nodes. Quick Selection keeps push/relabel.
24 MP synthetic, release, median of 3: Select Subject 480 -> 207 ms,
Object Selection 337 -> 140 ms, Quick Selection unchanged. IoU unchanged.
- The Stroke Color Picker on a shape whose stroke is off (none or 0 px)
previews the stroke its OK turns on, at the enabled width, even for the
colour it opened on (CodeRabbit).
- No Color's diagonal uses the theme's danger token, not a fixed red.
- docs/ui-parity.md: the history entry notes Recently Used Colors is a new
preference, so 12 of 182 do nothing (matching the row).
- The Fill/Stroke swatches clip their checker to the rounded corners, so
dark themes no longer show white specks there (#8741).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TYsCL5E2GM6hUabP9dmYAv