The source scanners in xtask (i18n coverage, scorecard) and engine/tests/it/prefs_usage.rs already walk src/ recursively. The i18n coverage scan also skips directories named tests, as the other two do, so test files moved to foo/tests/*.rs stay out of the key list. The report is unchanged on current main.
craft-ui's docking draws every layout, the default one included, so the
native dock's own renderer no longer runs. Remove dock::show with its
per-frame group and strip records, peek, splitter resize, group and tab
drag and drop; the column height solver it used; DockLayout's move_group
and move_tab, which only it called; panel_docking's drag promotion from
the native strip and its extra strip menu; the card widgets that drew the
native groups and the Pro tab strip; and the tab drag and reorder paths
of the strip the Studio Properties card still uses.
The native dock's state, the commands that change it, the default layout
built from it and workspace loading and saving stay as they are. Tests
of the removed code go; the default-height test runs on the drawn layout.
- Remove blank lines between doc comments or #[test] attributes and the item (S8855, S8856)
- type_tool: drop the redundant else after continue in the IME event arm (S8862)
- ui_state: pass OsStr::to_os_string instead of an equivalent closure (S1612)
- macos packaging: [[ ]] for the attempt test (S7688); bind validate_staple's argument to a local (S7679)
* chore: resolve SonarCloud maintainability issues
* fix: format imports and fix effect_entry argument type
* fix: restore test closure and wildcard import that broke compilation
* refactor: split composite_to_surface to reduce cognitive complexity
a2ab774eb raised the limit for the hover preview test only; on the PR's CI
options_bar_menu_arrows_walk_on_while_recording_recent_fonts then failed the
same way ("Harness::run exceeded max_steps (4). It would have settled after
6 steps", repaints from font_preview.rs:152). Every font picker harness that
opens the menu now allows SETTLE_STEPS (16) frames; Harness::run still fails
if the menu never settles.
Co-authored-by: hectorviov <1501713+hectorviov@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Opening the menu on the current family (#9197) paints rows whose font
samples load over a few frames; on CI's font set that takes 6 steps,
past egui_kittest's default of 4. Raise max_steps as other harnesses do.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Picks up the startup prompt without the glyphs a font may lack (storytold/craft-libs#343, #344): the close mark is painted and the version pill is ASCII, so apps that panic on a missing glyph no longer take the prompt down.
Part of tracking issue storytold/craft-libs#319
uncached_refresh_counts_every_pixel_for_the_current_state counts an 18 MP
document pixel by pixel (the proxy only starts above 16 Mi pixels). In a
debug build on fork CI's loaded Linux runner that took over the 5 s
settle() allowed ("the histogram never settled"); locally it takes well
under a second. settle() returns as soon as the histogram lands, so the
longer limit only matters on a slow machine.
Co-authored-by: mathildalabs <347373177+mathildalabs@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
brush-parity.md, gaps.md and ui-parity.md had 2026-10-25 revision rows
under a 2026-10-23/24 "Last updated" header; the headers now carry the
latest row. gaps.md (24 of 171), ui-parity.md and target-app-parity.md
(46 of 149) quoted stale counts of preferences that do nothing; they now
quote the scorecard's 12 of 178. target-app-parity.md still listed the
Camera Raw Calibration panel as missing, which landed on 2026-10-13
(#5128); the row now names per-camera colour for non-DNG cameras, as
gaps.md G14 does.
Found by CodeRabbit on #9386.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
With a text edit and no selected range, styles_at read the paragraph at
byte 0, so the alignment and direction buttons showed the first
paragraph wherever the caret was: in "First\rSecond" with the second
paragraph right-aligned, a caret in "Second" lit Left. A collapsed caret
now picks the paragraph it is in, as Photoshop's options bar and
Paragraph panel do.
Found by CodeRabbit on #9386.
Co-authored-by: Hector Villarreal <1501713+hectorviov@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The tone histogram cache tag gave HistSource::UpTo(layer) kind 6, which
#3297 also gave the filter-mask Curves target, so both sources of one
layer had the same tag and the cache could hand one's histogram out as
the other's. UpTo now has kind 7, and a test checks every source of a
layer has its own tag.
Found by CodeRabbit on #9386.
Co-authored-by: mathildalabs <347373177+mathildalabs@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
An Alt-press with the Mixer Brush loaded paint and returned, but left
no state for the press: if Alt was let go before egui recognised the
drag, the drag's start reached the tool as a plain press and painted a
Mixer stroke from the sampled point (Alt-press, release Alt, move 20 px,
release: one edit). The press now stays a sample press until it is
released, as #7802 made it for the Brush's Alt eyedropper.
Found by CodeRabbit on #9386.
Co-authored-by: durtyrobbin <76844303+durtyrobbin@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The tests' setup returned None, without a message, when the device
request or the pipeline build failed, so every test passed early: with
a type error appended to camera_raw.wgsl all 13 tests still passed on a
machine with a GPU. A pipeline that doesn't build on a supported adapter
now fails the tests, a missing device skips with a message (and fails
with WGPU_BACKEND set, as in parity.rs), and a naga validation of the
shader fails on runners without a GPU too.
Found by CodeRabbit on #9386.
Co-authored-by: p0rps <134095787+fjamesprice@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>