Commit Graph
6339 Commits
Author SHA1 Message Date
aiongg 3edbb00f0d refactor(algo): move resample.rs tests to resample/tests.rs 2026-10-26 22:30:12 +00:00
aiongg d6e7fcef13 refactor(algo): move art_history.rs tests to art_history/tests.rs 2026-10-26 22:30:12 +00:00
aiongg 812736396f refactor(algo): move panorama.rs parallel_tests to panorama/parallel_tests.rs 2026-10-26 22:30:12 +00:00
aiongg ba7399fe0c refactor(algo): move seam.rs tests to seam/tests.rs 2026-10-26 22:30:12 +00:00
aiongg 5215fe8755 refactor(algo): move stack.rs tests to stack/tests.rs 2026-10-26 22:30:12 +00:00
aiongg 388ad984d5 refactor(algo): move inpaint.rs tests to inpaint/tests.rs 2026-10-26 22:30:12 +00:00
aiongg c602c47dbd refactor(algo): move content_aware.rs tests to content_aware/tests.rs 2026-10-26 22:30:12 +00:00
aiongg 6288f5a8c1 refactor(algo): move blur.rs tests to blur/tests.rs 2026-10-26 22:30:12 +00:00
aiongg a83bd683c2 refactor(algo): move transform.rs tests to transform/tests.rs 2026-10-26 22:30:12 +00:00
aiongg 02d2de4b99 refactor(psd): move patterns.rs tests to patterns/tests.rs 2026-10-26 22:30:12 +00:00
aiongg 363a5797f8 refactor(psd): move compression.rs tests to compression/tests.rs 2026-10-26 22:30:11 +00:00
aiongg d314299d5b refactor(psd): move layer.rs tests to layer/tests.rs 2026-10-26 22:30:11 +00:00
aiongg 35107dccae refactor(psd): move tiff.rs tests to tiff/tests.rs 2026-10-26 22:13:07 +00:00
aiongg 5286968033 refactor(psd): move abr.rs tests to abr/tests.rs 2026-10-26 22:13:07 +00:00
aiongg 893acab66b refactor(io): move smart_map tests to src/smart_map/tests.rs 2026-10-26 22:13:07 +00:00
aiongg 25e8edb784 refactor(xtask): read the i18n registry from i18n.rs 2026-10-26 22:13:07 +00:00
aiongg b7b113352e refactor(ui-egui): move src/i18n/mod.rs to src/i18n.rs 2026-10-26 22:13:07 +00:00
aiongg 640d35c19a refactor(engine): move src/presets/mod.rs to src/presets.rs 2026-10-26 22:13:07 +00:00
aiongg ea6268d736 refactor(codecs): move src/codecs/mod.rs to src/codecs.rs 2026-10-26 22:13:07 +00:00
aiongg 24a11846e6 refactor(codecs): move src/codecs/vp8/mod.rs to src/codecs/vp8.rs 2026-10-26 22:13:07 +00:00
aiongg 6d0692ce53 refactor(algo): move src/segment/mod.rs to src/segment.rs 2026-10-26 22:13:07 +00:00
aiongg df8ffb2a63 test: scan source directories recursively
The source scanners in xtask (i18n coverage, scorecard) and engine/tests/it/prefs_usage.rs already walk src/ recursively. The i18n coverage scan also skips directories named tests, as the other two do, so test files moved to foo/tests/*.rs stay out of the key list. The report is unchanged on current main.
2026-10-26 22:13:07 +00:00
Dylan M. Taylor a0ce166acd refactor: lower cognitive complexity in styles apply, affinity text read and warp identity 2026-10-26 16:01:43 -04:00
skylar taylor-barrick d641b96a52 Merge pull request #9518 from storytold/codex/egui-037-photo-followup-20261025
Preserve locale-aware CJK fonts and migration regressions after #9363
2026-10-26 13:16:03 -06:00
skylar taylor-barrick 3f2229b9ad M0.37: cover CJK fallback and font cache edge cases 2026-10-26 06:42:19 +01:00
skylar taylor-barrick 819d863c4e ci: restore craft-common-actions tracking main 2026-10-26 04:27:36 +01:00
aiongg 59cb4c49bd Panels: remove the native dock's drawing, strip and drag code (#9583)
craft-ui's docking draws every layout, the default one included, so the
native dock's own renderer no longer runs. Remove dock::show with its
per-frame group and strip records, peek, splitter resize, group and tab
drag and drop; the column height solver it used; DockLayout's move_group
and move_tab, which only it called; panel_docking's drag promotion from
the native strip and its extra strip menu; the card widgets that drew the
native groups and the Pro tab strip; and the tab drag and reorder paths
of the strip the Studio Properties card still uses.

The native dock's state, the commands that change it, the default layout
built from it and workspace loading and saving stay as they are. Tests
of the removed code go; the default-height test runs on the drawn layout.
2026-10-25 23:13:32 -04:00
Dylan M. Taylor d3b0a76c3f lint: drop blank lines after doc comments and attributes; tidy IME else, closure, shell tests (#9576)
- Remove blank lines between doc comments or #[test] attributes and the item (S8855, S8856)
- type_tool: drop the redundant else after continue in the IME event arm (S8862)
- ui_state: pass OsStr::to_os_string instead of an equivalent closure (S1612)
- macos packaging: [[ ]] for the attempt test (S7688); bind validate_staple's argument to a local (S7679)
2026-10-25 22:08:50 -04:00
aiongg b078e0e8a6 Panels: review follow-ups to the shared docking and egui 0.37 merges (#9575) 2026-10-25 22:03:26 -04:00
aiongg 6a199e224f Merge pull request #9366 from aiongg/docking-adopt
Panels: move onto craft-ui's shared docking
2026-10-25 21:23:10 -04:00
skylar taylor-barrick bf6e25af9a Use relocated nextest binaries in process integration tests 2026-10-26 01:20:00 +01:00
aiongg da02d0ef2d Merge remote-tracking branch 'upstream/main' into docking-adopt
# Conflicts:
#	Cargo.toml
#	crates/ui-egui/Cargo.toml
2026-10-26 00:12:23 +00:00
aiongg edaa41cf05 Panels: tests find the rail by its own button, since it is drawn inside the canvas panel 2026-10-26 00:07:40 +00:00
aiongg cece50d513 Merge pull request #9386 from davidmann4/integration-batch-8
Integration batch 8: 37 reviewed community PRs on main
2026-10-25 20:04:41 -04:00
skylar taylor-barrick 1a67881144 Use reviewed optional-font coverage setup 2026-10-26 00:56:36 +01:00
Dylan M. Taylor 3877bb1dbe chore: resolve SonarCloud maintainability issues (#9044)
* chore: resolve SonarCloud maintainability issues

* fix: format imports and fix effect_entry argument type

* fix: restore test closure and wildcard import that broke compilation

* refactor: split composite_to_surface to reduce cognitive complexity
2026-10-25 19:38:31 -04:00
skylar taylor-barrick bae0b9d290 Pin coverage workflow with immutable nested actions 2026-10-26 00:32:24 +01:00
skylar taylor-barrick 718950cab6 chore(deps): refresh safe dependency bumps (#9558)
serde_json 1.0.154, proptest 1.12, criterion 0.8, crc32fast 1.5.3, rmcp 3.6,
tokio 1.54.1, base64 0.23 (direct deps), schemars 1.2.3, wat 1.262, libc 0.2.191,
objc2 =0.6.5, arboard 3.7, open 5.4.5, muda =0.21.2, winresource 0.1.34.
2026-10-25 19:30:07 -04:00
skylar taylor-barrick 03993b949f Supply pinned fonts throughout instrumented coverage 2026-10-26 00:21:34 +01:00
skylartaylor f979c0bc68 Stabilize camera preview coverage tests and simplify font prerequisites 2026-10-26 00:06:06 +01:00
ccff1361b5 Integration: the other font picker tests let the menu settle too (#9197)
a2ab774eb raised the limit for the hover preview test only; on the PR's CI
options_bar_menu_arrows_walk_on_while_recording_recent_fonts then failed the
same way ("Harness::run exceeded max_steps (4). It would have settled after
6 steps", repaints from font_preview.rs:152). Every font picker harness that
opens the menu now allows SETTLE_STEPS (16) frames; Harness::run still fails
if the menu never settles.

Co-authored-by: hectorviov <1501713+hectorviov@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-25 23:40:45 +01:00
David MannandClaude Opus 5.5 a2ab774eb4 Tests: the font-menu hover preview test lets the menu settle
Opening the menu on the current family (#9197) paints rows whose font
samples load over a few frames; on CI's font set that takes 6 steps,
past egui_kittest's default of 4. Raise max_steps as other harnesses do.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-25 22:59:53 +01:00
Dylan M. Taylor 5bb8536541 build: pin craft-update to craft-libs main (495e597) (#9548)
Picks up the startup prompt without the glyphs a font may lack (storytold/craft-libs#343, #344): the close mark is painted and the version pill is ASCII, so apps that panic on a missing glyph no longer take the prompt down.

Part of tracking issue storytold/craft-libs#319
2026-10-25 17:55:21 -04:00
skylartaylor f632ef06cb Validate selected font faces before registration 2026-10-25 22:35:20 +01:00
4bb367750e Integration: histogram panel tests wait up to 60 s for a count (#9139)
uncached_refresh_counts_every_pixel_for_the_current_state counts an 18 MP
document pixel by pixel (the proxy only starts above 16 Mi pixels). In a
debug build on fork CI's loaded Linux runner that took over the 5 s
settle() allowed ("the histogram never settled"); locally it takes well
under a second. settle() returns as soon as the histogram lands, so the
longer limit only matters on a slow machine.

Co-authored-by: mathildalabs <347373177+mathildalabs@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-25 22:23:18 +01:00
David MannandClaude Opus 5.5 8aa8e4f0cb Integration: docs status lines follow the revision history
brush-parity.md, gaps.md and ui-parity.md had 2026-10-25 revision rows
under a 2026-10-23/24 "Last updated" header; the headers now carry the
latest row. gaps.md (24 of 171), ui-parity.md and target-app-parity.md
(46 of 149) quoted stale counts of preferences that do nothing; they now
quote the scorecard's 12 of 178. target-app-parity.md still listed the
Camera Raw Calibration panel as missing, which landed on 2026-10-13
(#5128); the row now names per-camera colour for non-DNG cameras, as
gaps.md G14 does.

Found by CodeRabbit on #9386.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-25 21:56:01 +01:00
e9af3b71b6 Integration: the options bar shows the paragraph at a collapsed caret (#9179)
With a text edit and no selected range, styles_at read the paragraph at
byte 0, so the alignment and direction buttons showed the first
paragraph wherever the caret was: in "First\rSecond" with the second
paragraph right-aligned, a caret in "Second" lit Left. A collapsed caret
now picks the paragraph it is in, as Photoshop's options bar and
Paragraph panel do.

Found by CodeRabbit on #9386.

Co-authored-by: Hector Villarreal <1501713+hectorviov@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-25 21:56:01 +01:00
4183f91dda Integration: the Adjustment Composite histogram has its own cache tag (#9139)
The tone histogram cache tag gave HistSource::UpTo(layer) kind 6, which
#3297 also gave the filter-mask Curves target, so both sources of one
layer had the same tag and the cache could hand one's histogram out as
the other's. UpTo now has kind 7, and a test checks every source of a
layer has its own tag.

Found by CodeRabbit on #9386.

Co-authored-by: mathildalabs <347373177+mathildalabs@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-25 21:56:01 +01:00
7664d960e6 Integration: a Mixer Brush Alt-press that loads paint never paints (#3627)
An Alt-press with the Mixer Brush loaded paint and returned, but left
no state for the press: if Alt was let go before egui recognised the
drag, the drag's start reached the tool as a plain press and painted a
Mixer stroke from the sampled point (Alt-press, release Alt, move 20 px,
release: one edit). The press now stays a sample press until it is
released, as #7802 made it for the Brush's Alt eyedropper.

Found by CodeRabbit on #9386.

Co-authored-by: durtyrobbin <76844303+durtyrobbin@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-25 21:56:01 +01:00
bf3ff9ce60 Integration: Camera Raw GPU tests fail on a shader that doesn't build (#6923)
The tests' setup returned None, without a message, when the device
request or the pipeline build failed, so every test passed early: with
a type error appended to camera_raw.wgsl all 13 tests still passed on a
machine with a GPU. A pipeline that doesn't build on a supported adapter
now fails the tests, a missing device skips with a message (and fails
with WGPU_BACKEND set, as in parity.rs), and a naga validation of the
shader fails on runners without a GPU too.

Found by CodeRabbit on #9386.

Co-authored-by: p0rps <134095787+fjamesprice@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-25 21:56:01 +01:00