The gpu group (at most 4 at a time) was chosen by name: every ui-egui
integration test and every test whose path contained canvas, gpu, mip or
type_tool. On main's gate that put about 680 ui-egui tests that never
open a device on four slots.
The group is now photocraft-gpu plus every test in a module named
`gpu_tests` or `<name>_gpu_tests`:
- ui-egui integration tests that draw on a device move to
tests/it/gpu_tests/; mixed files and unit tests keep their GPU tests in
a nested `gpu_tests` module or a `*_gpu_tests` file.
- photocraft-automation's GPU backend tests are `gpu_backend::gpu_tests`.
- batch_export_options checks menus and exported bytes, so it runs on the
CPU canvas instead of a GPU harness.
No test assertion changes. The Windows priority list follows the moved
test names.
The gate's archive of ~98 test binaries would be 10-18 GB compressed, so
every shard restores the dependency cache, builds the tests and runs its
partition (scripts/ci-test-shard.sh). `cargo xtask ci tests` runs the test
steps on $NEXTEST_PARTITION, `ci build` builds exactly what a shard builds
(main's cache warm-up), and `ci doctest` runs in one shard. The `ci archive`
part, the archive's xtask binary and the extraction are gone.
The Linux GPU shard keeps the gpu group alone on lavapipe; shards 2-4 split
the rest. Windows uses six shards: ~55 min of tests on one runner, and its
slowest test alone takes ~9.6 min, so a seventh would not shorten the
slowest shard.
- xtask starts every cargo without the variables `cargo run` sets for xtask
(CARGO_MANIFEST_DIR, CARGO_PKG_*, ...), so a build script that declares
`rerun-if-env-changed` for them (ring) no longer reruns, with the whole
craft facade above it, between builds inside and outside xtask.
- `cargo xtask ci` splits into the gate's parts without a second step list:
`lint` (fmt, egui-fork, clippy, layers, panel-commands, scorecard, wasm,
i18n report), `archive` (test build into the nextest archive, doctests),
`tests --from <dir>` (test and panic_hunt from the extracted archive, on
$NEXTEST_PARTITION; --gpu / --no-gpu select by the gpu test group) and
`build` (cache warm-up). Plain `cargo xtask ci` still runs every step.
PHOTOCRAFT_CI_EXCLUDE leaves packages out of the test build and doctests.
- The `ci` nextest profile's archive carries the xtask binary, so a shard
builds nothing (scripts/ci-test-shard.sh).
- Linux gate: lint leg, one build, four shards. Shard 1 runs the gpu group
alone on lavapipe and checks its output (scripts/ci-gpu-lavapipe.py now
wraps that run); the second GPU run and its rebuild are gone.
- Windows unit, integration, clippy and warm legs move onto the shared gate
(Windows runner, lint leg for Clippy, four shards), keeping the PR
selection from the platforms job, rust-lld, /OPT:NOICF, /DEBUG:NONE and
the D:\t target dir.
- The slowest-tests-first priorities apply on Linux too.
- Swatinem/rust-cache v2.9.3 by commit for this repository's own cache
steps, with fresh keys; cache-version v2 for the gate and docs entries.
`test (without heif)` restores the gate's entry through the shared action.
Dispatch-only jobs no longer save caches no pull request reads; the quick
perf suite restores perf-nightly's entry.
- windows_delay_loads reads the app from NEXTEST_BIN_EXE_photocraft, as the
other app tests do, since archives relocate binaries.
PhotoCraft's UI moves onto the shared craft UI framework in storytold/craft-libs (next branch): shell, dock and panels, hosted dialogs, keyboard, focus, IME and pointer routing, the canvas's view commands, themes and tokens. The engine, document model, file formats, commands and automation stay. PhotoCraft pins storytold/craft-libs next.
Main's #14220 already landed the KRA/ORA/XCF/PDN cutover, so conflicts take
main's io code, manifests and lockfile. crates/cms is gone on main, so its
synth.rs clippy edit is dropped. XCF metadata cancellation is already in main
(parse_with); the PR's regression test is kept and still fails without it.
PDN cancellation already stops before the next surface through keep_going.
The Save Preset… button under Preset Details is gone. An icon right of
the Name field turns the pane into SAVE DOCUMENT PRESET, proposing the
next free "Saved N" with its text selected, with Save Preset / Cancel.
Cancel returns to Preset Details without saving.
Retain the Classic Actions feature unchanged and incorporate official main fixes for workspace write policy, Format persistence, RAW fixtures and SVG resource accounting. No manual merge resolution.
main's dropdowns skip greyed options on the wheel: wheel_steps takes
this branch's notches and main's enabled filter. docs/ui-parity.md: main's
rows and status line, with this branch's entries first.
main's slider is now as tall as a text field (#9320), so the open-list
test's point beside the list landed on it; the point is now below the
slider.
Answers CodeRabbit on #13533: size defaults to Point Sample and sampleLayer to all,
so the zoom alone doesn't reproduce a 3 by 3 Average.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Answers CodeRabbit on #13533: the side is (N+1)/zoom rounded, the box starts
ceil(side/2)-1 pixels before the sampled pixel, and it is clipped to the canvas,
as sample_rect_at does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The command's params text already describes `zoom`; the protocol doc listed only
x, y, size and sampleLayer, so an agent following it got the centred square
instead of the Eyedropper's zoom-dependent box (4 x 4 for a 3 by 3 Average at
100 %).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
In closed-app headless MCP mode, a given --automation-read-root or
--automation-write-root replaces the app's agent folder for that
direction only. Say so in control-protocol.md and mcp.md, and pin it
with a test for each direction.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Without the AI-MCP flag plain `photocraft-cli mcp` is headless as before: a
Control Port saved before the agents switch no longer makes it look for the
app, start it or apply When PhotoCraft Is Closed. Test in
mcp_without_consent_works_headless (fails without the gate).
- `prefs::read_integrations_section` (migrate + lenient read) is shared by the
app's launch read and `photocraft-cli mcp`: one bad value resets only itself,
so a saved "error" closed-app choice no longer falls back to Launch in the CLI.
Replaces the app's hand-written per-field reader. Test in
integrations_come_from_the_saved_preferences_or_default (fails without it).
- docs/development.md: the headless client examples pass --headless.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>