Commit Graph
11509 Commits
Author SHA1 Message Date
David Mann 2be87e4463 Merge pull request #13035 from ljkx/feat/pen-rubber-band
feat(ui): the Pen's gear has a Rubber Band check item, off by default (#12900)
2026-11-11 02:49:37 +01:00
David Mann dcbd128dae Merge pull request #13048 from Bobderto/codex/anchor-point-lock-position
Respect Lock Position in Add and Delete Anchor Point
2026-11-11 02:42:39 +01:00
David Mann db16701427 Merge pull request #13080 from rmsff/fix/background-eraser-channel-refused-12488
Background Eraser: refuse one colour channel of an RGB document
2026-11-11 02:41:26 +01:00
David Mann 799e4b8c59 Merge pull request #12646 from x-labb/fix-12017-gradient-refusal-alerts
fix(ui): the Classic gradient's refusals are the reference application's alerts (#12017)
2026-11-11 02:32:16 +01:00
David Mann f39a3c1fb5 Merge pull request #12718 from slafebre/feat/12052-type-bar-size-presets
Type options bar: font size preset list
2026-11-11 02:19:24 +01:00
ljkxandClaude Fable 5.2 0bd45e4a69 Merge main into feat/pen-rubber-band
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 02:04:44 +01:00
David Mann ab217cd32f Merge pull request #12995 from rmsff/fix/delete-anchor-escape-12773
Delete Anchor Point: Escape clears selected anchors, then the targeted path
2026-11-11 02:01:59 +01:00
David Mann 6a712d54c9 Merge pull request #12908 from hectorviov/fix/eraser-gray-background
Eraser and Fill: background swatch through the Grayscale document's grey profile (#11940)
2026-11-11 02:00:53 +01:00
David Mann 927cd5aecb Merge pull request #12240 from ElNeMeR70/fix/content-aware-move-context-menu-12194
Open selection context menus on right-click with Content-Aware Move tool
2026-11-11 02:00:35 +01:00
David Mann 7f4e4461bb Merge pull request #12983 from rmsff/fix/history-brush-format-mismatch-12842
History Brush: refuse a source of another colour mode or bit depth
2026-11-11 01:57:03 +01:00
David Mann 7539e14dce Merge pull request #12869 from Raghav2012Code/fix/12852-object-transparent-layer
fix(engine): Object Selection finds objects on a transparent layer (#12852)
2026-11-11 01:56:43 +01:00
Dylan M. Taylor a5342b134d packaging: use [[ for bash tests (SonarCloud S7688) (#13050)
Behaviour-preserving: `[[ ]]` in place of `[ ]` for bash tests (SonarCloud shell:S7688). Every script has a bash shebang; no test uses `-a`/`-o`, escaped parentheses or an unquoted pattern on the right of `=`. `bash -n` passes on each script; the rest is left to CI.

- `packaging/linux/apprun-cli-test.sh` (14)
2026-11-10 19:52:30 -05:00
rmsff af2fe890f8 Test the Background Eraser refusing one colour channel 2026-11-11 03:48:24 +03:00
rmsff e7c68638ce Background Eraser: refuse one colour channel of an RGB document
With only Red, Green or Blue targeted the reference application refuses
the stroke ("target channels do not cover the composite"), erases nothing
and adds no History state. The check sits in the setup shared by the
command and its live preview, so the preview draws nothing either. The
composite and the partial sets that weren't measured keep erasing.

The transparency-lock preview test targeted Green alone; it targets
Green and Blue now. Its helpers are pub(super) for the new tests.
2026-11-11 03:48:24 +03:00
David Mann 81236bdfd2 Merge pull request #13079 from davidmann4/fix/default-tool-cursor-complexity
Fix main: split the Pencil outline out of draw_default_tool_cursor (clippy cognitive complexity)
2026-11-11 01:43:13 +01:00
David MannandClaude Fable 5.2 47d3dcde33 Fix main: split the Pencil outline out of draw_default_tool_cursor
main fails the gate at clippy since #12214 landed: its Count arm took
draw_default_tool_cursor to a cognitive complexity of 31 (limit 30).
The Pencil / Block eraser outline moves into pencil_outline_cursor;
behaviour is unchanged.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 01:36:38 +01:00
x-labb adc4d3356d fix(ui): the Classic gradient's refusals are the reference application's alerts (#12017)
A Classic gradient drag on a hidden layer, a fully locked layer or a group now opens a modal alert
with OK (the texts of the Brush's #11898 alerts, for the gradient tool) and changes nothing, instead
of a status-bar line or a command error that named paint.gradient. The live Gradient and the
unmeasured cases (partly locked layers) keep their behaviour.
2026-11-11 01:33:40 +01:00
David Mann e99e07c04a Merge pull request #13022 from ljkx/feat/sponge-flow-field
Sponge: the options bar has a Flow field and strokes use it (#12976)
2026-11-11 01:27:21 +01:00
David Mann 9064c343d1 Merge pull request #13044 from rmsff/fix/warp-split-mode-stays-armed-12498
Warp: a Split button places one split, then its mode ends
2026-11-11 01:27:10 +01:00
David Mann c882bfd832 Merge pull request #13043 from rmsff/fix/red-eye-refuses-non-rgb-12575
Red Eye: refuse CMYK, Grayscale and Indexed Color documents
2026-11-11 01:26:57 +01:00
David Mann e1c5b771ea Merge pull request #13074 from storytold/fix/ruler-new-tuple-pattern
Fix main: match the tuple variant Drag::RulerNew(_) in the ruler Escape check
2026-11-11 01:16:00 +01:00
David MannandClaude Fable 5.2 9653bf1da6 Ruler: match the tuple variant Drag::RulerNew(_) in the Escape check
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 01:13:19 +01:00
David Mann b4383dbeed Merge pull request #13003 from rmsff/fix/sharpen-refusal-alerts-12952
Sharpen: alert on a hidden, locked or group layer
2026-11-11 01:08:19 +01:00
FredApps 847d87bb9b Windows: a pen moves and resizes the window through the custom title bar (#7967) (#12992)
* Windows: a pen or a finger moves and resizes the window through the custom title bar (#7967)

winit takes pen and touch input as WM_POINTER messages and Windows makes no mouse
input from them, so the OS move/size loop that StartDrag/BeginResize start saw no
button down and never ran. winit only clears its dragging flag when that loop ends,
so after one pen try the mouse could no longer move the window either. A pen or
touch press on the title bar's gap or an edge now moves or resizes the window
itself (OuterPosition/InnerSize), restores a maximized window under the pen, and
stops at the minimum size; the mouse still hands the move to the OS.

* Pen title-bar move and resize follow the pen's own screen position (#7967)

On Windows winit moves the window asynchronously (SWP_ASYNCWINDOWPOS), so the
window position egui reads can be ahead of the window-relative pen position and
the drag counted the move twice (an injected pen ran +687/+909 for +200/+120).
The tablet hook now keeps the pen's screen pixels from GetPointerPenInfo
(ptPixelLocation) while the pen is down, and a PenDrag follows that.

A drag that follows the OS position no longer needs egui's pointer position: the
parked mouse cursor can leave the window as it moves away, and egui-winit's
PointerGone ended the drag after a few steps. It ends on release or when no
touch is down.
2026-11-11 01:08:12 +01:00
David Mann c908c79235 Merge pull request #12355 from rmsff/fix/type-mask-off-canvas-12074
fix(engine): a Type Mask keeps the part of its selection past the canvas edge (#12074)
2026-11-11 00:55:07 +01:00
David Mann f1b9b09f29 Merge pull request #13006 from rmsff/fix/make-selection-dialog-12917
Make Selection: Rendering and Operation groups; the dialog's step is Selection Change
2026-11-11 00:54:51 +01:00
David Mann 18ec9b1dc8 Merge pull request #12334 from rmsff/fix/vertical-type-history-name-12058
fix(engine): new vertical text is the history state "New Vertical Type Layer" (#12058)
2026-11-11 00:53:57 +01:00
David Mann d58afecac9 Merge pull request #12244 from ElNeMeR70/fix/gradient-live-drops-selection-12196
fix(engine): drop selection after masking a live Gradient Fill layer
2026-11-11 00:53:39 +01:00
David Mann 00430df4fe Merge pull request #12161 from hectorviov/fix/wand-inside-selection
Magic Wand: a New-mode click inside the selection deselects, a drag moves the outline (#11782)
2026-11-11 00:53:22 +01:00
David Mann 723cd6483e Merge pull request #12165 from hnoerenberg/fix/rotate-dialog-two-decimals-12035
fix(ui): the Arbitrary rotation dialog keeps the ruler's two decimals (#12035)
2026-11-11 00:53:03 +01:00
David Mann 8e104a84ae Merge pull request #12270 from DuBearte/fix/11980-ruler-click-keeps
Ruler: a plain click keeps the current ruler instead of deleting it
2026-11-11 00:52:10 +01:00
David Mann 536d4e7b67 Merge pull request #12214 from hectorviov/fix/count-cursors
Count tool: arrow cursors with 1+, 1 over a marker and 1- with Alt (#11773)
2026-11-11 00:51:50 +01:00
David Mann 5ba0bb0a3a Merge pull request #12201 from hectorviov/fix/eyedropper-zoom-box
Eyedropper: at 100 % zoom and below an N by N Average covers (N+1) x (N+1) screen pixels (#11751)
2026-11-11 00:51:27 +01:00
David Mann e9ab58e1f5 Merge pull request #12209 from DuBearte/fix/11966-auto-erase-exact
Pencil Auto Erase: the start pixel must be exactly the foreground colour
2026-11-11 00:51:02 +01:00
David Mann c4b4afc0a9 Merge pull request #12169 from DuBearte/fix/11886-airbrush-rate
Airbrush: about ten dabs a second while held, and a click lays two dabs
2026-11-11 00:50:39 +01:00
ljkxandClaude Fable 5.2 de5baf8746 Merge main into feat/sponge-flow-field
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 00:15:38 +01:00
ljkxandClaude Fable 5.2 81b3a2cb62 Merge main into feat/pen-rubber-band
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 00:15:17 +01:00
Dan e8cfc515a2 fix(ui): honor Lock Position in anchor point tools 2026-11-10 23:15:03 +00:00
rmsff 00eed2243f Test Escape with the Delete Anchor Point tool (#12773) 2026-11-11 02:08:56 +03:00
rmsff 45b2b36433 Delete Anchor Point: Escape clears selected anchors, then the targeted path (#12773)
With the Delete Anchor Point tool, Escape with no running operation first clears
anchors selected on the saved path targeted in the Paths panel, then deselects that
path, so its outline and anchors go and a click deletes nothing. It waits while the
path's name is typed in the Paths panel, where Escape cancels the rename. Full screen
and a pixel selection still take Escape first; the Work Path and a layer's path keep
today's Escape.
2026-11-11 02:08:56 +03:00
rmsff 551f9d2369 Test the Sharpen tool's layer alerts
Makes the Brush alert tests' helpers pub(super) and reuses them.
2026-11-11 02:08:55 +03:00
rmsff 8122d83e7c Test the Make Selection dialog's groups, greyed operations and History step (#12917) 2026-11-11 02:08:55 +03:00
rmsff 72dbfd9725 Sharpen: alert on a hidden, locked or group layer (#12952)
A Sharpen press on a hidden target layer, a layer with Lock All or
Lock Image Pixels, or with a group active opens the reference
application's modal alert instead of a status-bar message. A tool with
a colour-mode alert now gets it first and falls through to the layer
checks otherwise; the Dodge tool still has no layer alerts.
2026-11-11 02:08:55 +03:00
rmsff 8824661f47 Make Selection: Rendering and Operation groups; the dialog's step is Selection Change (#12917)
The Pen's Make Selection dialog (canvas menu, options bar) now has
Photoshop's layout: Rendering with Feather Radius in pixels and
Anti-aliased, then Operation with New / Add to / Subtract from /
Intersect with Selection as radio buttons. The last three are greyed out
without a selection. The fields and params are the same as before.

OK with New Selection names the step it added "Selection Change".
Cmd/Ctrl+Enter, the Paths panel and the combining operations keep
"Make Selection" (not measured).
2026-11-11 02:08:55 +03:00
rmsff 0cb2e8cc99 Test the one-shot Warp split buttons 2026-11-11 02:04:25 +03:00
rmsff 639b446ffe Warp: a Split button places one split, then its mode ends
The options-bar Split buttons stayed armed after the split, so every further
click on the canvas added another line. The release that places a split now
clears split_tool, as in the reference; a release that places none keeps the
mode armed, as today. The existing test now expects the mode to end instead of
staying armed.
2026-11-11 02:04:25 +03:00
rmsff ab19246243 Test the Red Eye tool's colour mode refusal 2026-11-11 02:04:08 +03:00
rmsff 9c7e055957 Red Eye: refuse CMYK, Grayscale and Indexed Color documents (#12575)
A click in these modes opens the reference's alert instead of running, and paint.redEye returns the same text, leaving pixels and History unchanged. The two tests that expected CMYK to run and Grayscale to miss now expect the refusal.
2026-11-11 02:04:08 +03:00
David Mann de9add28b2 Merge pull request #13023 from ljkx/fix/pen-enter-tests-make-labels
Pen Enter tests: look the Make buttons up by their new labels (main red since #12993)
2026-11-11 00:00:07 +01:00
Dylan M. Taylor f45711c749 codecs: check TIFF structural tags, predicted rows and JPEG chunk frames (#10983)
* codecs: check TIFF structural tags, predicted rows and JPEG chunk frames

- Duplicate structural tags: the directory checks read a tag's first
  entry and the tiff crate its last, so a small SamplesPerPixel first
  and a large one last was admitted with one value and sized with the
  other. A repeated structural tag is now refused.
- Floating-point predictor: the tiff crate reads each tile row at its
  full stored width into a buffer of its own, outside the scratch cap.
  That row (TileWidth x samples x sample size) must now fit the cap.
- JPEG-compressed chunks: the tiff crate decodes each chunk into a
  whole JPEG image sized by the embedded frame header, with no limits.
  Each chunk's frame (read from the chunk or JPEGTables, at most 256
  marker segments in) must now fit the nominal strip or tile, as
  libtiff requires, and its decoded size must fit the scratch cap.

* address review: JPEG chunk dedup by count, offset-2 frame, shared fill budget

* address review: bound JPEG chunk list by scratch cap

* address review: reserve JPEG chunk list at the budgeted length
2026-11-10 17:57:55 -05:00