Commit Graph
11287 Commits
Author SHA1 Message Date
David Mann 0e256a90fa Merge pull request #12873 from rmsff/fix/remove-cursor-centre-cross-12550
Remove tool: show the centre + in its brush cursor by default
2026-11-10 15:45:26 +01:00
terminalgateandClaude Sonnet 5.5 fb3b6a4b70 Eraser: add Erase to History (Brush, Pencil and Block modes) (#10692)
* Eraser: add Erase to History (Brush, Pencil and Block modes)

Photoshop's Eraser has an Erase to History option; PhotoCraft had only the History Brush.
With it ticked, the Eraser paints the History panel's source state back instead of
erasing, through paint.historyBrush with eraseToHistory. Pencil and Block modes paint back
through their hard tips. A layer that did not exist in the source state paints that
state's visible image; the History Brush itself still refuses such a layer, as Photoshop's
does.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Keep tool_event within clippy's complexity limit

* Test Erase to History at every depth and tip

* Update the History Brush params comment for Erase to History

* Erase to History paints a layer made since only from a single-layer state

Compared with Photoshop 27.11.0: on a layer the source state does not hold, Erase to History paints
when that state holds a single layer, Background or not, and gives an error when it holds a second
layer, even an empty one. The composite of a multi-layer state is gone; those states now refuse
the layer with the History Brush's error.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Erase to History paints a single source layer's own pixels

Photoshop 27.11.0 paints a layer made since with the source layer's pixels: a 50% opacity layer
gives a solid stroke, where the composite gave a faded one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Erase to History: Pencil mode paints at full flow; test a group-only source state

Pencil mode has no Flow control, so a lower Flow set in Brush mode must not carry over. A source
state holding only a group has no pixels of its own and refuses a layer made since.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Erase to History keeps its options if a tool key is pressed mid-stroke

The stroke read the current tool and brush when it was committed, so pressing a tool's letter
during the drag dropped eraseToHistory and the stroke failed on a layer made since. The options
and the Eraser's tip are now captured at the press.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Erase to History: a single solid shape paints its colour; name the History row

Photoshop 27.11.0 paints a shape layer's solid colour along the whole stroke, past its path, and
calls the stroke History Eraser in the History panel.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Erase to History: a single shape without a solid fill paints white

Observed in Photoshop 27.11.0: a gradient, pattern or no fill paints plain white along the whole stroke, past the path and whatever the outline, in RGB, CMYK, Grayscale and Lab.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Eraser: Alt at the press reverses Erase to History for that stroke

As in Photoshop 27.11.0: with the option off Alt restores, with it on Alt erases. Alt pressed or released during the stroke changes nothing, and the option itself is left as it was.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Erase to History: name the Photoshop version compared

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Erase to History: review fixes for the error and the History Brush tip

A layer without pixels now gets the error that the target did not exist
in that history state, not "no active document". The History Brush keeps
its size, hardness and spacing from the press, as the Eraser does, if a
tool key is pressed mid-stroke.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Brush parity: add the Eraser's Erase to History

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Erase to History: document the functions this change touches

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* History Brush and Erase to History keep their whole brush from the press

Only mode, opacity, flow, size, hardness and spacing were kept from the press; the rest of the brush (tip shape, sampled tip, angle, dynamics, smoothing) came from the session brush at release. A tool key mid-stroke changed that brush, the commit rejected the live preview, and the fallback repainted the whole stroke with the new tool's brush. The stroke's params now carry the press-time brush as "brush" (stored tips as references, as each tool's remembered brush), and paint.historyBrush deep-merges it onto the session brush, so the live preview, the commit, its fallback and a replayed action all paint with it. Tests: a tool switch mid-stroke paints exactly what the same stroke paints without it, for the History Brush and Erase to History in Brush, Pencil and Block mode, across tip shape, sampled tips, dynamics and smoothing; a "brush" param paints as the session brush would; a malformed one is refused.

* History Brush docs: say "outside its shape", not "past its path"

The automation crate flags any command whose params text mentions a path as a possible filesystem path (registry_filesystem_path_params_are_classified); the eraseToHistory description meant a shape's vector outline. Also a test that a state whose one root item is a group of several layers is refused like the one-layer group: a group has no pixels to paint back.

* Test that a Shift-click Erase to History line commits its live pixels unsmoothed

Main's Shift-click fix (#11887) and this branch's press-time History
Brush params meet in finish_stroke_with; check the commit sends
smoothing 0 beside the brush param in all three Eraser modes.

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-10 14:51:20 +01:00
David Mann bf08f0834c Merge pull request #12862 from rmsff/fix/clone-stamp-reset-tip-12601
Reset Tool gives the Clone Stamp a 21 px soft tip at 25 % spacing
2026-11-10 14:45:08 +01:00
David Mann f222dd77e9 Merge pull request #12859 from rmsff/fix/blur-strength-range-alert-12650
Blur Strength: alert when a typed value is out of range
2026-11-10 14:36:07 +01:00
ec97a146f5 Support ordered automation read roots with safe save provenance (#3023)
* fix(cli): reject repeated automation read roots

* feat(automation): add ordered read roots with isolated saves

Stage source and regression tests for GGEO-AI02 validation before updating PR #3023. Repeated reads accumulate; writes remain single-root and implicit saves retain their selected capability provenance.

* style: format multi-root automation extension

* test: use fixed pixel chunks in read-root regression

* docs: reconcile control protocol with upstream TGA options

* docs: state multi-root capabilities directly in API summaries

* test: construct regression actions through upstream defaults

* Clarify headless and desktop directory automation reads

* Format the shared root parser and relocated service regressions

* test: adapt automation import callback to ImportOptions

* test: expect read-root diagnostic for denied smart-object input

* test: reject repeated write roots while allowing ordered read roots

* test: assert explicit empty-root parser diagnostic

* test: exercise leaf-link save using a supported image filename

---------

Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Codex <codex@openai.com>
2026-11-10 14:28:12 +01:00
David Mann 4d5f8f116b Merge pull request #12851 from rmsff/fix/fill-rasterize-prompt-text-12538
Rasterize prompt: the fill wording as in the reference
2026-11-10 14:21:49 +01:00
David Mann 5705d4c9fa Merge pull request #12843 from rmsff/fix/red-eye-history-state-12573
Red Eye: name the step Red Eye Removal Tool and record a click that changes nothing
2026-11-10 14:21:39 +01:00
David Mann 9ec6a65aa7 Merge pull request #12819 from rmsff/fix/remove-new-layer-name-12542
Remove Tool: name the new layer "Remove tool edits"
2026-11-10 14:21:29 +01:00
David Mann 5dc18fa87b Merge pull request #12812 from rmsff/fix/dodge-refuses-indexed-12686
Dodge: refuse Indexed Color and Bitmap documents
2026-11-10 14:21:19 +01:00
David Mann 7f64c24195 Merge pull request #12811 from rmsff/fix/delete-last-anchor-12764
Delete Anchor Point: deleting a saved path's last anchor leaves it empty
2026-11-10 14:21:08 +01:00
David Mann 3466609441 Merge pull request #12809 from rmsff/fix/art-history-noop-state-12636
Art History Brush: a click held back by the tolerance adds its state
2026-11-10 14:20:58 +01:00
David Mann b6c4a7fc8b Merge pull request #12808 from rmsff/fix/add-anchor-options-bar-text-12731
Add Anchor Point: options bar says the tool has no options
2026-11-10 14:20:48 +01:00
David Mann bd2d87f64d Merge pull request #12813 from rmsff/fix/convert-point-history-names-12736
Convert Point: name History steps Change Anchor Point and Corner Drag
2026-11-10 14:20:39 +01:00
David Mann 60fef64a7a Merge pull request #12295 from hectorviov/fix/mixer-load-solid-colors
Mixer Brush: Load Solid Colors Only in the load menu (#11952)
2026-11-10 14:20:02 +01:00
David Mann 331aa99d50 Merge pull request #12232 from hectorviov/fix/perspective-crop-click-preview
Perspective Crop: the quad follows the pointer while corners are clicked
2026-11-10 14:11:08 +01:00
rmsff be83ed2182 Test the Blur Strength range alert 2026-11-10 15:50:05 +03:00
rmsff 22fe3deba8 Tests: Remove tool cursor centre + and Show Crosshair for other brushes (#12550) 2026-11-10 15:49:59 +03:00
rmsff 1f5ae5b7d3 Tests: the Clone Stamp's reset and first-use tip 2026-11-10 15:44:39 +03:00
David Mann 2a950d64dd Merge pull request #7377 from smyrgeorge/fuji-compressed-raf
Fujifilm compressed RAF: decode lossless and lossy files instead of the embedded preview
2026-11-10 13:36:29 +01:00
FredApps 7091cb6b8c Raster: the memory reservation tests take turns (#12854)
RESERVED is process-wide. Under cargo test (the FreeBSD job) the module's tests run on threads of one process, so an_operation_that_fits_alone_waits_for_a_concurrent_one's reservation could land between reservations_are_bounded_and_returned's before and after counts (left: 434166548, right: 0). nextest on Linux gives each test its own process, which hid it. Locally the unfixed module failed 15 of 40 runs, the fixed one 0 of 40.
2026-11-10 13:16:05 +01:00
rmsff 9b438fb90e Remove tool: show the centre + in its brush cursor by default (#12550) 2026-11-10 15:04:08 +03:00
rmsff c7407f50e5 Reset Tool gives the Clone Stamp a 21 px soft tip at 25 % spacing
The Clone Stamp now starts, and comes back after Reset Tool and Reset All Tools, with the reference's 21 px soft round at 25 % spacing and no smoothing (#12601).
2026-11-10 14:29:38 +03:00
rmsff 1195fb971a Blur Strength: alert when a typed value is out of range
Typing a Blur Strength past 1..100 now stores the closest whole number and shows the reference's "Closest value inserted" alert once the field is left, as the Eraser's fields do. Sharpen and Smudge share the field but were not measured, so they keep the silent clamp.
2026-11-10 14:27:13 +03:00
rmsff 75650176b6 Tests: the fill-layer rasterize prompt text and OK (#12538)
A Paint Bucket click on a Solid Color fill layer shows the reference
question; OK only rasterizes the fill (one history state, no fill). The
catalogs that translated the old text translate the new one, a language
without an entry falls back to English, and no catalog keeps the old key.
2026-11-10 14:14:40 +03:00
rmsff 75341eff57 Rasterize prompt: the fill wording as in the reference (#12538)
A Paint Bucket (or other pixel tool) click on a fill layer asks "The fill
for this layer must be rasterized before proceeding. It will no longer be
editable as a fill. Rasterize the fill?", as measured in the reference
application. The 22 catalogs that translated the old text are re-keyed to
the new English text, so those languages keep a translation, as #11899
did for the smart object text. The test that pinned the four prompts now
expects the new fill text; OK and Cancel are unchanged.
2026-11-10 14:01:38 +03:00
rmsff 2390a935ff Tests: Red Eye history states for hits, misses and refusals 2026-11-10 13:56:00 +03:00
rmsff 6106c825e7 Red Eye: name the step Red Eye Removal Tool and record a click that changes nothing
A click that runs but changes no pixel (a blue pupil, a transparent area, an
empty layer, Darken Amount 0) now adds one unchanged history state instead of
the "no red-eye pixels" error, as in Photoshop. Non-RGB/Lab documents, channel
and mask targets, hidden layers and clicks outside the selection or the canvas
keep the error and add no state.
2026-11-10 13:56:00 +03:00
Hector Villarreal d8fdb5aa4b Merge main into fix/perspective-crop-click-preview (picks up the fixed sampler and wand tests) 2026-11-10 04:46:18 -06:00
Hector Villarreal 8257d890a9 Merge main into fix/mixer-load-solid-colors (picks up the fixed sampler and wand tests) 2026-11-10 04:37:57 -06:00
rmsff aa4ef1735c Test the Remove Tool new layer name 2026-11-10 13:14:42 +03:00
rmsff 829a8b8f51 Remove Tool: name the new layer "Remove tool edits"
With Create new layer on, the result layer was "Layer N". Name it as the
reference does: "Remove tool edits", then "Remove tool edits 1", "2"...
taking the first free name.
2026-11-10 13:14:42 +03:00
rmsff 6c3579fb59 Test Convert Point's History step names 2026-11-10 13:14:39 +03:00
rmsff 35abce7773 Name Convert Point's History steps Change Anchor Point and Corner Drag
path.convertPoint and path.moveHandle take an optional stepName (only
that one name is accepted, as with edit.transform), and the Convert Point
tool sends it. Direct Selection, the Pen's Alt conversion and the
Curvature Pen keep Convert Point and Drag Direction Point.
2026-11-10 13:14:39 +03:00
rmsff bc3d366c4c Test the Dodge tool's Indexed Color and Bitmap refusal 2026-11-10 13:14:36 +03:00
rmsff 7188facf57 Refuse Dodge in Indexed Color and Bitmap documents
paint.dodge and its live stroke return the reference application's
message in Indexed Color and Bitmap documents and tone nothing; a press
with the Dodge tool shows it as a modal alert. Other modes keep dodging.
2026-11-10 13:14:36 +03:00
rmsff 0610e89921 Test deleting the last anchor of a saved path 2026-11-10 13:14:33 +03:00
rmsff 7a77b42a35 Delete Anchor Point: deleting a saved path's last anchor leaves it empty
A saved path whose only anchor is deleted keeps its place in the Paths panel with no subpaths, as in Photoshop. The Work Path, a shape's path, a vector mask and a Type Path still refuse it.
2026-11-10 13:14:33 +03:00
rmsff c4296987d3 Test the Art History Brush state of a click held back by the tolerance 2026-11-10 13:14:30 +03:00
rmsff bdf1050f6f Art History Brush: a click held back by the tolerance adds its state
Photoshop adds one unchanged "Art History Brush" state when the Tolerance holds back every dab. A stroke that could write nothing anyway (wholly outside the selection, on locked transparent pixels) stays a quiet no-op, and refusals still add no state.
2026-11-10 13:14:30 +03:00
rmsff 992d2d77a4 Test the Add and Delete Anchor Point options bars 2026-11-10 13:14:27 +03:00
rmsff 9878a61e3b Add Anchor Point: options bar says the tool has no options
Photoshop's bar holds only the preset picker and "No options for the Add Anchor Point Tool.", centred in the rest of the bar. The Alt hint goes; the Delete Anchor Point bar keeps its hint.
2026-11-10 13:14:27 +03:00
David Mann 71a5c58585 Merge pull request #12790 from tjbbjt/fix/sampler-tests-pixel-centre
Tests: expect Color Sampler points on pixel centres after #12174
2026-11-10 11:04:45 +01:00
tjbbjt e2580ccdb5 Tests: document the Color Sampler tests updated for pixel centres 2026-11-09 22:26:46 -08:00
Hector Villarreal 4cb7519df6 Perspective Crop click-preview tests: pass the modifiers main's pointer() now takes 2026-11-10 00:12:40 -06:00
Hector Villarreal aedda3996c Merge main into fix/perspective-crop-click-preview (conflicts as asked on the PR) 2026-11-10 00:09:37 -06:00
Hector Villarreal 1beefac1ed Merge main into fix/mixer-load-solid-colors (conflicts as asked on the PR) 2026-11-09 23:46:36 -06:00
tjbbjt 010fbe9e2e Tests: expect Color Sampler points on pixel centres after #12174 2026-11-09 21:44:47 -08:00
David Mann d6b97e5b4b Merge pull request #12174 from hectorviov/fix/sampler-pixel-centre
Color Sampler: points sit on the clicked pixel's centre (#11725)
2026-11-10 03:04:39 +01:00
David Mann 7c263e28eb Merge pull request #12721 from Bobderto/codex/12670-burn-dodge-tooltips
fix(ui): add Burn and Dodge options-bar tooltips
2026-11-10 02:24:33 +01:00
David Mann 382ed04521 Merge pull request #12677 from RickiNano/fix/remove-history-name-12541
Remove tool: name the History step "Remove Tool" (#12541)
2026-11-10 02:24:19 +01:00