mirror of
https://github.com/storytold/photocraft.git
synced 2026-11-21 17:37:14 +00:00
fix(filters): clippy findings in the new Lens Flare
A leftover doc comment from the removed ghost struct, an unneeded max(0) on an unsigned width, and index loops over the colour channels written as zips.
This commit is contained in:
1 parent
a9e55793b9
commit
2adff9e7d9
2 files changed
+7
-9
No files matched your search
@@ -114,7 +114,7 @@ pub(crate) fn lens_flare(src: &Image, out: Rect, ctx: &Ctx, brightness: f32, cen
|
||||
let bright = brightness.clamp(10.0, 300.0) / 100.0;
|
||||
let d = design(lens);
|
||||
|
||||
let (w, h) = (out.width().max(0) as usize, out.height().max(0) as usize);
|
||||
let (w, h) = (out.width() as usize, out.height() as usize);
|
||||
let mut light = vec![[0.0f32; 3]; w * h];
|
||||
let (ox, oy) = (out.x0 as f32, out.y0 as f32);
|
||||
|
||||
@@ -133,8 +133,8 @@ pub(crate) fn lens_flare(src: &Image, out: Rect, ctx: &Ctx, brightness: f32, cen
|
||||
if let Some(v) = profile(e.knots, fx.hypot(fy) / g.unit)
|
||||
&& let Some(px) = light.get_mut(y * w + x)
|
||||
{
|
||||
for k in 0..3 {
|
||||
px[k] += v[k];
|
||||
for (p, v) in px.iter_mut().zip(v) {
|
||||
*p += v;
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -156,8 +156,8 @@ pub(crate) fn lens_flare(src: &Image, out: Rect, ctx: &Ctx, brightness: f32, cen
|
||||
}
|
||||
let along = ((fx * cos + fy * sin) / g.unit).abs();
|
||||
let k = (1.0 - smoothstep(half * (1.0 - taper), half, along)) * (-across * across).exp();
|
||||
for c in 0..3 {
|
||||
px[c] += k * s.rgb[c];
|
||||
for (p, c) in px.iter_mut().zip(s.rgb) {
|
||||
*p += k * c;
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -184,8 +184,8 @@ pub(crate) fn lens_flare(src: &Image, out: Rect, ctx: &Ctx, brightness: f32, cen
|
||||
let pos = (rad - r0) / length;
|
||||
let env = ((pos.min(1.0 - pos)) / fade).clamp(0.0, 1.0);
|
||||
if let Some(v) = light.get_mut(ly as usize * w + lx as usize) {
|
||||
for k in 0..3 {
|
||||
v[k] += env * r.rgb[k];
|
||||
for (p, c) in v.iter_mut().zip(r.rgb) {
|
||||
*p += env * c;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -106,8 +106,6 @@ pub(crate) fn fibers(src: &Image, out: Rect, ctx: &Ctx, variance: f32, strength:
|
||||
res
|
||||
}
|
||||
|
||||
/// One lens-flare ghost: position along the flare→centre axis, radius and tint.
|
||||
|
||||
pub(crate) struct LightingSpec<'a> {
|
||||
pub lights: &'a [Light],
|
||||
pub gloss: f32,
|
||||
|
||||
Reference in new issue
Block a user