M4: the selection-bar test anchors at the selection's left edge and checks the whole bar (#5658)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GbuSKAS2k5248LGFEapMUR

crates/ui-egui/src/canvas/selection.rs

@@ -76,9 +76,14 @@ impl DocView {
     /// Screen position of the centre of glyph `glyph` on `page`, if that page is on screen and its
     /// text layer is loaded (used by UI tests and automation to aim pointer input).
     pub fn glyph_screen_pos(&self, page: usize, glyph: usize) -> Option<Pos2> {
+        self.glyph_screen_rect(page, glyph).map(|r| r.center())
+    }
+
+    /// The screen rectangle of glyph `glyph` on `page`, when the page is on screen.
+    pub fn glyph_screen_rect(&self, page: usize, glyph: usize) -> Option<Rect> {
         let (_, xf) = self.screen_xforms.iter().find(|(p, _)| *p == page)?;
         let g = self.texts.get(&page)?.glyphs.get(glyph)?;
-        Some(xf.view_rect(g.rect).center())
+        Some(xf.view_rect(g.rect))
     }
 
     /// Selected text, if any (⌘C).

crates/ui-egui/tests/it/comments.rs

@@ -3036,16 +3036,13 @@ fn the_selection_bar_stays_inside_the_pages_area() {
     h.state_mut().views[0].select_text(0, last, last);
     h.run_steps(4);
     let viewport = h.state().views[0].viewport_rect();
-    let (first, copy) = (h.get_by_label("Kommentar hinzufügen").rect(), h.get_by_label("Kopieren").rect());
-    let glyph = h.state().views[0].glyph_screen_pos(0, last).unwrap();
-    // The setup puts a bar opening at the glyph past the area's right edge.
-    assert!(
-        glyph.x + (copy.right() - first.left()) > viewport.right(),
-        "glyph at {}, bar {} wide, area {viewport:?}",
-        glyph.x,
-        copy.right() - first.left()
-    );
-    assert!(first.left() >= viewport.left() && copy.right() <= viewport.right(), "bar {first:?}..{copy:?} inside {viewport:?}");
+    // The bar's whole area, frame included, not only its first and last buttons.
+    let id = egui::Id::unique(("text-selection-actions", h.state().views[0].id.0));
+    let bar = h.ctx.memory(|m| m.area_rect(id)).expect("the selection bar is shown");
+    // The bar opens at the selection's left edge: past the area's right edge, without the clamp.
+    let anchor = h.state().views[0].glyph_screen_rect(0, last).unwrap().left();
+    assert!(anchor + bar.width() > viewport.right(), "selection at {anchor}, bar {} wide, area {viewport:?}", bar.width());
+    assert!(viewport.contains_rect(bar), "bar {bar:?} inside {viewport:?}");
 }
 
 /// `n` pages with one comment each, "Card 1" to "Card n".