- Remove location: export checked only the photo's own EXIF, so an
original HEIC whose GPS was in its thumbnail's EXIF or a second EXIF
item was copied out with it. lightcraft_meta::embeds_location reads
every HEIF EXIF and XMP item, and one it can't read counts as a
location; other formats are checked as before. The refusal offers DNG
only for raws (DNG export of a JPEG or HEIC fails).
- iloc is walked once for all candidate items instead of once per
candidate (a hostile 48 MB iloc with 64 items took over a second).
- EXIF tied to an image the primary is made from (dimg: iden, iovl,
tmap, grid inputs, followed with a seen-set) is the photo's; a pitm
naming no item counts as no primary.
- Full-box versions are read from the box's own payload.
- meta README lists HEIF in embedded and ISO/IEC 14496-12 and 23008-12
in its sources; target-app-parity no longer cites HEIC (#693) as a
file-exchange discount reason.
Tests, failing before: GPS in a thumbnail's EXIF, a second EXIF item or
an XMP item, and the unsure cases; a work bound counting iloc entries
walked; derived primaries and a missing pitm item; a HEIC original
refused under remove location; DNG offered only for raws.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Imported HEIC photos had no camera, capture time or All Metadata rows:
lightcraft_meta::embedded had no HEIF branch, and only the decoder read the
EXIF, while decoding pixels. crates/meta/src/heif.rs reads the primary
image's Exif item and XMP (mime) item from the ISO BMFF item structure
(meta: pitm, iinf, iref cdsc, iloc versions 0 to 2 with construction
methods 0 and 1 and idat) and honours the Exif item's TIFF-header offset.
No picture is decoded, so it works without the heif feature, and AVIF goes
through the same code. Offsets and lengths are checked; boxes, candidates
and item sizes are bounded. The CR3 box walker is reused.
Tests: the issue sweep's synthetic-metadata.heic case, EXIF offsets,
extents and construction methods, primary-image association, malformed
bounds, and a truncation, byte-damage and property sweep (meta); HEIC
import to the catalog and All Metadata, and AVIF export metadata reading
back (engine).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On merge: the HDR histogram is applied in develop_reporting (#712 split develop), is skipped for
draft renders (a second render per drag tick), and HdrBins::bin clamps a hand-built split so it
can't underflow (test hdr_bins_with_any_split_stay_in_range).
#884 focuses a develop slider on click so the wheel and arrows adjust it, but a focused widget
owned the whole keyboard, so after touching a slider no shortcut fired (O for the mask overlay,
caught by mask_adjustments_hide_overlay_without_disabling_the_mask). Now a selected slider owns
the arrow keys only. The wheel test opens the Edit panel explicitly (the demo may start on it, and
panel.edit then toggles it shut), and the Export dialog snapshot is 546 px wide since #833's
nine watermark positions.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BKWB9TCnvzJHV6xMLAj2J4
photo.editExternal takes the selection (or ids, at most 50): each photo gets its own -Edit copy
stacked on its original, the copies are selected and returned in copies (path / id / original
still name the first). Photo ▸ Edit In opens each copy in the editor.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BKWB9TCnvzJHV6xMLAj2J4
On merge: Lightroom's default profiles (Adobe Standard, Adobe Color), named by nearly every sidecar,
give no camera-profile warning; other profiles still do (test default_lightroom_profiles_are_not_reported).
The import help string keeps main's onDeleted wording and gains warnings.
On merge: the quick preview path orients like the whole-file path (preview_orientation with the
raw's header prefix, so a portrait raw whose embedded JPEG carries no orientation is not sideways),
and its doc links point at preview_window.
- Settings ▸ General ▸ External Editing: the PhotoCraft location and Other editor
fields move from egui::TextEdit to TextField (edit menu, Esc restores).
- Edit In with the system default on Windows starts explorer.exe with the file
as one argument instead of cmd /C start, which read & ^ % | in file names as
shell syntax.
- psd::packbits walks the row with first()/get()/split_at_checked instead of
direct indexing and slicing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BKWB9TCnvzJHV6xMLAj2J4
move_across_volumes read both whole files into memory to compare them; it now
compares lengths first, then streams 1 MiB chunks. The grid's Move to Folder…
asks through pick::ask (background dialog where the host has one) like the
other folder pickers.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BKWB9TCnvzJHV6xMLAj2J4
Alex ChambersandClaude Opus 5.5
BFlat