* links: spawn the Windows opener by absolute path (#2176)
Explorer is now spawned as %SystemRoot%\explorer.exe (falling back to
windir, then C:\Windows; only local drive paths are accepted), so an
explorer.exe planted next to the app or in the CWD can't run. Space, ",
comma and ^ are percent-encoded before Explorer parses its command line.
macOS uses /usr/bin/open; a target starting with - or / is refused on
every platform so it can never become an opener option.
* links: rename opener enum variant (clippy)
`Os::MacOs` -> `Os::Mac` (clippy::enum_variant_names). Also give the
desktop-theme watcher's non-Linux `Link` a non-unit type so
clippy::let_unit_value stops firing on Windows/macOS.
* ui: leave desktop_theme Link alone (covered by #2141)
* #2176: say why the Explorer escape still encodes commas
* Linux: run on native Wayland again by default (revert #165)
winit 0.30.13 reported dropped files only on X11. The egui 0.37 migration
(#2543) pins storytold/winit, whose patch W15 reports file drops through
a per-seat Wayland data device (rust-windowing/winit#4729), so files
dragged from the file manager open on native Wayland too. The XWayland
default is no longer needed.
It also costs a startup crash: winit's X11 backend loads
libxkbcommon-x11, which the Linux packages don't depend on. Where it's
missing (a Fedora toolbox, minimal installs), GridCraft panics before the
window opens: "Library libxkbcommon-x11.so could not be loaded."
Checked on GNOME (Wayland, Fedora 44) with a build of main plus other
proposed changes, run with GRIDCRAFT_WAYLAND=1 (the path this revert
makes the default): an .xlsx and a .csv dragged from Files each open as a
workbook, and the app starts without libxkbcommon-x11 installed.
This reverts commit 6f0e43c21c.
Claude-Session: https://claude.ai/code/session_01Rvu8dWh26U2fsLQMSBQfH8
* test: header AutoFit check measures the text as AutoFit did
table_filter_autofit_works_through_command_and_header_double_click
compared the autofitted column with the engine's text-width estimate,
but in the app AutoFit measures with the installed fonts
(Session::text_width). Where those are narrower than the estimate (a
Mac with Carlito, metric-compatible with Calibri), the estimate
"overlapped" the filter button and the test failed on main. It now
measures with the same function AutoFit used.
* test: the header AutoFit UI check measures with the app's fonts, which the app always installs
The fallback to the engine's estimate never ran: SheetApp::logic installs the measure before
AutoFit. AutoFit on the estimate is covered by the engine's autofit_filter_buttons tests.
* Keyboard: punctuation shortcuts follow the character the layout types (#1384)
On a Croatian or German keyboard Shift+, types `;`, so Excel inserts the
date with Ctrl+Shift+,. GridCraft matched the key's US position and ran
Decrease Font Size. Punctuation keys now go by the character typed
(translated to the US key and Shift that type it), digits keep their
position, and a character egui has no key for (č, ö) still falls back to
the position. ribbon::shortcut reads the same key, so Ctrl+Shift+0
typing `=` unhides columns instead of opening Insert, and Ctrl++ opens it.
* Keyboard: Cmd+Shift+; on a Mac doesn't insert today's date (review)
ribbon::shortcut's Semicolon arm took Shift too, so the US-key mapping turned Cmd+Shift+; (and
Cmd+Shift+. on a Croatian or German layout) into the date. Ctrl+Shift+; stays the time.
* Keyboard: tests for AZERTY and Czech, and for typing while a cell is edited (#1384)
French AZERTY (`;` and `:` unshifted on the US `,` and `.` keys) and Czech (`;` on the US
backtick key, `:` Shift+.) give the date and the time with Ctrl. The layout mapping runs only
in the grid, which reads no shortcuts while a cell is edited; a test pins that: `;` and `:` typed
as Shift+, and Shift+. on a Croatian or German keyboard go into the cell, and the font size stays.
* Fuzzer: undo checks follow the bounded undo history
The undo history drops its oldest steps past 100 entries or 128 MB of snapshots (#1263). The
command-sequence fuzzer still compared "undo everything" with the episode's starting workbook,
so any episode whose snapshots passed the budget failed with "undoing all N steps doesn't give
back the starting workbook" although undo worked (seeds 104, 110 and 163 at 80 steps: a column
inserted next to whole-column borders, or rows deleted after filling whole columns, each made a
100 MB step).
The harness notices when an undoable command changed the workbook without the history growing,
and then compares with the state before the oldest step still in the history.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fuzzer: undo and redo checks follow the reachable history boundary
Review of #2332. The harness now tracks the oldest state the undo history
can reach instead of a trimmed flag: whenever the history's oldest entry
changes without it emptying in between, the history dropped a step, and
undoing everything stops at the new oldest entry. That boundary is kept
when an edit.undo in the sequence uses up the retained history before the
episode ends, which used to fall back to the episode's start and report a
false undo mismatch.
The redo round trip no longer assumes n undos leave n redo entries: the
redo history is bounded too, so when it dropped the first step undone,
redo is expected to stop at the oldest entry it kept.
---------
Co-authored-by: nihilist-narwhal <240798405+nihilist-narwhal@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Flush a saved workbook to disk before the rename
write_file renamed the temporary file over the workbook without sync_all, so a power loss right after a save could leave an empty or truncated file under the workbook's name. Sync the file before the rename and, on unix, sync the folder after it (best effort).
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
* Tolerate file systems that cannot flush when saving
On Apple targets std's sync_all asks for F_FULLFSYNC, which network mounts refuse with ENOTTY or ENOTSUP. Treat exactly those errors (and ErrorKind::Unsupported) from the temp file's sync as 'cannot flush here' and carry on with the rename, as before the flush was added. All other errors still fail the save.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
* Treat raw error 25 as unsupported-flush only on Unix
On Windows 25 is ERROR_SEEK, a real failure that must not be skipped.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
* Save: treat Apple's ENOTSUP from F_FULLFSYNC as unsupported flush
On Apple targets ENOTSUP is 45 and std leaves it uncategorized (only
EOPNOTSUPP, 102, and ENOSYS map to ErrorKind::Unsupported), so a volume
refusing F_FULLFSYNC with ENOTSUP failed the save and deleted the
temporary file. The raw code is now matched on Apple targets only;
elsewhere 45 is a different errno and stays a failed save. The check is
split into a platform-parameterised helper so each platform's codes are
tested on any host, plus an Apple-only test on the real helper.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
* Sort: Custom Sort dialog redesign
* Sort: keep the dialog on its worksheet and open when sorting fails
* Improve custom sort dialog and localisation
Localise sort controls and adapt their layout to translations. Track worksheets by identity, restore selections across sheet changes, and allow additional levels to reuse columns.
* Fix sort dialog worksheet and input handling
Open Sort on the requested worksheet, reject invalid ranges, and close any open filter menu so Enter confirms the sort. Add regression tests for each case.
A table whose Total Row was turned off still holds each column's total:
Excel writes totalsRowFunction, totalsRowLabel and a custom
totalsRowFormula without totalsRowCount, and restores them when the row
is turned back on. The reader took them, but the writer wrote them only
while the row was shown, so a save lost a custom formula or an Average
and Excel brought back SUBTOTAL(109,...) instead. They are now written
whether the row is shown or not.
Fixes#4296
A sheet set to First page number 7 has pageSetup firstPageNumber="7"
useFirstPageNumber="1"; neither attribute was read, so a save reset it
to Automatic. PrintSettings now holds it (None for Automatic), the
reader takes the number when useFirstPageNumber is on, and the writer
writes both in the schema's order. A JSON workbook leaves it out when
Automatic, so existing files are written as before.
Fixes#4293
* Functions: GETPIVOTDATA (#284)
The engine records each PivotTable report value cell (value field,
row/column items, value) on refresh and when a workbook is opened;
GETPIVOTDATA is an evaluator special form that looks the value up by
value field and field/item pairs, #REF! when the report doesn't show it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* GETPIVOTDATA: shared lazy index, report values, hash lookup (review of #290)
- PivotTable::data_index is an Arc-shared PivotLookup (serde-skipped), so the
per-command workbook clone no longer copies the index; refresh sets it, clear resets it.
- No index work on open: the first GETPIVOTDATA on a pivot without one builds it from the
source via the engine-registered PIVOT_INDEXER; a failure is #REF!, not an empty index.
- The result is the value the sheet shows at the cell's report position, so formula and
report cell agree (test with a source edited after the last refresh).
- Lookup by a pre-lowercased hash key; numbers/booleans fall back to a scan on a miss.
- GETPIVOTDATA is no longer volatile: it depends on its pivot's whole report area.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
* GETPIVOTDATA: keep the index of the stored report; collision-free keys; align estimates
The lookup index describes the report as last refreshed and is saved with
the pivot. A pivot loaded without one (XLSX) only builds it when the
recomputed layout matches the stored labels. Lookup keys are length-prefixed
and distinguish Boolean from text items. Function-parity estimates match.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
* pivot: import PivotDataCell, PivotItemRef and PivotLookup explicitly after upstream dropped the glob import
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
* pivot: add an ignored measurement of edits on a sheet with a large report
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
* pivot: keep a failed lazy GETPIVOTDATA build retryable, never save an empty index
A failed lazy index build stored unwrap_or_default() into the shared,
first-set-wins PivotLookup, so a valid state coming later (undo, a
source fix, a reopen) could never rebuild it, and the empty list was
saved as a restored index. Cache only validated builds, treat an empty
list as no index in serialization, reject reports with more value
cells than the index cap instead of truncating, register the pivot
indexer in gridcraft-cli check, and add two regression tests.
* GETPIVOTDATA: move cached offsets with edits inside the report; exact numeric items first
Inserting or deleting rows or columns inside a report remapped the cells
and last_range but kept the cached value-cell offsets, so a lookup could
read another item's cell. shift_sheet_features now maps each indexed
cell through the edit into a new index (the shared one stays with the
undo snapshots); a value cell deleted with its line drops out (#REF!).
A numeric item was accepted on a formatted-label hash hit, so 0.6 and 1
both shown as "1" returned the first. A number now prefers the cell
whose item has exactly that value, before any label match.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix pivot chart test for the new Output.data field
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Native JSON workbook: golden bytes before the move to craft-libs
A workbook with text, numbers, a formula, bold, a number format and a macro is
saved as native JSON. Its bytes, the bytes saved after a newer-format macro is
kept, and the error for a non-workbook file are golden files written by the
current code. Opening the golden file as .json and .scjson and saving it again
gives it back.
* Native JSON workbook: read and write through craft-gridcraft-format
The `.json`/`.scjson` extension check, the reader and its error text, and the
pretty writer with newer-format macros written back into `macros` now come from
craft-gridcraft-format (storytold/craft-libs#1749), pinned at its PR tip. The
Workbook model, the style-index and cell-band rebuilds after a read, and macro
reading and checks stay here.
The golden tests from the previous commit pass unchanged.
Part of storytold/craft-libs#778.
* Native JSON workbook: pin craft-gridcraft-format to the craft-libs merge commit 9a6d8942 (storytold/craft-libs#1749)
---------
Co-authored-by: FredApps <FredApps@users.noreply.github.com>