Commit Graph
5140 Commits
Author SHA1 Message Date
vangel76 de69ca4866 OpenEXR limit: a limit set while the system's memory is read stays, and a reading without answer is asked for again (#3750 review)
The session's figure set during the reading was replaced by the older reading's
answer; it is now published only while nothing set a limit meanwhile. A reading
that gave no answer now makes earlier refusals for size out of date, so the
second reading is asked for by the next request.
2026-11-17 11:10:48 +01:00
vangel76 ba2cb5f759 OpenEXR limit: one decompressed block stays at 8 GiB whatever memory a read may use (#3749 review)
The read's limit (the floor or the memory budget) bounds the planes it
allocates; one block the decompressor allocates whole is capped apart, at
the fixed floor (8 GiB, 512 MiB in the browser), with craft-exr's
max_block_bytes. A larger block is a damaged or hostile header, refused
for its size before anything is read. That refusal doesn't depend on the
limit, so remembering it for requests asking at least as much stays
right; after a limit change it is only decided once more.
2026-11-16 23:38:19 +01:00
vangel76 c0c53353fe OpenEXR limit: memory the system refuses is neither remembered nor read again at once, and never handed to the whole file's decode (#3749 review)
craft-exr's OutOfMemory is now a refusal of its own (ReadError::OutOfMemory,
Refused::NoMemory) instead of a failed read: the store doesn't remember it,
doesn't retry it or read a copy, and a picture without memory for its
effects' channels is read alone, else refused with the reason, as for a
file too large; never the image crate's decode of the whole file. The
planes held, copied into a request's new set, are reserved fallibly too;
a copy for the disk cache that can't be had is not written. The tests
that set the process-wide disk cache take turns, and a test shows that
an unreadable request stays refused when the decode limit changes.
2026-11-16 23:35:44 +01:00
vangel76 f08a2290c2 OpenEXR limit: the planes a request ends with count together, held and from the disk cache too (#3749)
The limit applied to the planes read from the file just now, so planes held in
memory or handed back by the disk cache were never counted and repeated
requests could pass it. It now applies to what the request ends with, asked
before anything is read or allocated. When the held planes don't fit with the
missing ones they are let go and the request is read on its own; only a
request that doesn't fit alone is refused.
2026-11-16 23:11:26 +01:00
vangel76 a7e7cb6b6a OpenEXR limit: only a refusal for size depends on the limit's generation; sequentially consistent counters (#3749 review) 2026-11-16 23:10:29 +01:00
vangel76 bdf500f4ba OpenEXR limit: a refusal for size is decided anew when the limit changes; a failed reading is asked twice (#3749 review) 2026-11-16 23:09:59 +01:00
vangel76 b591f95ce4 OpenEXR: a file's channels may take what the machine's RAM allows, not a fixed 8 GiB (#3749)
The limit of one read is decided here (the 8 GiB floor, or the memory
budget when that is more) and handed to craft-exr as the read's max_bytes,
so the planes it reserves and the largest block it decompresses follow it.
craft-exr reserves the planes fallibly, so the reader's own fallible plane
allocation is not needed: memory the system can't give is a read that
failed just now (read_error), a plane over the limit a refusal for size.
2026-11-16 23:09:47 +01:00
vangel76 ea4ac2e5ed Refuse OpenEXR blocks larger than their chunk can hold
craft-exr now holds every block to what its chunk's bytes can
decompress to, using the ratio the index was built with: the index is
built with craft-exr's default ratio (no longer unbounded), a file with
such a block is refused when indexed and by safe_to_decode before the
image crate sees it, and each read checks it again. Memory the system
refuses during a read is a read that failed just now, not remembered,
instead of a file too large.
2026-11-16 23:07:23 +01:00
vangel76 c1aea6d65a Bound OpenEXR pictures in memory and keep effects' depth fill
The picture of an OpenEXR file (also the black one of a file without a
main picture) is checked before anything is read: no larger than a
still may decode to and than one read of the file may allocate, else
refused with the reason instead of allocated. Import refuses such a
picture as other stills. The fill of a picture channel in a part named
like depth is the background depth again, as effects read it; the
picture is 0 outside that part's data window when composed instead.
A read decompresses on at most four threads of its own, none for a
small file.
2026-11-16 22:59:38 +01:00
vangel76 d671f6e45b Show an OpenEXR file's main picture as After Effects does
The picture of an OpenEXR file is now craft-exr's main picture: the
unprefixed R, G, B (and A) of the first part that has all three, else
the first part's unprefixed Y (and A) as grey. A file of named layers
only (Blender's ViewLayer.Combined.R, a compositor's Image.R) has none
and shows black at its display window's size, opaque, as After Effects
shows it; it still imports and its layers stay readable by effects
(EXtractoR, Cryptomatte, the 3D Channel effects).

The own picture choice (the beauty pass by name, data passes, the first
channel as grey) is gone. The picture's channels keep a fill of 0
outside the data window even in a part named like depth, so the picture
of such a file stays what the image crate shows. The golden hashes of
the named-layer files are re-pinned (their channels are unchanged), and
the docs describe the new rule.
2026-11-16 22:30:46 +01:00
vangel76 ccd4c75f4f Keep refusing damaged OpenEXR headers before a decoder sees them
safe_to_decode accepts a file only when its headers index (or name a
compression or part kind this reader doesn't cover); damaged headers,
offset tables longer than the file, oversized parts and failed reads
are refused again, as the old lenient parse did. Indexing also refuses
a channel list the exr crate's validation refused (a zero sampling
factor or one not dividing the data window, channels out of order),
since headers are now read leniently only. Follows craft-exr's new
UnsupportedCompression error kind for HTJ2K and its non-exhaustive
error enum. The damaged-file test now checks that the good files index
and read and that damaged ones reach the reader.
2026-11-16 22:02:29 +01:00
vangel76 58038903bd Read OpenEXR planes through craft-exr's seekable reader
The plane store's index and reader now use craft_exr::seek: Index::build
reads and checks the headers and offset tables, read_planes fetches only
the chunks of the requested channels, rows and level. The app keeps what
is its own: the file identity, plane names and aliases, Cryptomatte
manifests, the picture's channels, the memory cap of one read and its
message, cancellation and the error mapping. The own chunk reading,
batching and header parsing are gone, and the exr crate is only a
dev-dependency of effectcraft-media now (the tests write files with it).
2026-11-16 21:45:05 +01:00
vangel76 9ff031c5f1 Merge upstream/main into the plane store branch (#3301)
Conflicts: Cargo manifests (craft-libs pins from main, plus memory-stats, exr and
half for effectcraft-media), exr_channels.rs (the plane store's version; main's
craft-exr channel decode is replaced by the plane store until craft-exr reads
from a seekable source), pool.rs (frame_px takes the rows of #3271 and the
forget generation of #2042), session open/forget (main's forget_files plus the
reload counter), Project panel thumbnails (main's Thumb types, keyed by content).
2026-11-16 20:57:45 +01:00
FredApps 91f9e9b1ef Merge pull request #3776 from FredApps/onee/i786-psd-cutover-followup
psd: parse linked files with craft-psd and pin past #1845
2026-11-16 15:20:44 +01:00
FredApps ed8811d2d8 psd: parse linked files with craft-psd and pin past #1845
Repin only craft-psd to craft-libs main e836b6fd (includes #1845).
lnk2 / lnkD / lnk3 / lnkE records come from craft_psd::smart::linked_files;
payload ranges are shifted from the block back into the document bytes.
is_linked_layer_key is the deferral predicate.

Descriptors, placed objects, and pixel decode stay local until
craft-libs#1887 (parse_prefix) and #1885 (PackBits recovery) are on main.
2026-11-16 14:55:09 +01:00
FredApps 554bb887c8 Merge pull request #3767 from storytold/onee/i786-psd-writer-craft-psd
psd: write fixtures with craft_psd
2026-11-16 14:45:37 +01:00
FredApps 4edbd480fb Merge remote-tracking branch 'upstream/main' into onee/i786-psd-writer-craft-psd 2026-11-16 14:20:51 +01:00
FredApps cb9c1b5e1a Merge pull request #3766 from storytold/onee/i786-psd-reader-craft-psd
psd: read the document structure with craft_psd (#786)
2026-11-16 14:20:28 +01:00
FredApps 5d5be53bef Merge remote-tracking branch 'upstream/main' into onee/i786-psd-writer-craft-psd 2026-11-16 13:55:36 +01:00
FredApps dfa9584993 Merge remote-tracking branch 'upstream/main' into onee/i786-psd-reader-craft-psd 2026-11-16 13:55:36 +01:00
Dylan M. Taylor b617ea08e5 Merge pull request #3745 from storytold/extract/shared-sony-luts
effects: cut SPI3D and SPIMTX parsing over to craft-cms
2026-11-16 07:33:27 -05:00
FredApps 7311b6574c psd: rustfmt write.rs to the workspace style
The previous commit had been formatted without rustfmt.toml
(use_small_heuristics = "Max"), so cargo fmt --check failed on the gate.
2026-11-16 13:30:21 +01:00
FredApps f8aa110655 Merge remote-tracking branch 'upstream/main' into onee/i786-psd-reader-craft-psd 2026-11-16 13:30:21 +01:00
FredApps 2fdf6f4912 Merge remote-tracking branch 'upstream/main' into onee/i786-psd-writer-craft-psd 2026-11-16 13:30:10 +01:00
ash 7b4138e2fb Merge pull request #2047 from arnav-hiwarkar/perf/timeline-drag-adaptive
Fast Previews: Adaptive Resolution applies while dragging in the Timeline
2026-11-16 17:31:17 +05:30
FredApps 952918aa02 psd: keep finite 32-bit color samples outside 0..1
Integer depths are still clamped. NaN and infinities use the same
mapping as the reader.
2026-11-16 12:59:44 +01:00
FredApps 105cd87f42 Merge remote-tracking branch 'upstream/main' into onee/i786-psd-reader-craft-psd 2026-11-16 12:57:55 +01:00
FredApps 12746e0dd1 Merge remote-tracking branch 'upstream/main' into onee/i786-psd-writer-craft-psd 2026-11-16 12:57:46 +01:00
ash 5300531387 Merge pull request #2042 from arnav-hiwarkar/perf/close-project-frees-caches
Close, New and Open Project free the closed project's memory
2026-11-16 17:27:13 +05:30
Dylan M. Taylor 9fa8a069da Merge current main and pin merged shared Sony LUT readers 2026-11-16 06:51:41 -05:00
FredApps 7f9f0bc489 psd: record stray leading bytes before the layer block check, use craft-psd's long-length keys 2026-11-16 12:31:10 +01:00
FredApps 00bf6a06c9 psd: keep the luni block's bytes so exported files are unchanged 2026-11-16 12:30:10 +01:00
FredApps e9690b2c02 psd: walk top-level global blocks for the layer block repair 2026-11-16 12:17:28 +01:00
FredApps 6ddcd5ee9c Merge pull request #3765 from storytold/onee/i781-drop-filmcraft-codec-pins
media, export: drop the filmcraft-mpegts, -vp9, -hevc and -av1 pins for craft-libs (#781)
2026-11-16 12:04:47 +01:00
FredApps e51a805f4e psd: recover layers from a length-prefixed or fallback Lr16/Lr32 block 2026-11-16 12:04:22 +01:00
FredApps 49abf0b402 psd: write 32-bit layers in Lr32, wide RLE rows raw 2026-11-16 11:57:54 +01:00
FredApps 50f8cc3397 psd: write fixtures with craft_psd 2026-11-16 11:45:48 +01:00
FredApps 59671cfd29 psd: keep layers past a damaged resource, report an unreadable Lr16 block 2026-11-16 11:41:54 +01:00
FredApps 1cc80e7443 psd: read the document structure with craft_psd
Psd::parse reads the header, colour mode data, layer records with their
additional information and the global blocks with
craft_psd::PsdFile::from_source. Channel data and the merged image stay in
the document as ranges, and the linked-file blocks are left in the source.
A damaged layer section still opens as the merged image. The local 8BPS
section, record and block walkers are removed (storytold/craft-libs#786).
2026-11-16 11:33:33 +01:00
FredApps 3570d59d43 media, export: read MPEG TS AAC config and check encoders with craft-libs, drop four filmcraft pins
crates/media reads the MPEG TS/PS stream FilmCraft's source plays with
craft_media::mpegts and LATM configuration with craft_audio::aac::latm_config.
The VP9, HEVC and AV1 encoder round-trip tests decode with craft-video's
decoders. filmcraft-mpegts, filmcraft-vp9, filmcraft-hevc and filmcraft-av1
are no longer direct dependencies (storytold/craft-libs#781).
2026-11-16 11:18:56 +01:00
FredApps 3d84810b43 Merge pull request #3735 from storytold/i778/effectcraft-opus-craft-audio
Export: WebM Opus from craft-audio; remove crates/opusenc
2026-11-16 11:10:13 +01:00
FredApps ce23259bf5 Merge main into i778/effectcraft-opus-craft-audio
Take #3763's shared GIF/WebP frame decode (craft-gif/craft-webp frames
features). Keep workspace craft-libs pins at 5a7a63a2 except the #3653
PDF/PS pins at 808730f4.
2026-11-16 10:32:46 +01:00
FredApps b8fb20d3ac Merge pull request #3221 from vangel76/rotation-tool-drag-2769
The Rotation tool turns a layer by exactly the angle you drag from the press point
2026-11-16 10:30:40 +01:00
FredApps 7c3a9ffe15 Merge pull request #3218 from vangel76/graph-flat-segments-2720
Graph Editor curves pass through every keyframe and show Hold steps as vertical jumps
2026-11-16 10:29:41 +01:00
FredApps 2bfb8bad3b Merge pull request #3254 from vangel76/effect-controls-alt-expression-1460
Alt-click on a stopwatch in Effect Controls adds or removes an expression, as in After Effects, instead of toggling keyframes
2026-11-16 10:28:40 +01:00
FredApps e250f8fcb6 Merge pull request #3707 from gmrmad1/docs/roadmap-2026-11-15
docs: bring ROADMAP.md and parity assessment current through 2026-11-15
2026-11-16 10:27:08 +01:00
FredApps 583a8a02db Merge pull request #3147 from dotCooCoo/fix/plugin-library-file-url-unc
Plug-in Library: a file URL cannot name a network path
2026-11-16 10:26:13 +01:00
FredApps af069369fc Merge pull request #3148 from dotCooCoo/fix/plugin-library-release-urls
Plug-in Library: a package downloads only release assets of its repository
2026-11-16 10:25:12 +01:00
FredApps 3a7999f5cd Merge pull request #3763 from storytold/codex/effectcraft-gif-webp-decode-shared
media: decode animated GIF and WebP through craft-gif and craft-webp (#778)
2026-11-16 10:23:11 +01:00
FredApps 2881f048f1 Merge pull request #3343 from dotCooCoo/fix/update-outcome-at-start
Updates: the first start after an update shows how it ended
2026-11-16 10:23:06 +01:00