Commit Graph
3664 Commits
Author SHA1 Message Date
tylerjenningsw c979f585ac Timeline: focus newly added expressions after Alt-click (refs #1072)
Alt-clicking a stopwatch added an expression, but its editor needed
another click before typing went into it. In After Effects the new
expression's field takes the keyboard at once, its text selected.

The pick whip's one-shot refocus (the editor takes the keyboard back
after a reference goes in) is now an ExprFocus request for any
property: which text to select, counted from the end, and the pass it
was asked for in. An Alt-click that adds an expression asks for it with
the whole text selected, so typing replaces it; the expression row is
opened if it was closed and scrolled into view (it is added below the
stopwatch's row, which can be the last one shown). The request is taken
once, when the editor is drawn, and dropped if its expression doesn't
appear or it isn't taken within a few passes, so it never takes the
keyboard later; an Alt-click that removes the expression clears it.

Tests (ui_inline_edit): typing straight after the Alt-click replaces
the new expression; a field clicked right after keeps the keyboard;
after removing it nothing has the keyboard; an expression added at the
Timeline's bottom brings its editor into view with the keyboard. Both
fail on main.
2026-10-13 13:47:22 -04:00
tylerjenningsw 87d28ac6fe GPU: a frame the device rejected isn't reported as out of memory (refs #1319) 2026-10-13 13:43:33 -04:00
tylerjenningsw 1b3a70a7bc GPU: discard_kept is public like clear_uploads, so wasm builds don't flag it unused (refs #1319) 2026-10-13 13:43:33 -04:00
tylerjenningsw babdcd3b9f GPU: the frame guard contains validation errors and drops the failed frame's textures (refs #1319) 2026-10-13 13:36:04 -04:00
tylerjenningsw f382e5a5d6 UI: an expression on separated X Position turns only X red (#1306)
With Separate Dimensions, X Position and Y Position are separate scalar
properties. The new test puts an expression on X Position only and checks,
in the Timeline and Properties panel and in both themes, that X is red and
Y keeps the ordinary colour. It fails on main.
2026-10-13 13:32:14 -04:00
tylerjenningsw ec29d78ca2 GPU: working textures are labelled with their size (refs #1319) 2026-10-13 13:25:42 -04:00
sanyamsingh001andCodex 36ebe2eada Honor duration rounding in timeToFrames
Round nonzero duration frame counts away from zero while retaining
absolute-time rounding, default argument selection and numeric coercion.

Cover fractional durations, absolute controls, defaults and coercion.
Sort expected paths in the existing footage test for temporary-directory portability.

Co-authored-by: Codex <codex@openai.com>
2026-10-14 03:21:23 +10:00
vangel76andClaude Sonnet 5.5 6bf9c87a1a Markers: the disk key keeps protected markers with a duration and drops a lone plain comp marker (#1083)
pixel_form_with borrowed the comp unchanged when it held only comp markers and no layer
markers, so a lone plain comp marker still reached the disk key. Tests: a lone comp marker
keeps the key; a protected marker with a duration (and its duration) on a stretched precomp's
source changes the key of the comp that nests it.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-13 19:07:25 +02:00
Lloyd NicholsonandClaude Opus 5.5 d309d6f1d0 Effects & Presets: drag animation presets onto a layer
Preset rows (text, built-in and user .ecpreset) were click-only, so dragging
one onto a layer did nothing. They now start a DragPayload::Preset drag with
a ghost, and the Timeline, Composition viewer and Effect Controls apply the
preset to the layer it is dropped on, as they already do for effects and as
After Effects does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 19:04:33 +02:00
DWAA1660andClaude Opus 5.5 76a3e7eefe Masks: addVertex and setVertex fill in missing tangents of a loaded path (#1250)
A path's vertices and its two tangent arrays deserialize independently,
and nothing on load makes them agree. mask.new pads them, but a path
read from a project file may carry fewer tangents than vertices.
mask.addVertex checked its index against the vertices only and then
inserted into both tangent arrays, and mask.setVertex indexed the
tangent arrays after the same check, so either command panicked on
such a path (Vec insert/index out of bounds).

ShapePath::fit_tangents gives both arrays one entry per vertex (missing
tangents become corners, extras are dropped), and edit_path_counted
calls it on the value it edits, so every mask/shape-path vertex command
works on a consistent path. Other keyframes of an animated path were
already padded by apply_count_op when the vertex count changes.

Tests: two regression tests save a project, cut every mask path's
tangent arrays to one entry (static value and keyframes), reopen it
through Project::from_json and run setVertex and addVertex. Both panic
at mask.rs:209 without the fix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 11:04:02 -06:00
tylerjenningsw 764e9c5cde UI: expression value colour tests require every part, hover in every panel and a drag (#1306)
Each checked property now names the panels that must show it: the layer's
Position, Rotation and Opacity in the Timeline and Properties panel, the
Transform effect's in Effect Controls. Every component rectangle is
required, and the painted text must include both numbers of a vector (and
the Timeline's comma), the revolutions, sign and degrees of an angle, and
the number of a scalar. These presence checks run in both themes and after
every expression state change.

Hover now covers all three panels in dark and light themes, and a new test
scrubs Opacity in the Timeline and Effect Controls, confirming a drag is
active before checking the colour. All four tests fail on main.
2026-10-13 13:02:37 -04:00
zitann2020andDeepSeek V4.1 Flash 5569aad8b5 i18n(ja): four labels After Effects contradicts
Co-Authored-By: DeepSeek V4.1 Flash <noreply@deepseek.com>
2026-10-14 01:57:37 +09:00
tylerjenningsw e923a645f7 UI: colour expression-driven values red in the Timeline, Effect Controls and Properties (#1306)
A property driven by an expression showed its value in the ordinary blue;
After Effects shows it red (refs #1072). Tokens::for_value(expression)
gives the value fields the expression colour (expr_text, dark and light)
for both hot_text and accent_hover, so a hovered or dragged value stays
red. The Timeline's value_editor, Effect Controls' parameter rows and the
Properties panel's transform rows pass these value tokens to their
number and angle fields (and the Timeline's vector separator and plain
enum number), from Property::has_expression() every frame: a disabled,
removed or empty expression is blue again. Names, stopwatches, keyframe
buttons, link icons and dropdowns keep the ordinary tokens. Red means an
expression drives the value, not that it evaluated; errors keep their
own reporting.

Tests (ui_expression_values, reading the painted text colour): a vector
(Position, with its separator), an angle (Rotation, both parts) and a
scalar (Opacity), on the layer and on the Transform effect, are red in
all three panels, in dark and light themes, and Scale (no expression)
stays blue; disabled, removed and whitespace-only expressions are blue
and enabling again is red; a hovered expression value stays red while a
hovered ordinary one takes the hover accent. All three fail without this
change. ui_effect_controls and ui_inline_edit still pass.
2026-10-13 12:27:50 -04:00
tylerjenningsw 987faa0b20 Timeline: selected nulls get no track matte (#1260)
The Track Matte menu and pick whip applied to every selected layer,
nulls, cameras and lights included, though their rows have no Track
Matte. A mode chosen for selected solids then went to a selected null
too: at the top of the comp it had no layer above to take as its matte
and the whole change was refused; at the bottom it took the layer above
as its matte and hid it.

Track Matte edits now go to the selected layers that can have a matte
(matte_layers); parenting still includes nulls, cameras and lights.

Tests (ui_batch_links): a selected null on top or at the bottom gets no
matte and changes nothing else; a layer locked with its Lock switch
stays selected and keeps its parent, transform and matte through the
other row's menus and pick whips. Both fail before.
2026-10-13 12:19:36 -04:00
tylerjenningsw 6f57b9eee3 Parent and Track Matte: locked layers keep theirs (#1260)
With several layers set at once from one selected row, a selected
layer locked after it was selected (its Lock switch doesn't deselect
it) had its parent, its compensated transform or its matte changed too.

layer.setParent, layer.setTrackMatte and layer.trackMatte now leave
locked layers as they are, the rule the other layer edits follow
(unlocked): among several, the others change; alone, it is an error
that changes nothing. Done in the engine, a layer locked while a pick
whip is being dragged is covered too.

Test: locked_layers_keep_their_parent_and_matte.
2026-10-13 12:19:35 -04:00
Ian-ChegeandClaude Opus 5.5 5270eab095 Masks: Mask Expansion past a curve's radius grows a solid mask instead of a ring
Expansion was a fill plus a stroke 2·|expansion| wide, blended per pixel. Once the
expansion passed the shape's curvature radius the stroke's inner edge inverted: a
20 px circle expanded by 60 left a ring with the layer showing through the middle,
+600 cut only the original dot, and negative values left islands. The outline is
now offset with Offset Paths' geometry (round joins) and filled.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 19:15:30 +03:00
MarekSpodBiedry 9050b1818e Scripting: add the missing app.preferences.saveToDisk() so imported scripts like Duik get past startup (#1263) 2026-10-13 18:02:11 +02:00
zitann2020andDeepSeek V4.1 Flash 2ff7639219 i18n(ja): the resolution labels agree with the panel catalog and After Effects
Co-Authored-By: DeepSeek V4.1 Flash <noreply@deepseek.com>
2026-10-14 00:57:21 +09:00
Vikram Bhaskaran d15c82b163 Liquify: expose Distortion Mesh Offset in Effect Controls (#1194)
After Effects' Liquify shows Distortion ▸ Offset (x, y), and the renderer
already applied distortionMeshOffset — sampling the mesh at layer
coordinates minus the offset — but the parameter was declared hidden, so
users could neither see nor edit it, and #1194 read as 'the effect does
not work and the Offset option is missing'.

It is now a visible 2D Point control (still defaulting to 0,0, still
scriptable by its old path). Regression test: the spec exposes it as a
Point, a [20,0] offset moves the displaced-region centroid right by the
offset (the render differs, and the left of the shifted mesh is back to
untouched pixels), docs/effects.md refreshed via UPDATE_DOCS.
2026-10-14 02:46:26 +11:00
Vikram Bhaskaran bde6eb57f3 UI: Spacebar previews the demo opened from the start screen (#1059)
The reported flow — launch to the start screen, Open Demo Project, press
Space — does not reproduce on main: the demo comp activates, the start
screen closes, and playback starts. The behaviour already held (the
#279 menu-focus and #204 start-screen work fixed the neighbouring bugs),
so this lands as a regression test:
space_previews_after_opening_the_demo_from_home walks the exact flow
headlessly and asserts playing=true.

cargo test -p effectcraft-ui-egui --test ui_menus: 8 passed.
2026-10-14 02:20:07 +11:00
Vikram Bhaskaran f12d75e37a Engine: Interpret Footage loop coverage for sequences (#1068)
Looped *video* footage had a regression (#1045); a grouped PNG sequence
going through the same path — interpret a fresh placeholder to Loop 15,
drag it onto the timeline — did not. The behaviour is already correct on
main (addItem sizes a sequence layer from looped_duration, the pool's
frame_index wraps per cycle), so this is coverage, not a change:
interpret_footage_loop_extends_sequence_layers asserts a 15-loop of a
0.4 s sequence lands a 6 s layer.

cargo test -p effectcraft-engine --lib interpret_footage: 4 passed.
2026-10-14 02:15:32 +11:00
Vikram Bhaskaran 4ddf5ffd6f CC Particle World: motion blur smears particles across the shutter (#1195)
With the comp's and the layer's motion-blur switches on, the renderer
hands effects the shutter (angle, phase, samples) — CC Particle World
now uses it: eight to sixty-four sprite fields sampled across the shutter
are averaged into the transfer, so fast particles draw the motion trails
After Effects shows instead of one sharp frozen field.

The GPU particle pass defers to the CPU while the shutter is open
(catalog::gpu_supported), keeping the oracle identical on both backends.

Tests: sim::particle_world_motion_blur_trails (blurred differs from
sharp, lights more pixels, keeps alpha energy) and a catalog assertion
for the CPU gate; effects 450 and gpu 212 lib tests pass; fmt and
clippy -D warnings clean.
2026-10-14 02:01:30 +11:00
tylerjenningsw 4ce9569454 Timeline: parent and matte selected layers together (#1260)
On a selected layer's row, the Parent menu and pick whip and the Track
Matte menu now set every selected layer's parent or matte, as moving a
selected layer's bar moves them all; on an unselected row they set that
layer's alone. Each is one undo step. A selected layer chosen as the
parent or the matte is left out of the layers it links, and parenting
that would make a loop is refused as a whole.

A new matte layer keeps each layer's mode (layer.setTrackMatte with
kind: preserve); a mode and No Track Matte apply to all of them.

The Track Matte column gets a pick whip, like the parent's
(timeline.layer.<id>.trackMattePickWhip, with a translated tooltip):
dropped on an audio-video layer's row, it makes that layer the matte.
The layers a parent or matte pick whip links are taken when its drag
starts.

Tests (ui_batch_links): the Parent menu and pick whip, and the Track
Matte menu, mode, No Track Matte and pick whip, with real clicks and
drags: selected layers change together and unselected ones don't, modes
are kept, one undo puts links, compensated transforms and the matte's
visibility back, and a refused cycle changes nothing. Both fail on main.
2026-10-13 10:52:40 -04:00
tylerjenningsw f51b4b7e1b Track Matte: set the matte of several layers at once (#1260)
layer.setTrackMatte took one layer. It now also takes `layers`, set in
one undo step; `layer` and the first selected layer still work as
before. `kind: "preserve"` keeps each layer's own matte mode (Alpha for
a layer without one), so giving several layers a new matte doesn't turn
a mix of Alpha and Luma mattes into one mode; without `kind` the mode
is Alpha, as before. A layer can't be its own matte and an empty list
is refused, before anything changes.

Test: several_layers_take_one_matte_and_keep_their_modes.
2026-10-13 10:52:40 -04:00
dotCooCoo 1cc315708e Find Missing Fonts: fonts found by their PostScript or full name are no longer listed
File > Dependencies > Find Missing Fonts listed a text layer whenever
its font matched no family name, while text layout finds a font by its
family, PostScript or full name (effectcraft_text::resolve). For a
layer set to the PostScript name Inter-Bold, EffectCraft draws the text
in Inter Bold, and text.fontFeatures reports the layer's font as not
missing. Find Missing Fonts listed that layer and a layer set to the
full name Inter SemiBold.

find_missing now lists a layer when effectcraft_text::resolve, which
text layout uses for each run, reports the layer's font as missing.

fonts_named_by_their_postscript_or_full_name_are_not_missing adds text
layers in Noto Serif, Inter-Bold, Inter SemiBold and a font that no face
has, and checks that Find Missing Fonts lists only the last one.
2026-10-13 07:43:21 -07:00
zitann2020 9ab33d9758 i18n(ja): the first rows of the Japanese effect catalog (#821) 2026-10-13 23:33:38 +09:00
Matej Kozlovský 9a202b133a Render: effect stacks keep the cover's pixel-grid phase, only known-margin stacks skip the cover, and displacement and Repeat Edge Pixels get the room the cover gave them (#1205) 2026-10-13 15:53:10 +02:00
nanox333 e043fc0bb0 #712: color pickers get an eyedropper everywhere
The Character panel's pipette (#938) only sampled text. Every color picker now has an eyedropper in its hex row: click it, then click in the Composition panel to take the color under the pointer. The picker is one shared popup, so Solid Settings, Fill and Stroke, attached images, effects and the rest get it without caller changes.

- color_picker: the eyedropper arms the picker. Escape or a second click disarms it and the picker stays open. While armed, the viewer shows a crosshair, a "Click to sample color" chip and a swatch under the pointer, and the next press on the viewer samples into the picker. A press over the picker or a dialog is not a sample, and a press elsewhere closes the picker as before.
- The Character panel's pipette glyph moves to color_picker::draw_pipette, so both show the same icon.
- Automation id colorPicker.eyedropper.
- Modal dialogs (modal_fit) and the picker's popup register their rects as overlays, so a press on them never samples the viewer beneath.

Not compiled, tested or rustfmt-checked: the machine it was written on has no Rust toolchain. Run cargo xtask ci before relying on it. Pushed to the fork for testing only.
2026-10-13 15:47:05 +02:00
Vikram Bhaskaran fb715d9015 Render: drop the blanket layer cover from effect stacks; effects pay only what they need (#1205)
Since #659 every text or shape layer with an enabled video effect grew its
effect buffer to the comp-sized layer rectangle before the stack ran, so
glow and blur — which only need their own margins — allocated a 1920x1080
RGBA32F texture per layer per frame in flight (~5 GB peak VRAM in parallel
export, measured on an RTX 3090).

Effects that actually place pixels outside the painted content already
grow the buffer themselves by exactly what they need (CC Tiler, CC Smear,
CC Mosaic sharp via layer_cover_pad / Buf::pad), on CPU and GPU. The
blanket target.cover(layer_size) in Renderer::run_effects_on, the
FxTarget::cover trait method with its CPU default, and the GPU
GpuTarget::cover texture allocation are removed; Buf::cover/cover_plan
stay as the effects-crate helpers they were designed as.

The #659 regression tests (tiling across the layer region, centred-shape
edge pinning) and the render/effects/gpu suites pass unchanged.
2026-10-14 00:32:56 +11:00
Vikram Bhaskaran 48738093b5 Shapes: Merge Paths keeps paint that belongs to a group above it (#1174)
A Merge Paths item appended to a shape layer's Contents cleared every draw
collected so far, including fills and strokes inside groups above it, so
the layer's shapes vanished from the render. AE's rule is per group: only
paint items in the merge's own group above it are dropped. Draws now
record which contents level created them; the merge drops only its own
group's paint, and the group-bubbled draws keep rendering.

Adds a regression test (Merge Shapes and Add modes) that renders nothing
without the fix.
2026-10-14 00:02:12 +11:00
Vikram Bhaskaran 2720ae5fe2 Wave Warp: cover the Top/Bottom edge pinning paths end to end (#1181)
The pinning regression only exercised All Edges (and Left Edge in the CPU
unit test), so the reported 'does not work with Top/Bottom Edge' had no
coverage to catch or clear it. This holds the pinned first/last row in a
CPU test at Direction 90, and adds CPU/GPU parity cases for Top (4),
Bottom (6), diagonal directions, and single-edge pinning on shape layers.
CPU pinning verified correct on main: the guards in dst_wave_pin/wave_pin
agree; the gap was that neither edge path was tested.
2026-10-13 23:40:32 +11:00
Jannik Wappler dbc595b0d6 #1220: Hide layer bounds during path editing 2026-10-13 15:38:06 +03:00
vangel76andClaude Sonnet 5.5 89ae151c03 #1221: two path-format test failures on Windows
Problem: on Windows two tests failed on main although the app is fine; they assumed
macOS/Linux path formats.

Fix: the CLI test strips the verbatim path prefix that canonicalize adds on Windows (a
child's current_dir() never reports it); the host sink test uses a drive-letter path on
Windows (a path rooted without a drive is joined to the home drive by the engine, the test
expected the current drive). Test code only.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-13 14:25:42 +02:00
vangel76andClaude Sonnet 5.5 46aa69482d Merge upstream/main into fix-1083-beat-marker-audio-pause
Upstream's #1167 fix and this branch both stop marker edits from invalidating
cached frames. Kept this branch's shared Project::reads_markers/same_pixels_with/
pixel_form_with (viewer frames, disk cache, nested comps) and folded upstream's
rules into them: any expression counts as reading markers, protected time
markers with a duration still change the frames.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-13 14:17:47 +02:00
arnav-hiwarkar bb1a0e5209 perf(media-browser): reuse listings and cache filename sort keys 2026-10-13 17:42:07 +05:30
pravdomilandClaude Opus 5.5 07168cbf22 Settings: the page list's rows touch, with no gap between them
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 14:07:19 +02:00
tylerjenningsw c75ea46c86 Preview: the start with sound never waits for ever (#947)
The startup hold waited for the current frame to be cached before
anything else, so a frame that can never be cached held the first frame
for ever: a zero RAM preview budget, or a single frame larger than the
budget (which the comp-size estimate misses for Extended Viewer frames).

It now gives up at once when the budget can't hold even one comp-sized
frame, and otherwise after STARTUP_WAIT (2 s from pressing play): the
sound starts from the first frame, and the preview goes on as a stalled
one does. frame_bytes() is factored out of frames_that_fit() for it.

Tests (ui_audio_scrub): with a budget of 0 or half a frame the sound
starts on the first step; with an Extended Viewer frame larger than the
whole budget (the estimate says one fits) the first frame holds for about
two seconds, then the sound starts. Both wait for ever on the previous
commit. The Extended Viewer setup is now shared by its two tests.
2026-10-13 07:56:29 -04:00
Kristian Myram ab692dce70 #1190: enable drag toggling for built-in checkboxes 2026-10-13 11:43:31 +00:00
Kristian Myram 5586b40cf0 #1190: clear existing STL Clippy warning 2026-10-13 11:43:31 +00:00
arnav-hiwarkar da06216475 perf(presets): reuse cached text and user preset data 2026-10-13 16:48:19 +05:30
Moein Saharkhiz 2ddbf20466 #1070: refresh layered composition sources on import 2026-10-13 06:16:07 -04:00
Kristian Myram 037a21d5a6 #1200: allow TGA proxies and add import regressions 2026-10-13 10:09:51 +00:00
Kristian Myram 058da6f3b0 CI: use a match guard in the STL reader 2026-10-13 10:09:51 +00:00
arnav-hiwarkar b63efeb0d3 perf(project): read file sizes once per sort 2026-10-13 15:12:32 +05:30
Brandon ThomasandClaude Opus 5.5 549e9d8251 Footage: the missing-footage toast names the real menu item, Relink Missing Footage… (#1106)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 05:34:22 -04:00
Brandon Thomas 7a9213611e Merge pull request #1106 from eliasx45/upstream/relink-moved-footage
# Conflicts:
#	docs/footage.md
2026-10-13 05:34:14 -04:00
Brandon ThomasandClaude Opus 5.5 91ee7bf1b3 cargo fmt
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 05:23:52 -04:00
Brandon ThomasandClaude Opus 5.5 6c799f3c3b Batch fixes: tests and catalogs that meet each other once the batch lands together
- Keyboard Shortcuts: Enter is not Delete while the delete confirmation is open (#1113 with #1019).
- Speed graph drag test compares proportions, since the Graph Editor now fits its selection (#1182 with #1109).
- Spanish panel test no longer demands the Chinese catalogs' exact rows (#996 with #1189, #1019).
- Object Matte gets its Simplified Chinese effect-name row (#1199 with #792).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 05:23:30 -04:00
Brandon ThomasandClaude Opus 5.5 3ac283eee4 Review fixes for the landed batch
- Cryptomatte (#1183): planes shorter than the image read as empty instead of panicking.
- layer.addMarker (#1180): a comp marker no longer replaces one at the same time.
- Desktop (#1005): ignore macOS's -psn_ argument instead of refusing to launch.
- Doc comments put back on their own items (#1153, #1037).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 04:47:52 -04:00
Brandon ThomasandClaude Opus 5.5 900b921dbf PSD: the optimisation tests use the reference decoder once #1137 and #1139 land together
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 04:47:52 -04:00