Commit Graph
4294 Commits
Author SHA1 Message Date
FredApps c149bb513f psd: read vector mask records through craft-psd 2026-11-18 13:19:34 +01:00
ash 3f1cd00745 Merge pull request #3843 from arnav-hiwarkar/fix/3830-3831-ocio-lut-limits
OCIO: cap the .3dl mesh and rows before cubing them (#3830)
2026-11-18 17:20:01 +05:30
FredApps 8a4a29b227 Merge pull request #3779 from FredApps/onee/i786-psd-descriptors-placed
psd: parse descriptors and placed layers with craft-psd
2026-11-18 18:36:59 +07:00
arnav-hiwarkar c6612da798 #3830: tell a 3-entry .3dl mesh apart by the row count alone 2026-11-18 15:46:04 +05:30
arnav-hiwarkar bf31b65271 #3830: keep four .3dl tokens and a spare mesh row at small limits 2026-11-18 15:38:08 +05:30
arnav-hiwarkar 648ae78591 #3830: test the .3dl cap through an injectable limit; drop the local .spi3d precheck (#3831 belongs in craft-cms) 2026-11-18 15:27:36 +05:30
Sean Hawkey 67942cda7b Expressions: a layer parameter left at None is the layer it sits on (#3601)
Fixes #3601.

### What

A layer parameter left at None (a Layer Control, or an effect's layer parameter) now stands for the layer it sits on, as in After Effects (values observed in AE 26.3 are in #3601). Before, its value was `null`. The property was still truthy, so a rig's `L ? L.sourceRectAtTime(t) : 0` went down the wrong branch and stopped with "not a callable function".

The change is one line in `Prop.__wrap` (`crates/expr/src/prelude.js`).

### Tested

- **`an_empty_layer_control_stands_for_its_own_layer`** in `crates/expr/src/tests.rs`: truthiness, `name`, `index`, the `L ? L.transform.position[0] : -1` pattern, and `sourceRectAtTime`. It fails without the change.
- **Suites:** `cargo test -p effectcraft-expr` (167 passed) and `cargo test -p effectcraft-script` pass. clippy and fmt are clean.
- **Not covered here:** calling the empty parameter like a layer (`L("ADBE Transform Group")`). That depends on #3554, and works with both applied.
2026-11-18 16:25:57 +07:00
JCleanCode 981981632c Fix #1986 Cmd+A ("select all") doesn't work in "Import multiple files…
Fixes #1986

**Cause.** On macOS the open panel has no key equivalents of its own. Cmd+A (and C/V/X/Z) work
because the menu bar sends `selectAll:`, `copy:` and so on down the responder chain to the key
window. EffectCraft's Edit items are custom muda items, so while the sheet was up Cmd+A ran
Edit > Select All on the Project panel behind it.

**Fix.** The native file dialogs on screen are counted (`native_dialogs`). While one is open on
macOS, Undo / Redo / Cut / Copy / Paste / Select All become macOS predefined items, which send
the real actions to the dialog. The other `edit.*` items are disabled. The UI is repainted when
a dialog opens so the menu is rebuilt before the next key.

**Tests.** `edit_menu_is_disabled_while_a_file_dialog_is_open`,
`edit_text_commands_are_predefined_while_a_file_dialog_is_open`. Checked by hand on macOS:
Cmd+A in "Import multiple files" selects the files.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
<!-- coderabbit-ai-generated:v1 -->

## Summary by CodeRabbit

* **Bug Fixes**
  * On macOS, Edit menu commands are disabled while a native file dialog is open and return to their appropriate enabled state when it closes or is canceled.
  * While a dialog is open, Undo, Redo, Cut, Copy, Paste, and Select All appear as native macOS menu commands with their current labels.
  * Opening a file dialog now triggers an immediate interface refresh, helping the menu update before the next key event.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-11-18 16:25:06 +07:00
FredApps 49170cdf18 fix(psd): surface unsupported modern placements at import boundary 2026-11-18 09:43:01 +01:00
FredApps cb3f66e06c fix(psd): align local warp bounds with shared numeric contract 2026-11-18 09:36:47 +01:00
FredApps a1c1288b13 #3779: pin bounded PSD placement fixes and test app boundaries 2026-11-18 05:59:44 +01:00
FredApps cc5c5cb732 #3779: integrate reviewed shared PSD adapters with current main 2026-11-18 04:13:58 +01:00
arnav-hiwarkar 104875a897 #3830: read only the three .3dl Mesh header tokens it uses 2026-11-17 22:28:16 +05:30
arnav-hiwarkar 6232bed556 #3830: stop collecting a .3dl line's numbers past the mesh limit 2026-11-17 22:20:14 +05:30
arnav-hiwarkar a65a1f746f #3830: cap the .3dl mesh and rows and cube with checked math; #3831: refuse a .spi3d short of its rows before the lattice is reserved 2026-11-17 22:11:34 +05:30
arnav-hiwarkar d550d3d476 #3830: regression tests for hostile .3dl meshes and row-less .spi3d lattices 2026-11-17 22:09:04 +05:30
arnav-hiwarkar c07dbf32ca Merge remote-tracking branch 'upstream/main' into fix/3464-drop-shadow-softness-range 2026-11-17 20:54:02 +05:30
ash 4c38f78307 Merge pull request #3817 from arnav-hiwarkar/fix/3467-radial-blur-amount-range
Radial Blur: Amount takes After Effects' range 0..1000
2026-11-17 19:03:14 +05:30
ash 0bd848c272 Merge pull request #3153 from jayzed80/fix/parse-cube-huge-size
fix(effects): parse_cube rejects a hostile LUT_3D_SIZE before cubing it
2026-11-17 18:37:21 +05:30
arnav-hiwarkar eb14583749 Merge remote-tracking branch 'upstream/main' into fix/3467-radial-blur-amount-range
# Conflicts:
#	crates/aep/src/export/fx_defs.rs
#	crates/engine/src/tests/effect_ranges.rs
#	docs/effects-parity.md
2026-11-17 18:34:15 +05:30
arnav-hiwarkar 7f14df8355 Merge upstream main into fix/3460-gaussian-blur-range
Keeps the Gaussian Blur (#3460) and Sharpen (#3466) tests in
crates/effects/src/misc.rs; Sharpen's code is as main has it.
2026-11-17 18:08:30 +05:30
ash a188867a42 Merge pull request #3810 from arnav-hiwarkar/fix/3466-sharpen-amount-range
Sharpen: Amount takes After Effects' 0..4000 range (#3466)
2026-11-17 18:06:39 +05:30
arnav-hiwarkar 44663c5e9f #3464: raster: an unbounded blur is exactly 0 where it doesn't reach
Outside the boxes' combined reach of the moved line the result is 0,
but boxes_unbounded still evaluated the prefix-sum polynomials there,
and far past the line their cancelling terms left a rounding residue
(about 5 for a one-pixel line moved a billion pixels). Those positions
are now 0 without evaluating anything. Also wraps the raster re-export
line rustfmt asks for.
2026-11-17 17:58:30 +05:30
arnav-hiwarkar ff9584fa64 Merge remote-tracking branch 'upstream/main' into fix/3467-radial-blur-amount-range
# Conflicts:
#	crates/engine/src/tests/effect_ranges.rs
#	docs/effects-parity.md
2026-11-17 17:57:33 +05:30
arnav-hiwarkar 69666e68c7 Merge upstream main into fix/3460-gaussian-blur-range
Keeps the Gaussian Blur (#3460) and Turbulent Displace (#3469) rows in
the engine range test and the effects parity log.
2026-11-17 17:57:21 +05:30
arnav-hiwarkar 1654633bcf fix(effects): test the cube row bound without a huge input 2026-11-17 17:33:35 +05:30
arnav-hiwarkar ce0c4c8a75 #3464: Drop Shadow: blur before moving when the margin is cut
With the padding cut to its budget, a Distance larger than what's left
of the margin moved the layer out of the buffer before the blur, so the
blur had nothing to spread back in: a 64 x 48 layer moved 3000 px at
Softness 8000 left no shadow at all. The cut-margin path now samples
only the fraction of the move and lets the blur move the rest:
raster::gaussian_blur_unbounded_at evaluates the transparent-edged blur
of the image at a whole-pixel shift, through a window the size of the
buffer, so content outside the window still reaches into it. Margins
that fit are unchanged.

The blur's intermediate rows are freed before the output is allocated,
so it holds at most three buffers at once. On an M-series Mac a
4096 x 4096 layer at Softness 30000 takes 0.51 s, and 1080p 0.13 s.
2026-11-17 17:30:44 +05:30
arnav-hiwarkar 06c41a1ee4 fix(effects): merge current upstream main into cube safety fix 2026-11-17 17:27:35 +05:30
arnav-hiwarkar 1eb4f39808 fix(effects): bound cube data row collection 2026-11-17 17:27:22 +05:30
arnav-hiwarkar 95685d8d41 Merge remote-tracking branch 'upstream/main' into fix/3469-turbulent-displace-amount-range
# Conflicts:
#	docs/effects-parity.md
2026-11-17 17:26:50 +05:30
arnav-hiwarkar ae2d595d9d fix(effects): exercise the wrapped combined cube row count 2026-11-17 17:25:47 +05:30
arnav-hiwarkar 83285272e3 Merge upstream main into fix/3460-gaussian-blur-range
Keeps the Gaussian Blur (#3460), Fractal Noise (#3486) and CC Power Pin
(#3492) rows in the effects parity log.
2026-11-17 17:25:22 +05:30
arnav-hiwarkar ffdcdb507d Merge remote-tracking branch 'upstream/main' into fix/3464-drop-shadow-softness-range 2026-11-17 17:25:13 +05:30
arnav-hiwarkar cebe224d85 Merge remote-tracking branch 'upstream/main' into fix/3467-radial-blur-amount-range
# Conflicts:
#	docs/effects-parity.md
2026-11-17 17:24:34 +05:30
arnav-hiwarkar 5adc96bfbf Merge remote-tracking branch 'upstream/main' into fix/3466-sharpen-amount-range
# Conflicts:
#	crates/engine/src/tests/effect_ranges.rs
2026-11-17 17:24:31 +05:30
arnav-hiwarkar c2a38f21ad Merge remote-tracking branch 'upstream/main' into fix/3466-sharpen-amount-range 2026-11-17 17:19:31 +05:30
ash 0d1fc924a3 Merge pull request #3820 from arnav-hiwarkar/fix/3486-fractal-noise-sub-scaling-range
Fractal Noise: Sub Scaling takes After Effects' 10..10000 (CPU and GPU)
2026-11-17 17:19:30 +05:30
arnav-hiwarkar 9bb0db0207 Merge upstream main into fix/3460-gaussian-blur-range
Keeps both the Gaussian Blur (#3460) and CC Power Pin (#3492) rows in
the engine range test and the effects parity log.
2026-11-17 16:55:18 +05:30
ash 6c36ad1e17 Merge pull request #3818 from arnav-hiwarkar/fix/3585-effect-controls-up-down
Effect Controls: Up and Down select the previous and next effect (#3585)
2026-11-17 16:52:09 +05:30
arnav-hiwarkar 969286ae76 #3460: review: name the open follow-up for SLIDERS_0_24, use the shared pixel budget in the test
The table holds only Gaussian Blur's row; the ranges changed since 0.24.1
by other work are tracked in #3815. The 30000 render test checks the
buffer against crate::pixel_budget instead of a copied constant.
2026-11-17 16:52:08 +05:30
arnav-hiwarkar 8fe42b29c6 Merge remote-tracking branch 'upstream/main' into fix/3464-drop-shadow-softness-range 2026-11-17 16:49:21 +05:30
arnav-hiwarkar 79d4be499d Merge remote-tracking branch 'upstream/main' into fix/3466-sharpen-amount-range
# Conflicts:
#	crates/engine/src/tests/effect_ranges.rs
#	docs/effects-parity.md
2026-11-17 16:48:30 +05:30
arnav-hiwarkar 63ec0033d1 #3486: merge main (CC Power Pin range rows in the shared tables) 2026-11-17 16:48:19 +05:30
arnav-hiwarkar a3ab20e9f7 Merge remote-tracking branch 'upstream/main' into fix/3469-turbulent-displace-amount-range
# Conflicts:
#	crates/engine/src/tests/effect_ranges.rs
#	docs/effects-parity.md
2026-11-17 16:46:35 +05:30
arnav-hiwarkar 8420bb9f4d Merge remote-tracking branch 'upstream/main' into fix/3467-radial-blur-amount-range
# Conflicts:
#	crates/engine/src/tests/effect_ranges.rs
#	docs/effects-parity.md
2026-11-17 16:46:29 +05:30
arnav-hiwarkar cec04744f3 #3464: Drop Shadow: test a huge Softness; say what the GPU test checks
A Softness far past the range (an expression can set one) overflowed
the padding's u32 before drop_shadow_pad saturated it; the new test
panicked there in a debug build and renders a finite shadow now. The
GPU test's comment and the parity row now say that a cut margin renders
on the CPU, and the CPU test quotes the measured 0.11 at Softness 8000.
2026-11-17 16:24:22 +05:30
arnav-hiwarkar 0bd722b1a5 #3464: raster: unbounded blur skips zero radii and caps sigma
A zero-radius box is an identity, but as a difference of prefix sums it
kept their rounding error; those boxes are now left out (one to three
boxes, of the matching prefix-sum order). A sigma above 1e7 blurs as
1e7, wider than any buffer, so box_radii's i64 arithmetic can't
overflow on a huge or infinite sigma.
2026-11-17 16:24:22 +05:30
arnav-hiwarkar f149b65c57 #3464: Drop Shadow: Softness takes After Effects' range
Softness took 0..1000, so prop.set and the value editors clamped values
After Effects accepts: its recorded definition for ADBE Drop Shadow
allows 0..30000 in the same pixels (the .aep mapping is plain). The hard
range is now 0..30000; the default (0) and the slider (0..250) are
unchanged. Projects saved with the old range take the new one on open.

The .aep range guard loses its allow-list row, and the engine test sets
both ends through prop.set, undo / redo, save / reopen and an old
project. Keyframe text keeps no unit for it (only 0..100 sliders read
as percent).
2026-11-17 16:24:22 +05:30
arnav-hiwarkar 8903090007 #3464: Drop Shadow: keep the whole blur when the padding budget cuts the margin
Drop Shadow pads its buffer by Distance + 1.5 x Softness, but the pixel
budget (#2261) cuts that margin for a large Softness: from about 870 on
a 1080p layer. The box passes then dropped what they spread past the
edge, so the shadow came out too faint: at the centre of a 64 x 48
layer, 0.11 of the Gaussian at Softness 8000. With a cut margin the CPU now blurs as
if the buffer went on with transparency (the Gaussian is unchanged,
sigma = Softness / 2). The GPU hands that case to the CPU and keeps
every margin that fits, so those results are unchanged.

Measured on an M-series Mac: 1080p at Softness 30000 takes 0.10 s, and
a 4096 x 4096 layer (an 8192 x 8192 buffer) takes 0.99 s on the CPU.

The pad is computed once for both paths (drop_shadow_pad) and saturates
instead of overflowing on a huge Softness.
2026-11-17 16:24:22 +05:30
arnav-hiwarkar e60d6ac706 #3486: review: the octave test checks the bound; clearer bound comment
The octave test asserts both values stay within OCTAVE_SCALE_MAX (it
passed with the bound removed). The comment names Perspective Offset as
what multiplies the offset by the depth, and says why an octave at the
bound has no detail.
2026-11-17 16:22:07 +05:30