#3464: Drop Shadow: Softness takes After Effects' range

Softness took 0..1000, so prop.set and the value editors clamped values
After Effects accepts: its recorded definition for ADBE Drop Shadow
allows 0..30000 in the same pixels (the .aep mapping is plain). The hard
range is now 0..30000; the default (0) and the slider (0..250) are
unchanged. Projects saved with the old range take the new one on open.

The .aep range guard loses its allow-list row, and the engine test sets
both ends through prop.set, undo / redo, save / reopen and an old
project. Keyframe text keeps no unit for it (only 0..100 sliders read
as percent).
This commit is contained in:
arnav-hiwarkar committed 2026-11-17 16:24:22 +05:30
1 parent 8903090007
commit f149b65c57
4 files changed
+11 -2

No files matched your search

-1
View File
@@ -727,7 +727,6 @@ mod tests {
("ec.blur.channel", "blueBlurriness", 3462),
("ec.blur.channel", "alphaBlurriness", 3462),
("ec.obsolete.gaussianlegacy", "blurriness", 3463),
("ec.perspective.dropshadow", "softness", 3464),
("ec.blur.compound", "maximumBlur", 3465),
("ec.blur.sharpen", "amount", 3466),
("ec.blur.radial", "amount", 3467),
+9 -1
View File
@@ -885,7 +885,7 @@ pub fn specs() -> Vec<EffectSpec> {
p("opacity", "Opacity", num(50.0), slider(0.0, 100.0, 0.0, 100.0, 0)),
p("direction", "Direction", num(135.0), ParamUi::Angle),
p("distance", "Distance", num(5.0), slider(0.0, 32000.0, 0.0, 120.0, 1)),
p("softness", "Softness", num(0.0), slider(0.0, 1000.0, 0.0, 250.0, 1)),
p("softness", "Softness", num(0.0), slider(0.0, 30000.0, 0.0, 250.0, 1)),
p("shadowOnly", "Shadow Only", Value::Bool(false), ParamUi::Checkbox),
],
drop_shadow,
@@ -1050,6 +1050,14 @@ mod tests {
assert_ne!(row(2.0), row(2.4));
}
/// #3464: Softness takes After Effects' valid range, 0..30000; the slider still shows 0..250.
#[test]
fn drop_shadow_softness_takes_the_after_effects_range() {
let spec = crate::find("ec.perspective.dropshadow").unwrap();
let ui = &spec.params.iter().find(|p| p.id == "softness").unwrap().ui;
assert_eq!(*ui, slider(0.0, 30000.0, 0.0, 250.0, 1));
}
/// #3464: past the padding budget (#2261) the shadow keeps its whole blur (σ = Softness / 2)
/// up to the buffer's edge. A 64 × 48 layer's shadow at its centre is the Gaussian's share
/// of the layer, less the 6 % three boxes' peak is under a Gaussian's; dropping what the
+1
View File
@@ -60,6 +60,7 @@ const ROWS: &[(u32, &str, &str, f64, f64)] = &[
(3471, "ec.distort.transform", "scaleHeight", -30000.0, 30000.0),
(3471, "ec.distort.transform", "scaleWidth", -30000.0, 30000.0),
(3470, "ec.distort.turbulentdisplace", "evolutionOptions/randomSeed", 0.0, 100000.0),
(3464, "ec.perspective.dropshadow", "softness", 0.0, 30000.0),
];
fn path(effect: &str, param: &str) -> String {
+1
View File
@@ -64,6 +64,7 @@ the GPU is performance, not parity.
| Date | Change | Summary |
|---|---|---|
| 2026-11-17 | minor | Drop Shadow: Softness takes After Effects' recorded valid range, 0..30000 (default and 0..250 slider unchanged). Past the padding budget the shadow keeps its blur (σ = Softness / 2) and is cut at the buffer's edge (CPU and GPU) |
| 2026-11-12 | minor | Parameters take After Effects' recorded valid ranges (hard range; defaults and sliders unchanged): Levels (Individual Controls) levels −10000..10000 and Gamma from 0; 4-Color Gradient Blend to 10000 and Jitter to 500 %; Change Color Hue Transform ±1800°; Noise HLS (and Auto) amounts to 1000 % and Grain Size from 0; Grid Border to 2000; Venetian Blinds Width 1..32000 and Feather to 32000; Radial Wipe Feather to 32000; Scatter Amount to 1000; Beam thicknesses to 4000; Transform Scale ±30000 %; Turbulent Displace Random Seed to 100000. A test checks every mapped parameter's range against the recorded table (CPU and GPU) |
| 2026-10-19 | minor | Glow (original colours): bright pass per channel, 8 × (value − threshold + 0.061), measured against After Effects 2026 (CPU and GPU) |
| 2026-10-19 | minor | Glow (colour channels): the glow covers the layer's blurred alpha, blur σ = 0.384 × radius, measured against After Effects 2026 renders (CPU and GPU) |