Commit Graph
5162 Commits
Author SHA1 Message Date
FredApps 5ff845951c Merge vector cutover and pin combined shared PSD readers 2026-11-18 19:33:39 +01:00
FredApps f3c28669a2 Merge pull request #3894 from FredApps/fix/786-psd-vector-adapter
psd: read vector mask records through craft-psd
2026-11-19 01:29:30 +07:00
FredApps 450d21647c Merge main preserving Unicode and vector regression modules 2026-11-18 18:34:41 +01:00
FredApps e436d421cd psd: pin section reader with hosted validation repair 2026-11-18 17:42:52 +01:00
FredApps a2e2d68107 fix(psd): pin vector revision with repaired Windows validation 2026-11-18 17:40:26 +01:00
FredApps 723f47a3b4 Merge remote-tracking branch 'origin/main' into fix/786-psd-section-adapter 2026-11-18 17:40:03 +01:00
Dylan M. Taylor dfcb6d5356 Merge pull request #3903 from storytold/fix/unused-is-wav-import
Drop the now-unused WAV probe re-export
2026-11-18 10:42:05 -05:00
Dylan M. Taylor a6c46ec7c5 Drop the now-unused WAV probe re-export 2026-11-18 10:41:47 -05:00
FredApps d0693d9dcb psd: share recovering section-divider framing 2026-11-18 16:39:11 +01:00
FredApps 7edb6b154a Merge pull request #3898 from FredApps/fix/786-psd-fixed-adjustments
psd: share fixed-binary adjustment readers
2026-11-18 22:05:40 +07:00
Dylan M. Taylor c89395d5d7 Merge pull request #3743 from storytold/extract/shared-wav-markers
media: cut WAV cue, adtl, RF64 and XMP markers over to craft-libs
2026-11-18 09:47:41 -05:00
Dylan M. Taylor 292313f2a1 Merge pull request #3774 from storytold/cutover/shared-psd-packbits
psd: cut over recovery PackBits decoding to craft-psd
2026-11-18 09:13:46 -05:00
Dylan M. Taylor e3cf168119 Merge remote-tracking branch 'origin/main' into pr-3743 2026-11-18 09:12:54 -05:00
FredApps 1d823a01a1 psd: share fixed-binary adjustment readers 2026-11-18 15:12:01 +01:00
FredApps 71ff90865d Merge pull request #3895 from FredApps/fix/786-psd-unicode-name-reader
psd: share Unicode layer-name record framing
2026-11-18 21:07:45 +07:00
FredApps 67e6e27fa7 psd: share Unicode layer-name record framing 2026-11-18 14:27:17 +01:00
Dylan M. Taylor 47384980a4 psd: cover the shared PackBits row-limit error mapping
The recovery wrapper maps every non-decompress failure to Error::Invalid so a
limit refusal is never reported as truncated data. That arm had no test, which
left the changed lines under the coverage gate.
2026-11-18 07:44:01 -05:00
FredApps 82cf1b5c5e psd: align vector fixtures with fixed-size chunk lint 2026-11-18 13:39:15 +01:00
FredApps c149bb513f psd: read vector mask records through craft-psd 2026-11-18 13:19:34 +01:00
ash 3f1cd00745 Merge pull request #3843 from arnav-hiwarkar/fix/3830-3831-ocio-lut-limits
OCIO: cap the .3dl mesh and rows before cubing them (#3830)
2026-11-18 17:20:01 +05:30
FredApps 8a4a29b227 Merge pull request #3779 from FredApps/onee/i786-psd-descriptors-placed
psd: parse descriptors and placed layers with craft-psd
2026-11-18 18:36:59 +07:00
arnav-hiwarkar c6612da798 #3830: tell a 3-entry .3dl mesh apart by the row count alone 2026-11-18 15:46:04 +05:30
arnav-hiwarkar bf31b65271 #3830: keep four .3dl tokens and a spare mesh row at small limits 2026-11-18 15:38:08 +05:30
arnav-hiwarkar 648ae78591 #3830: test the .3dl cap through an injectable limit; drop the local .spi3d precheck (#3831 belongs in craft-cms) 2026-11-18 15:27:36 +05:30
FredApps e48cfde63f fix(psd): pin corrected quilt policy test revision 2026-11-18 10:40:03 +01:00
Sean Hawkey 67942cda7b Expressions: a layer parameter left at None is the layer it sits on (#3601)
Fixes #3601.

### What

A layer parameter left at None (a Layer Control, or an effect's layer parameter) now stands for the layer it sits on, as in After Effects (values observed in AE 26.3 are in #3601). Before, its value was `null`. The property was still truthy, so a rig's `L ? L.sourceRectAtTime(t) : 0` went down the wrong branch and stopped with "not a callable function".

The change is one line in `Prop.__wrap` (`crates/expr/src/prelude.js`).

### Tested

- **`an_empty_layer_control_stands_for_its_own_layer`** in `crates/expr/src/tests.rs`: truthiness, `name`, `index`, the `L ? L.transform.position[0] : -1` pattern, and `sourceRectAtTime`. It fails without the change.
- **Suites:** `cargo test -p effectcraft-expr` (167 passed) and `cargo test -p effectcraft-script` pass. clippy and fmt are clean.
- **Not covered here:** calling the empty parameter like a layer (`L("ADBE Transform Group")`). That depends on #3554, and works with both applied.
2026-11-18 16:25:57 +07:00
JCleanCode 981981632c Fix #1986 Cmd+A ("select all") doesn't work in "Import multiple files…
Fixes #1986

**Cause.** On macOS the open panel has no key equivalents of its own. Cmd+A (and C/V/X/Z) work
because the menu bar sends `selectAll:`, `copy:` and so on down the responder chain to the key
window. EffectCraft's Edit items are custom muda items, so while the sheet was up Cmd+A ran
Edit > Select All on the Project panel behind it.

**Fix.** The native file dialogs on screen are counted (`native_dialogs`). While one is open on
macOS, Undo / Redo / Cut / Copy / Paste / Select All become macOS predefined items, which send
the real actions to the dialog. The other `edit.*` items are disabled. The UI is repainted when
a dialog opens so the menu is rebuilt before the next key.

**Tests.** `edit_menu_is_disabled_while_a_file_dialog_is_open`,
`edit_text_commands_are_predefined_while_a_file_dialog_is_open`. Checked by hand on macOS:
Cmd+A in "Import multiple files" selects the files.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
<!-- coderabbit-ai-generated:v1 -->

## Summary by CodeRabbit

* **Bug Fixes**
  * On macOS, Edit menu commands are disabled while a native file dialog is open and return to their appropriate enabled state when it closes or is canceled.
  * While a dialog is open, Undo, Redo, Cut, Copy, Paste, and Select All appear as native macOS menu commands with their current labels.
  * Opening a file dialog now triggers an immediate interface refresh, helping the menu update before the next key event.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-11-18 16:25:06 +07:00
FredApps 8030fd96e6 fix(psd): pin quilt bounds context validation 2026-11-18 10:12:07 +01:00
FredApps 49170cdf18 fix(psd): surface unsupported modern placements at import boundary 2026-11-18 09:43:01 +01:00
FredApps cb3f66e06c fix(psd): align local warp bounds with shared numeric contract 2026-11-18 09:36:47 +01:00
FredApps 7bb70c73d8 #3779: pin audited quilt read-write contract fixes 2026-11-18 08:43:41 +01:00
FredApps 218470e7b6 #3779: pin explicit quilt bounds and template roundtrip fixes 2026-11-18 08:08:36 +01:00
FredApps a1c1288b13 #3779: pin bounded PSD placement fixes and test app boundaries 2026-11-18 05:59:44 +01:00
FredApps cc5c5cb732 #3779: integrate reviewed shared PSD adapters with current main 2026-11-18 04:13:58 +01:00
arnav-hiwarkar 104875a897 #3830: read only the three .3dl Mesh header tokens it uses 2026-11-17 22:28:16 +05:30
arnav-hiwarkar 6232bed556 #3830: stop collecting a .3dl line's numbers past the mesh limit 2026-11-17 22:20:14 +05:30
arnav-hiwarkar a65a1f746f #3830: cap the .3dl mesh and rows and cube with checked math; #3831: refuse a .spi3d short of its rows before the lattice is reserved 2026-11-17 22:11:34 +05:30
arnav-hiwarkar d550d3d476 #3830: regression tests for hostile .3dl meshes and row-less .spi3d lattices 2026-11-17 22:09:04 +05:30
ash cd9ee1e46a Merge pull request #3822 from arnav-hiwarkar/fix/3464-drop-shadow-softness-range
Drop Shadow: Softness takes After Effects' range, and keeps its blur past the padding budget
2026-11-17 21:53:35 +05:30
arnav-hiwarkar c07dbf32ca Merge remote-tracking branch 'upstream/main' into fix/3464-drop-shadow-softness-range 2026-11-17 20:54:02 +05:30
ash 4c38f78307 Merge pull request #3817 from arnav-hiwarkar/fix/3467-radial-blur-amount-range
Radial Blur: Amount takes After Effects' range 0..1000
2026-11-17 19:03:14 +05:30
ash 0bd848c272 Merge pull request #3153 from jayzed80/fix/parse-cube-huge-size
fix(effects): parse_cube rejects a hostile LUT_3D_SIZE before cubing it
2026-11-17 18:37:21 +05:30
arnav-hiwarkar eb14583749 Merge remote-tracking branch 'upstream/main' into fix/3467-radial-blur-amount-range
# Conflicts:
#	crates/aep/src/export/fx_defs.rs
#	crates/engine/src/tests/effect_ranges.rs
#	docs/effects-parity.md
2026-11-17 18:34:15 +05:30
ash e679859e07 Merge pull request #3814 from arnav-hiwarkar/fix/3460-gaussian-blur-range
Gaussian Blur: Blurriness takes After Effects' range 0..30000 (#3460)
2026-11-17 18:33:54 +05:30
arnav-hiwarkar 7f14df8355 Merge upstream main into fix/3460-gaussian-blur-range
Keeps the Gaussian Blur (#3460) and Sharpen (#3466) tests in
crates/effects/src/misc.rs; Sharpen's code is as main has it.
2026-11-17 18:08:30 +05:30
ash a188867a42 Merge pull request #3810 from arnav-hiwarkar/fix/3466-sharpen-amount-range
Sharpen: Amount takes After Effects' 0..4000 range (#3466)
2026-11-17 18:06:39 +05:30
arnav-hiwarkar 44663c5e9f #3464: raster: an unbounded blur is exactly 0 where it doesn't reach
Outside the boxes' combined reach of the moved line the result is 0,
but boxes_unbounded still evaluated the prefix-sum polynomials there,
and far past the line their cancelling terms left a rounding residue
(about 5 for a one-pixel line moved a billion pixels). Those positions
are now 0 without evaluating anything. Also wraps the raster re-export
line rustfmt asks for.
2026-11-17 17:58:30 +05:30
arnav-hiwarkar ff9584fa64 Merge remote-tracking branch 'upstream/main' into fix/3467-radial-blur-amount-range
# Conflicts:
#	crates/engine/src/tests/effect_ranges.rs
#	docs/effects-parity.md
2026-11-17 17:57:33 +05:30
arnav-hiwarkar 69666e68c7 Merge upstream main into fix/3460-gaussian-blur-range
Keeps the Gaussian Blur (#3460) and Turbulent Displace (#3469) rows in
the engine range test and the effects parity log.
2026-11-17 17:57:21 +05:30
ash f717edcf81 Merge pull request #3819 from arnav-hiwarkar/fix/3469-turbulent-displace-amount-range
Turbulent Displace: Amount takes After Effects' range and stays finite at the extremes
2026-11-17 17:55:25 +05:30