Commit Graph
4716 Commits
Author SHA1 Message Date
Dylan M. Taylor 019a89d96d Pass the Linux signing key to the release workflow (#2328) 2026-11-04 17:44:40 -05:00
Mex b98687c3e1 M5: keep out-and-back cubic segments in striped strokes (#2323)
* M5: preserve out-and-back cubics in striped strokes

A cubic can travel out and back when its endpoints and first control point coincide. Include the second control point in the zero-length guard and cover its offset extent and both stripe bands.

* M5: record striped cubic regression coverage

Record the scoped cubic stroke correction without changing readiness estimates or other progress entries.
2026-11-04 15:36:05 -05:00
Dylan M. Taylor ef6c368615 Linux: let the shared makepkg job build the Arch package (#2322)
package.sh built its own Arch package with nfpm while the shared release
workflow also built one with makepkg, because has-arch defaults to true. Both
wrote designcraft-<version>-linux-<arch>.pkg.tar.zst, the draft release merges
the release-* artifacts last-writer-wins, and 0.17.0 shipped the nfpm copy,
which declared fewer dependencies than the makepkg template.

Drop arch from the formats this script builds and remove the archlinux section
from nfpm.yaml, so the shared action is the single builder. It names the
package after the .desktop bundle id, declares the same provides/conflicts
against the AUR packages, and adds the optdepends nfpm could not express.
2026-11-04 14:46:58 -05:00
Dylan M. Taylor f3bcc886dc Linux packages: require libxkbcommon-x11, which winit dlopens on X11 (#2320)
The binaries load their windowing libraries at run time, and xkbcommon's X11
keyboard module is a separate library from the core one. Nothing declared it,
so a package installed on a system without it crashes before opening a window:

  thread 'main' panicked at xkbcommon-dl-0.4.2/src/x11.rs:59:28:
  Library libxkbcommon-x11.so could not be loaded.

winit's X11 backend cannot fall back, so the dependency is required for deb,
rpm and Arch rather than recommended.
2026-11-04 13:57:08 -05:00
aiongg fb630909c4 Merge pull request #2304 from texjer/feat/finder-drop-pointer
Place: a file dragged in from the Finder fills the frame it was dropped on
2026-11-04 11:19:45 -05:00
aiongg 8b1e20fd8f Apply review fixes
- crates/ui-egui/src/app/input.rs
- crates/ui-egui/src/services.rs
2026-11-04 15:40:44 +00:00
Tex Jernigan 632df6178a Place: a graphic dropped on a frame holding a nested image replaces it (#2303)
Split out of #2073. A frame holding its image as an item pasted into it (how a
document from InDesign keeps a photo) takes a dropped graphic as a graphic
frame does: `canvas::drop_frame` uses `Item::takes_graphic` (#2226).
2026-11-04 10:40:17 -05:00
Hamza Naveed b48a9507b1 Swatches: renaming a swatch renames it on the images it colours (#2306) (#2311)
rename_swatch_refs visited every page item's fill and stroke but not the swatch applied to a placed greyscale or bitmap image (Graphic::fill), framed or in a table cell. Those images kept the old name, found no swatch, and drew in black.
2026-11-04 10:39:14 -05:00
MarekSpodBiedry df9f0656ca Master pages: skip hidden and locked layers when picking items (#2221) (#2292) 2026-11-04 07:09:20 -05:00
aiongg dffef02773 Merge pull request #1755 from Hamza0101/fix/korean-sans-fallback
Fonts: a missing Korean sans face falls back to a sans one (#1692)
2026-11-04 07:07:31 -05:00
MarekSpodBiedry 7215a559e5 Hyphenation: enable the Danish hypher patterns (#2282) (#2293) 2026-11-04 07:01:31 -05:00
Hamza 39ea3513a4 Korean fallback: spell 바탕 right, and choose the label's fallback style once 2026-11-04 12:55:57 +05:00
Dylan M. Taylor a4017a3cda Fonts: bound named instances per file, index axis settings in style strings (#2215)
* fix(fonts): bound named-instance listing and index variable-style settings

* address review: bound inspected named-instance records file-wide
2026-11-03 23:26:17 -05:00
aiongg 5309d7d81a Merge pull request #2291 from aiongg/integration-designcraft-20261104-1
Integration batch integration-designcraft-20261104-1
2026-11-03 23:25:23 -05:00
aiongg d30c2b1e66 Merge pull request #2271 2026-11-04 04:14:13 +00:00
aiongg c3ea317837 Merge pull request #2250 2026-11-04 04:14:12 +00:00
aiongg b1f67ee4e4 Merge pull request #2211 2026-11-04 04:14:12 +00:00
aiongg 6c2ab93b03 Merge pull request #2231 2026-11-04 04:14:12 +00:00
Dylan M. Taylor b46ee47982 pdf: placements of one media asset share one embedded file (#2266) 2026-11-03 23:07:05 -05:00
aiongg a2cc32a8d1 Apply review fixes
- crates/epub/src/tests.rs
2026-11-04 03:50:09 +00:00
aiongg 3326d919bb Apply review fixes
- crates/compose/src/tests.rs
2026-11-04 03:49:15 +00:00
Dylan M. Taylor e2c2266087 warichu: split long runs in one pass instead of trying every length (#2184)
* warichu: split long runs in one pass instead of trying every length

The exact split tries every line length for every start, so its work grew with
the square of the run's length, and a document can set warichu on a run of any
length. Runs longer than 512 glyphs are now split where the running advance
reaches each line's share, keeping the break minimums. The glyphs drawn with the
run find their anchor by binary search instead of a scan per glyph.

* address review: warichu split picks the break closest to the target
2026-11-03 22:32:31 -05:00
Dylan M. Taylor 7faf7029fb fix(pdf): indexed membership in page ranges, optional content and PDF/X scans (#2207) 2026-11-03 22:32:10 -05:00
Dylan M. Taylor 36da81e03b fix(textimport): bound xlsx data sources and make docx and hyphenation parsing linear (#2213) 2026-11-03 22:23:32 -05:00
Dylan M. Taylor 64c956f09e fix(render): index line style groups, stop futile glyph-cache eviction, read PDF page sizes once (#2217) 2026-11-03 22:23:11 -05:00
Dylan M. Taylor c4ed9b2210 fix: write screenshots, signing certificates and benchmark files in private temp folders (#2219) 2026-11-03 22:16:28 -05:00
Dylan M. Taylor bcc74f29c9 fix(app): log message line breaks continue the record instead of starting another (#2220) 2026-11-03 22:16:06 -05:00
texjer 8815ef7350 Place: a file dragged in from the Finder fills the frame it was dropped on
Split out of #2073. winit sends no pointer events during a drag from another
application on macOS, so a Finder drop had no pointer and never found the frame
under it. The host now gives the pointer's place on the screen
(`Services::pointer`, `PointerFn`: the system's points before the UI scale,
from `NSEvent.mouseLocation`), and `take_pending_drops` uses it for the files
that came without a pointer, divided by egui's zoom factor and made relative
to the window.
2026-11-03 21:50:08 -05:00
Dylan M. Taylor cf0c6971d6 doc: repair parent based_on links in one graph walk (#2244) 2026-11-03 21:29:58 -05:00
Dylan M. Taylorandaiongg 9437553fd4 Images: one budget for the nested SVG data images of a parse (#2254)
* images: one nested-SVG byte budget per parse

* Apply review fixes

- crates/images/src/lib.rs

---------

Co-authored-by: aiongg <67543387+aiongg@users.noreply.github.com>
2026-11-03 21:29:36 -05:00
Dylan M. Taylorandaiongg 1a059304f9 PPTX export: table border and paragraph lookups by index, direct charmap lookups (#2256)
* pptx: table border lookups by position, paragraph lines grouped once

* pptx: look a character up in the face's map, don't expand it

* Apply review fixes

- crates/pptx/src/table.rs

---------

Co-authored-by: aiongg <67543387+aiongg@users.noreply.github.com>
2026-11-03 21:29:14 -05:00
Dylan M. Taylorandaiongg 1d752d2f1f Text import: cap style names read from Tagged Text and DOCX files (#2258)
* textimport: cap style names read from files

* Apply review fixes

- crates/textimport/src/tagged.rs

---------

Co-authored-by: aiongg <67543387+aiongg@users.noreply.github.com>
2026-11-03 21:28:52 -05:00
aiongg b18ed2e7ad Merge pull request #1294 from KnottyDyes/squad/place-never-into-line-v2
Place: implicit image placement preserves lines and open paths
2026-11-03 21:17:15 -05:00
KnottyDyesandClaude Opus 5.5 5e8571d11e Geom: test that stray end handles leave a line without area
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 18:58:37 -07:00
Dylan M. Taylor ae93ea5115 table: refuse to split more than 1024 merged-cell owners at once (#2273) 2026-11-03 20:55:20 -05:00
aiongg 2042bd9698 Merge pull request #1302 from KnottyDyes/squad/package-pdf-soft-effects
PDF: keep hyperlinks on rasterized frames; report package PDF warnings
2026-11-03 20:55:11 -05:00
aiongg c05afc6b44 Apply review fixes
- crates/geom/src/path.rs
2026-11-04 01:54:40 +00:00
KnottyDyesandClaude Opus 5.5 b032aa26e8 PDF: test that link stand-ins add only the link to tagged PDF
The nonprinting stand-in for a rasterized linked frame keeps the frame's
story, alt text and effects for link bounds and text composition. A test
now checks that a tagged PDF of a linked frame differs from the same frame
without the link only by the link annotation: no extra structure elements
or alt text. Note why the stand-in keeps the frame's ItemId.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 18:20:58 -07:00
KnottyDyesandClaude Opus 5.5 5cd8d99db7 Package: report PDF warnings and keep hyperlinks on rasterized frames
Include the PDF export warnings in the package result and report. Cover
shadow and feather output in packaged PDFs with a synthetic regression test.

Preserve frame and text-range hyperlinks on rasterized frames, including
inside groups, at their original source bounds.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 18:20:58 -07:00
KnottyDyesandClaude Opus 5.5 5bd8ada171 Place: lines don't become frames when content is placed
Placing an image or media with no placement parameters used the selected
item as the frame, and so did a click of the loaded place cursor. On a
line that made a zero-height frame that kept its stroke. All three now
skip items that enclose no area (PathData::encloses_area): lines and
paths whose points all lie on one line get a new frame instead. Frames,
and open paths that enclose an area, take the content as before.

An explicit frame, x, y, spread or width behave as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 17:52:04 -07:00
Dylan M. Taylor 4071bd40e6 address review: skip a graphic whose PDF crop is too large to trace 2026-11-04 00:39:05 +00:00
aiongg b17dd017d5 Merge pull request #2287 from con3code/test/mojikumi-one-em-close-up
Mojikumi: test consecutive punctuation under the one-em line-end set too
2026-11-03 19:23:28 -05:00
con3codeandClaude Opus 5.5 3894566812 Mojikumi: test consecutive punctuation under the one-em line-end set too
The close-up test checked the half-em line-end set only; the other Japanese
base set closes up the same pairs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-04 09:01:20 +09:00
aiongg 823eef9838 Fix mojikumi: middle dot loses its quarter em beside a proportional (#2285)
Fixes #2281.

- crates/doc/src/mojikumi.rs
- crates/doc/tests/autocraft_regression.rs
2026-11-03 18:57:15 -05:00
aiongg fe7db96e11 Merge pull request #2168 from 4waymedia/fix/open-large-stored-assets
Format: a saved document opens whatever the size of its placed images (#2166)
2026-11-03 18:33:36 -05:00
Paul GemignaniandClaude Fable 5.1 50780180e7 Format read_entry's caller (cargo fmt)
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Claude-Session: https://claude.ai/code/session_012xiyiD63mAukLtyDQFCQKU
2026-11-03 15:21:13 -08:00
.CooCoo f889d7c47b Tables: Convert Cell to Graphic Cell… is dimmed without a table target (#2270)
The menu item was enabled whenever a document was open. With no table
target it opened the file picker, and placing the image then failed
because table.placeGraphic needs a table target. The item now takes the
enablement of table.placeGraphic, as Justification… takes that of
type.para.
2026-11-03 17:33:43 -05:00
aiongg b8af07ee68 Apply review fixes
- xtask/src/main.rs
2026-11-03 22:33:04 +00:00
Dylan M. Taylor b0cf3f75fd xtask: bound the corpus download (archive size, entries, expanded bytes) 2026-11-03 22:24:45 +00:00
Tex Jernigan e1910529a7 Frames with a nested image: hit inside the frame, take a placed graphic; replacing keeps the crop; open on a usable layer (#2226)
* Frames holding pasted-in images are hit inside the frame, take a placed graphic; documents open on a usable layer

A frame with items pasted into it (how a document from InDesign keeps a cropped photo) was hit
through its children like a group, so the whole uncropped image counted: a click on the empty
page beside such a photo selected it, and nothing could be deselected there. It is now hit by
its own area, as it is drawn clipped. Such a frame holding only graphics also takes a placed or
dropped graphic (Item::takes_graphic), which fills it as an empty or graphic frame is filled.

A document opened with new objects going to its top layer even when that layer was hidden and
locked (a dieline), so a placed graphic showed as an empty frame outline. It now opens on the
topmost layer that is shown and unlocked (Document::working_layer).

* Place: a graphic replacing the one a frame shows keeps the frame's crop and zoom

Placing or dropping into a frame that shows a graphic (in it, or as the one graphic pasted into
it) filled the frame afresh, so the crop and zoom chosen for the old picture were lost. The new
graphic now covers the old one's area, centred on it: an edited copy of the same picture lands
exactly where the old one was.

* Move the replace-keeps-crop and open-on-a-usable-layer changes to their own PRs

Review asked for them to be checked against reference app behaviour on their own. This PR keeps
the frame hit area and Item::takes_graphic. Reverts 8ea0bc16 and drops Document::working_layer.

* Move Document::working_layer and its test to #2267
2026-11-03 17:21:35 -05:00