Merge pull request #1316 from storytold/sonar/s4790-format-hash-exclusions

sonar: ignore the weak hashes the encrypted formats require (SonarCloud S4790)
This commit is contained in:
Dylan M. Taylor authored and GitHub committed 2026-11-14 11:47:14 -05:00
commit 3e399149a8
1 file changed
+16 -1
+16 -1
View File
@@ -15,9 +15,24 @@ sonar.cpd.exclusions=**/*tables.rs
# S4790 (weak hash): the ICC specification defines the profile ID as the MD5 of the profile, so
# no other algorithm produces an ID other software accepts. It identifies, it does not protect.
sonar.issue.ignore.multicriteria=icc_profile_id,gha-lockfile
#
# The encrypted packages below are the same case: each format derives its keys from MD5 or SHA-1,
# so substituting a stronger hash stops the files the module reads and writes from opening.
sonar.issue.ignore.multicriteria=icc_profile_id,xls_filepass_hash,pdf_standard_security_hash,odf_package_hash,gha-lockfile
sonar.issue.ignore.multicriteria.icc_profile_id.ruleKey=rust:S4790
sonar.issue.ignore.multicriteria.icc_profile_id.resourceKey=crates/cms/src/write.rs
# xls: [MS-OFFCRYPTO] 2.3.6.1-2.3.6.2, where RC4 1.1 takes its key and verifier from MD5, and
# 2.3.5.1-2.3.5.2, where RC4 CryptoAPI takes them from SHA-1.
sonar.issue.ignore.multicriteria.xls_filepass_hash.ruleKey=rust:S4790
sonar.issue.ignore.multicriteria.xls_filepass_hash.resourceKey=crates/xls/src/crypt.rs
# pdf: ISO 32000-1 7.6.3.3, Algorithms 2-7. Revisions 2-4 derive the file key and the /O and /U
# values from MD5; revisions 5 and 6 use SHA-256 and SHA-512 (Algorithm 2.B).
sonar.issue.ignore.multicriteria.pdf_standard_security_hash.ruleKey=rust:S4790
sonar.issue.ignore.multicriteria.pdf_standard_security_hash.resourceKey=crates/pdf/src/crypt.rs
# odf: OpenDocument 4.16.6 and 4.16.3, a start key and a file checksum made with SHA-1, each used
# only where the package's manifest names it.
sonar.issue.ignore.multicriteria.odf_package_hash.ruleKey=rust:S4790
sonar.issue.ignore.multicriteria.odf_package_hash.resourceKey=crates/odf/src/crypt.rs
# githubactions:S7637 asks for every action to be pinned to a commit SHA. A workflow covered by
# .github/workflows/actions.lock runs the commit the lockfile records, so its tag refs are pinned