The root step that fixes the modes of the root-owned file list ran chmod, which follows
symlinks, on paths a staging tree changed after staging could have made symlinks. Check each
path, shallowest first, and stop on a symlink so its target's modes are never changed as root.
The script is now a constant in root_record with tests that run it.
System-wide FreeBSD tree installs are removed with /bin/rm as root, but the
files to remove came only from installed.json in the desktop user's data
folder. Anything running as that user could rewrite the record and add any
file under /usr/local to an uninstall the user approved.
A system-wide install now copies a list of its files into
/usr/local/share/artcraft-launcher/installed/<app>.files along with them,
so it is owned by root. Uninstall reads that list (refusing it unless it
and every folder above it is root-owned, not group/world writable and not
a symlink) and only deletes files it names. Installs that predate the list
are refused with a message asking to reinstall first.
* Add MaterialCraft to the launcher suite
* Stage MaterialCraft integration for its first published release
* Fix MaterialCraft website link and installer icon layout
* Add TextureCraft to the launcher suite
* Fix formatting of TextureCraft release fixture test
* Distinguish TextureCraft details headline from its card
* ci: run the test and web jobs through the shared gate
ci.yml ran its own test (Linux, Windows) and wasm jobs. Both now call craft-common-actions'
gate.yml, as the CI workflow rules ask (storytold/craft-common-actions#118):
- test: `cargo xtask ci` on Linux (fmt, clippy, tests, wasm check); clippy and tests on Windows.
- web: clippy for wasm32 and packaging/web/package.sh with trunk 0.21.14, in its own cache.
The gate saves caches from main only, so pull requests stop writing their own.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ci: the test gate installs no cargo tools
Nothing in it runs nextest, and installing it fell back to cargo-binstall on both legs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ci: call the shared gate at main
storytold/craft-common-actions#119 is merged, so main's gate takes an empty packages list.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(detect): sort MSI entries without a version last (#936)
msi_installs promised newest first but had the no-version arms swapped,
so an entry without a DisplayVersion came first and .next() took it as
the primary install.
* test(detect): check every arm of newest_first (#936)
The sort in this test never compares None against Some in that order, so flipping that arm still passed.
A dropped connection to Apple's CloudKit ticket lookup (Error 68) failed the release's verify step twice although the DMG was notarized and stapled. package.sh already retries stapler; verify.sh now does the same.
ci.yml still runs its own jobs, and the CI workflow rules (CLAUDE.md, AGENTS.md) keep additions
out of such files: moving the jobs into craft-common-actions is its own task. #1109 added
prefix-key and save-if to both rust-cache steps; this removes them. The dev profile change from
#1109 stays. The cache churn is raised as storytold/craft-common-actions#118.
Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
PR runs saved their own Rust caches (up to 1.2 GB per OS, 7.1 GB in all), which only the PR
can read. With the repository over its 10 GB limit they evicted main's, so Windows legs often
found no cache and compiled every dependency (13 min test build). Only main saves now.
The dev profile drops dependency debug info and keeps line tables for workspace crates, as the
other craft apps do, which shortens Windows links and shrinks the cache. The cache prefix moves
to v1 because rust-cache never resaves an existing key.
Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* docs: record the Windows antivirus incident from Update all
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* docs: tighten the incident note's claims and product name
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
packages::find tried each bundle id across every record, so a system
io.tangencylabs.solidcraft beat a user ai.storyteller.solidcraft. Packages now say
whether they're a user install; find looks through the user ones first, current id
first within each scope.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#1071 moved release checks to twelve minutes and changed this test to match, but detection runs on RESCAN_EVERY in app.rs, a separate timer that stayed at five. The test has failed on main since.
AGENTS.md (and CLAUDE.md where present) gets a CI workflows section: workflows only call
craft-common-actions at @main, with no other jobs; feature and fix PRs don't touch CI and
link or open a craft-common-actions issue (a PR only for a small fix that is safe for
every app and does not increase CI time); legacy jobs
aren't added to and move only as their own task, staying until a shared workflow runs them.
Flatpak mounts the host's /usr/share/fonts at /run/host/fonts and
/usr/local/share/fonts at /run/host/local-fonts (add_font_path_args in
flatpak's common/flatpak-run.c). The sandbox's own /usr/share/fonts holds
only the runtime's fonts, so the Flatpak launcher found no Chinese or
Japanese font and fell back to English.
Each system candidate is now followed by its /run/host path, for the same
family. User fonts need no twin, since both manifests grant
--filesystem=home. PhotoCraft fixed the same lookup in
storytold/photocraft#1204.
An AppImage the launcher installed is renamed into place whole, and the old file is removed
only after that, the same as an update. Going back to a version chosen by name now takes
that route too (Downgrade::KeepOldCopy), with no older package fetched first. It needs the
launcher's own record of an AppImage: a user's own AppImage, an unrecorded one and the
tarball install (whose bin and share swap one at a time) are still refused.
Not run on a real Linux desktop; the linux module only compiles there.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The window sets its app id (Wayland) and WM_CLASS (X11) to
ai.storyteller.artcraft-launcher, but the entry said
StartupWMClass=artcraft-launcher. Desktops that find the entry by its
file name were fine; an entry under another name (AppImageLauncher,
Gear Lever, a hand-made one) never matched, so the dock showed a
generic icon and the launcher could not be pinned.
pkexec exits 126 when the prompt is dismissed. 127 is its default code and
also covers not authorized and no authentication agent, so a desktop with no
polkit agent ended an install as a quiet "Install cancelled" with no prompt.
get_api shared the 4 MiB limit for small answers, and SolidCraft's list of 67
releases is 5.4 to 6.5 MB. The request failed every time, so Choose version
showed an error and no versions. Other small requests keep 4 MiB.
Dates ran to 130 px in Brazilian Portuguese and 108 px in Chinese and
Japanese, past the 104 px column, and were cut with an ellipsis. The
column is now 132 px; Author gives up 16 px ("Tangency Labs" still fits)
and the app column 12 px.