Commit Graph
386 Commits
Author SHA1 Message Date
Dylan M. Taylor cffde3a643 address review: refuse a root uninstall behind a symlink, remove the root-owned list last 2026-11-03 21:56:38 +00:00
Dylan M. Taylor 64e8be52fe native(install): refuse a symlink instead of chmod-ing through it in the FreeBSD root copy step
The root step that fixes the modes of the root-owned file list ran chmod, which follows
symlinks, on paths a staging tree changed after staging could have made symlinks. Check each
path, shallowest first, and stop on a symlink so its target's modes are never changed as root.
The script is now a constant in root_record with tests that run it.
2026-11-02 21:57:53 -05:00
Dylan M. Taylor 933043427b native(install): remove the root list's files on FreeBSD uninstall and keep the list readable 2026-11-02 21:33:40 -05:00
Dylan M. Taylor 01016e2bc6 native(install): clear group/world write on the FreeBSD root file list after copying it in 2026-11-02 21:24:26 -05:00
Dylan M. Taylor e242654fcc native(install): take FreeBSD root uninstall targets from a root-owned list
System-wide FreeBSD tree installs are removed with /bin/rm as root, but the
files to remove came only from installed.json in the desktop user's data
folder. Anything running as that user could rewrite the record and add any
file under /usr/local to an uninstall the user approved.

A system-wide install now copies a list of its files into
/usr/local/share/artcraft-launcher/installed/<app>.files along with them,
so it is owned by root. Uninstall reads that list (refusing it unless it
and every folder above it is root-owned, not group/world writable and not
a symlink) and only deletes files it names. Installs that predate the list
are refused with a message asking to reinstall first.
2026-11-02 20:19:30 -05:00
Brandon ThomasandClaude Opus 5.5 4add62aaf9 Release 0.14.0
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v0.14.0
2026-11-02 19:25:11 -05:00
Dylan M. Taylor ab20d70e38 Add MaterialCraft to the launcher suite (#1162)
* Add MaterialCraft to the launcher suite

* Stage MaterialCraft integration for its first published release

* Fix MaterialCraft website link and installer icon layout
2026-11-02 17:36:42 -05:00
Dylan M. Taylor ec205366eb Release 0.13.0 v0.13.0 2026-11-01 12:28:43 -05:00
Dylan M. Taylor 9a9a1004b4 Add a setting to hide community apps (#1136) 2026-11-01 12:28:36 -05:00
Dylan M. Taylor c3b6a8dfc2 Add TextureCraft to the launcher suite (#1135)
* Add TextureCraft to the launcher suite

* Fix formatting of TextureCraft release fixture test

* Distinguish TextureCraft details headline from its card
2026-11-01 12:22:34 -05:00
ffa3440c15 ci: run the test and web jobs through the shared gate (#1112)
* ci: run the test and web jobs through the shared gate

ci.yml ran its own test (Linux, Windows) and wasm jobs. Both now call craft-common-actions'
gate.yml, as the CI workflow rules ask (storytold/craft-common-actions#118):
- test: `cargo xtask ci` on Linux (fmt, clippy, tests, wasm check); clippy and tests on Windows.
- web: clippy for wasm32 and packaging/web/package.sh with trunk 0.21.14, in its own cache.
The gate saves caches from main only, so pull requests stop writing their own.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ci: the test gate installs no cargo tools

Nothing in it runs nextest, and installing it fell back to cargo-binstall on both legs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ci: call the shared gate at main

storytold/craft-common-actions#119 is merged, so main's gate takes an empty packages list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 10:55:09 +01:00
VoiceLessQ 7eeb66d01f fix(i18n): fill placeholders in one pass (#782) (#1063)
A value holding {other} was expanded again by a later argument. fmt now
walks the template once, so values stay exactly as they came.
2026-11-01 10:54:15 +01:00
VoiceLessQ 82b60070f6 fix(detect): sort MSI entries without a version last (#936) (#1049)
* fix(detect): sort MSI entries without a version last (#936)

msi_installs promised newest first but had the no-version arms swapped,
so an entry without a DisplayVersion came first and .next() took it as
the primary install.

* test(detect): check every arm of newest_first (#936)

The sort in this test never compares None against Some in that order, so flipping that arm still passed.
2026-11-01 10:53:57 +01:00
aiongg ee4985d90d fix(macos): retry stapler validate in verify.sh (#1116)
A dropped connection to Apple's CloudKit ticket lookup (Error 68) failed the release's verify step twice although the DMG was notarized and stapled. package.sh already retries stapler; verify.sh now does the same.
2026-11-01 00:02:40 -04:00
Dylan M. Taylor d4ea71c9fd ci: grant packages: write permission to release workflow v0.12.0 2026-10-31 23:39:30 -04:00
Dylan M. Taylor 12c3a9b203 Release 0.12.0 2026-10-31 23:36:34 -04:00
Dylan M. Taylor c0fd8b06e4 feat: add Craft Anything to the launcher suite (#1113) 2026-10-31 23:32:54 -04:00
d5cef81e61 ci: undo the rust-cache lines #1109 added to ci.yml (#1111)
ci.yml still runs its own jobs, and the CI workflow rules (CLAUDE.md, AGENTS.md) keep additions
out of such files: moving the jobs into craft-common-actions is its own task. #1109 added
prefix-key and save-if to both rust-cache steps; this removes them. The dev profile change from
#1109 stays. The cache churn is raised as storytold/craft-common-actions#118.

Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 02:44:24 +01:00
6026920771 ci: only main saves the Rust caches; line-table debug info in dev (#1109)
PR runs saved their own Rust caches (up to 1.2 GB per OS, 7.1 GB in all), which only the PR
can read. With the repository over its 10 GB limit they evicted main's, so Windows legs often
found no cache and compiled every dependency (13 min test build). Only main saves now.

The dev profile drops dependency debug info and keeps line tables for workspace crates, as the
other craft apps do, which shortens Windows links and shrinks the cache. The cache prefix moves
to v1 because rust-cache never resaves an existing key.

Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 01:39:02 +01:00
Dylan M. Taylor 48b1a04c18 packaging(flatpak): add OCI image build and GHCR publishing helper (#1104) 2026-10-31 15:43:40 -04:00
Brandon ThomasandClaude Opus 5.5 68eeee97b8 docs: record the Windows antivirus incident from Update all (#1079)
* docs: record the Windows antivirus incident from Update all

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs: tighten the incident note's claims and product name

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 02:03:42 -04:00
Brandon ThomasandClaude Opus 5.5 61f54f2739 Release 0.11.1
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v0.11.1
2026-10-31 01:53:58 -04:00
Dylan M. Taylor f3ac5c265d Revert "feat(install): one permission prompt for an Update all of all-users apps on Windows (#974)" (#1077)
This reverts commit b827fed74a.
2026-10-31 01:31:34 -04:00
Dylan M. Taylor e13bc89e89 Merge pull request #1074 from aiongg/docs-tidy
docs: tidy AGENTS.md, CI comment and attribution
2026-10-31 01:07:01 -04:00
aiongg ff8f098743 docs: tidy AGENTS.md, CI comment and attribution 2026-10-31 04:17:26 +00:00
Brandon ThomasandClaude Opus 5.5 a5ef79f379 Release 0.11.0
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v0.11.0
2026-10-30 23:26:28 -04:00
Dylan M. Taylor 5cd3bacdbe Merge pull request #1072 from VoiceLessQ/fix/main-ci-tests
test: fix the two tests failing on main (#1071, #974)
2026-10-30 23:22:20 -04:00
Dylan M. Taylor 21615e80fc Merge branch 'main' into fix/main-ci-tests 2026-10-30 23:22:00 -04:00
Dylan M. Taylor dce0a77083 Merge pull request #924 from SusieeTheLinuxUser/fix/881-flatpak-user-over-system
Detection: a user Flatpak install is read before a system one (#881)
2026-10-30 23:17:43 -04:00
Dylan M. Taylor 0032247ecc Merge pull request #1073 from storytold/feat/integrate-flatpak-system-update-406
fix(update): integrate system Flatpak self-update (#406)
2026-10-30 23:17:01 -04:00
Dylan M. Taylor 367c35981b test(ui): keep app detection cadence separate 2026-10-30 23:09:52 -04:00
SusieeTheFemboyandClaude Opus 5.5 677b9047ed Detection: a user Flatpak wins over a system one under any app id
packages::find tried each bundle id across every record, so a system
io.tangencylabs.solidcraft beat a user ai.storyteller.solidcraft. Packages now say
whether they're a user install; find looks through the user ones first, current id
first within each scope.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 04:04:02 +01:00
SusieeTheFemboy 55842dd91a Merge remote-tracking branch 'origin/main' into fix/881-flatpak-user-over-system 2026-10-31 04:00:55 +01:00
Dylan M. Taylor 8b9dc209dc fix(update): pin merged Flatpak self-update support 2026-10-30 22:58:06 -04:00
Dylan M. Taylor 93de4a9008 fix(update): use system Flatpak bundle self-update 2026-10-30 22:50:36 -04:00
VoiceLessQ 1f5aed9f66 test(native): a shared call only counts on Linux and Windows
failed_in_shared_call is false on other systems, but the test from #974 expected true everywhere, so the FreeBSD x86_64 job has failed since.
2026-10-31 00:35:26 -02:00
VoiceLessQ c5586148e3 test(ui): the installed-apps rescan still waits five minutes
#1071 moved release checks to twelve minutes and changed this test to match, but detection runs on RESCAN_EVERY in app.rs, a separate timer that stayed at five. The test has failed on main since.
2026-10-31 00:35:26 -02:00
Dylan M. Taylor f74bb9d1a6 AGENTS.md: CI workflows only call craft-common-actions at @main
AGENTS.md (and CLAUDE.md where present) gets a CI workflows section: workflows only call
craft-common-actions at @main, with no other jobs; feature and fix PRs don't touch CI and
link or open a craft-common-actions issue (a PR only for a small fix that is safe for
every app and does not increase CI time); legacy jobs
aren't added to and move only as their own task, staying until a shared workflow runs them.
2026-10-30 22:15:19 -04:00
VoiceLessQ ae5ac6aef7 fix(native): cap a GitHub rate-limit wait at one hour (#782)
An absurd x-ratelimit-reset or retry-after stopped the API until restart
and went to the footer as it came. GitHub's quota refills within the hour.
2026-10-30 22:14:18 -04:00
VoiceLessQ 829e2c49c8 fix(logging): never open a log path that's already there (#782)
The mode only applies to a new file, so a path recreated between rotation
and the open would keep its owner's permissions. create_new refuses it.
2026-10-30 22:13:54 -04:00
VoiceLessQ e673dab14f fix(logging): only the user can read the log file (#782)
The log names the user's folders, so create it with mode 0600 on Unix.
Logs from older runs keep their mode until they rotate out.
2026-10-30 22:13:54 -04:00
Dylan M. Taylor 7da8ef2dec fix(ui): reduce automatic release polling 2026-10-30 22:13:36 -04:00
VoiceLessQ 02a99f01a1 fix(ui): find the host's CJK fonts inside the Flatpak sandbox (#620)
Flatpak mounts the host's /usr/share/fonts at /run/host/fonts and
/usr/local/share/fonts at /run/host/local-fonts (add_font_path_args in
flatpak's common/flatpak-run.c). The sandbox's own /usr/share/fonts holds
only the runtime's fonts, so the Flatpak launcher found no Chinese or
Japanese font and fell back to English.

Each system candidate is now followed by its /run/host path, for the same
family. User fonts need no twin, since both manifests grant
--filesystem=home. PhotoCraft fixed the same lookup in
storytold/photocraft#1204.
2026-10-30 22:02:02 -04:00
JeremyandClaude Opus 5.5 73a824c4dc feat(versions): go back to an older version of a launcher-installed AppImage
An AppImage the launcher installed is renamed into place whole, and the old file is removed
only after that, the same as an update. Going back to a version chosen by name now takes
that route too (Downgrade::KeepOldCopy), with no older package fetched first. It needs the
launcher's own record of an AppImage: a user's own AppImage, an unrecorded one and the
tarball install (whose bin and share swap one at a time) are still refused.

Not run on a real Linux desktop; the linux module only compiles there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 22:01:23 -04:00
VoiceLessQ 014422ad15 fix(packaging): declare the launcher's real window class in its .desktop file (#1026)
The window sets its app id (Wayland) and WM_CLASS (X11) to
ai.storyteller.artcraft-launcher, but the entry said
StartupWMClass=artcraft-launcher. Desktops that find the entry by its
file name were fine; an entry under another name (AppImageLauncher,
Gear Lever, a hand-made one) never matched, so the dock showed a
generic icon and the launcher could not be pinned.
2026-10-30 22:00:18 -04:00
VoiceLessQ d95ae4b5be fix(install): name the code in the pkexec 127 error
127 also covers other pkexec errors and a wrapped installer exiting 127, so
say which code came back and list the likely causes instead of naming one.
2026-10-30 21:58:07 -04:00
VoiceLessQ cbc6fe60d9 fix(install): stop reading pkexec exit 127 as a cancel (#737)
pkexec exits 126 when the prompt is dismissed. 127 is its default code and
also covers not authorized and no authentication agent, so a desktop with no
polkit agent ended an install as a quiet "Install cancelled" with no prompt.
2026-10-30 21:58:07 -04:00
VoiceLessQ 361e3e82f4 fix(http): read long release lists up to a 16 MiB cap (#1021)
get_api shared the 4 MiB limit for small answers, and SolidCraft's list of 67
releases is 5.4 to 6.5 MB. The request failed every time, so Choose version
showed an error and no versions. Other small requests keep 4 MiB.
2026-10-30 21:57:43 -04:00
VoiceLessQ e1ada85d02 test(ui): compare the table date with its whole width
The check for more than 110 px passed at any column from 111 to 129 px, where
the date is still cut. Lay out the same text and require its full width.
2026-10-30 21:55:09 -04:00
VoiceLessQ c911793006 fix(ui): widen the table's released column so dates show whole (#1038, #754)
Dates ran to 130 px in Brazilian Portuguese and 108 px in Chinese and
Japanese, past the 104 px column, and were cut with an ellipsis. The
column is now 132 px; Author gives up 16 px ("Tangency Labs" still fits)
and the app column 12 px.
2026-10-30 21:55:09 -04:00