Commit Graph
176 Commits
Author SHA1 Message Date
dotCooCoo bc2a9fbe65 fix(windows): keep running when the update helper would use other folders
When the launcher can't find its per-user folders, it keeps its files in
the temporary folder. The update helper finds the folders again from the
installed exe. It then failed to find them, or found a cache other than
the one holding the update, and stopped after the launcher had quit
without starting the launcher again.

Before the launcher quits, the update now also checks that the helper
finds the cache holding the download, the staging folder and the
helper's copy. Otherwise the update stops with an error and the launcher
keeps running.
2026-10-22 10:24:22 -07:00
skylartaylor 123032ea07 style: wrap portable update signatures and documentation 2026-10-22 15:59:32 +02:00
skylartaylor b9b24da3d2 Merge main and retain both Windows API features 2026-10-22 15:58:43 +02:00
skylartaylor c868893f30 fix: validate the portable launcher before committing its update 2026-10-22 15:58:28 +02:00
skylar taylor-barrick d405a75016 Merge pull request #743: read Windows versions without PowerShell
Read ProductVersion directly from Windows VERSIONINFO, including fallback string tables.

Validated by Windows and Linux tests, WASM checks, Nix evaluation, and SonarCloud.
2026-10-22 07:33:17 -06:00
BFlat baf0e33eb3 Merge pull request #759 from storytold/readme/app-icon
README: the app icon above the title
2026-10-22 18:01:16 +07:00
bflatastic eb3fbfadc2 README: the app icon above the title 2026-10-22 17:57:26 +07:00
Dylan M. Taylor bf39e92f30 Merge pull request #745 from storytold/sonar-fix/pin-actions-sha
ci: pin GitHub Actions to full commit SHA (SonarCloud S7637)
2026-10-21 19:34:28 -04:00
Dylan M. Taylor 78cbc6e149 Merge pull request #746 from storytold/sonar-fix/enforce-https
security: enforce HTTPS on curl downloads (SonarCloud S6506)
2026-10-21 19:34:11 -04:00
Dylan M. Taylor 89ff63e6fc security: enforce HTTPS on curl downloads (SonarCloud S6506)
Add --proto '=https' to curl invocations so redirects cannot downgrade to
plaintext HTTP. Resolves SonarCloud S6506 (shell/docker/githubactions).
2026-10-21 17:06:36 -04:00
Dylan M. Taylor 8abe6e0c03 ci: pin GitHub Actions to full commit SHA (SonarCloud githubactions:S7637)
Pin third-party actions to full-length commit SHAs (with version comments)
instead of mutable tags/branches to prevent supply-chain tampering via
retagged releases. Resolves SonarCloud rule githubactions:S7637.
2026-10-21 17:04:15 -04:00
Martin BallandClaude Opus 5.5 fe2534d51b fix(windows): retry busy download renames and log Windows Installer runs (#687)
* fix(windows): retry busy download renames and log Windows Installer runs

Antivirus scanners often hold a just-written installer open, so renaming
the finished .part file failed with "Access denied (os error 5)". Retry
the rename for a few seconds on Windows errors 5 and 32.

Windows Installer error 1603 carries no detail on its own: run msiexec
with a verbose log beside the package and name it in the error.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* fix(download): honour pause and cancel while retrying a busy rename

Check the stop flag before every rename attempt, so a cancel that lands
while the checksum is being computed, or during a Windows retry backoff,
stops the download instead of installing it. A cancelled download still
throws its partial file away.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-21 14:47:46 -06:00
dotCooCoo 51ab0ca09e fix: write the self-update marker before the swap starts
The Windows helper runs alongside the launcher and clears the marker when
it refuses an update, which it can do before update() returns. Writing the
marker after scheduling could then put it back and hide the release for
24 hours. update() now writes the marker before the swap and removes it
only when scheduling fails, so it never writes after the helper started.
2026-10-21 13:22:29 -07:00
dotCooCoo 837c7e5b1d test: read a version from a program without a Translation entry
The new test writes a minimal 64-bit program file that holds only a
VERSIONINFO, with ProductVersion 1.2.3 in the 040904B0 string table and
no \VarFileInfo\Translation entry, and checks that executable_version
reads 1.2.3 from it. Without the fallback string tables it reads no
version.
2026-10-21 13:09:35 -07:00
dotCooCoo 5efadbee9e fix: record a self-update as installed only once its swap is scheduled
update wrote the just-updated marker before it scheduled the swap, so a
swap that failed to start (the Windows helper couldn't be copied or
started, an AppImage couldn't be replaced, a package install failed)
still hid that release for 24 hours. The marker is now written only when
the swap was scheduled, on every platform; a failure reaches the user
through the job's error as before and leaves the update on offer.
2026-10-21 13:06:47 -07:00
Dylan M. Taylor c27cf7b62c ci: add sonar-project.properties for CI-based analysis
Marks the project ineligible for SonarCloud Automatic Analysis, resolving the
CI-vs-automatic-analysis conflict so the SonarCloud workflow succeeds.
2026-10-21 16:00:26 -04:00
dotCooCoo 439fb46ac2 fix(windows): look for the version in the usual string tables when a file lists none
executable_version looked for ProductVersion only in the languages the
file's \VarFileInfo\Translation lists, so a file without that entry had
no version and its portable install was rolled back. After the listed
languages it now also tries U.S. English in UTF-16, Windows-1252 and no
code page (040904B0, 040904E4, 04090000), as .NET's FileVersionInfo does.
2026-10-21 12:51:47 -07:00
dotCooCoo dfc7de00c9 fix(windows): a portable self-update that fails part way puts the old files back
unpack_over copied the new files over the launcher's folder one at a
time, so a copy that failed part way (a locked file, a full disk) left new
and old files mixed, and the helper then started that mix. It now saves
each file it replaces under the staging folder and, when a copy fails,
removes the files the update added and copies the saved ones back before
it returns the error.

When a saved file can't be copied back, the saved files move to a
launcher-update-recovery-<time> folder in the cache, which later updates
leave alone, and the error names it. If that move fails, they stay in the
staging folder, and the next update refuses to run until they are moved.
2026-10-21 12:51:47 -07:00
Dylan M. Taylor 45ce3c2b93 ci: add SonarCloud scan via shared reusable workflow
Calls storytold/craft-common-actions/.github/workflows/sonarcloud.yml@main
with secrets: inherit. Adds SonarCloud badge to README where missing and
removes the redundant sonar-project.properties (config now passed by the
reusable workflow).
2026-10-21 15:46:49 -04:00
dotCooCoo bf16e21f76 fix(windows): self-update runs no PowerShell and installs only files signed like the launcher
On Windows the launcher finished its own update with a detached
powershell.exe started with -ExecutionPolicy Bypass -WindowStyle Hidden.
The script waited for the launcher to exit, ran the new MSI or unpacked
the portable zip with Expand-Archive, deleted the download and started the
new exe. Antivirus heuristics score that sequence, and the command line
sits in the signed exe as a string.

The update helper is now a copy of the launcher itself, put in
<cache>\launcher-update-helper and started with --finish-update. It waits
for the old process with OpenProcess and WaitForSingleObject (winsafe),
runs msiexec /i /passive /norestart and checks its exit code, or unpacks
the portable zip with the checks portable app installs already use, and
then starts the launcher again. main() hands --finish-update to the helper
before logging, the single-instance claim and the window.

The helper finishes only the launcher's own update:
- the exe is this launcher's MSI or portable installation, and the
  helper, the download and the staging folder are in that installation's
  cache;
- the MSI, every program in the portable zip and the exe it starts carry
  a valid Authenticode signature from the helper's own publisher
  (verifysign, through WinTrust).
The launcher checks its own signature, the installed exe and the new MSI
before it quits, so an unsigned build reports that it doesn't install
updates instead of closing. A failed update clears the self-update marker,
so the next check offers it again, and the next start logs the error.
2026-10-21 12:07:47 -07:00
dotCooCoo e41c282432 fix(windows): read a portable app's version without starting PowerShell
After unpacking a portable app, the launcher checks the exe's
ProductVersion against the release. It started a hidden powershell.exe
-NoLogo -NoProfile -NonInteractive -Command to read
FileVersionInfo.ProductVersion, which costs a PowerShell start on every
portable install and is one of the command lines antivirus heuristics
score.

executable_version now reads the ProductVersion string from the file's
VERSIONINFO with GetFileVersionInfo and VerQueryValue (winsafe), in the
first language the file lists, and no process is started.
2026-10-21 12:02:33 -07:00
Dylan M. Taylor 7dc837560e ci: add SonarCloud scan workflow and config 2026-10-21 13:54:43 -04:00
Brandon ThomasandClaude Opus 5.5 ba3b0345f0 i18n: translate the reworded AppImage note (#663)
#663 reworded the settings dialog's note to "On Linux, custom folders use
AppImage format." The meaning is unchanged, so each catalog's existing
translation is reused under the new key. The old wording is still used in
dialogs.rs, so its rows stay.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v0.6.1
2026-10-20 15:00:06 -04:00
Brandon ThomasandClaude Opus 5.5 5479f0a618 Release 0.6.1: saved filters no longer hide every app (#678)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-20 14:56:04 -04:00
Brandon ThomasandClaude Opus 5.5 5fcbed6db8 i18n: translate the update dialog's download prompt
#677 added "A new version is available. Download it to replace this
version?" without catalog rows, so complete_catalogs_cover_every_ui_literal
failed on main and those languages showed English. Adds the row to all ten
complete catalogs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-20 14:56:04 -04:00
Dylan M. Taylor 8caaabed5d Merge pull request #663 from Felix-Helleckes/fix/issue-649
fix: address issue #649
2026-10-20 14:53:27 -04:00
Dylan M. Taylor 2ae652f750 Merge pull request #675 from storytold/fix/freebsd-aarch64-tests
fix(freebsd): pick the aarch64 tarball on FreeBSD aarch64; steady the pipe-deadline test
2026-10-20 14:49:47 -04:00
Dylan M. Taylor d6117aa2de Merge pull request #677 from Felix-Helleckes/fix/issue-388
fix: address issue #388
2026-10-20 14:48:49 -04:00
skylar taylor-barrick a538251f1e Fix saved filters hiding all apps on startup (#678) (#684)
* #678: clear obsolete saved filters at desktop startup

* #678: share saved filter migration across startup paths

* #678: cover legacy saved filters and locale-safe UI startup
2026-10-20 14:46:55 -04:00
irgendwasmitfelix aee3305d89 fix: address issue #388 2026-10-20 18:42:12 +02:00
Brandon ThomasandClaude Opus 5.5 046d48fb2a Skip CodeRabbit reviews on Dependabot PRs (#676)
Adds .coderabbit.yaml so CodeRabbit no longer reviews or comments on PRs opened by dependabot[bot].

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-20 11:41:13 -04:00
Brandon ThomasandClaude Opus 5.5 7e6460e5c8 fix(freebsd): install the aarch64 tarball on FreeBSD aarch64 and steady the pipe-deadline test
Craft App releases ship <app>-<ver>-freebsd-aarch64.tar.gz next to the
x86_64 tarball, but the platform tokens had none for FreeBSD on ARM64, so
nothing was picked there and the backend's kept-download tests failed on
the nightly FreeBSD aarch64 job. Pick freebsd-aarch64 on FreeBSD ARM64 the
way freebsd-x86_64 is picked on x86_64 (no cross-arch fallback), with a
core test on SoundCraft v0.10.0's release metadata trimmed to its FreeBSD
tarballs, and add the token to the backend tests' synthetic release.

The inherited-pipe test gave its direct child one second to start a second
test process and fill both pipes; under emulation that takes longer, so
run() killed the child first and the test never reached the case it
checks. Retry with a longer deadline (1 s, 4 s, 16 s) when the child didn't
get that far, let the descendant hold the pipes for 120 s unless stopped,
and still require run() to return within twice its deadline.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-20 10:53:56 -04:00
irgendwasmitfelix 39ceecb5c2 fix: address issue #649
[Bug Report] [App Launcher] Bad grammar on Linux Appimage directory menu

---
*Auto-fixed by daemon*
2026-10-20 10:41:07 +02:00
Brandon ThomasandClaude Opus 5.5 8b107ffff2 Release 0.6.0
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v0.6.0
2026-10-19 22:17:37 -04:00
Dylan M. Taylor 7c7271e5f6 docs: add SonarCloud and CodeRabbit badges to README (#599)
* docs: add SonarCloud and CodeRabbit badges to README

* docs: put SonarCloud and CodeRabbit badges on their own line
2026-10-18 16:14:51 -06:00
skylar taylor-barrick 345c509fe8 Merge pull request #527 from Jeremy8776/feat/launcher-redesign
feat(ui): a calmer header, toolbar, cards, app page and dialogs
2026-10-18 15:03:44 -06:00
Dylan M. Taylor f1676dfb41 fix(linux): only update release Arch packages and delegate AUR/repo packages (#586) (#588)
* fix(linux): only update release Arch packages and delegate AUR/repo packages (#586)

- Only consider release Arch packages (bundle ID starting with 'ai.storyteller.') eligible for launcher updates.
- Keep AUR packages (<app>, <app>-bin, <app>-git) directed to the user's AUR helper (yay/paru).
- Direct repository packages (e.g. Omarchy) to 'sudo pacman -Syu' and add translations across all 10 locales.
- Only self-update launcher if installed as the release Arch package ('ai.storyteller.artcraft-launcher'), preventing conflicts on AUR installs.
- Check pacman DB presence before assuming ArchPkg availability.

* fix(linux): exclude ArchPkg from candidates for non-release Pacman installs

* i18n: add AUR update hint translations across all catalogs

* fix(linux): return empty kinds for AUR packages, preserve can_pacman fallback, and bound pacman queries

* fix(linux): tighten arch package self-update check, streamline hint message, and test deterministically

* fix(linux): require arch availability for new preferred installs
2026-10-18 14:33:45 -04:00
Gabriel Matozo 887d72b3ed docs: point the README's Trunk link at the bundler's site (#562)
The "Build from source" section linked trunk to https://trunkrs.dev/, which no
longer serves the WAsm bundler: the domain was re-registered and now serves an
unrelated site. The bundler's own repo (trunk-rs/trunk) points at
https://trunk-rs.github.io/trunk/ in its README and in site/config.toml
(base_url), so the link now goes there. No other occurrence of the old URL in
the repo.
2026-10-18 14:31:43 -04:00
Dylan M. Taylor 2b9c13eff7 ci: configure Dependabot for Cargo and GitHub Actions
Co-authored-by: Dylan M. Taylor <dylan@dylanmtaylor.com>
2026-10-18 12:31:09 -06:00
Dylan M. Taylor e0af0f81f8 fix(linux): require arch availability for new preferred installs 2026-10-18 14:03:19 -04:00
skylar taylor-barrick 8773041c72 Load a grey card's colour icon ahead of the hover
egui decodes the colour picture on a background thread the first time it is
asked for, so the first hover over a card showed no icon for a moment, and the
grey-card test (8 frames, no real time) failed on CI's slower Windows runner.
The grey path now starts that load, and the test waits for the decode.
2026-10-18 12:02:31 -06:00
Dylan M. Taylor b511457458 fix(linux): tighten arch package self-update check, streamline hint message, and test deterministically 2026-10-18 12:48:10 -04:00
Dylan M. Taylor 54f18abc62 fix(linux): return empty kinds for AUR packages, preserve can_pacman fallback, and bound pacman queries 2026-10-18 09:47:40 -04:00
Dylan M. Taylor 5ab2fd1bbb i18n: add AUR update hint translations across all catalogs 2026-10-18 09:08:11 -04:00
Dylan M. Taylor 3243d96ddb fix(linux): exclude ArchPkg from candidates for non-release Pacman installs 2026-10-18 08:43:48 -04:00
Dylan M. Taylor 9cef5d2a0f chore(details): drop competitor reference from deckcraft feature copy (#579) 2026-10-18 08:41:23 -04:00
40f22a612a Fix flake.nix (#526)
* Add experimental flake.nix for NixOS/Linux development

This adds an experimental flake-based development environment and package entry for ArtCraft Launcher.

What this adds:
- `flake.nix` at the repository root
- Rust toolchain via `rust-overlay`
- Required native Linux libraries for the Rust workspace
- A dev shell via `nix develop`
- A package/app target via `nix run` / `nix build`

Why:
ArtCraft Launcher is a Rust workspace and currently has no Nix flake support. This makes local development and installation much easier for NixOS/Linux users.

Notes:
- This is intentionally minimal and experimental.
- It targets the development environment and local package use.
- Additional refinements may be needed for specific Wayland/X11 setups.

* Fix flake metadata to match ArtCraft Launcher and remove GTK dependency

* add flake.lock

* Update flake.nix: replace deprecated xorg packages with their new names

* added runtimeDependencies and fixed nativeBuildInputs: removed ninja and cmake to resolve conflicts with Cargo on app build, added autoPatchelfHook to auto hook runtimeDependencies into the RPATH of bin; added result in .gitignore to prevent build results from project

* Add X11 support libraries

Added X11 support libraries to the flake configuration.

* Nix: build the flake in CI and document nixGL for other distros

The new Nix workflow builds the flake and checks that every library
winit and wgpu dlopen() at runtime is on the binary's RUNPATH, so a
missing runtimeDependencies entry fails CI instead of failing on
`nix run`. It only runs when the flake, Cargo manifests or lockfile
change.

The README gains a short Nix section: the dev shell, `nix run`, and
nixGL for non-NixOS distros, where a Nix-built program can't load the
host's GPU drivers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Drop the local runtime-libs job; it moves to the shared Nix workflow

Per review: the build-and-RUNPATH check belongs in
storytold/craft-common-actions (opt-in check-runtime-libs), so
.github/workflows/nix.yml goes back to main's shared eval job.

---------

Co-authored-by: SaB131X <sea1024wm@gmail.com>
Co-authored-by: skylar taylor-barrick <hi@skylar.cc>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 08:41:02 -04:00
Dylan M. Taylor 4e533d6d7a fix(linux): only update release Arch packages and delegate AUR/repo packages (#586)
- Only consider release Arch packages (bundle ID starting with 'ai.storyteller.') eligible for launcher updates.
- Keep AUR packages (<app>, <app>-bin, <app>-git) directed to the user's AUR helper (yay/paru).
- Direct repository packages (e.g. Omarchy) to 'sudo pacman -Syu' and add translations across all 10 locales.
- Only self-update launcher if installed as the release Arch package ('ai.storyteller.artcraft-launcher'), preventing conflicts on AUR installs.
- Check pacman DB presence before assuming ArchPkg availability.
2026-10-18 08:35:47 -04:00
skylar taylor-barrick b39b80580c Merge main into the redesign
Main's Arch package option (#565) went into the Linux install-format list in
dialogs.rs, which this branch moved to settings_dialog.rs; it is added there.
2026-10-17 23:55:57 -06:00
skylar taylor-barrick ccc2f4b96c Tests: check the one header label directly instead of looping over it
Rust 1.99's clippy (CI's) rejects a for loop over a one-item array; the list
lost its other entry when the "Launcher" tag left the header.
2026-10-17 22:59:34 -06:00