Commit Graph
210 Commits
Author SHA1 Message Date
FredAppsandClaude Opus 5.5 f4d0962352 sonarcloud: free disk space in the background in the archive build
As gate.yml does: the build starts at once and the space is free before
it needs it. The scan job's cleanup is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-11 13:44:07 +01:00
FredAppsandClaude Opus 5.5 9746d75ce5 gate: opt-in sccache for the workspace's own crates
rust-cache keeps dependencies but not the workspace's crates, so every
gate run compiles all of them again. With `sccache: true` the gate wraps
rustc in sccache over the GitHub Actions cache. It writes where the
dependency cache saves (the default branch, opted-in dispatches) and
only reads elsewhere; SCCACHE_GHA_RW_MODE in `env` overrides that.

Off by default, so no caller changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-11 13:44:07 +01:00
Dylan M. Taylor 91e2c76173 sonarcloud: opt-in SQLX_OFFLINE and extra cargo features for the coverage build (#195) 2026-11-10 23:08:00 -05:00
Dylan M. Taylor 0588474894 sonarcloud: optional JavaScript/TypeScript coverage (#194)
* sonarcloud: optional JavaScript/TypeScript coverage (node-coverage-script)

* sonarcloud: scan after failing JS/TS tests, then fail the job
2026-11-10 22:29:06 -05:00
Dylan M. Taylor 4b47a2a3c7 Sonar: [[ in sign-linux.sh, a linear trailer regex in refresh-contributors (S7688, S8786) (#193)
Clears both open SonarCloud issues.

- `actions/draft-release/sign-linux.sh`: `[[ ]]` in place of `[ ]` for bash tests (SonarCloud shell:S7688). Every script has a bash shebang; no test uses `-a`/`-o`, escaped parentheses or an unquoted pattern on the right of `=`.
- `actions/refresh-contributors/refresh_contributors.py` `model()`: `([^<>]*)<([^<>]+)>` on the stripped trailer, with the name stripped after, in place of `\s*(.*?)\s*<([^<>]+)>\s*` (python:S8786, backtracking). Same result for every Git identity: a name can't hold `<` or `>`.
2026-11-10 18:45:19 -05:00
Dylan M. Taylor 644a5d76b9 ci: harden workflows with credential isolation, template injection defenses, and dependabot cooldown (#191)
* ci: harden workflows with credential isolation, template injection defenses, and dependabot cooldown

- Add persist-credentials: false across all actions/checkout invocations
- Eliminate template injection by mapping matrix and input variables to env: in freebsd.yml, release.yml, and sonarcloud.yml
- Add 7-day cooldown to dependabot.yml to protect against supply-chain compromise of recently published releases
- Update test suite to validate hardened environment mappings

* ci: allow static.crates.io and registry endpoints in gate and windows-arm64 runners
2026-11-10 18:07:38 -05:00
FredApps 9b9e0f5128 Merge pull request #188 from storytold/sonar/docker-build-job-permissions
fix(docker-build): scope packages: write to the pushing jobs
2026-11-10 18:27:46 +01:00
FredApps 567530acb5 Merge branch 'main' into sonar/docker-build-job-permissions 2026-11-10 18:23:14 +01:00
FredApps b24513e795 fix(freebsd): cap the VM's ZFS ARC so big test crates aren't OOM-killed (#190)
* fix(freebsd): give the VM a swap file and cap the ZFS ARC

photocraft's FreeBSD job was SIGKILLed compiling photocraft-ui-egui's lib tests late in the run (release run 42609972735, dispatch 42805955303). Add an 8 GB swap file when the guest has none, cap the ARC at 2 GB when the image uses ZFS, and print disk, swap and memory so the next OOM is diagnosable.

* fix(freebsd): only touch swap and the ARC inside a FreeBSD guest

The workflow tests run the prepare script on Linux under sh -eu, where swapctl doesn't exist. Run the ARC cap, swap file and diagnostics only when uname is FreeBSD, and don't let the diagnostics fail the step.

* fix(freebsd): add the swap file only with room to spare, and remove a partial one

Per review: a dd that runs out of space must not leave a partial /var/swap0 that then starves the build. Require 16 GB free on /var first and delete the file if any step fails.

* fix(freebsd): keep only the ZFS ARC cap; drop the swap-file fallback

Per review: swap on a ZFS-backed file can hang FreeBSD under memory pressure, and today's image already has a swap partition, so the fallback never ran. The verified run passed on the ARC cap alone.
2026-11-10 16:40:36 +01:00
Dylan M. Taylor 969c32dcf2 ci: allow SonarCloud S3 analysis sensor cache and scanner data endpoints 2026-11-10 08:26:20 -05:00
Dylan M. Taylor 0912de799d ci: expand allowed-endpoints with wildcard domains for APT, GPG, and PyPI 2026-11-10 08:26:20 -05:00
Dylan M. Taylor 21875aea67 ci: add GPG keyservers to sonarcloud.yml allowed-endpoints 2026-11-10 08:26:20 -05:00
Dylan M. Taylor 2edf8b6175 ci: address review findings for Harden-Runner egress policy
- Add allowed-endpoints to ast-grep.yml matching test-ast-grep.yml
- Add pypi.org and files.pythonhosted.org to sonarcloud.yml for Python coverage
- Add packages.microsoft.com:443 and https mirrors to apt allowed-endpoints
- Set unvalidated reusable workflows (release, docker-build, gate, etc.) to audit mode
2026-11-10 08:26:20 -05:00
Dylan M. Taylor 9e571bd658 ci: add allowed-endpoints to packaging-lint and house-rules workflows 2026-11-10 08:26:20 -05:00
Dylan M. Taylor 5a43790c93 ci: replace anchore/sbom-action with step-security/sbom-action
Switch to the StepSecurity-maintained secure drop-in replacement
pinned to v0.24.2 (28bb7d0d2869c9ab0e5571c93591747945819d39).
2026-11-10 08:26:20 -05:00
Dylan M. Taylor df5f1fef9a ci: specify allowed-endpoints for block mode in workflows 2026-11-10 08:26:20 -05:00
Dylan M. Taylor 80cb1d6a31 ci: switch Harden-Runner egress-policy to block mode 2026-11-10 08:26:20 -05:00
Dylan M. Taylor 529d68aa05 test: account for Harden-Runner step in workflow assertions
Update unit test step inspections and unpacks to locate steps by name/action
or ignore the leading Harden-Runner security step.
2026-11-10 08:26:20 -05:00
Dylan M. Taylor 83e81167c6 ci: add StepSecurity Harden-Runner to every workflow job
Adds step-security/harden-runner (v2.22.4, SHA-pinned) as the first step of
every job in the reusable and repo workflows, in egress-policy: audit mode.
Audit mode only records network, file and process activity; it blocks nothing.
Unsupported environments (containers, FreeBSD VM guests, ubuntu-slim) are
skipped by the action itself. Dependabot's github-actions group keeps the pin
current.
2026-11-10 08:26:20 -05:00
FredApps 1a6c6c0dd5 fix(docker-build): scope packages: write to the pushing jobs 2026-11-10 11:10:27 +01:00
Dylan M. Taylor fd14193f06 fix(docker-build): set up Buildx before registry logins (#181) 2026-11-08 20:16:57 -05:00
Dylan M. Taylor c9f7255114 chore(docker-build): remove DigitalOcean Container Registry support (#180) 2026-11-08 20:10:10 -05:00
Dylan M. Taylor a5eda472ea feat(docker-build): support Docker Hub registry alongside DOCR and GHCR (#179) 2026-11-08 19:33:37 -05:00
Dylan M. Taylor 3b3ea7ed62 feat(release): dual-push Flatpak OCI layouts to Docker Hub (#178)
* feat(release): dual-push Flatpak OCI layouts to Docker Hub

* fix(release): derive Docker Hub repo name from REGISTRY
2026-11-08 19:11:04 -05:00
FredApps 4b23a68072 fix(packaging-lint): retry transient actionlint downloads (#176)
Bound archive and checksum download retries, including refused connections, while retaining HTTPS and SHA-256 validation. Report missing checksum entries using an exact archive filename lookup. Add nine real-curl regression tests for recovery, permanent failures, retry bounds and checksum validation.
2026-11-08 14:16:10 +01:00
FredApps 8fb29161c2 fix(sonar): reduce sharded coverage disk usage (#174)
* fix(sonar): bound sharded coverage disk usage

* test(signing): detect restricted GPG agent sockets
2026-11-08 14:15:27 +01:00
Dylan M. Taylor 8e9b8b96c5 fix: support rpm 4.20+ signing and pin release job to ubuntu-24.04 (#175)
* fix(draft-release): use rpmsign --resign to support RPM 4.20+

* fix(release): run Draft GitHub Release on ubuntu-24.04
2026-11-07 20:48:33 -05:00
Dylan M. Taylor 626427bb5f Build without provenance so digests match across registries (#173)
An attestation names the repository it was pushed to, so DOCR and GHCR received
different digests and the merge job could only tag one of them.
2026-11-07 15:22:47 -05:00
Dylan M. Taylor a9cdd6881c Push every image by digest in the docker build (#172)
buildx pushes a by-digest output to one repository per invocation, so with two
imagerepositories only the last one received the manifest and the merge job failed
with "not found". Loop over the image list and assert the digests agree.
2026-11-07 15:18:14 -05:00
Dylan M. Taylor 4acf645c17 Give the composed build output its image type (#171)
buildx requires a `type=` prefix in `outputs`; without it every caller failed
with "type is required for output" before the first layer was built.
2026-11-07 15:13:09 -05:00
Dylan M. Taylor 18c197bc08 Add a reusable docker build workflow (#170)
Builds every platform in `platforms` by digest into each repository in `images`,
then joins those digests into one multi-arch manifest per repository, logging in
to DOCR, GHCR or dhi.io only when an image needs it. It carries the inputs both
craft web images need: a custom Dockerfile and stage, build args, a GHA layer
cache, preinstalled-SDK pruning, and a hook for preparing large build contexts
such as the font sources.
2026-11-07 14:29:07 -05:00
Dylan M. Taylor 3e2ac193fd feat: drop Windows 32-bit builds (#163)
Drops i686-pc-windows-msvc (x86) builds from the Windows release matrix, retaining 64-bit x64 and arm64 targets.
2026-11-06 21:27:06 -05:00
Dylan M. Taylor 2f46576245 feat: allow uploading assets to an existing published release (#164) (#165)
Add allow-published (default false) to draft-release. When true, draft-release
permits uploading assets to an existing published release without failing or
attempting to convert it to a draft with --draft.
2026-11-06 20:40:48 -05:00
Dylan M. Taylor aa106c86ee feat: allow additional Arch runtime dependencies (#161) 2026-11-06 19:33:10 -05:00
Dylan M. Taylor 489222f309 feat: optionally retain existing draft release assets (#160) 2026-11-06 19:24:50 -05:00
Dylan M. Taylor dd3d987521 feat: allow a custom draft release tag prefix (#159) 2026-11-06 16:06:01 -05:00
dependabot[bot] 91428662bf ci(deps): bump the actions group with 2 updates (#154)
Bumps the actions group with 2 updates: [taiki-e/install-action](https://github.com/taiki-e/install-action) and [SonarSource/sonarqube-scan-action](https://github.com/sonarsource/sonarqube-scan-action).


Updates `taiki-e/install-action` from 2.89.1 to 2.90.0
- [Release notes](https://github.com/taiki-e/install-action/releases)
- [Changelog](https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/taiki-e/install-action/compare/682ce6c3c696a4cd5168a05f98e51aa02b877941...b80e2bb2635f28eb98b9fce1e2f0887e1535c6b2)

Updates `SonarSource/sonarqube-scan-action` from 8.4.0 to 8.4.1
- [Release notes](https://github.com/sonarsource/sonarqube-scan-action/releases)
- [Commits](https://github.com/sonarsource/sonarqube-scan-action/compare/4d1dc0c91ee400dcf8a6dddf2f705ac36542e304...e805d875275f728fac1885b413934be6d7c63f65)

---
updated-dependencies:
- dependency-name: taiki-e/install-action
  dependency-version: 2.90.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
- dependency-name: SonarSource/sonarqube-scan-action
  dependency-version: 8.4.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-11-06 07:36:43 -05:00
nnaannooandnnaannoo 13f3c2c99b release.yml: export each app's build variables from its env.sh, so a new app needs no change here (#148)
* release.yml: export each app's build variables from its env.sh, not a list

Eight release jobs set <APP>_VERSION, <APP>_BUILD_DATE and <APP>_BUILD_SHA for
every app by name (298 lines), and the FreeBSD VM step listed them all again,
so every new app meant editing this workflow. materialcraft and texturecraft
were never added: their packaging reads MATERIALCRAFT_* and TEXTURECRAFT_*,
so their release builds got no release version, date or commit, and a
dispatched run with a version override packaged them under Cargo.toml's.

actions/export-app-build-env reads the prefix the app's packaging/env.sh (or
packaging/common.sh) already declares in VERSION="${<PREFIX>_VERSION:-...}",
falling back to app-name in capitals, and writes the three variables to
GITHUB_ENV; its names output feeds the FreeBSD VM's envs. Each job runs it
right after checkout. On all 17 apps' env.sh it finds the prefix the old
list used.

Tests run the script on sample env.sh files and check release.yml sets no
app's variable by name, so the list can't come back.

* Export the build variables after the contributor snapshot, which must follow the checkout

test_contributor_refresh requires each build job to load the contributor snapshot directly after checkout, so the export step goes after it when a job has one. Also fix the line-break test passing a variable twice.

---------

Co-authored-by: nnaannoo <n4nosaur@gmail.com>
2026-11-06 07:36:30 -05:00
FredApps e8500913a3 Merge pull request #153 from storytold/house-rules-check
Check that AGENTS.md copies the shared house rules
2026-11-06 11:45:26 +01:00
FredAppsandCursor 3207fcf8ad Keep the house-rules rewrite on the checked AGENTS.md path.
The path is resolved and has to stay inside the named directory. The existing file's text is written back as text, so the path-traversal finding on that write is suppressed.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-11-06 11:42:33 +01:00
FredAppsandCursor 9a3db2d31d Validate house-rules paths and revisions before git or file access.
A checkout path and a recorded commit have to match a fixed pattern, and the standards path has to be one of the two known files. The per-block check is its own function.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-11-06 11:39:18 +01:00
FredAppsandCursor 70fc5d4964 Check that AGENTS.md copies the shared house rules.
The writer and the checker share one normalization. A rewritten digest does not make an edit pass, an intact older copy warns only when main has moved on, and a source that cannot be read is reported as could not check.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-11-06 11:34:30 +01:00
Dylan M. Taylor f2e6f2a639 fix(install-riscv64-cross): read amd64 from the primary mirror (#150)
The runner's amd64 mirror (azure.archive.ubuntu.com) lags ports.ubuntu.com, and
Multi-Arch: same packages must be the same version on both architectures. When
ports publishes a linux-libc-dev before the mirror does, apt cannot install
libc6-dev:riscv64 and reports a dependency that "is not going to be installed",
which fails the riscv64 build until the mirrors happen to catch up.

Point amd64 at archive.ubuntu.com for main and updates as the action already
does for security, so both architectures always offer matching versions.
2026-11-05 22:47:15 -05:00
dependabot[bot] 9bcbea6fa2 ci(deps): bump taiki-e/install-action (#134)
Bumps the actions group with 1 update in the / directory: [taiki-e/install-action](https://github.com/taiki-e/install-action).


Updates `taiki-e/install-action` from 2.88.1 to 2.89.1
- [Release notes](https://github.com/taiki-e/install-action/releases)
- [Changelog](https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/taiki-e/install-action/compare/68a389c788b2cd04016ce8c80ee23b80d2ab3d68...682ce6c3c696a4cd5168a05f98e51aa02b877941)

---
updated-dependencies:
- dependency-name: taiki-e/install-action
  dependency-version: 2.89.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-11-05 09:13:33 -05:00
nnaannooandKristian Myram 4d1066685f Add git-sources.yml: the shared "Git dependencies come from storytold" check (#147)
Eight apps paste the same 25-line job into ci.yml, nix.yml or release.yml (ten
copies): Cargo.lock exists and is up to date, no .cargo/config(.toml)
replaces, patches or overrides a source, and every git dependency comes from
github.com/storytold. Apps' workflows are meant to only call workflows here.

actions/check-git-sources holds the check as a tested script, and
git-sources.yml runs it on a credential-less checkout, so an app swaps its
job for one `uses:` line and keeps `needs: git-sources`. It reports every
problem rather than the first, as GitHub error annotations, and treats
unreadable TOML as a failure. On all 18 apps' current Cargo.lock and Cargo
config it agrees with the inline copy.

Co-authored-by: Kristian Myram <kmy@oresundsbron.com>
2026-11-05 09:13:01 -05:00
nnaannooandKristian Myram 6b66469bba Push the Flatpak OCI tags in the release workflow, not the app's script (#146)
The release job ran each app's packaging/linux/flatpak-oci.sh --push. Most
apps still carry the copy from before scripts/scaffold-flatpak-oci.sh learnt
to guard the stable tag, and it moves stable-<arch> on every push, so a
prerelease or a test run dispatched from any branch became what stable-<arch>
clients install. 15 of the 17 apps carry that copy.

Call the script without --push, which only builds the layout in every copy,
and push from the workflow: <version>-<arch> on every non-PR run, and
stable-<arch> only for a stable version built from the release branch, the
rule the scaffold template already uses. No app needs to change.

Co-authored-by: Kristian Myram <kmy@oresundsbron.com>
2026-11-05 09:12:05 -05:00
f8dc631547 Add setup-windows-signing: the shared Authenticode signing script (#144)
* Add the setup-windows-signing action: the shared Authenticode signing script

Every app carries its own packaging/windows/sign.ps1 and the copies have drifted: four lack the
Trusted Signing client SHA-256 pin. The action exports the maintained script, parameterized by
product name and URL, for package.ps1 to call; it rejects line breaks that could inject
environment variables, and refuses an unset product name. The script reads file names literally.
Tests run it against a stand-in signtool.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013fTnVxnXTv2MBW6uj2PPyU

* Test that an unset product name gets the clear message, not a null-method error

PowerShell echoes the failing source line, so the message alone passed on the old code too.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013fTnVxnXTv2MBW6uj2PPyU

* Refuse a non-x64 signtool for Azure Trusted Signing

The Azure branch loads the x64 Azure.CodeSigning.Dlib.dll, but SIGNTOOL or
PATH can name an x86 or ARM64 signtool.exe, which cannot load it. Read the
PE machine type of the chosen signtool and fail with a clear message before
downloading the client. A file that is not a PE image is left alone.

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Kristian Myram <kmy@oresundsbron.com>
2026-11-05 09:10:10 -05:00
nnaannooandClaude Sonnet 5.5 7ae2c64a8a Add import-macos-certificate: the shared macOS signing certificate import (#140)
* Add shared macOS certificate import and Windows signing script actions

Every app carries its own packaging/macos/import-cert.sh and packaging/windows/sign.ps1, and the
copies have drifted: four apps lack the Trusted Signing client SHA-256 pin and eight still write the
signing certificate to a predictable temporary path.

- import-macos-certificate: the hardened import (private mktemp -d directory, keychain removed on
  failure), self-contained, with identity/keychain outputs.
- setup-windows-signing: exports the shared sign.ps1, parameterized by product name and URL, for
  package.ps1 to call; rejects line breaks that could inject environment variables.
- Tests run both scripts against stand-ins for security, openssl and signtool.

Existing callers are unchanged; apps adopt the actions one at a time.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Signing scripts: read file names literally, refuse an unset product name clearly

sign.ps1 resolved its file arguments with Resolve-Path, which treats [ and ] as wildcards, so a
file such as 'App [x64].msi' failed. setup-windows-signing called .Trim() on an unset product
name, a null-valued method call, instead of its own message. Tests for both.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013fTnVxnXTv2MBW6uj2PPyU

* Split the signing PR: keep only the macOS certificate import here

The Windows signing action moves to its own branch and PR. The tests, README text and bullet for
each action now live with that action, with separate README headings so the two PRs merge
independently.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013fTnVxnXTv2MBW6uj2PPyU

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 09:08:39 -05:00
FredApps bb16e4122a gate.yml: optional gate-timeout-minutes stops a hung gate with a process list and a clear error (#143)
CI green; CodeRabbit rate-limited with no findings; 0 review threads.
2026-11-05 11:27:56 +01:00
FredApps 0755fd19c7 Add changed-paths.yml: run a job only when its paths change or a label asks (#142)
* Add changed-paths.yml: run a job only when its paths change or a label asks

* changed-paths: read paths NUL-separated, keep the reason on one line; README: what the checkout holds
2026-11-05 11:12:34 +01:00