Commit Graph
92 Commits
Author SHA1 Message Date
nnaannooandKristian Myram 4d1066685f Add git-sources.yml: the shared "Git dependencies come from storytold" check (#147)
Eight apps paste the same 25-line job into ci.yml, nix.yml or release.yml (ten
copies): Cargo.lock exists and is up to date, no .cargo/config(.toml)
replaces, patches or overrides a source, and every git dependency comes from
github.com/storytold. Apps' workflows are meant to only call workflows here.

actions/check-git-sources holds the check as a tested script, and
git-sources.yml runs it on a credential-less checkout, so an app swaps its
job for one `uses:` line and keeps `needs: git-sources`. It reports every
problem rather than the first, as GitHub error annotations, and treats
unreadable TOML as a failure. On all 18 apps' current Cargo.lock and Cargo
config it agrees with the inline copy.

Co-authored-by: Kristian Myram <kmy@oresundsbron.com>
2026-11-05 09:13:01 -05:00
nnaannooandKristian Myram 6b66469bba Push the Flatpak OCI tags in the release workflow, not the app's script (#146)
The release job ran each app's packaging/linux/flatpak-oci.sh --push. Most
apps still carry the copy from before scripts/scaffold-flatpak-oci.sh learnt
to guard the stable tag, and it moves stable-<arch> on every push, so a
prerelease or a test run dispatched from any branch became what stable-<arch>
clients install. 15 of the 17 apps carry that copy.

Call the script without --push, which only builds the layout in every copy,
and push from the workflow: <version>-<arch> on every non-PR run, and
stable-<arch> only for a stable version built from the release branch, the
rule the scaffold template already uses. No app needs to change.

Co-authored-by: Kristian Myram <kmy@oresundsbron.com>
2026-11-05 09:12:05 -05:00
f8dc631547 Add setup-windows-signing: the shared Authenticode signing script (#144)
* Add the setup-windows-signing action: the shared Authenticode signing script

Every app carries its own packaging/windows/sign.ps1 and the copies have drifted: four lack the
Trusted Signing client SHA-256 pin. The action exports the maintained script, parameterized by
product name and URL, for package.ps1 to call; it rejects line breaks that could inject
environment variables, and refuses an unset product name. The script reads file names literally.
Tests run it against a stand-in signtool.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013fTnVxnXTv2MBW6uj2PPyU

* Test that an unset product name gets the clear message, not a null-method error

PowerShell echoes the failing source line, so the message alone passed on the old code too.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013fTnVxnXTv2MBW6uj2PPyU

* Refuse a non-x64 signtool for Azure Trusted Signing

The Azure branch loads the x64 Azure.CodeSigning.Dlib.dll, but SIGNTOOL or
PATH can name an x86 or ARM64 signtool.exe, which cannot load it. Read the
PE machine type of the chosen signtool and fail with a clear message before
downloading the client. A file that is not a PE image is left alone.

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Kristian Myram <kmy@oresundsbron.com>
2026-11-05 09:10:10 -05:00
nnaannooandClaude Sonnet 5.5 7ae2c64a8a Add import-macos-certificate: the shared macOS signing certificate import (#140)
* Add shared macOS certificate import and Windows signing script actions

Every app carries its own packaging/macos/import-cert.sh and packaging/windows/sign.ps1, and the
copies have drifted: four apps lack the Trusted Signing client SHA-256 pin and eight still write the
signing certificate to a predictable temporary path.

- import-macos-certificate: the hardened import (private mktemp -d directory, keychain removed on
  failure), self-contained, with identity/keychain outputs.
- setup-windows-signing: exports the shared sign.ps1, parameterized by product name and URL, for
  package.ps1 to call; rejects line breaks that could inject environment variables.
- Tests run both scripts against stand-ins for security, openssl and signtool.

Existing callers are unchanged; apps adopt the actions one at a time.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Signing scripts: read file names literally, refuse an unset product name clearly

sign.ps1 resolved its file arguments with Resolve-Path, which treats [ and ] as wildcards, so a
file such as 'App [x64].msi' failed. setup-windows-signing called .Trim() on an unset product
name, a null-valued method call, instead of its own message. Tests for both.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013fTnVxnXTv2MBW6uj2PPyU

* Split the signing PR: keep only the macOS certificate import here

The Windows signing action moves to its own branch and PR. The tests, README text and bullet for
each action now live with that action, with separate README headings so the two PRs merge
independently.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013fTnVxnXTv2MBW6uj2PPyU

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 09:08:39 -05:00
FredApps bb16e4122a gate.yml: optional gate-timeout-minutes stops a hung gate with a process list and a clear error (#143)
CI green; CodeRabbit rate-limited with no findings; 0 review threads.
2026-11-05 11:27:56 +01:00
FredApps 0755fd19c7 Add changed-paths.yml: run a job only when its paths change or a label asks (#142)
* Add changed-paths.yml: run a job only when its paths change or a label asks

* changed-paths: read paths NUL-separated, keep the reason on one line; README: what the checkout holds
2026-11-05 11:12:34 +01:00
Dylan M. Taylor ea2cae4a03 Match the SonarCloud token fallback the scan actually uses (#139) 2026-11-04 17:59:19 -05:00
FredAppsandClaude Opus 5.5 e09a018c65 Build model titles only from each provider's known words
Anyone can commit under an agent email, so a free-form Git name such as
"Private Person <noreply@anthropic.com>" became a published model title,
which the apps would ship in their About windows. Each provider now lists
the words a model title may use. A name with any other word credits the
agent's default model and repeats none of it; versions are bounded too.

Across the co-author trailers in the 13 apps' history, 18,099 keep their
model row and 7 unusual names now fall back to the default. Also pin that
the PR lookup reads the merge commit rather than the PR head.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-04 13:49:44 +01:00
FredAppsandClaude Opus 5.5 c2e0e404ab Batch PR lookups gently and ignore bot PR openers
effectcraft's 4,000-commit history made 50-commit association queries time
out on GitHub, so batches are smaller and a failed batch is retried once.
GraphQL names bot openers without the [bot] suffix, which turned dependabot
into a person; only User accounts now count as PR openers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 19:38:06 +01:00
FredAppsandClaude Opus 5.5 fbfdcb1b5e Credit AI agents as models and verify merge-commit and carried PRs
GitHub links agent trailers such as noreply@anthropic.com to the claude and
codex accounts, so they appeared as the top human contributors. Agents are now
recognized by exact Git email or GitHub account, never by name, and credited
only in the snapshot's models (About > Models), including commits an agent
authored itself. Bots are no longer listed as people. Model and version are
read from the agent's Git name, covering every provider the apps' history
uses.

Commits merged with a merge commit or rebase never equal a PR's merge commit,
so self-added names lost verification and unlinked commits lost their author.
GitHub's commit-to-PR association now supplies the opener of the one merged PR
containing the commit. An integration PR opened by a writer that carries the
person's own linked commit also verifies their entry.

Against the shipped snapshots of effectcraft, pdfcraft, photocraft and
lightcraft at their recorded heads, no person loses a row, a name or a commit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 19:30:28 +01:00
Kristian Myram ed26e3cd27 Harden contributor consent identities and preference preflight 2026-11-03 12:53:38 +00:00
Kristian Myram 4b2457cec2 Merge main and resolve workflow test trigger conflicts 2026-11-03 12:30:26 +00:00
Dylan M. Taylor 1304973f86 Keep development builds off stable OCI tags 2026-11-03 00:01:47 -05:00
Dylan M. Taylor 67cc91cfd1 Test release signing branch and rollout gates 2026-11-03 00:01:15 -05:00
Dylan M. Taylor f76b6b82d2 Fix Linux signing rollout and review findings 2026-11-03 00:00:15 -05:00
Dylan M. Taylor c351cb5b3e Merge pull request #128 from dylanmtaylor/feat/flatpak-bundle-oci-repo-url
feat(flatpak): make bundle installs update from the ArtCraft OCI repository
2026-11-02 23:56:41 -05:00
Dylan M. Taylor 4da08b882e Merge pull request #98 from g1obalworlds/ci/run-tests-for-every-tested-file
ci: run the unit tests when any workflow or action they cover changes
2026-11-02 22:29:15 -05:00
Dylan M. Taylor 08d40594f5 Merge pull request #97 from g1obalworlds/fix/arch-prerelease-version
arch-package: keep a prerelease version instead of packaging it as 0.0.0
2026-11-02 22:29:08 -05:00
Dylan M. Taylor 2851baf0c0 Merge pull request #130 from storytold/fix/sec-arch-metainfo-read
fix(arch-package): read AppStream metainfo only as a bounded regular file inside staging
2026-11-02 22:29:02 -05:00
Dylan M. Taylor 4a817c772b fix(ast-grep): end option parsing before the scanned paths
The paths input is checked to stay inside the checkout, but its original
spelling was then passed to ast-grep where option parsing still applied, so
a checked file named like an option (--update-all, --follow) changed how the
scan ran. Pass "--" before the path list in both scan invocations.
2026-11-02 22:17:40 -05:00
Dylan M. Taylor 8f96383158 fix(arch-package): read AppStream metainfo only as a bounded regular file inside staging
The metainfo path comes from the release archive. A symlink to an endless
stream such as /dev/zero, or a FIFO, made sed read without bound. Refuse a
metainfo entry that is not a regular file resolving inside staging, read at
most 1 MiB of it once, and parse the summary and homepage from that prefix.
2026-11-02 22:16:45 -05:00
Dylan M. Taylor 96b8516a40 feat(release): sign every Linux package format with LINUX_SIGNING_KEY
A new optional LINUX_SIGNING_KEY secret (an unprotected OpenPGP signing subkey, from the
release environment) signs each Linux format the way its tools check it:

- rpm: embedded signature (rpmsign), for `rpm -K` and dnf/zypper gpgcheck
- deb: embedded _gpgorigin member (debsigs) and a detached .asc
- Arch: <file>.sig, which pacman looks for
- AppImage, tar.gz, zsync: detached .asc
- Flatpak bundle: signed commit and embedded public key (flatpak-bundle.sh, via the
  scaffold's new step 4), so `flatpak install` verifies it, plus a detached .asc
- Flatpak OCI image: a containers/image signature for ghcr.io/<repo>@<digest>, which Flatpak
  checks from its signature lookaside; the flatpak job records the pushed manifest for it
- SHA256SUMS.txt.asc over every release asset, and release-signing-key.asc

The draft-release action signs before computing checksums (embedded signatures change the rpm
and deb files) and verifies every signature against the exported public key. The new
import-signing-key action is shared by the flatpak and release jobs and refuses a key that
needs a passphrase. Without the secret, releases are published unsigned with a warning.
2026-11-02 20:55:58 -05:00
Dylan M. Taylor bdbd1e7f5e fix(flatpak): no OCI update source for prereleases; match --repo-url exactly
- A prerelease bundle (a version with `-`, as resolve-version marks it) gets no --repo-url: the
  OCI index serves only the latest stable release, so Flatpak would replace the prerelease
  with that older build. The generated script clears OCI_REPO for such a version and passes
  ${OCI_REPO:+--repo-url="$OCI_REPO"}.
- --verify passes only with the exact URL, the prerelease guard and the option on the active
  build-bundle command; a commented-out command never matches, nor is it edited.
- A script that already sets OCI_REPO or its own --repo-url fails the scaffold instead of being
  reported ready or overwritten.
- The OCI export assertion matches the whole line (CodeRabbit).
2026-11-02 19:46:48 -05:00
Dylan M. Taylor 7e8c2b6c7c feat(flatpak): make bundle installs update from the ArtCraft OCI repository
scaffold-flatpak-oci.sh now also adds --repo-url=oci+https://getartcraft.com to each app's
.flatpak build-bundle command, and --verify reports it. A bundle installed with that URL gets an
origin remote that updates from the OCI index, which points Flatpak at GHCR. Installing such a
bundle over an existing bundle install rewrites the existing origin's URL in place, so existing
users switch over on their next bundle update without a reinstall.
2026-11-02 19:24:22 -05:00
g1obalworlds 0a8bd343f6 Merge remote-tracking branch 'upstream/main' into ci/run-tests-for-every-tested-file
# Conflicts:
#	.github/workflows/test-freebsd.yml
2026-11-01 09:52:33 -08:00
g1obalworlds 8ea6648f3e Merge remote-tracking branch 'upstream/main' into fix/arch-prerelease-version
# Conflicts:
#	tests/test_arch.py
2026-11-01 09:51:55 -08:00
Kristian Myram 22db905cd2 fix(release): bind contributor preferences to the release commit 2026-11-01 14:16:19 +01:00
Kristian Myram 65bc9298e4 feat(release): provide the shared contributor snapshot generator 2026-11-01 13:59:31 +01:00
Dylan M. Taylor 75fbd9b7b5 Merge pull request #96 from g1obalworlds/fix/supply-chain-gh-repo
supply-chain: name the repository for the SBOM upload
2026-11-01 01:06:07 -04:00
Dylan M. Taylor 817ac1cb88 Merge pull request #99 from g1obalworlds/sonar-shard-exclude-tests
sonarcloud: leave test code out of sharded coverage, as cargo llvm-cov does
2026-11-01 01:03:24 -04:00
Dylan M. Taylor 09a83a41f5 Merge pull request #101 from ZIDAN44/fix/arch-xkbcommon-x11
fix(arch-package): depend on libxkbcommon-x11, without which the window can't open
2026-11-01 01:02:40 -04:00
Dylan M. Taylor 2ce6aa59c7 Merge pull request #110 from nanox333/codex/release-contributor-refresh
Release: refresh contributor credits automatically before builds
2026-11-01 01:00:55 -04:00
FredAppsandClaude Opus 5.5 c1f5c18c01 feat(gate): packages is optional; an empty list installs none
Calls with nothing to install from apt (a Windows-only check, a wasm build) had to pass a package
list the gate would ignore or install for nothing. packages now defaults to empty, and the apt step
runs only on Linux legs that name packages. The README describes such second gate calls, with
their own command and cache-version, instead of keeping web builds in the app's own workflow:
the apps' CI rules now allow only calls to shared workflows (#118).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 04:26:35 +01:00
e031880d47 fix(install-apt-packages): time-limit and retry mirror downloads (#117)
* fix(install-apt-packages): time-limit and retry mirror downloads

A SonarCloud job in vectorcraft (run 41253493430) sat in this step for 58 minutes: the Azure
Ubuntu mirror timed out, apt fell back to archive.ubuntu.com, then a connection went silent and
apt printed nothing until the run was cancelled. Acquire::http::Timeout doesn't end a connection
that stays open, so the job's 90-minute timeout was the only bound.

apt-get update and a new --download-only pass now each run under timeout(1), 300 s per attempt,
up to 3 attempts. The install itself then works from downloaded files only, so dpkg is never
killed mid-configure. Acquire::https::Timeout is set alongside the http one for the HTTPS fallback.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(install-apt-packages): retry an update that fetched only some indexes

apt-get update warns and exits 0 when an index fails to download, so the retry never ran for
it. APT::Update::Error-Mode=any makes that a failure, which is retried. If indexes are still
missing after the last attempt the step continues with a warning, as it did before: they often
belong to a repository the packages don't need, and a package that needs one fails the download.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 02:05:24 +01:00
84ad881711 ci(windows-arm64): only main saves the packaging cache (#116)
Pull requests that touch Windows packaging saved their own windows-arm64-package cache (about
0.7 GB), visible only to that pull request. Every app repository is at the 10 GB cache limit,
so each one evicted a cache main's gate restores. The nightly run on main still saves it.

Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 01:39:08 +01:00
Dylan M. Taylor 09f920c3f4 feat: add Flatpak OCI repository scaffolding script and tests (#115) 2026-10-31 15:43:24 -04:00
Kristian Myram 215a7f48c1 fix(release): exclude contributor snapshots from release assets 2026-10-30 18:00:34 +01:00
Kristian Myram 3cb27117d0 Release: support automatic contributor snapshot refresh 2026-10-30 14:36:32 +00:00
FredApps 2b3fb9dc05 ci: preserve dependency cache reuse across root manifest updates (#108)
* ci: preserve dependency cache reuse across root manifest updates

* docs: align gate cache overview with profile keys and dispatch opt-in
2026-10-30 07:47:08 -04:00
Dylan M. Taylor fa5ef18780 Build FreeBSD aarch64 release archives by default (#104)
* ci(release): build FreeBSD aarch64 archives by default

app packaging/freebsd/package.sh scripts now honor CARGO_BUILD_TARGET, so
aarch64 is no longer opt-in: freebsd-architectures defaults to
'["x86_64","aarch64"]'. Callers can still narrow it to x86_64 only.

* docs(readme): FreeBSD aarch64 is in the default freebsd-architectures
2026-10-28 15:49:07 -04:00
Zinadin ZidanandClaude Opus 5.5 230d71cc34 test(arch-package): a docstring for the libxkbcommon-x11 test
The test's explanation was a comment; it's the method's docstring now, as CodeRabbit's
docstring-coverage check asks. No change to what it checks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 03:53:01 +06:00
Zinadin ZidanandClaude Opus 5.5 d5a8872113 fix(arch-package): depend on libxkbcommon-x11, without which the window can't open
The apps build winit's X11 backend, and the Craft apps' winit (storytold/winit a517b38)
loads libxkbcommon-x11 when it sets up the keyboard on X11 or XWayland: without it the app
panics at start ("Library libxkbcommon-x11.so could not be loaded"). Arch ships it as its own
package, apart from libxkbcommon, and the package only depended on libxkbcommon, so on a
system without it (a fresh install, a minimal or Wayland-first desktop) every Craft app's
Arch package started and couldn't open its window. PhotoCraft hit the same panic on its deb
(photocraft#201) and fixed its own nfpm.yaml; the shared Arch package never got it.

libxkbcommon-x11 is now in depends. A test checks the generated PKGBUILD.

Checked on a clean archlinux container with a Craft app's release tarball, under Xvfb: the
package built by main installs without libxkbcommon-x11 and the window fails with that error;
the one built with this change pulls in libxkbcommon-x11 1.13.2 and the window runs. The
unit tests pass on Ubuntu 24.04 as in test-freebsd.yml (155, 28 skipped), and test_arch
passes on Arch with makepkg, end-to-end build included; shellcheck is clean.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 03:39:41 +06:00
Jeremy 8bb4e5ab95 fix(ci): separate ARM64 install paths and scope (#100)
* fix(ci): separate ARM64 install paths and installation scope

* test(ci): exercise ARM64 installer contract fixtures on Windows
2026-10-27 15:45:39 -04:00
g1obalworlds 539b28997c ci: honor negated path patterns in the trigger test
GitHub applies path filters in order, so a later !pattern excludes a file an
earlier pattern matched. The test now does the same, instead of passing a file
any one pattern matches.
2026-10-26 17:47:48 -07:00
g1obalworlds ff3c35789a arch-package: keep a prerelease version instead of packaging it as 0.0.0
The tarball-name pattern allowed no hyphen in the version, so a prerelease
(photocraft-0.2.0-rc.1-linux-x86_64.tar.gz) did not match and fell back to
version 0.0.0: the draft release got photocraft-0.0.0-linux-x86_64.pkg.tar.zst
with pkgver=0.0.0. Accept the prerelease and drop its hyphens from pkgver
(0.2.0rc.1, which pacman sorts before 0.2.0). A numeric prerelease gets a
letter in front (1.2.3-1 is 1.2.3pre1), since 1.2.31 would sort after 1.2.4.
This also drops the pkgrel-from-suffix branch, which the old pattern made
unreachable and which would have turned 0.2.0-rc.1 into pkgver 0.2.0.
2026-10-26 17:25:46 -07:00
g1obalworlds 160d46a16b ci: run the unit tests when any workflow or action they cover changes
test-freebsd.yml is the only workflow that runs tests/, but its path filter
still lists the FreeBSD-era files. A change to sonarcloud.yml,
supply-chain.yml, nix.yml, ast-grep.yml, or to actions such as arch-package,
resolve-version, ast-grep or checkout-craft-fonts ran none of their tests:
#86 (sonarcloud.yml and the README) and #90 (sonarcloud.yml) merged without
test_sonarcloud.py running. Match every workflow, action and test file, and
test that the filter does, with GitHub's glob rules.
2026-10-26 17:22:20 -07:00
g1obalworlds 0e8822f295 sonarcloud: leave test code out of sharded coverage, as cargo llvm-cov does
cargo llvm-cov adds its own exclusions to --ignore-filename-regex: tests/,
examples/ and benches/ directories and tests.rs / *_tests.rs files. The
sharded merge (the default since #87) calls llvm-cov export directly with
only (vendor|xtask)/, so integration tests and src/**/tests.rs reached
lcov.info as almost fully covered source, and coverage moved when a caller
switched between shards: 1 and the default. Put those exclusions in the
shared regex; the unsharded run already applies them.
2026-10-26 17:16:25 -07:00
g1obalworlds 03a637cbc0 supply-chain: name the repository for the SBOM upload
The attest job has no checkout, so `gh release upload` had no git remote to
find the repository from and failed with "not a git repository" after the
attestations were already published. Pass GH_REPO, as draft-release does.
2026-10-26 17:00:22 -07:00
skylar b97d27ffa3 test: cover nextest installer aliases
Reject affected alias installers and duplicate selectors in the pin inventory.
2026-10-26 16:20:05 -06:00
skylar d07589f3fe ci: pin nextest to 0.9.150
Use the fixed release for GHSA-vc25-qg58-w57c.
2026-10-26 14:13:00 -06:00