Files
craft-common-actions/tests
nnaannooandClaude Sonnet 5.5 7ae2c64a8a Add import-macos-certificate: the shared macOS signing certificate import (#140)
* Add shared macOS certificate import and Windows signing script actions

Every app carries its own packaging/macos/import-cert.sh and packaging/windows/sign.ps1, and the
copies have drifted: four apps lack the Trusted Signing client SHA-256 pin and eight still write the
signing certificate to a predictable temporary path.

- import-macos-certificate: the hardened import (private mktemp -d directory, keychain removed on
  failure), self-contained, with identity/keychain outputs.
- setup-windows-signing: exports the shared sign.ps1, parameterized by product name and URL, for
  package.ps1 to call; rejects line breaks that could inject environment variables.
- Tests run both scripts against stand-ins for security, openssl and signtool.

Existing callers are unchanged; apps adopt the actions one at a time.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Signing scripts: read file names literally, refuse an unset product name clearly

sign.ps1 resolved its file arguments with Resolve-Path, which treats [ and ] as wildcards, so a
file such as 'App [x64].msi' failed. setup-windows-signing called .Trim() on an unset product
name, a null-valued method call, instead of its own message. Tests for both.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013fTnVxnXTv2MBW6uj2PPyU

* Split the signing PR: keep only the macOS certificate import here

The Windows signing action moves to its own branch and PR. The tests, README text and bullet for
each action now live with that action, with separate README headings so the two PRs merge
independently.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013fTnVxnXTv2MBW6uj2PPyU

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 09:08:39 -05:00
..