0 Fork 0

mirror of https://github.com/storytold/artcraft.git synced 2026-11-02 08:28:18 +00:00

T

Tanish Manku 4d4bfce3aa pagescene AssetMenu: fix featured Sets/Creatures never loading (#1508 )

## Summary

- Regression from PR #1492. After the refactor, `useFeaturedObjects`
auto-fetch effect was racing the `EngineContext` editor instance: on
AssetModal's first mount `editor` is `null`, the effect synchronously
flipped `firstFetch.current` to `IN_PROGRESS` and then called
`fetchFeaturedObjects()` which immediately bailed at `if (!editor)
return`. When the editor became available the effect re-fired (editor is
in the `useCallback` deps), but the `IN_PROGRESS` guard then blocked it
— so **the network request never fired** for any featured category.
- Visible only on Sets and Creatures tabs because
Characters/Objects/Memes are merged with local demo arrays in
`assetTabs` and looked populated despite the same fetch breakage.
- Fix: gate the auto-fetch effect on `editor` (early-return when null,
add `editor` to deps) so `IN_PROGRESS` isn't burned on the no-op call.

## Test plan

- [ ] Open `/edit-3d` in artcraft-webapp with DevTools Network panel +
"Disable cache" on.
- [ ] Open the AssetModal — confirm exactly 5 GETs to
`/v1/media_files/list_featured` (one each for `character`, `object`,
`location`, `creature`, `image_plane`).
- [ ] Switch to Sets and Creatures tabs — items render.
- [ ] Drag a Set into the 3D scene — loads via `addObject` (LOCATION
maps to `AssetType.OBJECT` in `responseMapping`).
- [ ] Tauri smoke: open the 3D page in the desktop app, AssetModal
Sets/Creatures tabs populate.
- [ ] `nx typecheck @storyteller/ui-pagescene` (no new errors).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

2026-05-12 18:30:47 -07:00

_database

include prompts with fal, fix alerts (#1507 )

2026-05-12 19:47:43 -04:00

_docs

codegen db

2026-02-13 09:25:08 +07:00

_tools/postman

beeble webhook (#1489 )

2026-05-08 20:06:09 -04:00

.claude/rules

import cleanup

2026-04-21 18:43:20 -04:00

.config

…

.github

update builds to trigger only on relevant changes (#1170 )

2026-03-18 22:07:20 -04:00

.idea

artcraft router: seedance (#1153 )

2026-03-16 22:43:50 -04:00

.sqlx

include prompts with fal, fix alerts (#1507 )

2026-05-12 19:47:43 -04:00

.vscode

cleanup root directory (#996 )

2026-01-19 23:08:39 -05:00

build

update builds to trigger only on relevant changes (#1170 )

2026-03-18 22:07:20 -04:00

crates

include prompts with fal, fix alerts (#1507 )

2026-05-12 19:47:43 -04:00

frontend

pagescene AssetMenu: fix featured Sets/Creatures never loading (#1508 )

2026-05-12 18:30:47 -07:00

includes

increase username randomness to stop pages (#1261 )

2026-03-31 00:31:22 -04:00

script

chrome launch script (#1371 )

2026-04-15 01:44:39 -04:00

test_data

…

.dockerignore

…

.env

cleanup root directory (#996 )

2026-01-19 23:08:39 -05:00

.gitattributes

…

.gitignore

2026-03-24 14:38:09 -04:00

Cargo.lock

tauri providers - fal api key support (#1502 )

2026-05-12 00:02:41 -04:00

Cargo.toml

beeble client (#1487 )

2026-05-08 12:49:15 -04:00

CLAUDE.md

import cleanup

2026-04-21 18:43:20 -04:00

Cranky.toml

…

diesel.toml

cleanup root directory (#996 )

2026-01-19 23:08:39 -05:00

LICENSE.md

update wording

2026-01-06 12:27:34 -05:00

README.md

REAMDE update

2026-03-08 11:21:03 -04:00

ROADMAP.md

formatting, small revisions

2026-01-06 12:22:46 -05:00

rustfmt.toml

…

README.md

The IDE for artists.

ArtCraft

ArtCraft is the IDE for interactive AI image and video creation. We turn prompting into crafting, so your ideas become a form of tangible expression and computing. This is Adobe Photoshop for everyone, and we're giving away the source code!

Show, Don't Tell: Advanced Crafting Features

Text-to-image is great, but artists need control. It's important to know what your image will look like before you generate it, and it's vitally important to achieve consistency and repeatability.

Feature	Demo + Explanation
Image to Location	Placing virtual actors into physical environments establishes single-location consistency. You can film multiple shots within a room without having things disappear.
3D Image Compositing	Use images (backdrops, foreground elements, props, etc.) in scenes with depth and blend them naturally together. Just a couple of images usually leads to great compositions.
2D Image Compositing	Use images, background removal, layers, and simple drawing tools to precisely compose a scene.
Image to 3D Mesh	It's almost impossible to lay out complicated objects or block complicated scenes; turning images into 3D helps position elements exactingly and intentionally.
Character Posing	You can dynamically pose your characters to achieve the precise character, scene, and camera blocking before calling "action".
Scene Blocking w/ Kit Bashing	Use 3D asset kits to precisely block out your scene: get the correct angles, object positions, and rich depth layering you can't with text prompting.
Character Identity Transfer	Use mannequins as simple 3D ControlNets for posing any character.
Background Removal	Remove backgrounds from images to make them useful in 2D or 3D compositing. They can be props, layers, or backdrops.
Mixed Asset Crafting	You can use image cutouts, worlds, and simple 3D meshes all together to precisely and intentionally lay out your scenes.
Scene Blocking	(preview coming soon)
Canvas Editing	(preview coming soon)
Scene Relighting	(preview coming soon)

Note: all of the above videos were generated for free with Grok Video; the cost to build this README was negligible.

Quick and Easy Prompting

We haven't abandoned text-to-asset generation for quick prototyping and ideation. We support every popular workflow in a first class fashion.

Feature	Demo + Explanation
Text to Image	Text prompt over a dozen different image models.
Image Editing	Edit with Nano Banana Pro and GPT Image 1.5.
Image Editing	Use inpainting, drawing, masking, etc. to edit images.
Image to Video	Image to video with lots of different options and controls.
Image Inpainting	(preview coming soon)
Image Ingredients	(preview coming soon)

Models and Providers Supported within Artcraft

Provider	Features
Artcraft	Nano Banana, Nano Banana Pro, GPT-Image-1 / 1.5, Seedance 1.0 Lite / 1.5 Pro / 2.0, Seedream 4 / 4.5, Flux 1.1 / Kontext, Veo 2 / 3 / 3.1, Kling 1.6 / 2.1 / 2.5 / 2.6, Sora 2 / Pro, Hunyuan 3d 2 / 3
Grok	Grok Imagine, Grok Video
Midjourney	Image Gen (all versions)
Sora	Sora 1, Sora 2, GPT-Image-1
WorldLabs	Marble (Gaussian Splat World Generation)

We're going to be adding the following providers soon: Kling (via Kling website accounts), Google (via API keys), Runway (via website account), Luma (via website account).

We're potentially interested in adding other aggregators for those who already have subscriptions and credits at those providers, for example: OpenArt, FreePik, etc.

Downloads

Visit our website for the stable Windows and MacOS releases
Or you can grab a more recent Windows and MacOS build directly
Linux requires building from source for now

README.md

ArtCraft

Show, Don't Tell: Advanced Crafting Features

Quick and Easy Prompting

Models and Providers Supported within Artcraft

Downloads

Documentation