mirror of
https://github.com/storytold/artcraft.git
synced 2026-11-06 18:21:12 +00:00
Miles Ryan
1d0fd7c429
Fixed timeline update with generating of preview as well as fixed memory leak. Call ffmpeg.exit() to fix memory leak with generation. if the editor is in preview mode it gens frames. Tests: tested multi spam click on previews. tested editor timeline. tested normal click on preview. No crashes and task manager does not show memory leak.
Short Style Guide TS React and Engine:
No use of lets
No basic for loop operators.
Use the collection operators and array operators.
React Side / No modules over 200 lines. ( loose rule )
Don't do:
if (condition) return;
Do:
if (condition) {
return;
}
No use of any type.
If you can use chat gpt to create the interface.
IF YOU ARE WORKING ON THIS PROJECT PLEASE ASK THE TEAM MEMBERS HOW TO SET UP THIS IS OUTDATED INFORMATION
GottaGoFast-SS
Fast Prototyping with Better Netlify Pipeline:
Setup
npm install
npm run dev