handle sora logged out state after app starts

crates/desktop/artcraft/src/commands/sora/sora_image_remix_command.rs

@@ -15,7 +15,7 @@ use base64::Engine;
 use errors::{AnyhowError, AnyhowResult};
 use image::codecs::png::{CompressionType, FilterType, PngEncoder};
 use image::{DynamicImage, ImageReader};
-use log::{debug, error, info};
+use log::{debug, error, info, warn};
 use openai_sora_client::credentials::SoraCredentials;
 use openai_sora_client::creds::credential_migration::CredentialMigrationRef;
 use openai_sora_client::recipes::image_remix_with_session_auto_renew::{image_remix_with_session_auto_renew, ImageRemixAutoRenewRequest};
@@ -29,6 +29,7 @@ use openai_sora_client::sora_error::SoraError;
 use serde_derive::{Deserialize, Serialize};
 use std::fs::read_to_string;
 use std::io::Cursor;
+use std::ops::Add;
 use std::time::Duration;
 use storyteller_client::api_error::ApiError;
 use storyteller_client::api_error::ApiError::InternalServerError;
@@ -64,7 +65,9 @@ pub enum SoraImageRemixErrorType {
   /// Generic server error
   ServerError,
   /// The user is sending too many requests
-  TooManyConcurrentTasks,
+  TooManyConcurrentTasks, 
+  /// User is not logged into Sora!
+  SoraLoginRequired,
   /// The user needs to create a Sora account
   SoraUsernameNotYetCreated,
   /// The Sora service is having problems. Try again soon.
@@ -86,6 +89,20 @@ pub async fn sora_image_remix_command(
 
   // TODO(bt,2025-04-24): Better error messages to caller
 
+  let has_credentials = sora_creds_manager
+      .has_apparently_complete_credentials()
+      .unwrap_or(true);
+  
+  if !has_credentials {
+    warn!("No apparently completed credentials found");
+    return Err(CommandErrorResponseWrapper {
+      status: CommandErrorStatus::Unauthorized,
+      error_message: Some("You need to log into Sora to continue. See the settings menu.".to_string()),
+      error_type: Some(SoraImageRemixErrorType::SoraLoginRequired),
+      error_details: None,
+    });
+  }
+
   let result = generate_image(request, &app_data_root, &sora_creds_manager, &sora_task_queue).await;
   
   match result {

crates/desktop/artcraft/src/state/sora/sora_credential_holder.rs

@@ -54,4 +54,20 @@ impl SoraCredentialHolder {
       }
     }
   }
+
+  /// This does not guarantee the credentials are correct, just that they're set.
+  pub fn has_apparently_complete_credentials(&self) -> AnyhowResult<bool> {
+    match self.credentials.read() {
+      Err(err) => Err(anyhow!("Failed to acquire read lock: {:?}", err)),
+      Ok(creds) => match &*creds {
+        None => Ok(false),
+        Some(creds) => {
+          let has_cookies = !creds.cookies.as_str().is_empty();
+          let has_bearer = creds.jwt_bearer_token.is_some();
+          let has_sentinel = creds.sora_sentinel.is_some();
+          Ok(has_cookies && has_bearer && has_sentinel)
+        },
+      }
+    }
+  }
 }

crates/desktop/artcraft/src/state/sora/sora_credential_manager.rs

@@ -63,6 +63,11 @@ impl SoraCredentialManager {
     self.stats.set_owned(SoraCredentialStats::new())
   }
   
+  /// This does not guarantee the credentials are correct
+  pub fn has_apparently_complete_credentials(&self) -> AnyhowResult<bool> {
+    self.holder.has_apparently_complete_credentials()
+  }
+  
   pub fn get_credential_stats(&self) -> AnyhowResult<SoraCredentialStats> {
     self.stats.get_clone()
   }

crates/desktop/tauri-artcraft/gen/schemas/acl-manifests.json

@@ -1 +0,0 @@
-{"core":{"default_permission":{"identifier":"default","description":"Default core plugins set.","permissions":["core:path:default","core:event:default","core:window:default","core:webview:default","core:app:default","core:image:default","core:resources:default","core:menu:default","core:tray:default"]},"permissions":{},"permission_sets":{},"global_scope_schema":null},"core:app":{"default_permission":{"identifier":"default","description":"Default permissions for the plugin.","permissions":["allow-version","allow-name","allow-tauri-version","allow-identifier"]},"permissions":{"allow-app-hide":{"identifier":"allow-app-hide","description":"Enables the app_hide command without any pre-configured scope.","commands":{"allow":["app_hide"],"deny":[]}},"allow-app-show":{"identifier":"allow-app-show","description":"Enables the app_show command without any pre-configured scope.","commands":{"allow":["app_show"],"deny":[]}},"allow-default-window-icon":{"identifier":"allow-default-window-icon","description":"Enables the default_window_icon command without any pre-configured scope.","commands":{"allow":["default_window_icon"],"deny":[]}},"allow-fetch-data-store-identifiers":{"identifier":"allow-fetch-data-store-identifiers","description":"Enables the fetch_data_store_identifiers command without any pre-configured scope.","commands":{"allow":["fetch_data_store_identifiers"],"deny":[]}},"allow-identifier":{"identifier":"allow-identifier","description":"Enables the identifier command without any pre-configured scope.","commands":{"allow":["identifier"],"deny":[]}},"allow-name":{"identifier":"allow-name","description":"Enables the name command without any pre-configured scope.","commands":{"allow":["name"],"deny":[]}},"allow-remove-data-store":{"identifier":"allow-remove-data-store","description":"Enables the remove_data_store command without any pre-configured scope.","commands":{"allow":["remove_data_store"],"deny":[]}},"allow-set-app-theme":{"identifier":"allow-set-app-theme","description":"Enables the set_app_theme command without any pre-configured scope.","commands":{"allow":["set_app_theme"],"deny":[]}},"allow-tauri-version":{"identifier":"allow-tauri-version","description":"Enables the tauri_version command without any pre-configured scope.","commands":{"allow":["tauri_version"],"deny":[]}},"allow-version":{"identifier":"allow-version","description":"Enables the version command without any pre-configured scope.","commands":{"allow":["version"],"deny":[]}},"deny-app-hide":{"identifier":"deny-app-hide","description":"Denies the app_hide command without any pre-configured scope.","commands":{"allow":[],"deny":["app_hide"]}},"deny-app-show":{"identifier":"deny-app-show","description":"Denies the app_show command without any pre-configured scope.","commands":{"allow":[],"deny":["app_show"]}},"deny-default-window-icon":{"identifier":"deny-default-window-icon","description":"Denies the default_window_icon command without any pre-configured scope.","commands":{"allow":[],"deny":["default_window_icon"]}},"deny-fetch-data-store-identifiers":{"identifier":"deny-fetch-data-store-identifiers","description":"Denies the fetch_data_store_identifiers command without any pre-configured scope.","commands":{"allow":[],"deny":["fetch_data_store_identifiers"]}},"deny-identifier":{"identifier":"deny-identifier","description":"Denies the identifier command without any pre-configured scope.","commands":{"allow":[],"deny":["identifier"]}},"deny-name":{"identifier":"deny-name","description":"Denies the name command without any pre-configured scope.","commands":{"allow":[],"deny":["name"]}},"deny-remove-data-store":{"identifier":"deny-remove-data-store","description":"Denies the remove_data_store command without any pre-configured scope.","commands":{"allow":[],"deny":["remove_data_store"]}},"deny-set-app-theme":{"identifier":"deny-set-app-theme","description":"Denies the set_app_theme command without any pre-configured scope.","commands":{"allow":[],"deny":["set_app_theme"]}},"deny-tauri-version":{"identifier":"deny-tauri-version","description":"Denies the tauri_version command without any pre-configured scope.","commands":{"allow":[],"deny":["tauri_version"]}},"deny-version":{"identifier":"deny-version","description":"Denies the version command without any pre-configured scope.","commands":{"allow":[],"deny":["version"]}}},"permission_sets":{},"global_scope_schema":null},"core:event":{"default_permission":{"identifier":"default","description":"Default permissions for the plugin, which enables all commands.","permissions":["allow-listen","allow-unlisten","allow-emit","allow-emit-to"]},"permissions":{"allow-emit":{"identifier":"allow-emit","description":"Enables the emit command without any pre-configured scope.","commands":{"allow":["emit"],"deny":[]}},"allow-emit-to":{"identifier":"allow-emit-to","description":"Enables the emit_to command without any pre-configured scope.","commands":{"allow":["emit_to"],"deny":[]}},"allow-listen":{"identifieLine truncated

crates/desktop/tauri-artcraft/gen/schemas/capabilities.json

@@ -1 +0,0 @@
-{"default":{"identifier":"default","description":"enables the default permissions","local":true,"windows":["main"],"permissions":["core:default","log:default","upload:allow-download","upload:default",{"identifier":"http:default","allow":[{"url":"https://*.storyteller.ai"},{"url":"https://*.fakeyou.com"}],"deny":[{"url":"https://private.tauri.app"}]}]}}

frontend/libs/components/promptbox/src/lib/PromptBox3D.tsx

@@ -446,6 +446,9 @@ export const PromptBox3D = ({
 
           if ("error_type" in generateResponse) {
             switch (generateResponse.error_type) {
+              case SoraImageRemixErrorType.SoraLoginRequired:
+                errorMessage = "You need to log into Sora to continue. See the settings menu.";
+                break;
               case SoraImageRemixErrorType.ServerError:
                 errorMessage = "Server error. Failed to enqueue image.";
                 break;

frontend/libs/tauri-api/src/lib/sora/SoraImageRemix.ts

@@ -26,8 +26,9 @@ export interface SoraImageRemixSuccess extends CommandResult {
 export enum SoraImageRemixErrorType {
   ServerError = "server_error",
   TooManyConcurrentTasks = "too_many_concurrent_tasks",
-  SoraUsernameNotYetCreated = "sora_username_not_yet_created",
   SoraIsHavingProblems = "sora_is_having_problems",
+  SoraLoginRequired = "sora_login_required",
+  SoraUsernameNotYetCreated = "sora_username_not_yet_created",
 }
 
 export interface SoraImageRemixError extends CommandResult {