artcraft: delete apps PageScene/engine shim folder

The engine/* shims (26 one-line re-export files) had no remaining
internal callers — every apps/PageScene/* file that previously
reached into engine/X has been migrated to either a sibling shim
(actions/, hooks/, contexts/, etc., which forward to the lib) or
directly to the @storyteller/ui-pagescene package.

PageEditor.tsx had the only two lingering engine-shim imports;
both fold into a single import line from the package:

  import {
    GridVisibleChangedEvent,
    pickDropPosition,
  } from \"@storyteller/ui-pagescene\";

The whole apps/PageScene/engine/ tree (editor.ts, scene.ts,
save_manager.ts, helper.ts, scene_manager_api.ts, keybinds_controls.ts,
keymap.ts, EngineStoreBridge.ts, events/{EngineEvent,EngineEventBus},
editor/{HistoryManager, ViewportController, PostProcessingPipeline,
GizmoController, CameraController, SelectionBridge}.ts,
editor/actions/{Color,Create,Delete,Lock,Transform,Visibility}Action.ts,
editor/actions/snapshots.ts, cameraMath.ts, pickDropPosition.ts,
pointer.ts) is now gone — 26 files deleted.

Verified: artcraft typecheck still at 62 errors.
This commit is contained in:
Tanish Manku committed 2026-05-08 16:13:20 -07:00
1 parent 41cc84d99c
commit 60e944d22b
28 files changed
+2 -199

No files matched your search

@@ -11,7 +11,7 @@ import { TabbedPages } from "./TabbedPages";
import { DomLevels } from "~/pages/PageScene/PageSceneStore";
import { setCameraAspect } from "~/pages/PageScene/actions";
import { GridVisibleChangedEvent } from "~/pages/PageScene/engine/events/EngineEvent";
import { GridVisibleChangedEvent, pickDropPosition } from "@storyteller/ui-pagescene";
import { EditorCanvas } from "./comps/EngineCanvases";
import { SceneContainer } from "./comps/SceneContainer";
import { useEditorCanvas } from "./hooks/useEditorCanvas";
@@ -36,7 +36,6 @@ import { AssetType, AUTH_STATUS } from "~/enums";
import { v4 as uuidv4 } from "uuid";
import { MediaItem } from "~/pages/PageScene/models";
import { UploaderState } from "~/models";
import { pickDropPosition } from "./engine/pickDropPosition";
import {
GalleryItem,
onImageDrop,
@@ -1,8 +0,0 @@
// Re-export shim. Single source of truth lives in
// @storyteller/ui-pagescene.
export {
EngineStoreBridge,
} from "@storyteller/ui-pagescene";
export type {
EngineStoreBridgeDeps,
} from "@storyteller/ui-pagescene";
@@ -1,19 +0,0 @@
export {
freeCamFrameTick,
lookAtFromCamera,
createFreeCamControlState,
emptyMoveKeys,
emptyRotateKeys,
moveSlotForKeyCode,
rotateSlotForKeyCode,
panFromDrag,
zoomFromWheel,
moveVectorFromKeys,
rotationVectorFromKeys,
lerpVelocity,
} from "@storyteller/ui-pagescene";
export type {
FreeCamControlState,
HeldMoveKeys,
HeldRotateKeys,
} from "@storyteller/ui-pagescene";
@@ -1,6 +0,0 @@
// Re-export shim. The Editor class lives in @storyteller/ui-pagescene.
// External callers that imported the default Editor export from this
// path keep working unchanged; the construction site (EngineProvider)
// supplies the PageSceneAdapter the lib's Editor now requires.
export { Editor as default } from "@storyteller/ui-pagescene";
export type { EditorInitializeConfig } from "@storyteller/ui-pagescene";
@@ -1,5 +0,0 @@
export { CameraController } from "@storyteller/ui-pagescene";
export type {
CameraControllerDeps,
RenderDimensions,
} from "@storyteller/ui-pagescene";
@@ -1,5 +0,0 @@
export { GizmoController } from "@storyteller/ui-pagescene";
export type {
GizmoControllerDeps,
GizmoCallbacks,
} from "@storyteller/ui-pagescene";
@@ -1,2 +0,0 @@
export { HistoryManager } from "@storyteller/ui-pagescene";
export type { UndoableAction, HistoryManagerOptions } from "@storyteller/ui-pagescene";
@@ -1 +0,0 @@
export { PostProcessingPipeline } from "@storyteller/ui-pagescene";
@@ -1,2 +0,0 @@
export { SelectionBridge } from "@storyteller/ui-pagescene";
export type { SelectionBridgeDeps } from "@storyteller/ui-pagescene";
@@ -1,2 +0,0 @@
export { ViewportController } from "@storyteller/ui-pagescene";
export type { ViewportEngineRefs } from "@storyteller/ui-pagescene";
@@ -1 +0,0 @@
export { ColorAction } from "@storyteller/ui-pagescene";
@@ -1 +0,0 @@
export { CreateAction } from "@storyteller/ui-pagescene";
@@ -1 +0,0 @@
export { DeleteAction } from "@storyteller/ui-pagescene";
@@ -1 +0,0 @@
export { LockAction } from "@storyteller/ui-pagescene";
@@ -1 +0,0 @@
export { TransformAction } from "@storyteller/ui-pagescene";
@@ -1 +0,0 @@
export { VisibilityAction } from "@storyteller/ui-pagescene";
@@ -1,108 +0,0 @@
import * as THREE from "three";
import type Editor from "../../editor";
// Shared snapshot types + helpers used by every UndoableAction that
// captures a piece of scene state. Lives outside HistoryManager so
// new action classes can import without pulling the manager itself.
export interface TransformSnap {
position: { x: number; y: number; z: number };
rotation: { x: number; y: number; z: number };
scale: { x: number; y: number; z: number };
}
// Enough state to fully reconstruct any object: primitive shape,
// image plane, GLB, MMD, splat. Captured at create-time and at
// delete-time so undo of either operation works the same way.
export interface ObjectSnap {
uuid: string;
name: string;
media_id: string;
transform: TransformSnap;
userData: Record<string, unknown>;
}
export const snapshotTransform = (obj: THREE.Object3D): TransformSnap => ({
position: { x: obj.position.x, y: obj.position.y, z: obj.position.z },
rotation: { x: obj.rotation.x, y: obj.rotation.y, z: obj.rotation.z },
scale: { x: obj.scale.x, y: obj.scale.y, z: obj.scale.z },
});
export const snapshotObject = (obj: THREE.Object3D): ObjectSnap => ({
uuid: obj.uuid,
name: obj.name,
media_id: (obj.userData.media_id as string) ?? "Parim",
transform: snapshotTransform(obj),
userData: { ...obj.userData },
});
export const transformsEqual = (a: TransformSnap, b: TransformSnap): boolean =>
a.position.x === b.position.x &&
a.position.y === b.position.y &&
a.position.z === b.position.z &&
a.rotation.x === b.rotation.x &&
a.rotation.y === b.rotation.y &&
a.rotation.z === b.rotation.z &&
a.scale.x === b.scale.x &&
a.scale.y === b.scale.y &&
a.scale.z === b.scale.z;
export const writeTransform = (
editor: Editor,
uuid: string,
t: TransformSnap,
): void => {
const obj = editor.activeScene.scene.getObjectByProperty("uuid", uuid);
if (!obj) return;
obj.position.set(t.position.x, t.position.y, t.position.z);
obj.rotation.set(t.rotation.x, t.rotation.y, t.rotation.z);
obj.scale.set(t.scale.x, t.scale.y, t.scale.z);
};
// Re-create an object from a snapshot. Used by Create/Delete actions
// to undo deletions and redo creations. Preserves the original uuid
// so subsequent history entries that reference it still resolve.
export const recreateFromSnapshot = async (
editor: Editor,
snap: ObjectSnap,
): Promise<THREE.Object3D | undefined> => {
const pos = new THREE.Vector3(
snap.transform.position.x,
snap.transform.position.y,
snap.transform.position.z,
);
// Shapes route through scene.instantiate's geometry switch, which
// matches on the geometry key ("Box", "Sphere", "PointLight"), not
// the display name ("Cube", "Point Light"). addShape stashes the
// original key in userData.shapeKey so we can recover it here.
const nameForCreate =
(snap.userData.shapeKey as string | undefined) ?? snap.name;
const obj = await editor.sceneManager?.create(
snap.media_id,
nameForCreate,
pos,
);
if (!obj) return undefined;
obj.uuid = snap.uuid;
// Restore the display name (instantiate/loadObject set obj.name to
// nameForCreate; for shapes that's the geometry key, not the label).
obj.name = snap.name;
obj.rotation.set(
snap.transform.rotation.x,
snap.transform.rotation.y,
snap.transform.rotation.z,
);
obj.scale.set(
snap.transform.scale.x,
snap.transform.scale.y,
snap.transform.scale.z,
);
obj.userData = { ...snap.userData };
if (typeof snap.userData.color === "string") {
editor.activeScene.setColor(obj.uuid, snap.userData.color);
}
if (typeof snap.userData.visible === "boolean") {
obj.visible = snap.userData.visible;
}
return obj;
};
@@ -1,4 +0,0 @@
// Re-export shim. Single source of truth lives in
// @storyteller/ui-pagescene; class identity is single-sourced so
// emit/subscribe lookups share the same constructor key.
export * from "@storyteller/ui-pagescene";
@@ -1,9 +0,0 @@
// Re-export shim. Single source of truth lives in
// @storyteller/ui-pagescene.
export {
EngineEventBus,
} from "@storyteller/ui-pagescene";
export type {
EngineEventCtor,
EngineEventListener,
} from "@storyteller/ui-pagescene";
@@ -1,2 +0,0 @@
export { SceneUtils } from "@storyteller/ui-pagescene";
export type { SceneUtilsDeps } from "@storyteller/ui-pagescene";
@@ -1,2 +0,0 @@
export { MouseControls } from "@storyteller/ui-pagescene";
export type { MouseControlsDeps } from "@storyteller/ui-pagescene";
@@ -1,5 +0,0 @@
export {
buildKeymap,
dispatchBinding,
} from "@storyteller/ui-pagescene";
export type { KeyBinding, KeyGroup } from "@storyteller/ui-pagescene";
@@ -1 +0,0 @@
export { pickDropPosition } from "@storyteller/ui-pagescene";
@@ -1,4 +0,0 @@
export {
ndcFromClient,
applyNdcToVector2,
} from "@storyteller/ui-pagescene";
@@ -1,2 +0,0 @@
export { SaveManager } from "@storyteller/ui-pagescene";
export type { SaveManagerDeps, SaveSceneStateArgs } from "@storyteller/ui-pagescene";
@@ -1,2 +0,0 @@
export { Scene as default } from "@storyteller/ui-pagescene";
export type { SceneDeps } from "@storyteller/ui-pagescene";
@@ -1 +0,0 @@
export { SceneManager } from "@storyteller/ui-pagescene";
+1 -1
View File
@@ -1 +1 @@
{"fileNames":["../../node_modules/typescript/lib/lib.es5.d.ts","../../node_modules/typescript/lib/lib.es2015.d.ts","../../node_modules/typescript/lib/lib.es2016.d.ts","../../node_modules/typescript/lib/lib.es2017.d.ts","../../node_modules/typescript/lib/lib.es2018.d.ts","../../node_modules/typescript/lib/lib.es2019.d.ts","../../node_modules/typescript/lib/lib.es2020.d.ts","../../node_modules/typescript/lib/lib.es2021.d.ts","../../node_modules/typescript/lib/lib.es2022.d.ts","../../node_modules/typescript/lib/lib.es2023.d.ts","../../node_modules/typescript/lib/lib.es2024.d.ts","../../node_modules/typescript/lib/lib.esnext.d.ts","../../node_modules/typescript/lib/lib.dom.d.ts","../../node_modules/typescript/lib/lib.dom.iterable.d.ts","../../node_modules/typescript/lib/lib.es2015.core.d.ts","../../node_modules/typescript/lib/lib.es2015.collection.d.ts","../../node_modules/typescript/lib/lib.es2015.generator.d.ts","../../node_modules/typescript/lib/lib.es2015.iterable.d.ts","../../node_modules/typescript/lib/lib.es2015.promise.d.ts","../../node_modules/typescript/lib/lib.es2015.proxy.d.ts","../../node_modules/typescript/lib/lib.es2015.reflect.d.ts","../../node_modules/typescript/lib/lib.es2015.symbol.d.ts","../../node_modules/typescript/lib/lib.es2015.symbol.wellknown.d.ts","../../node_modules/typescript/lib/lib.es2016.array.include.d.ts","../../node_modules/typescript/lib/lib.es2016.intl.d.ts","../../node_modules/typescript/lib/lib.es2017.arraybuffer.d.ts","../../node_modules/typescript/lib/lib.es2017.date.d.ts","../../node_modules/typescript/lib/lib.es2017.object.d.ts","../../node_modules/typescript/lib/lib.es2017.sharedmemory.d.ts","../../node_modules/typescript/lib/lib.es2017.string.d.ts","../../node_modules/typescript/lib/lib.es2017.intl.d.ts","../../node_modules/typescript/lib/lib.es2017.typedarrays.d.ts","../../node_modules/typescript/lib/lib.es2018.asyncgenerator.d.ts","../../node_modules/typescript/lib/lib.es2018.asynciterable.d.ts","../../node_modules/typescript/lib/lib.es2018.intl.d.ts","../../node_modules/typescript/lib/lib.es2018.promise.d.ts","../../node_modules/typescript/lib/lib.es2018.regexp.d.ts","../../node_modules/typescript/lib/lib.es2019.array.d.ts","../../node_modules/typescript/lib/lib.es2019.object.d.ts","../../node_modules/typescript/lib/lib.es2019.string.d.ts","../../node_modules/typescript/lib/lib.es2019.symbol.d.ts","../../node_modules/typescript/lib/lib.es2019.intl.d.ts","../../node_modules/typescript/lib/lib.es2020.bigint.d.ts","../../node_modules/typescript/lib/lib.es2020.date.d.ts","../../node_modules/typescript/lib/lib.es2020.promise.d.ts","../../node_modules/typescript/lib/lib.es2020.sharedmemory.d.ts","../../node_modules/typescript/lib/lib.es2020.string.d.ts","../../node_modules/typescript/lib/lib.es2020.symbol.wellknown.d.ts","../../node_modules/typescript/lib/lib.es2020.intl.d.ts","../../node_modules/typescript/lib/lib.es2020.number.d.ts","../../node_modules/typescript/lib/lib.es2021.promise.d.ts","../../node_modules/typescript/lib/lib.es2021.string.d.ts","../../node_modules/typescript/lib/lib.es2021.weakref.d.ts","../../node_modules/typescript/lib/lib.es2021.intl.d.ts","../../node_modules/typescript/lib/lib.es2022.array.d.ts","../../node_modules/typescript/lib/lib.es2022.error.d.ts","../../node_modules/typescript/lib/lib.es2022.intl.d.ts","../../node_modules/typescript/lib/lib.es2022.object.d.ts","../../node_modules/typescript/lib/lib.es2022.string.d.ts","../../node_modules/typescript/lib/lib.es2022.regexp.d.ts","../../node_modules/typescript/lib/lib.es2023.array.d.ts","../../node_modules/typescript/lib/lib.es2023.collection.d.ts","../../node_modules/typescript/lib/lib.es2023.intl.d.ts","../../node_modules/typescript/lib/lib.es2024.arraybuffer.d.ts","../../node_modules/typescript/lib/lib.es2024.collection.d.ts","../../node_modules/typescript/lib/lib.es2024.object.d.ts","../../node_modules/typescript/lib/lib.es2024.promise.d.ts","../../node_modules/typescript/lib/lib.es2024.regexp.d.ts","../../node_modules/typescript/lib/lib.es2024.sharedmemory.d.ts","../../node_modules/typescript/lib/lib.es2024.string.d.ts","../../node_modules/typescript/lib/lib.esnext.array.d.ts","../../node_modules/typescript/lib/lib.esnext.collection.d.ts","../../node_modules/typescript/lib/lib.esnext.intl.d.ts","../../node_modules/typescript/lib/lib.esnext.disposable.d.ts","../../node_modules/typescript/lib/lib.esnext.promise.d.ts","../../node_modules/typescript/lib/lib.esnext.decorators.d.ts","../../node_modules/typescript/lib/lib.esnext.iterator.d.ts","../../node_modules/typescript/lib/lib.esnext.float16.d.ts","../../node_modules/typescript/lib/lib.decorators.d.ts","../../node_modules/typescript/lib/lib.decorators.legacy.d.ts","../../node_modules/@remix-run/node/dist/globals.d.ts","../../node_modules/@types/cookie/index.d.ts","../../node_modules/@remix-run/server-runtime/dist/crypto.d.ts","../../node_modules/@remix-run/server-runtime/dist/cookies.d.ts","../../node_modules/@remix-run/server-runtime/dLine truncated
{"fileNames":["../../node_modules/typescript/lib/lib.es5.d.ts","../../node_modules/typescript/lib/lib.es2015.d.ts","../../node_modules/typescript/lib/lib.es2016.d.ts","../../node_modules/typescript/lib/lib.es2017.d.ts","../../node_modules/typescript/lib/lib.es2018.d.ts","../../node_modules/typescript/lib/lib.es2019.d.ts","../../node_modules/typescript/lib/lib.es2020.d.ts","../../node_modules/typescript/lib/lib.es2021.d.ts","../../node_modules/typescript/lib/lib.es2022.d.ts","../../node_modules/typescript/lib/lib.es2023.d.ts","../../node_modules/typescript/lib/lib.es2024.d.ts","../../node_modules/typescript/lib/lib.esnext.d.ts","../../node_modules/typescript/lib/lib.dom.d.ts","../../node_modules/typescript/lib/lib.dom.iterable.d.ts","../../node_modules/typescript/lib/lib.es2015.core.d.ts","../../node_modules/typescript/lib/lib.es2015.collection.d.ts","../../node_modules/typescript/lib/lib.es2015.generator.d.ts","../../node_modules/typescript/lib/lib.es2015.iterable.d.ts","../../node_modules/typescript/lib/lib.es2015.promise.d.ts","../../node_modules/typescript/lib/lib.es2015.proxy.d.ts","../../node_modules/typescript/lib/lib.es2015.reflect.d.ts","../../node_modules/typescript/lib/lib.es2015.symbol.d.ts","../../node_modules/typescript/lib/lib.es2015.symbol.wellknown.d.ts","../../node_modules/typescript/lib/lib.es2016.array.include.d.ts","../../node_modules/typescript/lib/lib.es2016.intl.d.ts","../../node_modules/typescript/lib/lib.es2017.arraybuffer.d.ts","../../node_modules/typescript/lib/lib.es2017.date.d.ts","../../node_modules/typescript/lib/lib.es2017.object.d.ts","../../node_modules/typescript/lib/lib.es2017.sharedmemory.d.ts","../../node_modules/typescript/lib/lib.es2017.string.d.ts","../../node_modules/typescript/lib/lib.es2017.intl.d.ts","../../node_modules/typescript/lib/lib.es2017.typedarrays.d.ts","../../node_modules/typescript/lib/lib.es2018.asyncgenerator.d.ts","../../node_modules/typescript/lib/lib.es2018.asynciterable.d.ts","../../node_modules/typescript/lib/lib.es2018.intl.d.ts","../../node_modules/typescript/lib/lib.es2018.promise.d.ts","../../node_modules/typescript/lib/lib.es2018.regexp.d.ts","../../node_modules/typescript/lib/lib.es2019.array.d.ts","../../node_modules/typescript/lib/lib.es2019.object.d.ts","../../node_modules/typescript/lib/lib.es2019.string.d.ts","../../node_modules/typescript/lib/lib.es2019.symbol.d.ts","../../node_modules/typescript/lib/lib.es2019.intl.d.ts","../../node_modules/typescript/lib/lib.es2020.bigint.d.ts","../../node_modules/typescript/lib/lib.es2020.date.d.ts","../../node_modules/typescript/lib/lib.es2020.promise.d.ts","../../node_modules/typescript/lib/lib.es2020.sharedmemory.d.ts","../../node_modules/typescript/lib/lib.es2020.string.d.ts","../../node_modules/typescript/lib/lib.es2020.symbol.wellknown.d.ts","../../node_modules/typescript/lib/lib.es2020.intl.d.ts","../../node_modules/typescript/lib/lib.es2020.number.d.ts","../../node_modules/typescript/lib/lib.es2021.promise.d.ts","../../node_modules/typescript/lib/lib.es2021.string.d.ts","../../node_modules/typescript/lib/lib.es2021.weakref.d.ts","../../node_modules/typescript/lib/lib.es2021.intl.d.ts","../../node_modules/typescript/lib/lib.es2022.array.d.ts","../../node_modules/typescript/lib/lib.es2022.error.d.ts","../../node_modules/typescript/lib/lib.es2022.intl.d.ts","../../node_modules/typescript/lib/lib.es2022.object.d.ts","../../node_modules/typescript/lib/lib.es2022.string.d.ts","../../node_modules/typescript/lib/lib.es2022.regexp.d.ts","../../node_modules/typescript/lib/lib.es2023.array.d.ts","../../node_modules/typescript/lib/lib.es2023.collection.d.ts","../../node_modules/typescript/lib/lib.es2023.intl.d.ts","../../node_modules/typescript/lib/lib.es2024.arraybuffer.d.ts","../../node_modules/typescript/lib/lib.es2024.collection.d.ts","../../node_modules/typescript/lib/lib.es2024.object.d.ts","../../node_modules/typescript/lib/lib.es2024.promise.d.ts","../../node_modules/typescript/lib/lib.es2024.regexp.d.ts","../../node_modules/typescript/lib/lib.es2024.sharedmemory.d.ts","../../node_modules/typescript/lib/lib.es2024.string.d.ts","../../node_modules/typescript/lib/lib.esnext.array.d.ts","../../node_modules/typescript/lib/lib.esnext.collection.d.ts","../../node_modules/typescript/lib/lib.esnext.intl.d.ts","../../node_modules/typescript/lib/lib.esnext.disposable.d.ts","../../node_modules/typescript/lib/lib.esnext.promise.d.ts","../../node_modules/typescript/lib/lib.esnext.decorators.d.ts","../../node_modules/typescript/lib/lib.esnext.iterator.d.ts","../../node_modules/typescript/lib/lib.esnext.float16.d.ts","../../node_modules/typescript/lib/lib.decorators.d.ts","../../node_modules/typescript/lib/lib.decorators.legacy.d.ts","../../node_modules/@remix-run/node/dist/globals.d.ts","../../node_modules/@types/cookie/index.d.ts","../../node_modules/@remix-run/server-runtime/dist/crypto.d.ts","../../node_modules/@remix-run/server-runtime/dist/cookies.d.ts","../../node_modules/@remix-run/server-runtime/dLine truncated