mirror of
https://github.com/storytold/wordcraft.git
synced 2026-11-07 03:01:32 +00:00
Hamza Naveed
cbe6a9d5f7
* Pin that a comment id past u32 is refused, not truncated (#3677) `validate_comment_id` refuses an `id` that does not fit a `u32`, so the `as u32` casts behind it can no longer reach another comment -- but nothing pinned it, and the casts are still there to be reached if the guard moves. The ids the test sends are the ones that would alias onto real comments if the truncation came back: 2^32 truncates to 0 (and the first comment is 0), 2^32 + id to that comment, 4294967301 to 5 as the report describes, and u64::MAX to u32::MAX. Each of the four commands that take an id is tried with each, then the comments are checked to be unchanged and unresolved, and a valid id is accepted afterwards so the guard is shown to be a range check rather than a refusal. * Comment ids: the values past u32 go in the existing invalid-id test, refused by the range check