alt_numpad_code_types_its_character_without_keytips always expected é, but on
Windows the app (rightly) reads 0233 in the system locale's ANSI code page, so
a Russian system (1251) types й and the test failed. The test now works out the
expected character the same way, as its Alt+233 half already did.
split_row already keeps widow/orphan control in each cell paragraph.
When that moves all of a cell's lines on although its first line would
fit, the other cells stayed on the page and the row was split beside
an empty cell. Word moves the whole row on instead. Observed with
synthetic documents (exact 14 pt lines, a one-line cell next to a
longer one near the bottom of the page):
long cell | room for | Word | before | now
4 lines | 2 | 2 + 2 | 2 + 2 | 2 + 2
3 lines | 2 | row moves | short cell kept | row moves
3 lines | 1 | row moves | short cell kept | row moves
4 lines | 1 | row moves | short cell kept | row moves
5 lines | 3 | 3 + 2 | 3 + 2 | 3 + 2
3, control off | 2 | 2 + 1 | 2 + 1 | 2 + 1
Co-authored-by: Daniele Mori <Dinasty@hotmail.it>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Automatic text in a styled text box takes the shape style's font colour
A text box shape whose style has a:fontRef with a colour (Word's
default shape style uses lt1, white on the accent fill) shows its
automatic-colour text in that colour. WordCraft drew it black. Word,
observed with a synthetic document: only text whose resolved colour is
automatic takes the fontRef colour; a run's own colour, a paragraph or
character style colour and a colour from the document defaults all win
over it. A box without a fontRef keeps black.
- wordcraft-doc: TextBody gets `auto_color`.
- wordcraft-docx: read from wps:style/a:fontRef (theme colours resolved
as for SmartArt).
- wordcraft-layout: lines in a text box story resolve automatic colour
to it.
Saving does not write a shape style yet, so the colour is not kept
through a save; the reader and layout parts stand on their own.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Remove stray doc-comment lines from the new test
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Daniele Mori <Dinasty@hotmail.it>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
Some generators write a placeholder Heading 1 and then their own,
under the same w:styleId. The reader kept the first definition and
skipped the rest, so headings came out in the placeholder's font,
size and colour. Word uses the last definition, whole: a synthetic
document with an italic red 20 pt first definition and a bold blue
12 pt second one shows bold blue 12 pt, with nothing of the first
(no italic, no centring), for a custom style and for Heading 1 alike.
The reader now replaces an earlier definition in place instead of
skipping the later one.
Co-authored-by: Daniele Mori <Dinasty@hotmail.it>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Tab already follows reading order (next logical cell) and right-to-left
tables (w:bidiVisual) already lay the first cell out at the right. The
bug was that insert.table ignored the caret paragraph's direction, so a
table made while writing RTL text was a left-to-right table and Tab went
rightwards. Like Word, insert.table now makes a right-to-left table when
the caret's paragraph reads right to left.
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
Found while testing crates/doc/src/table.rs:129 (Table::delete_row), called from crates/engine/src/cmd/table.rs:526 (del_row)
Co-authored-by: Claude Haiku 5.5 <noreply@anthropic.com>
Found while testing crates/docx/src/write/story.rs:512-530 (InlineObject::NoteRef, the `current_note == Some(..)` branch)
Co-authored-by: Claude Haiku 5.5 <noreply@anthropic.com>
Indonesian spelling reads the installed Hunspell id_ID dictionary at runtime
(Debian/Ubuntu hunspell-id, LibreOffice dict-id, the Dictionaries folder or
WORDCRAFT_DICTIONARIES), like Czech, Polish and Portuguese: nothing is bundled,
and without a dictionary Indonesian text gets no spelling marks.
- ProofLang::Id for id, id-ID, ind and the legacy in tag
- suggestions reuse the dictionary-driven Czech ranking (MAP/REP/TRY/KEY of
the loaded dictionary), nothing Indonesian hard-coded
- hyphenated reduplication accepted whole or by parts (kupu-kupu, anak-anak);
hyphenated clitics after capitals/abbreviations (KTP-nya, se-Indonesia)
- generic grammar only: repeated word (offers anak-anak first), space before
punctuation, double space, with Indonesian messages
- Review > Language, status bar, Set Proofing Language, File > Options >
Proofing list Indonesian; name translated in every catalog
- tests use a hand-written synthetic dictionary; engine end-to-end test
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
Found while testing crates/formats/src/markdown.rs:253 (join_lines); also the trim_start() calls at lines 229, 311, 426 and 432, against escape_line_start at line 1077
Co-authored-by: Claude Haiku 5.5 <noreply@anthropic.com>
Two new interface languages, each a complete catalog of 2,585 entries:
every key the parity-class catalogs hold (the Polish-complete set — the
keys Italian, Hungarian, Bulgarian, Vietnamese, Swedish and Croatian
still carry beyond it are deprecated interface strings, so they are not
carried here). Written from the meaning of the English labels with each
language's standard software vocabulary: Dutch informal-neutral je,
Danish informal du with accented imperatives.
Registered in the language list (23 -> 25) with locale matching
(nl-NL/nl-BE, da-DK). The preferred-language test now uses the
private-use tag where it used nl as its unsupported example, and checks
that nl wins over da now that both are languages.
Supersedes #1070, whose Korean and Swedish were landed by other pull
requests; its Dutch and Danish catalogs are the ones carried here,
updated to today's key set.
Each underline style in the drop-down is now a sample of its own line,
drawn in code in the theme's text colour (Single, Double, Thick, Dotted,
Dashed, Dot-dash, the missing Dot-dot-dash, Wave), named for tooltips and
assistive technology. Words only uses format.wordUnderline (its own
Ctrl+Shift+W); None removes the underline and shows no shortcut; More
Underlines… opens the Font dialog; Underline Color › offers Automatic and
the theme/standard colours with More Colors….
- engine: format.underlineColor {"color": "RRGGBB" | "auto"} sets or
clears CharProps::underline_color and leaves the style alone;
format.state reports underlineColor; catalog row Home|Font|Underline
Color (parity checklist regenerated: 490/505).
- i18n: Dot-dot-dash, More Underlines… and Underline Color in all 22
catalogs (Underline Color reuses each catalog's "Underline color").
- Tests: underline_color_sets_and_clears_the_underlines_own_colour (engine,
DOCX round trip, undo, junk params), underline_menu_entries_apply_their_style
(UI: every sample is a named entry that applies its style; Words only,
None, Underline Color › Automatic).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A row of an m:eqArr with no `&` was right-aligned at the first column edge and counted into the
first column width, shifting the wider rows. Per Word, such a row is centred across the whole
array and takes no part in the column widths. Regression test eqarr_rows_without_an_align_marker_are_centred
fails without this. Closes#2617.
A failure caused by the snapshot itself (size limit, folder or disk budget,
a value the format cannot keep) now keeps the recorded revision, so tick
does not rewrite up to 256 MiB every interval while nothing changes.
Transient failures (locks, I/O) still retry at the next interval.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Word sizes a line by the fonts in it, and a bullet in Symbol (Word's
default, U+F0B7) has a taller ascent than Calibri or Times New Roman.
Without Symbol (Linux, macOS without Office, the web build) WordCraft
draws the bullet from another face and used that face's height, so every
bulleted line was shorter than Word's: 14.5 pt against 15.1 pt in
Calibri 11 pt at 1.08 spacing, 14.9 against 15.7 in Times New Roman 12 pt.
symbol_font_metrics gives Symbol's and Wingdings' ascent and descent as
Word's PDFs state them, and a run in one of them that isn't installed
takes them. The label's ascent now comes from its style, so the existing
rule (the label's extra ascent added unscaled) sees them.
Measured in Word 2016: Calibri 11 / Times 12 bullets 15.08 / 15.72 pt,
WordCraft now 15.07 / 15.75 pt. On 251 real documents against Word PDFs,
page breaks at the same word 45.4% -> 50.1%.
#1613 draws a missing font in Cambria when the font table classes it as
roman, as Word does. Times New Roman is roman in every font table, so
where it isn't installed (Linux, the web build) every Times document came
out in Caladea: lines 2.1 pt taller at 12 pt and different line breaks.
Word always has Times New Roman, so it never applies that rule to it.
The rule now leaves alone a font whose substitutes are chosen by its name
(a metric-compatible clone or the same design under another name: Times,
Arial, Courier New, Palatino, the symbol, Hebrew and Persian fonts).
Fonts with no clone of their own (Cambria, Georgia, brand fonts) still
follow it.
Checked on 251 real documents against PDFs from Word: exact page counts
201 -> 229, page breaks in the same place 45.4% -> 51.9%.
Right-clicking the page offered only Cut, Copy and Paste, even with
formatted text on the clipboard. Word's context menu lets you choose how
to paste there.
The context menu now has the same items as Home › Paste's menu, in the
same order and with the same shortcuts: Paste (the clipboard's
formatting kept, Word's Keep Source Formatting), Keep Text Only, Merge
Formatting and Paste Special…. They run the same commands (edit.paste,
edit.pasteText, edit.pasteMerge, edit.pasteSpecial), and
system_clipboard::fill already reads the system clipboard's text, HTML
and RTF for all of them. Every label was already translated in the 22
interface catalogs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dragging an In Line with Text picture, shape or text box now moves it within
the text, as in Word: a dashed insertion cursor follows the pointer through
the text, and the drop puts the object there, still inline and selected, in
one undo step (Ctrl+drag drops a copy there). Before, the drop floated it with
Square wrapping where it was let go, and nothing showed where it would land.
arrange.bounds and arrange.copyTo take {"to": Pos} for inline objects; x/y
keep their old meaning for scripts. Floating objects drag as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Word for the web writes each table of contents entry as a HYPERLINK
complex field around the heading's text, a tab and a PAGEREF field.
The DOCX reader buffered the whole field into one field object with a
flat text result, so the tab was drawn as a box instead of reaching the
dotted right tab stop, the page number was no longer a field of its own,
and the link could not be followed. Rewriting those fields as
w:hyperlink elements makes WordCraft draw the TOC as Word does.
A HYPERLINK field, complex or simple, now reads the way a w:hyperlink
does: its result stays ordinary content carrying the link (url,
url#bookmark or #bookmark from \l), with nested fields kept. It is
written back as w:hyperlink; the tooltip (\o) and target frame (\t) are
dropped. A HYPERLINK field with no target stays a field.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Opening note.txt, typing, saving with Ctrl+S and closing still asked
"Do you want to save changes to note.txt?". Save in that prompt wrote
the file but left the window open, and only Don't Save closed it.
file.save marked the document saved only for formats that keep
everything (.docx, .odt, .rtf...). A save in any other format counted
as a copy, even over the file the document was opened from, so a .txt
or .md document could never become clean. The Save Changes prompt then
treated its own Save as "not saved" and cancelled the close.
A save over the document's own file now marks it saved in any format.
Save As to plain text, Markdown or a page image elsewhere is still a
copy that leaves the document unsaved, as before. AutoSave still
covers only the formats that keep everything.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>