Commit Graph
3352 Commits
Author SHA1 Message Date
Tyrel HavemanandClaude Opus 5.5 47bcb64dbe references: a table of figures from Word replaces its saved list (#3013)
A Word table of figures whose saved list sits in the field's result, in
the field's own paragraph, was listed twice after Update Table: the
cached result stayed and the rebuilt entries followed it. The rebuild now
clears that result and keeps the paragraph's tab leader for the entries.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019Nnsfu3QGqjD1aFZbBgUWP
2026-10-19 06:52:30 -07:00
Daniele MoriandClaude Opus 5.5 1ed20b8685 Stacking order test: two Behind Text objects, the higher one first in the XML
As reported on #2034 with a minimal document: Word keeps the object with
the higher relativeHeight on top even when it comes first in the XML.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 15:44:39 +02:00
Daniele MoriandClaude Opus 5.5 53296879db Floating objects are drawn in their stacking order (relativeHeight)
Word stacks floating objects by wp:anchor/@relativeHeight, not by the
order of their anchors in the paragraph. The reader ignored the
attribute, so a panel anchored after the text boxes it frames, but
lower in the stack, was drawn over them and hid their text.

- wordcraft-doc: Float gets a `z` (0 = none, drawn in document order).
- wordcraft-docx: it is read from relativeHeight and written back as
  read; an object without one gets the next order above, as before.
- wordcraft-layout: place_objects collects each object's items with
  its order and emits them lowest first (stable, so objects without an
  order keep the paragraph's).

Four round-trip tests compare whole floats after a save; saving now
gives objects without an order one, so those tests compare without it
(`unstacked`). The order itself is covered by its own round-trip test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 15:44:38 +02:00
Tyrel Haveman a923cf6dc5 Merge remote-tracking branch 'upstream/main' into table-of-figures-label
# Conflicts:
#	ROADMAP.md
#	docs/ui-parity.md
2026-10-19 06:09:48 -07:00
aiongg af9b00dd4c Task panes: follow craft-ui panes at f4f9e5b (#1756)
craft-ui's pane host names each title bar after its pane, so the
accessible name is "Move Pane: {title}" ("Move Pane: Styles") in all 22
catalogs. The pane tests find the title bars by that name.
2026-10-19 12:44:47 +00:00
aiongg 0dd5b56dfe Task panes: draw them with craft_ui::panes; Styles docks left or right or floats (#1756)
The nine task panes (SmartArt Text Pane, Navigation, Clipboard, Styles,
Style Inspector, Accessibility, Alt Text, Restrict Editing, Comments) are
drawn by craft_ui::panes with the Columns policy: a title bar with a menu
and close button, a resize edge that also takes arrow keys, and F6 to move
between panes and the document. Panes open from the same view flags, in
the same order and at the same default widths; close runs each pane's
existing command.

The Styles pane can dock left or right or float through the pane menu or
the new command view.stylesPaneDock. ui.json keeps its position and float
rect; unknown values read as the defaults.
2026-10-19 12:17:59 +00:00
dfgodvan 5813d01f73 Layout: paragraph border room in keep-together checks, after a kept break mark and in Outline view
- Keep lines together and keep with next count the paragraph's top and bottom
  border room, and the keep-with-next lookahead the next paragraph's top border
  room (unless the two join in one box): a kept paragraph that fits only
  without its borders moves on whole instead of splitting.
- A mark that stays with its closing page break leaves its bottom border's
  room on that page, as its space after: the next page no longer starts lower.
- Outline view makes room for paragraph borders above and below the lines.

Tests: a_kept_together_paragraph_counts_its_border_room,
a_bottom_border_stays_with_a_closing_page_break,
outline_view_makes_room_for_paragraph_borders (each fails before the change).
2026-10-19 14:40:53 +03:00
dfgodvanandClaude Opus 5.5 115ccd0e89 Layout: paragraph borders take their room and same-bordered paragraphs join in one shaded box
The top and bottom borders of a paragraph now take their distance plus width
in the text flow, as in Word, and the shading fills that room. Neighbouring
paragraphs with the same borders and indents make one box: the top border goes
above the first only, the bottom one below the last, and the shading and side
borders run on through the space between them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 14:08:09 +03:00
JoeyandClaude Opus 5.5 a7095086c3 Breaks menu tests pin the English interface, so they pass on a non-English machine
An integration test isn't built with cfg(test), so WordApp follows the system language and the
ribbon's "Breaks" button wasn't found on a French Mac. Set the app's language to English like
native_print.rs does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 13:07:23 +02:00
Fin Warman 85bbc821f0 Merge main117 into #2431 2026-10-19 12:06:00 +01:00
dfgodvan 3e5eeccfa2 Render: fade dimmed headers and footers as one layer
While the body is edited, headers and footers are drawn dimmed. Each draw
item got the dimming alpha on its own, so wherever two of them overlap the
alpha was applied twice: a header table's borders came out darker where
they meet and along shared cell edges, nearly black at crossings. The
PDF export and the undimmed view were fine.

page_layers gives a page's draws as two layers (headers/footers, body) at
full strength with the opacity to draw each at. The canvas draws a dimmed
layer inside one opacity layer, as Word dims it, and background_at blends
it the same way. page_display is unchanged for the PDF export and tests.
2026-10-19 14:05:15 +03:00
Gabriel MatozoandBrandon Thomas 117aea31a8 Navigation pane: a long heading wraps within the pane instead of ending in an ellipsis (#3015) (#3029)
The pane drew each heading with `Button::selectable(..).truncate()`, so a heading wider than the
pane ended in an ellipsis and its text had to be read from the hover tooltip. Word wraps the row
instead.

`nav_heading` now wraps: the button takes `Button::wrap()` and a minimum size of the available width
and one row, so the label continues on further lines inside the pane, the row grows with the text,
and the pane still keeps its width. The trailing grow atom still keeps the text flush left under its
parent (#1199). The hover tooltip goes with the ellipsis: nothing is hidden now, and a word wider
than the pane is broken by the wrap instead of overflowing.

The navigation test asserts the wrap instead of the ellipsis. For a heading well past the width and
for a single word wider than the pane, the label has more than one line, is not elided, stays inside
the pane, does not widen it, and takes a taller row than a one-line heading in the same pane.

`docs/ui-parity.md` and `ROADMAP.md` record the new behaviour.

Co-authored-by: Brandon Thomas <brandon@storyteller.ai>
2026-10-19 03:08:47 -04:00
SlavenDj fdf791a8b2 #3045: the empty window's ribbon tabs stay live, so File reaches the Start screen (#3064)
With no document open, the empty window greys the Share / Editing /
Comments buttons out by disabling the whole right-to-left line, and the
tab strip is a child of that line: egui gates interactions on a widget's
enabled state, so every tab was dead. File did nothing, and the empty
window had no way back to the Start screen, or to making a document.

Only those three buttons are disabled now. The test presses Escape on
the Start screen (the empty window, as #1129 has it), clicks the File
tab and asserts the Start screen, with its Blank document, is back.
2026-10-19 03:05:41 -04:00
MarekSpodBiedry dbc5c3407b Size the text cursor by the font, not the line spacing (#2920) (#3011) 2026-10-19 03:05:17 -04:00
MarekSpodBiedry 3f9c19d9f3 Opening a missing recent file keeps File open and shows the error (#2938) (#3012) 2026-10-19 03:05:11 -04:00
Martin BallandClaude Opus 5.5 435be0a4cb #2972: regression tests for File page AccessKit focus paths (mac chevron, Options back, Blank document) (#3019)
* #2972: regression tests for File page / sidebar AccessKit focus paths

The macOS back chevron beside the traffic lights (the report's "sidebar
collapse toggle"; there is no other toggle there), File > New/Home > Blank
document, Escape, and File > Options > back (both layouts, with a document
and from the Start screen) all run under kittest's AccessKit. The chevron
and Options tests panic with "Focused ID ... is not in the node list"
before #2856 and pass on main.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* #2972: review — fresh document per Blank document path; Options back asserts closing and focus in every case

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012WEhZXSxzS8orX7f9J3qpr

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-19 03:05:06 -04:00
Martin BallandClaude Opus 5.5 6950c22d73 #2999: a file dialog that "cancels" at once asks again without a parent, then shows the built-in browser (#3030)
* #2999: a file dialog that "cancels" at once asks again without a parent, then shows the built-in browser

rfd folds the xdg-desktop-portal's failure response into "cancelled", so on desktops whose
FileChooser portal fails to show a dialog, Save As, Export and Open did nothing and logged
nothing. A cancel quicker than anyone can make one (300 ms) is now taken as that failure: the
dialog is asked for once more without the parent window (GridCraft, which passes none, works on
the reporter's machine), and if that too comes back at once the app shows its built-in browser.
Each step logs a warning.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012WEhZXSxzS8orX7f9J3qpr

* #2999: review — the quick-cancel retry runs only on Linux and the BSDs; Windows and macOS answer a quick cancel as a cancel

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012WEhZXSxzS8orX7f9J3qpr

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-19 03:04:59 -04:00
Juan Camilo Agudelo e0ff4b0c3d Paste: Ctrl+V pastes a clipboard picture even when Ctrl is released before V (#3049) (#3058)
* Paste: Ctrl+V pastes a clipboard picture even when Ctrl is released before V (#3049)

egui-winit keeps the Mod+V press, so a clipboard picture is pasted on V's
release, which required Mod still held. Letting Ctrl up first (the natural
one-hand Left Ctrl+V) pasted nothing. A V release with no V press seen was
Mod+V: use the modifiers held with Mod then, so Mod+Shift+V and Mod+Alt+V
stay apart.

Fixes #3049

* Paste: record the modifiers held with Mod in event order (#3049)

Mod can go down and up within one frame, so the frame's modifiers may no
longer have it when the canvas reads them. Take them from each
ModifiersChanged and key press as they arrive. Review feedback on #3058.

* Paste: document the Mod+V release helpers and tests (#3049)
2026-10-19 03:04:54 -04:00
SlavenDjandBrandon Thomas ebabb57e5e #3039: mini toolbar font colour Automatic returns focus to the document (#3043)
Co-authored-by: Brandon Thomas <brandon@storyteller.ai>
2026-10-19 03:04:49 -04:00
rabisandClaude Opus 5.5 fba2331bbf #3027: reset test checks the fill rule and paint transform for real
The test scene set even-odd itself before its only path that depends on
it and used solid paints only, so a fill rule or paint transform left
over from the last render could not change its pixels. It now fills
nested squares and a gradient on the defaults first, and checks that a
stale rule or paint transform does change the scene.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 09:00:20 +02:00
SlavenDj 25ad07f868 #3038: mini toolbar highlight swatch returns focus to the document (#3042) 2026-10-19 02:59:34 -04:00
SlavenDj e1e6c31571 #3040: undo-list row returns focus to the document (#3044) 2026-10-19 02:59:29 -04:00
SlavenDj 396344c31e #3031: Tabs dialog says the list is empty instead of a blank box (#3050) 2026-10-19 02:59:24 -04:00
SlavenDj 6e3f800a8b #3032: Styles pane greys out Delete for built-in styles (#3051) 2026-10-19 02:59:19 -04:00
SlavenDj 83014016c6 #3036: AutoCorrect Replace list says when the filter matches nothing (#3053) 2026-10-19 02:59:14 -04:00
570b992947 #3037: file browser says when a folder (or the filter) shows no items (#3054)
* #3037: file browser says when a folder (or the filter) shows no items

* #3037: Czech and Vietnamese catalogs carry the file browser's no-items string

* #3037: show the no-items hint only for a folder that was read

An unreadable folder already shows its error below the list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Brandon Thomas <brandon@storyteller.ai>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 02:59:09 -04:00
SlavenDj 76d8347f77 #2892: rules end flat on screen, like the PDF export (#3061) 2026-10-19 02:44:02 -04:00
SlavenDj 19e5bb48cf #3033: file browser Open/Save uses the themed primary button (#3047) 2026-10-19 02:43:57 -04:00
SlavenDj ab968b072d #3034: SmartArt Pyramid separators follow the theme line colour (#3052) 2026-10-19 02:43:52 -04:00
SlavenDj d26b8dcae7 #3035: WordArt reflection swatch follows the theme's dimmed text colour (#3055) 2026-10-19 02:43:46 -04:00
SlavenDj 68bc118a68 Add @SlavenDj to contributors/people.toml (#3048) 2026-10-19 02:43:34 -04:00
Diego GueriniandClaude Opus 5.5 18c7c1d114 #2845 follow-up: clippy passes on Windows and Linux again (#3006)
`graphics.rs` allowed dead code only on macOS (where the Windows items are unused). Since #2845
the two indirect-validation functions are called only on macOS, so on Windows and Linux
`cargo clippy --workspace --all-targets -- -D warnings` stopped with "function is never used".
They now carry `allow(dead_code)` off macOS.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 02:43:28 -04:00
NetterSilverandClaude Haiku 5.5 60ad86acb3 Keep a single trailing space when exporting a paragraph to ODT (#3066)
Found while testing crates/formats/src/odt.rs:354-390 (plain_inlines)

Co-authored-by: Claude Haiku 5.5 <noreply@anthropic.com>
2026-10-19 02:43:22 -04:00
rabisandClaude Opus 5.5 955d166a69 #3027: renders reuse one render context instead of a thread pool each
Every page, area and icon render built its own multi-threaded vello_cpu
RenderContext, which starts and tears down a rayon thread pool: a few
threads per keystroke while typing. Renders now take one kept context,
reset to their size, and give it back; a render that overlaps another
builds its own, and one that panics drops its context.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 08:35:17 +02:00
Fin Warman 328b36c9bd PR2453: merge main documentation 2026-10-19 07:28:58 +01:00
Tyrel HavemanandClaude Opus 5.5 52e119da5f references: table of figures review fixes (#3013)
- The leader asked for is carried through the rebuild by a placeholder
  entry, so it lands on the new list even when a stale list above it
  gains entries and moves it down.
- \c picks captions by their SEQ identifier, as Word does; the label text
  is used only for captions typed by hand.
- The dialog test drives the dialog through egui_kittest: page numbers
  off disables the right margin choice, OK closes it and the entries get
  the chosen leader.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019Nnsfu3QGqjD1aFZbBgUWP
2026-10-18 21:59:21 -07:00
vangel76andClaude Sonnet 5.5 ee649d03da i18n: translate the View Side by Side disabled-reason strings
The two disabled reasons added by the Window commands ("only the desktop app has
several windows", "turn on View Side by Side first") had no catalog rows, so
i18n::audit::untranslated_interface_text and the cs/vi coverage tests failed.
Add rows to ru, hu, tr, bg, it, sv, hr, pl, cs and vi.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-19 02:28:02 +02:00
vangel76andClaude Sonnet 5.5 19094d4f3a Layout tests: start every test with test_fonts and refit three fixtures to the pinned fonts
Adds crate::test_fonts() to the 95 layout tests that lacked it (several arrived
with upstream merges). Three fixtures were sized for installed fonts and failed
with the pinned set: exact_row_moves_whole (one line less of filler),
an_at_least_row_at_the_top_of_a_page_splits_instead_of_moving_on (60 lines so
the split row does not spill an empty page) and the inline text box test
(FILLER 16).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-19 02:20:09 +02:00
vangel76andClaude Sonnet 5.5 fb3d600428 cargo fmt --all
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-19 02:12:04 +02:00
vangel76andClaude Sonnet 5.5 7b1c0402b0 Merge upstream/main into mcp-insert-table-2242
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-19 02:11:48 +02:00
vangel76andClaude Sonnet 5.5 365b8c003e Merge upstream/main into feat/1053-rtf-notes-comments
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-19 02:11:33 +02:00
vangel76andClaude Sonnet 5.5 1bec25c02d Merge upstream/main into control-mcp-delivery-1326-1331
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-19 02:11:16 +02:00
vangel76 fec6872e68 Merge remote-tracking branch 'upstream/main' into tmp-pr2691
# Conflicts:
#	ROADMAP.md
2026-10-19 02:11:15 +02:00
vangel76andClaude Sonnet 5.5 c3703ebc73 Regenerate parity checklist and headline coverage after merging main
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-19 02:10:30 +02:00
vangel76andClaude Sonnet 5.5 ede933dcc2 Merge upstream/main into feat/322-view-windows
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-19 02:09:57 +02:00
vangel76andClaude Sonnet 5.5 21604d5fde Merge upstream/main into fix/float-in-cell-align-1887
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-19 02:08:49 +02:00
vangel76andClaude Sonnet 5.5 ffec4db77b cargo fmt after merging main
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-19 02:08:25 +02:00
vangel76andClaude Sonnet 5.5 3de7f8e31e Merge upstream/main into feat/radar-chart-1890
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-19 02:08:06 +02:00
vangel76andClaude Sonnet 5.5 d955ff2874 Merge upstream/main into test/fixed-layout-fonts-2729
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-19 02:00:30 +02:00
Tyrel HavemanandClaude Opus 5.5 0d48f236e5 references: Insert Table of Figures dialog with a caption label choice (#3013)
Insert Table of Figures now opens a Table of Figures dialog (caption label,
include label and number, page numbers, right margin, tab leader) instead of
always building a list of Figures. The label list offers the built-in labels,
the user's own and those the document's captions use, so a document can have
a list of figures beside a list of tables.

references.tableOfFigures takes includeLabel, pageNumbers, rightAlign and
tabLeader and writes the TOC switches for them (ECMA-376 17.16.5.68: \c or \a,
\n, \p). Captions are matched on their whole label (SEQ identifier), a Word
table of figures with its switches in any order (TOC \h \z \c "Figure") is
recognised, and Update Table keeps each list's leader. The table of contents
code treats any \c or \a TOC as a table of figures.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 16:04:44 -07:00