* Backspace and Delete remove a section break, imported or not (fixes#2127)
* Delete removes a section break on the last paragraph too (#2127)
A continuous break on the mark of the document's last paragraph, with the
last section holding no paragraph (as in the file attached to #2127), had
nothing for Delete to join, so it stayed. Delete at the end now removes it.
The text takes the last section's setup, as in Word, and the headers and
footers that section showed by linking to the removed one stay, here and
when the break goes by joining two paragraphs. Undo brings it back.
* Deleting over several section breaks keeps the headers they linked to (#2127)
A range across two or more breaks dropped the paragraphs in between with
their sections, so only the first section's headers and footers were carried
over. The joined section now takes those it leaves out from every removed
section, nearest first, as "link to previous" resolved them before the delete.
The typing-parity row says that Delete with Track Changes on still leaves a
break on the last paragraph alone.
---------
Co-authored-by: Brandon Thomas <echelon@gmail.com>
The strip kept File, the active tab and contextual tabs however narrow the window got, so
they were drawn under the buttons on the right. The strip is now planned first: the buttons
keep their room and the tabs give way in order (tab padding, Comments and Editing labels,
Share label, plain tabs into », active and contextual labels cut with …, last the active tab
into »). File always stays. A regression test checks widths 300-1280 in en, pl and de.
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
With text selected, Layout > Columns used to change the whole section. As in
Word (observed black-box), a continuous section break now goes where the
selection starts and one where it ends, splitting a paragraph there, unless that
end already meets a section boundary (the document's start or end, or an
existing break); the columns go on the section between, in one undo step.
`layout.columns` gains `apply: "selection"`, its default when text is selected
in the main text. More Columns... offers "Selected text" and picks it then.
Co-authored-by: Brandon Thomas <echelon@gmail.com>
The legacy run properties w:outline, w:shadow, w:emboss and w:imprint were
read, resolved and saved but never drawn. Layout now turns them into text
effects (hollow outlined letters; a sharp grey copy down-right for shadow
and emboss, up-left for imprint, as Word's PDFs show them) and draws them
through the existing WordArt path, so screen and PDF both get them and the
PDF keeps the text. WordArt w14 effects on the same run take precedence.
Text drawn from outlines keeps synthetic bold (a widened outline, or one
in a solid fill's colour and transparency). Colour glyphs (emoji, no
outlines) and top-to-bottom runs with upright characters are drawn as
plain glyphs, and tracked insertions and deletions keep their legacy
effects.
Co-authored-by: Naxvog <4963183+naxvog@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
Review follow-ups: the German patterns' MIT notice goes into NOTICE with
the other pattern sets; the pattern reader skips other commands'
arguments, so hyph-de-1996.tex's \message{} line no longer adds junk
patterns and exception words; a load test for the German set; the
status bar names a bare "de" tag; the docs list the languages with
their own hyphenation.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Runs in German (de, de-DE, de-AT, de-CH) hyphenated with the English
patterns, giving breaks such as "unterlieg-ende" and "rechtli-cher".
They now use hyph-utf8's German patterns for the reformed spelling
(MIT, bundled unmodified as assets/hyphenation/de.pat). German gets a
ProofLang of its own that, like Bulgarian, hyphenates only: no spelling
or grammar marks yet (#1564). Portuguese, Italian and German share one
pattern lookup.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With Different First Page on, page 1 shows the first-page header, but
Insert > Header/Footer/Page Number always wrote the default one (which
page 1 no longer shows), Edit Header without a page went to the default
too, and a double-click in page 1's header area was ignored while
another header was being edited (the usual case: edit the header, tick
Different First Page, double-click page 1). Now hf_part and edit_hf use
the slot of the caret's page, and a double-click in a header/footer
zone switches to the one that page shows even from another header.
Fixes#2826Fixes#2811
Claude-Session: https://claude.ai/code/session_013kKPnx8r1vcYumjyL3kcuz
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
LibreOffice puts a paragraph indented on both sides on the clipboard as
<blockquote>, its margins in the page's stylesheet. Paste mapped it to the
centred, italic Quote style. On paste only, it now becomes a Normal
paragraph indented by the blockquote's stylesheet margins (else 0.5 in each
side). Opening .html files still maps blockquote to Quote.
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
* Shapes: preserve DrawingML outline dashes
* Shapes: scale dashes to effective path width (#380)
* Keep the outline dash with noFill; cap the raster dashed stroke width at 200 pt
Addresses the two CodeRabbit review notes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Use clamp for the dashed stroke width (clippy)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Brandon Thomas <echelon@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A copy or cut of one equation on its own now also puts its MathML in the
platform's MathML clipboard formats, beside the HTML (with MathML, #816) and
the linear text: "MathML" and "MathML Presentation" (UTF-16LE) on Windows,
public.mathml.presentation and public.mathml on macOS. These are the names
W3C MathML 3 section 6.2.4 registers, and Microsoft's "MathML Support in
Microsoft 365" doc says Office checks them first when it pastes math. No
public clipboard format carries OMML. A copy with text around the equation
doesn't offer them, so Word keeps the text.
Not yet verified in Word: the parity docs say MathML clipboard formats, not
an editable paste.
Claude-Session: https://claude.ai/code/session_01P8veLveuUsJJm6UEcQPEuW
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
Tab already follows reading order (next logical cell) and right-to-left
tables (w:bidiVisual) already lay the first cell out at the right. The
bug was that insert.table ignored the caret paragraph's direction, so a
table made while writing RTL text was a left-to-right table and Tab went
rightwards. Like Word, insert.table now makes a right-to-left table when
the caret's paragraph reads right to left.
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
Indonesian spelling reads the installed Hunspell id_ID dictionary at runtime
(Debian/Ubuntu hunspell-id, LibreOffice dict-id, the Dictionaries folder or
WORDCRAFT_DICTIONARIES), like Czech, Polish and Portuguese: nothing is bundled,
and without a dictionary Indonesian text gets no spelling marks.
- ProofLang::Id for id, id-ID, ind and the legacy in tag
- suggestions reuse the dictionary-driven Czech ranking (MAP/REP/TRY/KEY of
the loaded dictionary), nothing Indonesian hard-coded
- hyphenated reduplication accepted whole or by parts (kupu-kupu, anak-anak);
hyphenated clitics after capitals/abbreviations (KTP-nya, se-Indonesia)
- generic grammar only: repeated word (offers anak-anak first), space before
punctuation, double space, with Indonesian messages
- Review > Language, status bar, Set Proofing Language, File > Options >
Proofing list Indonesian; name translated in every catalog
- tests use a hand-written synthetic dictionary; engine end-to-end test
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
Each underline style in the drop-down is now a sample of its own line,
drawn in code in the theme's text colour (Single, Double, Thick, Dotted,
Dashed, Dot-dash, the missing Dot-dot-dash, Wave), named for tooltips and
assistive technology. Words only uses format.wordUnderline (its own
Ctrl+Shift+W); None removes the underline and shows no shortcut; More
Underlines… opens the Font dialog; Underline Color › offers Automatic and
the theme/standard colours with More Colors….
- engine: format.underlineColor {"color": "RRGGBB" | "auto"} sets or
clears CharProps::underline_color and leaves the style alone;
format.state reports underlineColor; catalog row Home|Font|Underline
Color (parity checklist regenerated: 490/505).
- i18n: Dot-dot-dash, More Underlines… and Underline Color in all 22
catalogs (Underline Color reuses each catalog's "Underline color").
- Tests: underline_color_sets_and_clears_the_underlines_own_colour (engine,
DOCX round trip, undo, junk params), underline_menu_entries_apply_their_style
(UI: every sample is a named entry that applies its style; Words only,
None, Underline Color › Automatic).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A failure caused by the snapshot itself (size limit, folder or disk budget,
a value the format cannot keep) now keeps the recorded revision, so tick
does not rewrite up to 256 MiB every interval while nothing changes.
Transient failures (locks, I/O) still retry at the next interval.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Word sizes a line by the fonts in it, and a bullet in Symbol (Word's
default, U+F0B7) has a taller ascent than Calibri or Times New Roman.
Without Symbol (Linux, macOS without Office, the web build) WordCraft
draws the bullet from another face and used that face's height, so every
bulleted line was shorter than Word's: 14.5 pt against 15.1 pt in
Calibri 11 pt at 1.08 spacing, 14.9 against 15.7 in Times New Roman 12 pt.
symbol_font_metrics gives Symbol's and Wingdings' ascent and descent as
Word's PDFs state them, and a run in one of them that isn't installed
takes them. The label's ascent now comes from its style, so the existing
rule (the label's extra ascent added unscaled) sees them.
Measured in Word 2016: Calibri 11 / Times 12 bullets 15.08 / 15.72 pt,
WordCraft now 15.07 / 15.75 pt. On 251 real documents against Word PDFs,
page breaks at the same word 45.4% -> 50.1%.
#1613 draws a missing font in Cambria when the font table classes it as
roman, as Word does. Times New Roman is roman in every font table, so
where it isn't installed (Linux, the web build) every Times document came
out in Caladea: lines 2.1 pt taller at 12 pt and different line breaks.
Word always has Times New Roman, so it never applies that rule to it.
The rule now leaves alone a font whose substitutes are chosen by its name
(a metric-compatible clone or the same design under another name: Times,
Arial, Courier New, Palatino, the symbol, Hebrew and Persian fonts).
Fonts with no clone of their own (Cambria, Georgia, brand fonts) still
follow it.
Checked on 251 real documents against PDFs from Word: exact page counts
201 -> 229, page breaks in the same place 45.4% -> 51.9%.
Right-clicking the page offered only Cut, Copy and Paste, even with
formatted text on the clipboard. Word's context menu lets you choose how
to paste there.
The context menu now has the same items as Home › Paste's menu, in the
same order and with the same shortcuts: Paste (the clipboard's
formatting kept, Word's Keep Source Formatting), Keep Text Only, Merge
Formatting and Paste Special…. They run the same commands (edit.paste,
edit.pasteText, edit.pasteMerge, edit.pasteSpecial), and
system_clipboard::fill already reads the system clipboard's text, HTML
and RTF for all of them. Every label was already translated in the 22
interface catalogs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dragging an In Line with Text picture, shape or text box now moves it within
the text, as in Word: a dashed insertion cursor follows the pointer through
the text, and the drop puts the object there, still inline and selected, in
one undo step (Ctrl+drag drops a copy there). Before, the drop floated it with
Square wrapping where it was let go, and nothing showed where it would land.
arrange.bounds and arrange.copyTo take {"to": Pos} for inline objects; x/y
keep their old meaning for scripts. Floating objects drag as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Word for the web writes each table of contents entry as a HYPERLINK
complex field around the heading's text, a tab and a PAGEREF field.
The DOCX reader buffered the whole field into one field object with a
flat text result, so the tab was drawn as a box instead of reaching the
dotted right tab stop, the page number was no longer a field of its own,
and the link could not be followed. Rewriting those fields as
w:hyperlink elements makes WordCraft draw the TOC as Word does.
A HYPERLINK field, complex or simple, now reads the way a w:hyperlink
does: its result stays ordinary content carrying the link (url,
url#bookmark or #bookmark from \l), with nested fields kept. It is
written back as w:hyperlink; the tooltip (\o) and target frame (\t) are
dropped. A HYPERLINK field with no target stays a field.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Opening note.txt, typing, saving with Ctrl+S and closing still asked
"Do you want to save changes to note.txt?". Save in that prompt wrote
the file but left the window open, and only Don't Save closed it.
file.save marked the document saved only for formats that keep
everything (.docx, .odt, .rtf...). A save in any other format counted
as a copy, even over the file the document was opened from, so a .txt
or .md document could never become clean. The Save Changes prompt then
treated its own Save as "not saved" and cancelled the close.
A save over the document's own file now marks it saved in any format.
Save As to plain text, Markdown or a page image elsewhere is still a
copy that leaves the document unsaved, as before. AutoSave still
covers only the formats that keep everything.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Apple Pages writes a sizeless w:framePr (xAlign left, y 0, hRule
exact) into w:pPrDefault. WordCraft read it as the default paragraph
frame, so every paragraph inherited it. The header's title of
traditional_skills_job_form was drawn from the page's left edge over
the first table, the footer's page number left the bottom of the page,
and table rows came out shorter than in Word.
Word ignores that frame: its PDF of the same file shows the title at
the left margin and "1/4" in the footer. Taking just that element out
of styles.xml gives WordCraft the same page. The reader now drops the
frame from the paragraph defaults and keeps the rest of them. Frames
from styles and direct formatting are unchanged, and the default frame
isn't written back on save.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On Wayland, AltGr (Right Alt on Polish, German, Czech… layouts) arrives as
the Right Alt key followed by a modifiers event without Alt, since it turns
on Level 3 Shift (Mod5), not Alt. The KeyTips state machine read that event
as Alt let go with nothing pressed in between and opened KeyTips while AltGr
was still held, so the next letter went to the badges instead of typing ś,
ł, ż.
A modifiers event without Alt no longer ends the press while an Alt key is
still down by key events (its key-up does), and a release opens KeyTips only
if the Alt modifier was on during the press (Left Alt always counts), so a
bare AltGr tap doesn't open them either. Right Alt that is Alt (US layout)
still does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Some fonts (the static Noto Naskh Arabic builds) draw لا as a lam and a
zero-advance alef with their own clusters at one x. visual_order kept the
tie in logical order, so the right-to-left run's ranges didn't decrease,
krilla dropped /ReversedChars and السلام extracted as السالم. Ties between
clusters now go in reverse text order when right to left (text order
otherwise).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>