* #778: take craft-libs integration/wordcraft-778 at beeea924
Every craft-libs git dependency (workspace, ui-egui, wordcraft, wordcraft-web,
krilla patch) moves from 453b0da782 to beeea92451 (craft-libs main 0649a07aa
plus open PRs #2061-#2064). Cargo.lock: only craft-libs sources move, plus
windows-sys edge changes inside craft-libs crates; no crates.io versions change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* #778: docx stacking-order test follows the shared reader's one-more z
craft-libs 5f453efa9 (craft-docx: a relativeHeight of 0 stays the lowest
stacking order) reads Float::z as one more than the file's relativeHeight and
writes stored orders one less, so a file's 0 is no longer "none". The test
expected the old values; relative order and the round trip are unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* #778: take craft-libs integration/wordcraft-778 at 24a15211
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* deps: pin craft-libs to the merged shared cutover prerequisites
* #778: pin craft-libs main at 93dac78c (with #2061-#2064)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Dylan M. Taylor <dylan@dylanmtaylor.com>
* Fonts: tell where a missing font can be downloaded (Get the Missing Fonts)
A document opened from a file that is missing fonts their publisher gives
away (Microsoft's Aptos family, Cascadia Code and Mono) brings up a box
naming each font, the font drawn instead, the publisher's download page and
how to install the download. Once per document; never for a new document or
one a script opened. "Don't show this again" turns it off (File > Options >
General turns it back on); the status bar's missing-fonts menu opens it by
hand (ui.dialog fontDownload).
font.missing reports the same page as "download", so agents get it without
the box. WordCraft links to the page only: nothing is downloaded or bundled.
The desktop and web apps switch the box on at start-up
(tell_about_font_downloads); tests and ui_shot don't, so what they show
doesn't depend on the fonts installed where they run.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GBVQLv63guWCuWUM3SctPP
* Get the Missing Fonts: the box with nothing to download is one row tall
Its Close button's far-side layout took the rest of the window's height.
The button row is now a row of its own, shared by both forms of the box.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GBVQLv63guWCuWUM3SctPP
* Floating windows: a flat title bar and room around the content
Dialogs, the Read Aloud player and the built-in file browser had a grey
band behind a centred title and 6 pt margins. The title bar is now the
window's own colour with no band or line under it, and the title and the
content have 18 pt of room. The close box follows the new title bar height.
egui fills the front window's title bar with the colour of an open menu
button, so show_window makes that colour the window's while the title bar
is drawn and puts it back before the content is.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GBVQLv63guWCuWUM3SctPP
* Get the Missing Fonts: a headline, a card to each download, numbered steps
The box was a plain table and a paragraph of steps. It now opens with the
warning mark and how many fonts are missing; lists each download once
(Aptos and Aptos Display come in one) with the fonts drawn instead, the
publisher and a Download button that opens the publisher's page; and gives
the two steps that add the download, with Add Font… beside its step.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GBVQLv63guWCuWUM3SctPP
* Fonts: the download pages are a JSON list (font_downloads.json)
The list of fonts their publisher gives away, and each publisher's page,
was a table in the code. It is now crates/fonts/src/font_downloads.json,
built into the app: adding a font is a new entry there. Entries without a
family, a publisher or an https page are left out, and a list that isn't
JSON has no downloads rather than failing.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GBVQLv63guWCuWUM3SctPP
* Get the Missing Fonts: licence notice, and fonts offered with limits
The box says that fonts come with licence terms and that following the
publisher's terms is up to the user. A font whose publisher limits who may
use it is marked "restricted" in font_downloads.json, says so on its card
and in font.missing ("restricted"), and has a card of its own.
The list gains Selawik (Microsoft's open-source font) and, marked
restricted, Segoe UI Variable, Segoe Fluent Icons and Segoe MDL2 Assets
from Microsoft's Windows design downloads page. Plain Segoe UI is not
offered for download and is not matched.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GBVQLv63guWCuWUM3SctPP
* Get the Missing Fonts: the downloads scroll in a short window
With many downloads in a short window the box ran past the bottom of the
screen, leaving the steps, Add Font…, Don't show this again and Close out
of reach. The cards now scroll in the room the window has left, between
96 and 320 pt, and the rest of the box stays in view.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
* Get the Missing Fonts: all above the Close row scrolls in a short window
Only the download cards scrolled, within fixed limits, so in a window
shorter than about 480 pt the opt-out and Close could still fall off
screen. Everything above the row with Don't show this again and Close now
scrolls in the room the window has left, and that row stays on screen.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
* Floating windows: the flat title bar and wider margins leave this change
Reverts 2d39c54e and its revision-history row. The restyle changes every
dialog, the Read Aloud player and the file browser, and is to be reviewed
on its own.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
* Get the Missing Fonts: the headline counts the fonts that can be downloaded
The box lists only the missing fonts with a download, so "1 font in this
document isn't installed" was wrong for a document missing others too. It
now says "1 missing font can be downloaded", and the line under it no longer
mixes one and many.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* Dependencies: take craft-libs main at 3af2280ee3
Every craft-libs git dependency (the workspace's 25, ui-egui's 3, the app's
craft-print, the web build's 2 and the krilla patch) moves to craft-libs main
at 3af2280ee3 from the 8 revisions they were pinned at. Cargo.lock changes
those sources, moves winprint and craft-winprint-gdi with craft-print, drops
the second craft-tiff, and adds cap-primitives and its dependencies, which
craft-font-store's Language pack recovery uses on native builds.
- craft_print::Job has two new fields. WordCraft sets grey_pages to false,
since it does not turn the spooled pages gray, and driver_settings to None.
- DOCX text boxes, rectangles, rounded rectangles and ellipses are now
written in mc:AlternateContent with a VML fallback that repeats the text
box's text. Two tests that counted w:txbxContent elements, or the story
text, now count the fallback copy as well.
* Printing: the isolated print helper keeps the job's grey pages and driver settings
The Windows print helper process rebuilt each job with grey_pages off and no
driver settings, whatever the job carried. Its request now carries both: the
driver settings travel as the printer's name and the DEVMODE in hex, and
damaged settings are an error. The request file may now be up to 2 MiB larger,
the size of the largest driver settings craft-print accepts, written as hex.
Comments in Cargo.toml and apps/wordcraft/Cargo.toml now describe the shared
craft-libs commit, and the shared-story text box test says where its two copies
are written.
* DOCX: open picture frame shapes and keep chart formatting from craft-libs
At this craft-libs commit the DOCX reader returns a picture frame shape
(`frame` preset) as its own shape kind, and charts carry series formatting
and axis settings. WordCraft's model had neither:
- A document with a picture frame shape failed to open with "unknown
variant `frame`". The model bridge now reads it as a rectangle, as the
earlier reader did.
- The chart model drops nothing the shared chart model holds: series fill,
line width, line and fill off, markers, smooth lines, data labels and
number format, and the category and value axes. Before, saving a chart
with any of these wrote the chart again without them.
- A new scatter series is drawn as markers without a line, as before.
Change Chart Type sets this when a chart becomes a scatter chart or stops
being one, Edit Data keeps each replaced series' formatting, and Data
Labels replaces each series' own label setting.
* Charts: draw turned axis titles and keep stored scatter charts without lines
At this craft-libs commit a chart's vertical axis title is a text item
turned -90°. WordCraft's graphic text item now carries that angle, and the
text is laid out along its box and drawn turned about the box's center.
Scatter series saved in a .json document or a recovery snapshot before
series formatting existed have no `noLine` value. They now read as markers
without a line, as they were drawn when saved.
* Charts: draw opened ODT scatter charts without lines
The ODF reader at this craft-libs commit does not read a scatter chart's
line setting, so a scatter chart saved as ODT and opened again was drawn
with lines between its points. The ODF writer writes every scatter series
as markers without a line, and the opened chart is now drawn that way.
* Charts: set scatter series to markers only for opened ODF files alone
Opened ODT, OTT and FODT files set their scatter series to markers
without a line, since the ODF reader does not read a series' line
setting. Other formats that go through the same import path keep their
series as read. A series that arrives with its markers turned off gets
them back, as Change Chart Type does, so it is still drawn.
The test for an opened scatter chart now also covers flat ODT, checks
the drawn items against the markers-only drawing, and checks that the
chart's paragraph is still written as read.
* Dependencies: take craft-libs main at 453b0da782
Every craft-libs dependency, and the craft-proof note in Cargo.toml,
moves from 3af2280ee3 to 453b0da782. Cargo.lock adds craft-dds, which
craft-image-codecs now uses; no crates.io version changes.
- craft-xls builds its test fixtures only for tests and its
test-support feature, and they return a Result. wordcraft-formats
gets a test-support feature that turns it on; sheet::xls_fixture is
behind it and returns Result, and wordcraft-engine's tests enable it.
- craft_metafile::Picture has new report fields; the render tests'
literals fill them with Default.
- The docx tests follow the writer: the font table is kept as read,
the flat OPC comparison allows a kept part without its XML
declaration, and the bibliography store is related from the main
part, once, after a second save too.
* DOCX: gutter position Top is kept when a document is opened and saved
craft-libs now reads w:gutterAtTop into its settings model instead of
keeping it as unread XML, and WordCraft's settings had no field for it,
so opening and saving a document dropped the setting. Settings gets
gutter_at_top (off by default), which the document bridge carries both
ways. Layout still puts the gutter on the left.
* Charts: Change Chart Type gives a pie chart's value axis the new type's gridlines
A pie or doughnut chart keeps a plain value axis (no gridlines, axis
line on), and a new chart of any other type has gridlines and no axis
line. Change Chart Type kept the old axis, so a pie chart changed to a
column chart was drawn and saved without gridlines and with an axis
line. Change Chart Type between a round chart and another type now sets
the value axis to the new type's when it is still the old type's; an
axis that was changed stays as it is.
The progress log gets a line for the chart formatting, turned axis
titles, picture frame shapes and gutter position this branch brings.
The gutter_at_top doc comment states only what the field holds.
* chore: cut over image codecs and zip to craft-libs, fix main test regressions
* tests: store ODS mimetype and use standard ODF namespaces in mailings test
* Remove unused quick-xml workspace dependency
* fix: use standard ODF namespaces in file_dialogs test and preserve trailing line in markdown import_on_with_lines
* fix(geom): use png_chunks for PNG dimensions and p.fits(budget) in decode_for_drawing
CodeRabbit pointed out that read_line returns InvalidData for bytes that are not UTF-8 while the socket stays open, and the helper treated every non-timeout error as a close. closed_by_peer() now accepts only ConnectionReset, ConnectionAborted, NotConnected and BrokenPipe, and the regression test pins InvalidData, TimedOut and WouldBlock as still open; the new assertion fails without the stricter match.
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
The Windows Print job on #6232 failed in a_silent_connection_is_closed: quiet.closed() only accepted end of stream, but Windows can deliver a close with nothing to read as a reset. The test binary finished in 0.81 s, so it was not the 5 s read timeout. closed_by_peer() now counts a reset, abort, not-connected or broken pipe as closed, and only a read timeout as still open; the new regression test fails before the fix with ConnectionReset. A loaded Windows runner can also take seconds to schedule the connection thread, so the silent test waits up to 20 s and still requires the close within 10 s (the production budget is 30 s).
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
* View: editable Markdown source view for .md files (#5826)
Co-authored-by: oldgranola <marken.john206@gmail.com>
* Address review feedback on Markdown source view
- Fix view.markdownSourceText purity and input validation
- Single-pass block line mapping in markdown parser
- Reuse parsed documents and block line ranges on apply and leave
- Bound memory usage with MAX_SOURCE_BYTES and clamp caret byte offsets
- Isolate temp directories in tests and test caret validation
- Preserve dirty state while markdown text edits are pending
- Flush pending markdown text edits in swap_doc
* Address CodeRabbit review feedback on Markdown source view
- Exempt view.markdownSourceText in command refusal
- Preserve original source line mapping when filtering link definitions
- Map between egui char indices and byte-offset caret in history and undo
* Remap block line numbers in a single linear pass
* Refuse over-limit Markdown Source edits to prevent document truncation
* Keep a Markdown file's own text when it is opened from handed-over bytes
`file.open` kept a Markdown file's exact text only for path-backed opens, so a
platform that hands the bytes over (data) lost front matter, comments and the
author's line endings on the first save, and the rewritten flag could not say
so. The kept text now comes from the same bytes `read_document` decodes, still
bounded by MAX_SOURCE_BYTES through FileText::from_bytes; the path read stays
for opens without data.
---------
Co-authored-by: oldgranola <marken.john206@gmail.com>
Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
Giving the dialog up cancels the request. If the portal then fails with an
error other than its cancellation code, the worker opened the rfd dialog even
though nothing was waiting for the answer, leaving an unwanted Save dialog on
screen. The fallback now checks this request's cancellation token first.
An abandoned portal request finishing late cleared the token of a newer
request in the shared slot, which left the newer Save dialog uncancellable.
Each arming now carries an identity and only its owner clears the slot; a
regression test arms two requests and disarms the older one.
- Recognize the XDG document portal mount inside a Flatpak sandbox
(`/run/flatpak/doc/`), so a changed extension reopens the dialog for the
overwrite confirmation like the host mount does.
- Give the portal SaveFile request a real cancellation path: the CancelToken is
armed before the waiting thread starts and cancelled when the system dialog is
given up (File > Open > Browse in WordCraft...). The request closes and the
answer reads as a cancel, so a portal that stops answering cannot keep Save As
stuck; a late cancel after the answer is ignored.
- Map the cancellation error to a cancelled dialog instead of the rfd fallback.
- Regression tests for the Flatpak mount, the CancelHandle arm/cancel/disarm,
and the UI calling the host's cancel hook when the dialog is given up.
Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
The deb and rpm only recommend the X11 libraries, and the release tarball
doesn't install them. When the display-server choice (#2184) or
WORDCRAFT_WAYLAND=0 asked for XWayland without them, the app failed to
start: winit panicked in xkbcommon-dl without libxkbcommon-x11 (seen on
Fedora 44 and Ubuntu 26.04).
uses_x11 now also takes a check of the libraries winit's X11 backend opens
(libX11, libXcursor, libX11-xcb, libXi, libxkbcommon-x11), asked only when
X11 would be forced. If any is missing, X11 isn't forced and the log line
names them. The packages now also recommend libX11-xcb and
libxkbcommon-x11, and the README lists the libraries XWayland needs.
Tests: missing_x11_libraries_leave_the_app_on_wayland (every way of asking
for X11, and that asking for Wayland doesn't run the check).
Co-authored-by: bmh129 <11478682+bmh129@users.noreply.github.com>
#5441 (92e0e67f) landed a Wayland clipboard size check in `apps/wordcraft/src/clipboard.rs` that left two clippy `-D warnings` failures on main:
- an unused `self` import in the Unix `platform` module (`use wordcraft_ui_egui::paste_picture::{self, ClipboardPicture}`)
- `items_after_test_module`: `platform::picture()` was defined after `mod tests`
This removes the unused import and moves `picture()` above the test module. Behaviour is unchanged.
Local checks: `cargo fmt -p wordcraft` and `cargo clippy -p wordcraft --all-targets --locked -- -D warnings` on Linux.
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
<!-- coderabbit-ai-generated:v1 -->
## Summary by CodeRabbit
* **Refactor**
* No user-visible changes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
* fix(clipboard): size-check a Wayland clipboard picture before it is decoded
* address review: refuse a clipboard PNG the renderer cannot decode within its budget
Moves craft-update, craft-pdf and the krilla patch from storytold/craft-libs
c5a1cbfb to dotCooCoo/craft-libs c7c84230, which is craft-libs main at
0a9d1f48 with storytold/craft-libs#687 and #696 merged in.
- The result window opens whenever the updater's status is not idle: at
the first start after an update it says the version that was installed
or why the update failed, and Help > Check for Updates shows Installing,
Ready and the launcher's choice. A check asked for from the ribbon now
shows the window on the next frame.
- Restart to Update closes the window and asks the app to quit. An update
that asks the app to close quits every window, after asking about each
document with unsaved changes.
- on_exit and the macOS terminate path start the waiting update's helper.
- The update prompt and the result window draw their words through the
interface catalog.
The web shell queues the page's calls as control requests (the channel the desktop control server uses) and answers them on the next frame. The API is installed in every mode; opening, saving, the file name and the unsaved flag stay with the host messages.
A Word template (.dotx, .dotm, .dot) the platform hands the app, from a
double-click in the file manager, the command line or the Finder, opened
as itself: the window called it saved, AutoSave was on, and Ctrl+S wrote
over the template. Word's default verb for a template makes a new,
untitled document based on it.
WordApp::open_from_platform sends a Word template to file.newFromTemplate
and opens anything else as File > Open does; main.rs (also for a name that
isn't valid Unicode) and the Apple Events handler use it.
file.newFromTemplate reads the template as file.open reads a file
(password, data, an empty file) and, with replaceBlank, takes an untouched
blank document's place, so a launch shows one window. The Password box
retries the command that asked for it, so a protected template still
starts a new document. File > Open and drops still open a template itself.
Claude-Session: https://claude.ai/code/session_01LvG6E1XTfHtZDbfYwfREhR
Co-authored-by: Filip Strajnar <filip.strajnar@proton.me>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Martin Ball <martin.ball@ucscaregroup.co.uk>
* Linux: ignore an AppImage environment inherited from another program (#5653)
An AppImage app that opens a document through xdg-open passes its APPIMAGE,
APPDIR, ARGV0 and OWD on to the WordCraft it starts. The self-update trusts
APPIMAGE, so an installed WordCraft replaced the other app's file with its own
AppImage.
The app now starts over without those variables, first thing in main, unless
its executable is under APPDIR. The update then goes through the package or
plain file this copy really is, and a real AppImage keeps its variables.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LvG6E2QwHfTULQtWYgVEXk
* #5653 review: turn the self-update off when starting over fails
If the process can't start again without another program's AppImage
variables, it still carries APPIMAGE, and an accepted update would replace
that program's file. The app now turns its self-update off for that
process: no update is offered, and Help > Check for Updates says why. The
app still opens, so the document the user asked for isn't lost.
Also documents the test helpers.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LvG6E2QwHfTULQtWYgVEXk
---------
Co-authored-by: Filip Strajnar <filip.strajnar@proton.me>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Martin Ball <martin.ball@ucscaregroup.co.uk>
* M14: keep native CLI input names after options
* docs(M14): clarify native CLI path option exceptions
Qualify the roadmap summary and history: text option values need Unicode, while run --file and run --script retain native paths. Addresses review4485129728. Documentation only; no CLI behavior changes.
* docs(M14): qualify Unicode values in format parity notes
Exclude the existing run --file and run --script native path operands from the text option Unicode requirement. Addresses review4485129728; documentation only.
* docs(M14): qualify Unicode values in CLI gap notes
Document the existing native path exceptions for run --file and run --script. Completes the three-file wording correction requested in review4485129728, without changing readiness estimates or CLI behavior.
---------
Co-authored-by: Martin Ball <martin.ball@ucscaregroup.co.uk>
* #5710: the Print panel lists printers without asking their drivers
On Windows the printer list waited until every printer's driver said
whether it prints on both sides. A networked printer in power save can
hold that query for a long time, so the list stayed empty and Refresh
stayed unavailable. WordCraft never used the answer.
Discovery now uses craft-print's printer_queues, which lists the same
queues and default without asking any driver (storytold/craft-libs#618).
Printing still checks the job's options with the driver. Only the
craft-print pin moves; craft-ui doesn't depend on it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* #5710: the docs say what is proven, not that the sleeping printer is fixed
Review: the progress log and gap rows stated the reported outcome as
certain, but the sleeping network printer hasn't been retested. They now
say the driver query is removed and the reported printer awaits retest.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* #5710: craft-print pin moves to the merge of storytold/craft-libs#618
e653048 is craft-libs main's merge of #618; crates/print is identical
to the reviewed and tested head 81c2488.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* #5710: a print job waiting on its driver can be cancelled, and quitting doesn't wait for it
On Windows a print job asks the printer's driver for its capabilities
before it is sent, and a networked printer in power save can hold that
query for a long time. The Print page stayed locked until the driver
answered, and quitting waited for the job before saving preferences
(CodeRabbit on #5732).
Each job now carries a craft-print Cancel token. Cancel printing
(ui.printCancel) stops a job that hasn't started reaching the spooler,
so it is never sent, and frees the Print page with the settings kept;
a job already being sent completes, and the page says to cancel it
from the system's queue. Quitting cancels jobs still waiting and waits
only for jobs already being sent.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* #5710: quitting cancels every waiting print job before it waits; Cancel asks the active job
Review: quitting cancelled and waited for jobs one by one, so a job left
waiting while an earlier one was being sent could start sending
meanwhile. Every job is now cancelled first, then only those already
being sent are waited for. Cancel printing asked every unfinished job,
so a job that had just been sent could be reported as cancelled and its
receipt lost; it now asks the job being submitted, which answers that it
was already sent.
The tests cover both orders, junk parameters for ui.printCancel, and the
kept printer list and status message.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* #5710: craft-print pin moves to storytold/craft-libs#622 for submit_cancellable
85c8ca1 is #622's head (craft-libs main e653048 plus the Cancel token);
it moves to #622's merge on craft-libs main before this merges.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* #5710: craft-print pin follows storytold/craft-libs#622 (230d522)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* #5710: pin craft-print to merged cancellation fix
* #5710: allow print cancellation after closing the document
* #5710: correct print-cancellation status date
* #5710: clarify when a print job cannot yet be cancelled in the queue
* #5710: isolate Windows print submissions in cancellable helper processes
* #5710: strengthen helper retry and crash-cleanup regressions
* #5710: erase helper inputs before driver work
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>