From ae2d2b43d694885d57e65889c0b35545bd6095ef Mon Sep 17 00:00:00 2001 From: Mex <44814932+MMexicann@users.noreply.github.com> Date: Tue, 17 Nov 2026 01:03:22 +0100 Subject: [PATCH] M3: describe the 32-bit comment identifier limit (#6696) --- crates/engine/src/cmd/review.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/crates/engine/src/cmd/review.rs b/crates/engine/src/cmd/review.rs index f0539f0a1c..d2a8724bd7 100644 --- a/crates/engine/src/cmd/review.rs +++ b/crates/engine/src/cmd/review.rs @@ -28,12 +28,12 @@ pub fn specs() -> Vec { vec![ CommandSpec::new("review.newComment", "New Comment", "Review › Comments", new_comment).key(super::mac_or("Mod+Alt+A / Mod+Alt+M", "Mod+Alt+M")).params(r#"{"text": string}"#), CommandSpec::new("review.reply", "Reply", "Review › Comments", reply) - .params(r#"{"id": non-negative JSON integer, "text": string}"#) + .params(r#"{"id": non-negative 32-bit JSON integer, "text": string}"#) .when(comments_change), CommandSpec::new("review.editComment", "Edit Comment", "Review › Comments", edit_comment) - .params(r#"{"id": non-negative JSON integer, "text": string}"#) + .params(r#"{"id": non-negative 32-bit JSON integer, "text": string}"#) .when(comments_change), - CommandSpec::new("review.deleteComment", "Delete", "Review › Comments", delete_comment).params(r#"{"id"?: non-negative JSON integer (omit to use the caret), "all"?: bool}"#), + CommandSpec::new("review.deleteComment", "Delete", "Review › Comments", delete_comment).params(r#"{"id"?: non-negative 32-bit JSON integer (omit to use the caret), "all"?: bool}"#), CommandSpec::new("review.resolveComment", "Resolve", "Review › Comments", |s, v| { validate_comment_id(v)?; let id = p::u64(v, "id").map(|x| x as u32).or_else(|| comment_at_caret(s)).ok_or_else(|| CmdError::Params("`id` required".into()))?; @@ -41,7 +41,7 @@ pub fn specs() -> Vec { c.resolved = p::bool(v, "value").unwrap_or(!c.resolved); sel_result(s) }) - .params(r#"{"id"?: non-negative JSON integer (omit to use the caret), "value"?: bool (omit to toggle)}"#), + .params(r#"{"id"?: non-negative 32-bit JSON integer (omit to use the caret), "value"?: bool (omit to toggle)}"#), CommandSpec::new("review.nextComment", "Next", "Review › Comments", |s, _| nav_comment(s, 1)).pure(), CommandSpec::new("review.previousComment", "Previous", "Review › Comments", |s, _| nav_comment(s, -1)).pure(), CommandSpec::new("review.comments", "Show Comments", "Review › Comments", list_comments).pure(),