From b93a182ef75b9717cdd1d361d5296f5f5088c2ee Mon Sep 17 00:00:00 2001 From: Mex <44814932+MMexicann@users.noreply.github.com> Date: Thu, 5 Nov 2026 00:11:18 +0100 Subject: [PATCH] test(engine): cover non-string stem output formats Exercise null, numeric, boolean, array and object format values through Engine::execute and verify the parameter error without creating a destination. The regression fails before the guard; all 363 engine unit tests pass with it. --- crates/engine/src/cmd/file/tests.rs | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/crates/engine/src/cmd/file/tests.rs b/crates/engine/src/cmd/file/tests.rs index 018952eb..35c821d8 100644 --- a/crates/engine/src/cmd/file/tests.rs +++ b/crates/engine/src/cmd/file/tests.rs @@ -135,6 +135,29 @@ fn bounce_stems_rejects_unsupported_formats_before_writing() { assert!(!created_output, "an unsupported format must not create the output directory"); } +#[test] +fn bounce_stems_rejects_non_string_formats_before_writing() { + let dir = std::env::temp_dir().join(format!("sc-stems-format-type-{}", std::process::id())); + std::fs::create_dir(&dir).unwrap(); + let mut e = Engine::default(); + e.execute("track.new", &json!({"count": 1, "name": "Tone", "format": "mono"})).unwrap(); + let results: Vec<_> = [json!(null), json!(123), json!(false), json!([]), json!({})] + .into_iter() + .enumerate() + .map(|(index, format)| { + let stems = dir.join(index.to_string()); + let result = e.execute("file.bounce_stems", &json!({"dir": stems, "format": format, "start": 0, "end": 1})); + (result, stems.exists()) + }) + .collect(); + std::fs::remove_dir_all(&dir).unwrap(); + for (result, created_output) in results { + let err = result.map(|_| ()).unwrap_err(); + assert!(err.to_string().contains("`format` must be a string"), "{err}"); + assert!(!created_output, "a non-string format must not create the output directory"); + } +} + #[test] fn bounce_refuses_formats_it_cannot_write() { let mut e = Engine::default();