From 1483dc833b8caf3bb137ca6430a84f5c6ded2b90 Mon Sep 17 00:00:00 2001 From: NetterSilver <133535268+Silvertree2010@users.noreply.github.com> Date: Wed, 11 Nov 2026 15:05:23 +0100 Subject: [PATCH] Fix AutomationLane::value_at overflow between extreme opposite-sign points (#1444) Found while testing crates/model/src/automation.rs:~161 (AutomationLane::value_at) Co-authored-by: Claude Haiku 5.5 --- crates/model/src/automation.rs | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/crates/model/src/automation.rs b/crates/model/src/automation.rs index a46dc47a..7bf7d2bd 100644 --- a/crates/model/src/automation.rs +++ b/crates/model/src/automation.rs @@ -164,7 +164,10 @@ impl AutomationLane { // Widen so far-apart breakpoints cannot overflow i64. let span = i128::from(b.at) - i128::from(a.at); let off = i128::from(at) - i128::from(a.at); - a.value + (b.value - a.value) * (off as f64 / span as f64) as f32 + // Interpolate in f64: the f32 difference overflows for + // opposite-sign values near f32::MAX. + let (av, bv) = (f64::from(a.value), f64::from(b.value)); + (av + (bv - av) * (off as f64 / span as f64)) as f32 } (Some(a), _) => a.value, _ => default, @@ -281,6 +284,17 @@ mod tests { assert!(w.is_finite() && (-10.0..=0.0).contains(&w)); } + #[test] + fn value_at_opposite_sign_extremes_stays_finite() { + let mut l = AutomationLane::new(AutoParam::Plugin { slot: 0, param: "Cutoff".into() }); + l.set_point(0, -3.0e38); + l.set_point(1000, 3.0e38); + let v = l.value_at(500, 0.0); + assert!(v.is_finite() && v.abs() < 1.0e32, "mid value {v}"); + let w = l.value_at(1, 0.0); + assert!(w.is_finite() && w < -2.9e38, "early value {w}"); + } + #[test] fn pan_label_max_does_not_overflow() { assert_eq!(AutoParam::Pan(255).label(), "pan 256");