4 people 437cd7f0fe fix: brush hints keep a feathered mask's ring and the effects' reach (#9329) (#10104) ...

* fix: brush hints keep a feathered mask's ring and the effects' reach (#9329)

A command's damage hint (the bare dab) was intersected with the edit's
own damage, which `tile_damage` had grown by the mask's feather and the
layer's and enclosing groups' effects. The intersection cut that growth
off, so painting on a feathered layer mask left a stale soft ring around
each dab, and a dab's drop shadow was outside the reported damage.

`hint_damage` now grows the hint by the same rule first (`grow_hint`,
sharing `grow_in_layer` and `effects_reach` with `tile_damage` and the
group walk). The hint is still checked against the changed tiles as is.

The group-shadow test now cuts a hole at a tile's right edge, so its
shadow crosses into the next tile (it passed without the group's growth
before), and the clip-base test gains a dab at a tile edge.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* fix: brush hints skip the effects of layers that aren't drawn (#9329)

`grow_hint` grew a dab by the effects of every layer in the document,
hidden ones included, so a large drop shadow on a hidden layer widened
every `paint.stroke` dab elsewhere to all the tiles `step_damage`
reported, and each dab recomposited and uploaded that much.

It now skips layers the compositor skips, by the same rule as
`effect_layers`: a hidden layer, a clipped layer over a hidden base, and
everything inside a hidden group. A change there shows nowhere, and
every drawn layer still grows the hint as before.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* test: the group-shadow brush test goes through the hint (#9329)

`a_dab_inside_a_group_with_a_drop_shadow_damages_the_shadow` painted
with a plain `Session::edit`, so its damage came from `step_damage` and
never exercised `grow_hint`. It now paints with `paint.stroke`, and the
child carries a shadow of its own inside the shadowed group: the group's
shadow of the child's shadow lands past either shadow's reach alone, in
the next tile, so dropping the enclosing groups' reach from `grow_hint`
fails it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
Co-authored-by: FredApps <FredApps@users.noreply.github.com>

2026-11-09 16:36:58 +01:00

..

actions_duplicate.rs

Limit Actions panel changes to the five reviewed commands

2026-11-05 17:13:15 -08:00

actions_panel_menu.rs

Scope Actions tool recording guard to the active take

2026-11-06 13:40:05 -08:00

actions_record_again.rs

Limit Actions panel changes to the five reviewed commands

2026-11-05 17:13:15 -08:00

actions_single_history.rs

feat(frame): rework the Frame tool's selection, handles and placement (#8920)

2026-11-05 12:39:02 +01:00

affinity.rs

fix(io, engine): Embed Color Profile writes sRGB for an untagged document (#9325)

2026-10-24 22:40:40 -06:00

artboard_export_names.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

atn_adjustment_make_props.rs

Port #8659: keep name, blend mode and clipping on adjustment-layer Make steps

2026-11-05 04:35:32 +01:00

atn_calculations.rs

fix: retain group canvas transparency after ATN integration

2026-11-02 14:36:08 -08:00

atn_classic_gradient.rs

Remove the unused Gradient integration test import

2026-11-03 19:57:59 -08:00

atn_color_lookup.rs

Preserve DDS subresources and recorded filter representations

2026-11-04 17:12:28 -08:00

atn_content_aware_fill.rs

Fix-up #10986 with #10965: a play that changes nothing adds no history entry

2026-11-04 15:45:35 +01:00

atn_crystallize_cell_size.rs

Reuse large buffers so returning freed memory to the OS doesn't slow filters (#10479) (#10514)

2026-11-02 09:29:59 +01:00

atn_dialog_filters.rs

Preserve DDS subresources and recorded filter representations

2026-11-04 17:12:28 -08:00

atn_direct_adjustments.rs

Batch 13: settle the overlaps between the batched PRs

2026-11-03 01:04:44 +01:00

atn_layer_style.rs

Test ATN layer style playback in both history modes

2026-11-03 19:22:21 -08:00

atn_newer_events.rs

Merge current main while preserving recorded Batch safeguards

2026-11-04 10:47:01 -08:00

atn_perspective_warp.rs

style(actions): apply Perspective Warp formatter

2026-11-05 08:40:04 -08:00

atn_reference_forms.rs

Integration: group-end layer index fails, ordinal precondition resolves once (#10753)

2026-11-02 02:17:31 +01:00

atn_review_regressions.rs

Address CodeRabbit review: batch 17 findings

2026-11-05 11:37:38 +01:00

atn_ripple_amount.rs

Reuse large buffers so returning freed memory to the OS doesn't slow filters (#10479) (#10514)

2026-11-02 09:29:59 +01:00

atn_selective_color.rs

Reuse large buffers so returning freed memory to the OS doesn't slow filters (#10479) (#10514)

2026-11-02 09:29:59 +01:00

atn_shape_blur.rs

Address CodeRabbit review: batch 17 findings

2026-11-05 11:37:38 +01:00

atn_shear.rs

Bound Shear action curves and preserve native precision

2026-11-02 18:26:17 -08:00

atn_stack_modes.rs

Keep unknown Stack Mode None descriptors inert

2026-11-05 12:57:30 -08:00

atn_stroke_width.rs

Reuse large buffers so returning freed memory to the OS doesn't slow filters (#10479) (#10514)

2026-11-02 09:29:59 +01:00

atn_type_path.rs

Document Type Work Path mapping and regression oracles

2026-11-03 22:06:23 -08:00

atn_v12.rs

Integration: track the v12 .atn fixtures and sniff v12 in the CLI (#10743)

2026-11-02 02:09:41 +01:00

atn_video_frames.rs

Handle edited Stack Modes and cap video frame growth

2026-11-05 08:48:40 -08:00

average_smart.rs

Execute Average through the shared smart-filter pipeline

2026-10-24 00:38:17 -07:00

background_and_mask_depth.rs

feat(frame): rework the Frame tool's selection, handles and placement (#8920)

2026-11-05 12:39:02 +01:00

background_layer_consistency.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

brush_smoothing.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

camera_raw_exposure_clamp.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

camera_raw_noise_clamp.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

canvas_artboard_crop.rs

Address CodeRabbit review: batch 17 findings

2026-11-05 11:37:38 +01:00

clipping_semantics.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

close_document.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

command_lookup.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

convert_keeps_references.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

copy_shape_placement.rs

Fix pasted shape group bounds and effects across documents (#8992)

2026-10-23 17:54:26 -04:00

corpus_atn.rs

Merge upstream consolidated integration test layout

2026-10-22 14:41:05 -04:00

crop_content_aware_layers.rs

Batch 18 (CodeRabbit nitpicks): crop test checks the active layer's covered pixels; Esc test goes through the shortcut handler

2026-11-06 04:04:26 +01:00

crop_content_aware.rs

Integration: a straight Content-Aware crop fills over hidden pixels (#8179)

2026-10-25 14:35:33 +01:00

crop_delete_off_background.rs

Reveal All's crop passes the session gate; Crop doc names the Content-Aware exception (#10867)

2026-11-03 00:32:25 +01:00

current_affinity_artboards.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

duplicate_layer_comps.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

duplicate_slices.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

duplicate_variables.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

empty_selection_combine.rs

perf(selection): combine marquee additions and subtractions sparsely

2026-10-27 12:15:33 +05:30

eraser_locked.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

explicit_layer_target.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

export_shape_strokes.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

fill_lock_transparency.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

filter_locked.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

finite_command_params.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

flatten_background.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

gallery_colours.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

gauss_small_sigma.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

gradient_overlay_strokes.rs

fix: brush hints keep a feathered mask's ring and the effects' reach (#9329) (#10104)

2026-11-09 16:36:58 +01:00

guide_layout_limit.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

guide_layout_preview.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

hdr_gamma_direction.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

huge_doc_flatten.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

integration_batch.rs

Format the acceptance tests

2026-10-24 02:33:02 -03:00

jpeg_exif_resolution.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

keyboard_shortcut_bulk.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

kra.rs

Keep tests correct and docs current with one test binary per crate

2026-10-22 16:55:34 +00:00

kys_import.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

layer_delete_last.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

layer_mask_depth.rs

Layers: a new fill or adjustment layer drops the selection it took as mask (#8801)

2026-10-23 10:05:10 +02:00

layer_props_several.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

layer_range_panel_order.rs

Merge origin/main into pr-4329-fixup

2026-10-27 15:22:03 +01:00

live_line_transform.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

main.rs

Merge remote-tracking branch 'origin/main' into pr-9077

2026-11-08 03:04:43 +01:00

mask_lock_all.rs

Integration: refuse Paste Into a Lock-All group before pasting (#6352)

2026-10-22 20:52:59 +02:00

merge_transparent_bounds.rs

Layers: a new fill or adjustment layer drops the selection it took as mask (#8801)

2026-10-23 10:05:10 +02:00

missing_layer_error.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

nonfinite_style.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

open_identity.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

path_blur_speed_clamp.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

path_transform_target.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

pdn.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

photoshop_oracles.rs

Reuse large buffers so returning freed memory to the OS doesn't slow filters (#10479) (#10514)

2026-11-02 09:29:59 +01:00

pixel_lock_edits.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

precheck.rs

Tests: spread three format-by-geometry matrices over the days, and build one precheck state per case

2026-10-23 08:30:48 +00:00

prefs_usage.rs

Preferences: show Effect Cache, which the engine reads (#204)

2026-11-03 18:46:28 +01:00

rasterize_psd_reopen.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

rasterize_selected_layers.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

rendering_preferences.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

save_keeps_encoding.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

selection_layer_commands.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

shortcut_sets.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

shortcuts_headless.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

smart_clipboard_sources.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

smart_duplicates.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

smart_filter_canvas_geometry.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

smart_object_tones.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

smart_psd.rs

fix(io): import a Displace smart filter that names its map file without embedding it (#9162)

2026-10-25 18:09:08 +03:00

style_and_align.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

svg_smart_object.rs

Web build: Place runs a slice per frame, so a large PNG no longer freezes the page (#10164, rebased onto main)

2026-11-06 08:51:17 +05:30

transform_budget_unclamped.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

type_format_targets.rs

perf: a pixel change damages only the tiles that changed; command rects become checked hints (#9329)

2026-10-27 23:09:58 -07:00

type_postscript_font.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

undo_keeps_active_layer.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

unicode_colors.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

unsupported_smart_filters.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

wand_transparent_copy.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

working_rgb_profile.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00

xmp_charref.rs

Build each crate's integration tests as one binary

2026-10-22 16:55:34 +00:00