mroxsoandhighperfocused 57d488032c fix(doc): variable definitions follow layer id remapping on copy and load (#5023) ...

* fix(doc): variable definitions follow layer id remapping on copy and load

A duplicated document (image.duplicate, history.newDocument) or a .pcraft
loaded with remapped ids assigned fresh layer ids but cloned VariableDef.layer
unchanged, so datasets silently drove no layer (or, after remap, a colliding
one). Remap variable targets through the same id map as layer comps and
slices; a dangling target keeps a non-colliding placeholder. A merged-only
duplicate drops the whole variable binding set, matching how it drops comps.

Closes #4969

* style: cargo fmt duplicate_variables test

---------

Co-authored-by: highperfocused <highperfocused@pm.me>

2026-10-14 15:02:43 -07:00

..

adjust_cmds

Layer masks: Reveal Selection drops the selection, as Photoshop does (#5251)

2026-10-14 01:59:27 -04:00

analysis_cmds

Fix/scale marker rollback layer state 4975 (#5391)

2026-10-14 12:45:36 -04:00

artboard_cmds

feat(ui): Photoshop's New Guide: units and colour (#3553)

2026-10-12 00:46:56 -04:00

atn_cmds

Map .atn duplicate-into-new-document (Mk) to layer.duplicate (#5371)

2026-10-14 12:45:11 -04:00

automate_cmds

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

brush_cmds

Brush Settings: a response curve per dynamic control (#3294) (#3302)

2026-10-14 14:09:39 -04:00

canvas_geom

…

channel_clip

Keep channel pastes transactional when pixel allocation fails. (#4588)

2026-10-14 12:44:47 -04:00

channel_cmds

Channels: clicking RGB hides the alpha channel overlay (fixes #4538) (#4564)

2026-10-13 00:37:42 -04:00

comps_cmds

Layer Comps: the warning icon clears only its own comp (#4197) (#4198)

2026-10-12 21:17:06 -04:00

distort_cmds

Puppet Warp: a linked layer mask moves with the pixels (#4910) (#4989)

2026-10-13 12:48:02 -04:00

edit_menu_cmds

Preserve document and history when Fade cannot allocate its buffers. (#4593)

2026-10-13 12:46:10 -04:00

eraser_cmds

…

file_cmds

Batch: Include All Subfolders (AUTO-219-5, #3753) (#3758)

2026-10-14 14:08:20 -04:00

filters

…

filters_ext

Fibers: fill an empty layer, as Photoshop does (#5241) (#5289)

2026-10-14 01:59:00 -04:00

float_cmds

…

gallery_cmds

…

gradient_fill_cmds

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

layer_copy_cmds

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

layer_label_cmds

…

layer_mask_props_cmds

perf: edits, undo and redo recomposite only where added or removed layers draw (#3847)

2026-10-12 08:47:05 -04:00

layer_menu_cmds

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

magnetic_cmds

…

mask_view_cmds

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

mode_cmds

Bitmap mode: validate the halftone screen angle (#4214) (#4215)

2026-10-12 21:17:49 -04:00

multichannel_cmds

…

plugin_cmds

…

prefs

Arrow-key nudges: a run of nudges is one History state, with Tools preferences (#2259) (#2764)

2026-10-14 15:32:39 -04:00

preset_store

Brushes: a New Brush Preset dialog for every way of making a preset (#4490) (#4563)

2026-10-13 00:58:50 -04:00

presets

Export As: exact pixel size, named presets, and profile options (#5344)

2026-10-14 15:17:44 -04:00

print_cmds

Merge current main while preserving native printing and system printer menus

2026-10-13 21:18:34 +02:00

rasterize_style_cmds

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

retouch_cmds

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

slice_cmds

…

smart_cmds

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

swatch_cmds

Swatches: importing an .ase file numbers repeated group names in linear time (#5087)

2026-10-13 12:47:17 -04:00

symmetry_cmds

…

type_extra_cmds

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

type_styles_cmds

…

variables_cmds

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

vector_cmds

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

video_cmds

fix: limit Render Video timeline and GIF staging allocations (#5670)

2026-10-14 15:02:17 -07:00

web_cmds

Save for Web: no matte by default, as Photoshop's scripted export (#4115) (#4578)

2026-10-12 23:52:16 -04:00

actions_cmds.rs

feat(actions): add Button Mode on the current Actions model (#5213)

2026-10-14 13:47:27 -04:00

actions_edit_cmds.rs

Map Place, Open, Image Size in percent, the Paint Bucket and Insert Conditional (#219) (#4470)

2026-10-12 19:12:35 -04:00

adjust_cmds.rs

Replace Color: Localized Color Clusters (points, localized, range) (#4477)

2026-10-13 12:47:47 -04:00

adjust_params.rs

Brush: remember the last selected brush across restarts (split from #2516) (#3472)

2026-10-13 12:48:41 -04:00

align_cmds.rs

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

allocation.rs

Free Transform: refuse outputs over a pixel budget instead of building them (#4293)

2026-10-12 21:27:12 -04:00

analysis_cmds.rs

Fix/scale marker rollback layer state 4975 (#5391)

2026-10-14 12:45:36 -04:00

artboard_cmds.rs

feat(ui): Photoshop's New Guide: units and colour (#3553)

2026-10-12 00:46:56 -04:00

atn_cmds.rs

Map .atn duplicate-into-new-document (Mk) to layer.duplicate (#5371)

2026-10-14 12:45:11 -04:00

automate_cmds.rs

Load Files into Stack: Photoshop's dialog with a Source Files list and the align option (#4671, #4696) (#4705)

2026-10-12 23:54:15 -04:00

background_cmds.rs

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

brush_cmds.rs

Brushes: import an image file as a brush tip (#3279) (#3292)

2026-10-14 14:09:08 -04:00

brush_key_cmds.rs

feat: Photoshop's tool keys (arrows turn the brush, Shift-click new type, Space+F canvas colour) (#3725)

2026-10-12 09:17:43 -04:00

brush_preset_cmds.rs

Brush: remember the last selected brush across restarts (split from #2516) (#3472)

2026-10-13 12:48:41 -04:00

build_info.rs

…

canvas_geom.rs

…

channel_clip.rs

Keep channel pastes transactional when pixel allocation fails. (#4588)

2026-10-14 12:44:47 -04:00

channel_cmds.rs

Channels: keep the cached composite across view-only changes (#4915)

2026-10-13 12:45:56 -04:00

clip_group.rs

Layers: clip groups follow New Layer, Arrange, Reorder and Delete (#2203) (#3090)

2026-10-11 17:43:30 -04:00

color_cmds.rs

Profile prompts on open: one file at a time, before it opens, and the answer goes to that file (#3471)

2026-10-13 13:10:04 -04:00

color_to_alpha_cmds.rs

fix(layers): identify the Background by structure, never by its English name (#4036)

2026-10-12 07:04:33 -04:00

commands.rs

Export As: exact pixel size, named presets, and profile options (#5344)

2026-10-14 15:17:44 -04:00

comps_cmds.rs

Layer Comps: the warning icon clears only its own comp (#4197) (#4198)

2026-10-12 21:17:06 -04:00

crop_fill.rs

Crop tool: Content-Aware fill of the area a rotated or extended crop uncovers (#3823) (#3827)

2026-10-14 15:15:15 -04:00

cutout_cmds.rs

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

display_color_tests.rs

perf: encode and quantize canvas pixels in parallel (display_color, Buffer::to_rgba8) (#4768)

2026-10-13 12:47:55 -04:00

display_color.rs

perf: encode and quantize canvas pixels in parallel (display_color, Buffer::to_rgba8) (#4768)

2026-10-13 12:47:55 -04:00

distort_cmds.rs

Puppet Warp: a linked layer mask moves with the pixels (#4910) (#4989)

2026-10-13 12:48:02 -04:00

document_preset_cmds.rs

New Document: a real Recent category of recently created documents (#3131) (#3135)

2026-10-11 22:17:17 -04:00

edit_cmds.rs

feat(ui): select guides, the guide context menu and Edit Selected Guides (#3734)

2026-10-14 15:17:10 -04:00

edit_menu_cmds.rs

Preserve document and history when Fade cannot allocate its buffers. (#4593)

2026-10-13 12:46:10 -04:00

eraser_cmds.rs

Paint Bucket and Gradient: validate opacity like the Magic Eraser (#4167) (#4168)

2026-10-12 20:37:47 -04:00

export_preset_cmds.rs

Export As: exact pixel size, named presets, and profile options (#5344)

2026-10-14 15:17:44 -04:00

exr_cmds.rs

EXR: an unnamed part can be opened by the name the part list gives it (#4210) (#4211)

2026-10-12 21:17:45 -04:00

extra_cmds.rs

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

file_cmds.rs

Batch: Include All Subfolders (AUTO-219-5, #3753) (#3758)

2026-10-14 14:08:20 -04:00

fill_cmds.rs

Crop tool: Content-Aware fill of the area a rotated or extended crop uncovers (#3823) (#3827)

2026-10-14 15:15:15 -04:00

fill_key_cmds.rs

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

fill_layer_mode_tests.rs

Color: Dot Gain 20%-compatible default working gray, as in Photoshop (#4610)

2026-10-13 02:45:09 -04:00

filters_ext.rs

feat(io): import Photoshop Displace smart filters with their embedded map (#3680)

2026-10-12 06:28:55 -04:00

filters.rs

Layer masks: Reveal Selection drops the selection, as Photoshop does (#5251)

2026-10-14 01:59:27 -04:00

flatten_cmyk_tests.rs

Keep CMYK ink values when flattening and merging (#3855)

2026-10-12 08:33:50 -04:00

float_cmds.rs

History: jump to a state in one step (history.selectState) (#2966) (#3533)

2026-10-13 12:48:26 -04:00

frame_cmds.rs

Frame tool: take type, shape and smart object layers into the frame (#4435) (#4441)

2026-10-14 13:06:32 -04:00

fx_mode_tests.rs

…

fx_view_cmds.rs

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

fx_visibility_cmds.rs

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

gallery_cmds.rs

…

gradient_fill_cmds.rs

fix(engine): create new layer masks at the document depth (#3359)

2026-10-11 22:30:26 -04:00

group_view_cmds.rs

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

guide_layout.rs

feat(ui): Photoshop's New Guide: units and colour (#3553)

2026-10-12 00:46:56 -04:00

hidden_target.rs

…

history_cmds.rs

feat(engine): add history.undo and history.redo aliases (#3675) (#3786)

2026-10-12 07:49:26 -04:00

history_select_cmds.rs

History: jump to a state in one step (history.selectState) (#2966) (#3533)

2026-10-13 12:48:26 -04:00

image_cmds.rs

fix(doc): variable definitions follow layer id remapping on copy and load (#5023)

2026-10-14 15:02:43 -07:00

inspect.rs

Expose shared Smart Object instances in inspection and replacement results (#4832)

2026-10-14 12:46:04 -04:00

installed_profiles.rs

…

jobs_tests.rs

Large document: large damage over the GPU budget redraws in the background; open warms layer bounds (#4024) (#5083)

2026-10-14 13:27:58 -04:00

jobs.rs

Large document: large damage over the GPU budget redraws in the background; open warms layer bounds (#4024) (#5083)

2026-10-14 13:27:58 -04:00

kys.rs

Shortcuts: a command can answer a second key (F2/F3/F4, Shift+F7, Cmd++) (#3665) (#3746)

2026-10-14 15:16:43 -04:00

layer_copy_cmds.rs

Layer: Duplicate Layer to a new document, as in Photoshop (#4805)

2026-10-13 12:48:18 -04:00

layer_label_cmds.rs

…

layer_list_cmds.rs

feat(engine): layer.list, a read-only listing of the layer tree (#5059) (#5148)

2026-10-14 12:46:18 -04:00

layer_mask_props_cmds.rs

…

layer_menu_cmds.rs

Global Light: reject angles beyond f32 range instead of storing NaN (#4181) (#4182)

2026-10-12 20:38:05 -04:00

layer_multi_cmds.rs

Actions: record layer selections by name and display the target (#2441)

2026-10-14 12:46:31 -04:00

layer_nav_cmds.rs

…

layer_style.rs

Layer Style: Bevel & Emboss Technique dropdown (#5147) (#5181)

2026-10-14 13:46:51 -04:00

lens_cmds.rs

Camera Raw on raw opens: Clarity, Texture and Dehaze in linear light, measured (#3815)

2026-10-12 08:52:45 -04:00

lib.rs

Export As: exact pixel size, named presets, and profile options (#5344)

2026-10-14 15:17:44 -04:00

link_watch.rs

…

magnetic_cmds.rs

…

mask_view_cmds.rs

…

migrate_cmds.rs

…

mode_cmds.rs

Bitmap mode: validate the halftone screen angle (#4214) (#4215)

2026-10-12 21:17:49 -04:00

multichannel_cmds.rs

…

new_layer.rs

Layers: Cmd/Ctrl-click New Layer adds the layer below the current one (#4475)

2026-10-13 12:47:24 -04:00

notes_cmds.rs

…

paint_cmds.rs

feat(gradients): Photoshop's interpolation method for Gradient Overlay, gradient Stroke and the Gradient tool (#4292)

2026-10-12 21:26:53 -04:00

param_check.rs

Engine: reject unknown params for layer.hideLayers/showLayers via an opt-in registry check (#4336) (#4364)

2026-10-12 22:23:46 -04:00

path_edit_cmds.rs

Curvature Pen: edit finished paths (drag, add, smooth/corner) with an adaptive cursor (#5197)

2026-10-14 15:13:46 -04:00

pattern_cmds.rs

Play real Photoshop action sets: TrueGrit .atn mappings and fixes (#4356, #219) (#4698)

2026-10-13 01:10:58 -04:00

pattern_fill_cmds.rs

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

pattern_mode_tests.rs

…

perspective_crop_cmds.rs

fix(layers): identify the Background by structure, never by its English name (#4036)

2026-10-12 07:04:33 -04:00

photo_cmds.rs

…

pick_cmds.rs

fix(layer-picker): include text bounds in right-click layer list (#4288)

2026-10-12 21:26:49 -04:00

pixels_tests.rs

CMYK: Hue/Saturation and Color Balance keep the black ink (#5000)

2026-10-14 14:12:06 -04:00

pixels.rs

Posterize and Threshold commands use the 16-bit rules on 16-bit layers (#5711)

2026-10-14 15:14:30 -04:00

plugin_cmds.rs

…

prefs.rs

Arrow-key nudges: a run of nudges is one History state, with Tools preferences (#2259) (#2764)

2026-10-14 15:32:39 -04:00

preset_import_cmds.rs

Brushes: import an image file as a brush tip (#3279) (#3292)

2026-10-14 14:09:08 -04:00

preset_store.rs

Brush: remember the last selected brush across restarts (split from #2516) (#3472)

2026-10-13 12:48:41 -04:00

print_cmds.rs

Merge current main while preserving native printing and system printer menus

2026-10-13 21:18:34 +02:00

proof_sim.rs

…

rasterize_style_cmds.rs

…

redeye_cmds.rs

…

render_cmds.rs

…

retouch_cmds.rs

Wrap Clone Stamp strokes and sampling in Pattern Preview (#4997)

2026-10-13 12:48:33 -04:00

sample_cmds.rs

…

sampler_cmds.rs

Color Sampler: keep the CMYK readout in range on 32-bit documents (#4191) (#4192)

2026-10-12 21:17:01 -04:00

select_extra_cmds.rs

Free Transform: refuse outputs over a pixel budget instead of building them (#4293)

2026-10-12 21:27:12 -04:00

selection_cmds.rs

Color Range: sample colours outside the active selection (#5244) (#5296)

2026-10-14 13:06:05 -04:00

slice_cmds.rs

fix(layers): identify the Background by structure, never by its English name (#4036)

2026-10-12 07:04:33 -04:00

smart_cmds.rs

Expose shared Smart Object instances in inspection and replacement results (#4832)

2026-10-14 12:46:04 -04:00

smartselect_cmds.rs

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

snap.rs

…

solid_fill_cmds.rs

…

stamp_cmds.rs

…

swatch_cmds.rs

Swatches: importing an .ase file numbers repeated group names in linear time (#5087)

2026-10-13 12:47:17 -04:00

symmetry_cmds.rs

…

tests.rs

Arrow-key nudges: a run of nudges is one History state, with Tools preferences (#2259) (#2764)

2026-10-14 15:32:39 -04:00

timeline_cmds.rs

fix: limit Render Video timeline and GIF staging allocations (#5670)

2026-10-14 15:02:17 -07:00

transform_cmds.rs

Free Transform: the box is the selection, and the marching ants follow it (#5297) (#5337)

2026-10-14 14:07:42 -04:00

trap_cmds.rs

…

type_caret_cmds.rs

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

type_cmds.rs

Tests: bad-layer-id checks use an id that can't exist (#3343) (#3351)

2026-10-14 01:59:43 -04:00

type_extra_cmds.rs

fix(type): missing-font checks follow layout's PostScript resolution; split hyphenless style suffixes (#608)

2026-10-13 12:48:09 -04:00

type_mask_cmds.rs

…

type_spell_cmds.rs

Type: every text edit respects Lock All (#4188) (#4189)

2026-10-12 21:16:56 -04:00

type_styles_cmds.rs

…

variables_cmds.rs

automation: export layers, data sets and CSVs through the granted roots (#3216) (#3230)

2026-10-11 21:01:26 -04:00

vector_cmds.rs

feat(vector): add shape from selection with simplify tolerance (#214) (#3954)

2026-10-13 00:28:50 -04:00

video_cmds.rs

fix: limit Render Video timeline and GIF staging allocations (#5670)

2026-10-14 15:02:17 -07:00

vp_cmds.rs

Vanishing Point: on-canvas plane editor with Create/Edit Plane, grid and paste (#3122) (#3133)

2026-10-11 22:02:04 -04:00

warp_cmds.rs

Smart Objects Warp: mesh knots span the contents, not the skewed bounding frame (#4113) (#4341)

2026-10-12 21:27:03 -04:00

web_cmds.rs

Save for Web: no matte by default, as Photoshop's scripted export (#4115) (#4578)

2026-10-12 23:52:16 -04:00

wia_cmds.rs

…