mirror of
https://github.com/storytold/photocraft.git
synced 2026-11-21 01:18:43 +00:00
The PR sent ⇧⌥ letters and ⇧+/⇧− to the selected layers whenever the tool has no Mode menu, Dodge, Burn and Sponge included. In Photoshop those keys pick the Dodge/Burn Range (⇧⌥S/M/H) and the Sponge's mode (⇧⌥D/S) and never touch the layer: with Dodge active, ⇧⌥M leaves the layer Normal (the Eraser and the Mixer Brush do set it). So Dodge + ⇧⌥S turned the layer Screen. They ignore the keys, as #5478 had them, until their own Range/mode keys exist. The Healing Brush's brush can hold a mode its short menu lacks: the Brush's Overlay remembered from before it had a Mode menu (restored at launch with the tool active, so no tool switch resets it), a brush preset with tool settings, or tools.setBrush. It then healed in Overlay, while its dropdown showed nothing and the first ⇧+ seemed dead. blend_keys::brush_tool_mode now treats such a mode as Normal for the stroke (clone_params), the dropdown and the keys. Also moves paint_mode_dropdown's doc comment back onto it, and the ui-parity row names the Paint Bucket's Clear. Tests: dodge_burn_and_sponge_leave_the_layer_alone and healing_brush_heals_in_normal_with_a_mode_outside_its_menu and healing_brush_with_a_mode_outside_its_menu_steps_from_normal fail without this change. Co-authored-by: paulou-jpg <79102098+paulou-jpg@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>