Files
photocraft/crates/plugins
David MannandClaude Opus 5.5 ab54aee120 Plug-ins: refuse a manifest that declares a parameter twice (#9441) (#9442)
* Plug-ins: refuse a manifest that declares a parameter twice (#9441)

`ordered_params` kept every entry of the `params` object, so a repeated
key gave one value two dialog controls and the last spec won in
`resolve_params`. Refuse the repeated key with an error naming it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Plug-ins: quote the repeated parameter name in the error (#9441)

The duplicate check runs before validate() checks the name, so a key
with control or bidi characters must not reach the message unescaped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Address CodeRabbit review: a repeated parameter is named before its spec is read

The key was checked after next_entry had parsed the value and after the
64-parameter limit, so a repeated key with a broken second spec, or one
past the limit, reported that error instead of naming the key.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 10:19:07 -04:00
..