mirror of
https://github.com/storytold/photocraft.git
synced 2026-11-11 04:40:31 +00:00
David MannandClaude Opus 5.5
b9613c6caa
Reverts #8039 ("Compose: Extend Softer outer glows past Size (#7899)"), which added a range-scaled fading tail beyond Size to Softer outer glows, on the CPU compositor and the GPU one alike, and widened the effect margin by it. The reference application, measured: Outer Glow, Softer, Size 60, Range 50 % (and 100 % alike), white, Normal, Opacity 100 %, Spread 0, Noise 0, on an opaque white shape over black (240 x 40 document, shape over the left 100 px, full height, sampled at row 20): the glow reads 4 at 50 px from the edge, 1 at 54, and 0 from 56 to 70 px. It reaches zero just before Size; there is no tail beyond it. The reverted code (the two-box tent) gives, in that setup, 8-bit levels 4, 1, 0, 0, 0 at 50/54/56/60/70 px for Range 50 % (unrounded 3.56, 1.20, 0.49, 0, 0) and 2, 1, 0, 0, 0 for Range 100 % (1.78, 0.60, 0.25, 0, 0); #8039's tail lifted 56-62 px above zero. So the revert stays as is, CPU and GPU unchanged from before #8039. Conflicts were formatting-only (later rustfmt of #8039's lines) in compose effects.rs, effects/paint.rs and gpu fx/builders.rs; resolved to the pre-#8039 code. The GlowSource/GlowTechnique imports a later commit kept in gpu fx/tests.rs for #8039's test go with the test. New test softer_outer_glow_fades_out_before_its_size renders that document through the CPU compositor at Range 50 % and 100 % and checks 50 and 54 px within 2 levels and 56, 60 and 70 px at exactly 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>