Commit Graph
2475 Commits
Author SHA1 Message Date
yoriswind faed6b4fb5 fix: capture action dependencies inside explicit Batch steps 2026-11-02 14:46:19 -08:00
funkvay-star 6ae97992c2 Merge upstream/main into feat/levels-reset-clipping
Main moved the adjustment dialogs into dialogs/: the clipping sync call,
levels_drag and the Input slider rect follow them, and targets_channel
now honours the dialog's own target param.
2026-11-03 01:59:39 +04:00
Fabio Lissi 0306fafb9b Preserve active spelling layer in recorded actions 2026-11-02 15:58:29 -06:00
yoriswind 3b22f79b80 fix: preserve Batch references and multi-image sources 2026-11-02 13:40:23 -08:00
FredApps 9eddf1d8ca Pause and retry a failed or full scratch disk instead of turning spilling off
A scratch write or create failure, or a volume about to drop below max(1 GiB, 5%)
free space, now pauses spilling with exponential backoff (1 s doubling to 60 s)
instead of disabling it for the session. Tiles stay resident, set_budget keeps
the latest budget for the resume, preference changes retry at once, and
spill::epoch lets the engine re-apply History's byte limit while paused.
spill::set_size_cap adds an explicit size limit; free space comes from sysinfo's
disk feature.
2026-11-02 22:31:56 +01:00
FredApps 44f13e5498 Scope scratch read failures to the document that holds the tile
One unreadable tile used to block editing, saving and exporting every open document
(spill::check_integrity was process-global). Add Tile/Surface/Document::scratch_health
(free while no tile has failed) and Document::for_each_surface (ops' history walk now
delegates to it). edit_with checks the document before and after, jobs the document they
captured, import the result, save/export the document written; check_since is now
generation-only so a failure or recovery during an operation refuses it once and a retry
works. Caches check their own sources and purge once per new failure instead of every
frame. Fault-injection tests use a duplicated handle (the Unix file has no name).
2026-11-02 22:23:42 +01:00
FredApps 947038d0db Unlink Unix scratch files right after opening
The spill manager is process-global and never dropped, so the Unix scratch file was only
removed by the next launch's reap. Unlink it immediately after opening and read/write
through the one handle with pread/pwrite (readers can no longer reopen it by path).
Windows keeps delete-on-close and per-thread readers. The abrupt-exit test now asserts
that no file remains on every platform; docs/scratch-disks.md updated.
2026-11-02 22:17:50 +01:00
FredApps b0f3c7516b Merge current main into codex/scratch-storage
Resolve conflicts with main's prefs UI split, session/execute.rs move, GPU memory
budget (gpuMemoryMb, 0 = auto, kept from main) and effective_memory_usage_mb history
budget. Port the Memory Usage % and Scratch Disks preferences into prefs_ui, the edit
integrity guard into session/execute.rs, and adapt main's new pixel readers to the
guarded TileBytes API. Cargo.lock regenerated; scorecard regenerated.
2026-11-02 22:16:22 +01:00
midasdf 7f592772c8 Merge remote-tracking branch 'origin/main' into pr
# Conflicts:
#	ROADMAP.md
2026-11-03 05:52:38 +09:00
Fabio Lissi 499f7ab609 Merge upstream main into action recording 2026-11-02 14:44:32 -06:00
Fabio Lissi 2537b927e0 Merge upstream main into batch automation 2026-11-02 14:38:41 -06:00
yoriswind 3d5a42e3bb Merge current main before Batch review repairs 2026-11-02 12:29:16 -08:00
Khawar Zamman Wani 5992650b36 fix: address PSD admission review and enable platform memory consent 2026-11-03 01:26:13 +05:30
Fabio Lissi 50670f9d67 fix: preserve active batch edits and cancellation result 2026-11-02 13:54:58 -06:00
Fabio Lissi 3e52046ed3 docs: clarify recorded layer selection behavior 2026-11-02 13:47:31 -06:00
David Mann 673bfb4d9c Merge remote-tracking branch 'origin/main' into integration-batch-12
# Conflicts:
#	docs/file-format-parity.md
2026-11-02 20:15:23 +01:00
FredApps f8e393fdb6 Merge pull request #6266 from danielmigueltejedor/fix/gnome-window-decorations
Enable font-free GNOME/Wayland controls for system title bars
2026-11-02 19:59:41 +01:00
ljkxandClaude Opus 5.5 7eb54124ea Merge origin/main into feat/raw-xmp-crop
Conflict only in docs/file-format-parity.md: main's status line with this PR's Camera Raw crop entry first (Last updated 2026-11-02), and both revision-history rows, this PR's redated to 2026-11-02 above main's 2026-10-30 YCbCr TIFF row.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 19:59:27 +01:00
Fabio Lissi d1141d08f8 Merge branch 'main' of https://github.com/storytold/photocraft into feat/actions-record-independent 2026-11-02 12:40:52 -06:00
9034223c4b TIFF: open YCbCr images as RGB (#10316) (#10319)
* TIFF: open YCbCr images as RGB (#10316)

Scanners often write JPEG-compressed YCbCr TIFFs with 2x2 chroma
subsampling. The tiff crate decodes and upsamples them but returns raw
YCbCr samples, which the decoder rejected with "colour type YCbCr(8)".

The new tiff/ycbcr.rs converts them to RGB after decoding: JPEG data
uses the JFIF full-range BT.601 conversion (as libtiff does), other
compressions honour ReferenceBlackWhite and YCbCrCoefficients with the
TIFF defaults as fallback. 8 and 16-bit. YCbCr with extra samples, or
in other sample formats, fails with a clear unsupported error.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Contributors: add Yuki-init's display name

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* TIFF YCbCr: test that YCbCrCoefficients set the luma weights

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* TIFF: YCbCr tags with the wrong value count use the defaults

tag_f64s now returns None unless the tag holds exactly n values, so a
YCbCrCoefficients or ReferenceBlackWhite tag with extra values falls
back to the TIFF defaults instead of being truncated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lrgj5pnShYtsSnrsZq5iRn

* TIFF YCbCr: tests for tiled JPEG with ICC, big-endian 16-bit and planar

Covers the layouts the review asked for: a tiled 4:2:0 JPEG file with an
embedded profile (checked against an independent JPEG decoder), a
big-endian 16-bit file, and planar data in both byte orders.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lrgj5pnShYtsSnrsZq5iRn

* TIFF YCbCr: cite the formula sources and pin the green-channel choice

Documents where the conversion comes from: TIFF 6.0 Section 21
(YCbCrCoefficients, pp. 90-91) and libtiff's tif_color.c
(TIFFYCbCrToRGBInit, TIFFYCbCrtoRGB). Red and blue follow the spec;
green follows libtiff and adds Y unscaled, which matches the spec only
when the luma weights sum to 1. The module doc records this as a
deliberate compatibility choice, and a new test pins it: with weights
0.25/0.25/0.25, mid gray stays (128, 128, 128).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lrgj5pnShYtsSnrsZq5iRn

* Codecs README: YCbCr TIFFs with three 8- or 16-bit samples decode to RGB

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lrgj5pnShYtsSnrsZq5iRn

* Format tiff_ycbcr tests with rustfmt

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(tiff): compare grouped YCbCr decoding and update support notes

* style(tiff): align grouped decode call with test formatting

* style(tiff): apply repository rustfmt to grouped YCbCr regression

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
Co-authored-by: FredApps <FredApps@users.noreply.github.com>
2026-11-02 19:31:22 +01:00
FredApps 9236d27eb6 Merge current main into fix/gnome-window-decorations 2026-11-02 19:10:43 +01:00
Fabio Lissi 00f75988b9 Match measured Photoshop Batch naming and error logs 2026-11-02 11:30:58 -06:00
Fabio Lissi 50360ac4ef Record portable nudges, document switches, and type positions 2026-11-02 11:30:37 -06:00
Hector VillarrealandClaude Opus 5.5 7be3957476 Docs: UI parity lists the Layers panel's Color filter (CodeRabbit review on docs/ui-parity.md:248)
The filter-type dropdown row now reads Kind, Name, Mode and Color, the other five missing; status
line and revision history updated. No percentage changed; the scorecard has no row for it
(`cargo xtask scorecard` leaves docs/scorecard.md as it was).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 11:21:39 -06:00
Hector VillarrealandClaude Opus 5.5 7dadc3177d Layers panel: filter by Color, as in Photoshop (#5898)
The Layers panel's filter row gains Color after Kind, Name and Mode. Like
Photoshop's, it filters at once (by no colour at first) and lists the layers
whose label is the chosen colour; the colour menu is None plus the label
colours in Photoshop's order. ui.set's layerFilter takes "by": "color" and a
"color" label id.

Fixes #5898

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 11:21:29 -06:00
David MannandClaude Opus 5.5 719786c234 Merge main into feat/history-snapshot-options
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 17:00:59 +01:00
David MannandClaude Opus 5.5 4488384e8c Merge main into fix/9137-control-click-coord-range
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 16:44:13 +01:00
David MannandClaude Opus 5.5 89b4ca021b Merge main into fix/remove-enable-animations
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 16:42:54 +01:00
David MannandClaude Opus 5.5 f79a169651 Integration: one Actions row and the batch's event total in the file format parity page
The doc merge left five Actions rows that disagreed (version 12 unsupported vs read; 120 vs
127 events). Found by CodeRabbit on #10776.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 16:42:36 +01:00
Khawar Zamman Wani 582a285b5d fix: enforce scoped PSD memory admission and complete retry integration 2026-11-02 19:01:15 +05:30
David MannandClaude Opus 5.5 8caea149c1 Integration: regenerate docs/atn.md for the batch (144 supported events, settings each PR keeps)
Supported table read from the batch's events.rs. The PRs' own sections (settings and command
options retained, Render defaults, steps kept disabled) are kept; the known-gaps tables that
#10702 and #10704 close are gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 13:03:44 +01:00
Khawar Zamman Wani bcc060180f feat(io,engine,ui): adaptive PSD/PSB memory budget and interactive confirmation
- Distinguish available physical RAM from swap and commit headroom
- Adaptive soft and hard import thresholds with native fallback
- Interactive preflight confirmation modal before pixel decoding
- Headless and command parameters for explicit high-memory approval
- One-shot source-bound validation rejecting altered sources or degraded RAM
- Process-wide serialized decode gate with reentrancy support
- Documentation and synthetic regression test coverage
2026-11-02 17:11:03 +05:30
Trevor BrownandClaude Fable 5.1 dab1280b1b Layer Style: a drag on the image moves a Gradient Overlay (#10763)
With the dialog on a Gradient Overlay page, a drag on the image moves the gradient's centre (params.offset, a fraction of the layer's bounds) by the pointer's movement over the layer's size, as a drag moves a shadow. Tests in layer_style and gradient_overlay.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-02 05:57:36 -05:00
ljkxandClaude Opus 5.5 2d30a2b669 Gradient stops: the release frame decides drag-off; review fixes (#10742)
The Gradient Editor/Properties strip and Layer Style's Gradient Overlay
ramp ignored the release frame. When the last pointer move came in the
same frame as the release, the stop stayed in the state the previous
frame left it in. A stop flicked off the bar was kept, and one brought
back onto the bar at release was deleted. Both now apply the same
drag-off rule on that frame, as Gradient Map and the shape strip
already did.

The editor strip also counted opacity stops from its preview, which
already leaves a dragged-off stop out. So while an opacity stop was off
the bar, the preview flipped between deleting and moving it every
frame. It now counts the committed stops, like colour stops.

Tests: a quick release off the bar and back onto it (both editors);
colour stops dragged up and opacity stops dragged down are kept; a
cancelled Gradient Map drag adds no history step. The parity row names
Gradient Map's control "Remove stop".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 09:37:01 +01:00
ljkxandClaude Opus 5.5 dec95112a0 Remove gradient stops dragged off the bar in every stop editor (#10742)
Dragging a colour stop down, or an opacity stop up, by about a marker's
height off the gradient bar now removes it on release in every stop
editor, as in Photoshop's Gradient Editor. At least two stops of that
kind always stay. While the stop is off the bar the ramp and the
preview show it gone, and dragging it back onto the bar cancels.

The Gradient Editor, Properties and shape gradient strips already did
this. Gradient Map had no drag-off at all, and Layer Style's Gradient
Overlay only deleted after about 44 pt and showed nothing until
release. All four now share stop_dragged_off() in gradient_ui.rs
(26 pt past the bar edge, by kind). Gradient Map and Gradient Overlay
take the stop out live and put it back if it returns.

Adds harness tests for drag-off removal, the two-stop minimum,
opacity stops dragged up and drag-back cancel, and updates
docs/ui-parity.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 08:53:33 +01:00
Fabio Lissi b82a354718 Preserve explicit action sources and replay named spelling edits 2026-11-02 00:43:44 -06:00
Fabio Lissi 3191b89064 Preserve styled text and explicit layers in action replay 2026-11-02 00:25:07 -06:00
Fabio Lissi 85cb54025c Guard Batch outputs and preserve partial results 2026-11-01 23:56:10 -06:00
Fabio Lissi 03799b62bc Keep recorded layer targets portable across documents 2026-11-01 23:54:42 -06:00
yoriswind 1dfc6bfa34 Clarify the supported Batch RAW opening subset 2026-11-01 21:30:49 -08:00
yoriswind 4fc3b9ee83 Use supported saved RAW settings for noninteractive Batch opening 2026-11-01 21:29:19 -08:00
yoriswind d898e46030 Apply Batch profile policy without losing import diagnostics 2026-11-01 21:25:16 -08:00
Fabio Lissi 4eba6bd2e9 Merge current main and complete Batch automation options 2026-11-01 23:04:19 -06:00
Fabio Lissi 21c0444559 Merge current main and preserve portable action recording 2026-11-01 23:01:23 -06:00
yoriswind d656c0f6e1 Replay Batch Override Open with scoped input bindings 2026-11-01 21:00:59 -08:00
yoriswind a347e69ac7 Support same-source Batch Save and Close 2026-11-01 20:14:27 -08:00
yoriswind 60dba86c22 Report unsupported files in recorded Batch folders 2026-11-01 19:40:11 -08:00
yoriswind f3e5c63383 Clarify Batch error policies and measured Custom settings 2026-11-01 19:29:58 -08:00
ljkxandClaude Opus 5.5 93381b4b23 Merge remote-tracking branch 'origin/main' into feat/photo-filter-last-settings
Conflicts: adjust_dialog.rs body() keeps main's captured target and curve_mode_for_fields, then the once-per-opening Photo Filter mode reset; tests.rs keeps both sides' new tests; docs/ui-parity.md keeps main's status line with the #9879 entry prepended (dated 2026-11-02) and both sides' rows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 04:27:11 +01:00
yoriswind c60fc81fc3 Stop recorded parents after Batch file failures 2026-11-01 19:17:33 -08:00