Commit Graph
18 Commits
Author SHA1 Message Date
yoriswind bf63a6639f Integrate recorded Custom and Fibers filter mappings
Adapt only Custom from #10631 by @hectorviov at 4ed3f5b591 and Fibers from #10620 at 33ee38b431. Retain the measured ranges and whole unsupported descriptors without importing unrelated filters. Source and fixtures only; combined validation remains.
2026-11-01 17:05:28 -08:00
yoriswind c78b84a1cd Port CSH import backend while retaining recorded shape IDs
Port the ten backend, automation and test paths from #5493 by
@jonathanwxh-cell, pinned at 43920ab780.
Keep its original CSH codec, bounded preset reader and protection tests.
The prerequisite's UI, translation and parity-document changes are excluded.

Adapt ShapePreset construction to retain the exact source identifier. Empty
identifiers remain anonymous presets; repeated identifiers resolve when their
geometry is identical and refuse resolution when it conflicts. Add one
import-to-ATN Shape Blur regression and document the source attribution.

Original contribution: https://github.com/storytold/photocraft/pull/5493
Source-only integration; compilation and combined runtime validation remain.
2026-11-01 17:01:17 -08:00
yoriswind 609d839607 Cover nonlinear 3DL shapers through action playback 2026-11-01 16:55:31 -08:00
yoriswind d752b8a3a2 Add embedded LUT and custom shape action support 2026-11-01 16:46:48 -08:00
yoriswind 9a59fc2b09 Read explicit merged transparency from the composite 2026-11-01 16:19:09 -08:00
yoriswind 8e71182017 Map recorded Calculations Make steps 2026-11-01 16:13:41 -08:00
David MannandClaude Opus 5.5 5a9ca48f8a docs(atn): Convert Stroke to Fill exists only internally; where it was looked for
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 18:37:35 +01:00
David MannandClaude Opus 5.5 ea326374b2 docs(atn): Convert Stroke to Fill is not a user command, nothing to map
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 18:23:54 +01:00
David MannandClaude Opus 5.5 2ec27abb95 docs(atn): measure the remaining menu events through recordings
Every remaining event recorded in the reference application through its
menus: Scale Effects, Create Layers, Frame and Artboards, all eleven
Stack Modes with their plug-in codes, video layer and frame commands,
Create Work Path, Find and Replace, Check Spelling, measurement scale
and Scale Marker, Close All, data sets (apply, import, export), Package,
Video Frames to Layers, Import Notes, Photomerge, Crop and Straighten
Photos, Conditional Mode Change and Fit Image. Close Others and Define
Variables record nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 18:10:32 +01:00
David MannandClaude Opus 5.5 0588012b29 docs(atn): measure Batch behaviour, document-independent recording, Trace Contour
Measured in the reference application: Batch source and destination keys
(open documents, Save and Close, override Open and Save As, suppress open
options), file naming output (the extension component only gets a dot as
the last component), processing order, flat output with subfolders, name
clashes, stop and log error modes with the log file format, and Esc.
What a normal recording names (layers by name, merged nudges and typing,
document offsets) and how it plays on another document. Trace Contour's
recorded keys and its 0..255 level; Quick Export records no step.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 17:11:39 +01:00
David MannandClaude Opus 5.5 5020854dde docs(atn): measure Shear, gradients, workspaces, Print, Droplet, Sky Replacement, layer comps
Measured in the reference application through its dialogs and recorded
actions: Shear point ranges and what ShrS/ShrE mean, the classic and the
new Gradient tool steps, Content-Aware Fill, Perspective Warp, Print,
Create Droplet and Sky Replacement descriptors, the mmdd/ddmm Batch date
components, and every layer comp reference form. Export As records no
step; Convert Stroke to Fill was not available in the measured version.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 16:31:26 +01:00
David MannandClaude Opus 5.5 a02e1211e9 Docs (atn): Custom ranges from the dialog; only Spatter of the Filter Gallery is mapped
Addresses CodeRabbit on #10603: the Group A intro said every Filter Gallery effect loads as a
kept step, but Spatter is mapped; Custom's scale, offset and matrix cells now have their
measured ranges and the matrix has no default (a step carries all 25 cells).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 15:51:23 +01:00
David MannandClaude Opus 5.5 2e0c0f9a69 Docs (atn): how Insert Menu Item and Insert Path are recorded
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 15:40:20 +01:00
David MannandClaude Opus 5.5 ceb5ddf6c5 Docs (atn): events measured through dialogs and recordings, Batch file naming, panel menu
Recorded in the reference application through its menus and read back from the saved Actions
panel, or returned by the dialog on OK: Custom, Fibers, Displace (with ranges), Color Lookup,
Shape Blur, Lighting Effects, Blur Gallery, Liquify, Camera Raw Filter, Vanishing Point,
Calculations; how Image Size, Canvas Size, Convert Mode and New Group are recorded. The Batch
descriptor with its file naming components, and the Actions panel menu and Playback Options.

Known gaps gain four rows: Convert Mode is saved with an enum the reference application
rejects, adjustment layer opacity on Make, Canvas Size in percent, Image Size in cm/inches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 15:37:04 +01:00
David MannandClaude Opus 5.5 fe3d8db7e3 Docs (atn): reference forms, newer events, version 12 files, wrong codes in the mapping
- Known gaps: every exported step of the round-trip test was played in the reference
  application (128 of 151 ran); six codes the mapping writes are wrong there (Vibrance and
  Gradient Map events, Stroke Outside, Pass Through, canvas extension colour, Absolute
  Colorimetric), and a document offset wraps around there.
- Reference forms: layers and documents by index, id, offset and ordinal, measured.
- Newer events: 63 candidates from the menu catalogue run in the reference application;
  which need no settings, which were measured with settings, which need their dialog.
- Version 12 files: the older descriptor layout, checked on 325 real sets.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 14:55:29 +01:00
David MannandClaude Opus 5.5 a23b30edd2 Docs (atn): known gaps in mapped events; fix the adjustment rows of the supported table
Every mapped event was checked against the reference application: the corpus sets'
5 296 recorded steps and factory descriptors went through Load and Save Actions and were
compared with the original, and the forms PhotoCraft writes were played there. The new
section lists the settings mapped events still lose (transform reference point, show
only this layer, group names, clipping and colour labels on Make, shape layers, layer
via copy options, load selection from another layer, Background by property, Close that
asks, Lab Photo Filter colours) and the settings the commands do not have yet.

The supported table showed 15 direct adjustment events with shifted columns.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 13:49:32 +01:00
David MannandClaude Opus 5.5 47287016d3 Docs (atn): fix the Filter Gallery row, mark example values, settle two specs
- The supported table read the command list of the next entry for an event whose
  list is a constant: Filter Gallery (`GEfc`) maps to `filter.gallery.spatter`, not
  Shadows/Highlights. The table now resolves constants and reads each entry alone.
- Steps measured in a prepared document (Fade, Replace Color, Trap, selection
  combinations, ...) show the example values that were sent, labelled as such, not
  as factory defaults.
- Mosaic cell size: write `#Pxl`, read a value without a unit as pixels.
- Custom: no factory matrix; the test matrix is no longer shown as defaults.
- Intro: kept steps with no document effect are imported switched off and skipped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 02:31:47 +01:00
David MannandClaude Opus 5.5 b408d4166d Docs: .atn event reference with the supported events and measured specs of unmapped ones
docs/atn.md lists the 117 events PhotoCraft maps today and, for 101 events it does
not map yet, every key the step carries in recorded order, with type, unit, factory
default, exact range and accepted enum values, measured in the reference application.
An implementation needs no further checks there. Linked from file-format-parity.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 02:17:06 +01:00