Commit Graph
11425 Commits
Author SHA1 Message Date
David MannandClaude Opus 5.5 b1b6bd2481 Address CodeRabbit review: a manual update check that fails to start opens its window (#5485)
When the checker cannot start, help.checkForUpdates sets Status::Failed and
returns the error, and `?` skipped opening the window, so Help > Check for
Updates showed neither the failure nor Check Again. The window now opens
for a failed check (the command error is still returned); bad params open
nothing. Covered by a test with a checker that fails to start.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-23 00:31:11 +02:00
David MannandClaude Opus 5.5 81bcf7f3df Address CodeRabbit review: no path pointer while a text box is dragged out (#6230)
Dragging out a paragraph box with the Type tool sets app.drag and no type
edit is open yet, so the hover lookup showed the area-type or path-type
pointer over a path although the release makes a box. hover_path_target now
returns nothing during a drag or an open type edit (the edit check moved in
from canvas.rs), and a test drives a drag over a shape.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-23 00:30:36 +02:00
David MannandClaude Opus 5.5 2a70501416 Address CodeRabbit review: Last updated matches the 2026-10-23 counts (#6214)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 00:29:34 +02:00
David MannandClaude Opus 5.5 72bafe9d25 Address CodeRabbit review: Type checklist counts match the scorecard (#6230)
The Features row said Type 5 / 4 / 1 and "RTL paragraph direction UI
missing"; scorecard/type.toml has 5 done / 5 partial / 0 missing, as the
status line says, and TYPE-218-2 is partial: the direction buttons exist,
the visual RTL caret is missing.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-23 00:28:19 +02:00
David MannandClaude Opus 5.5 08728a5677 Address CodeRabbit review: the manual PSD fixture command names the it test target (#6658)
psd_recovery_generated is a module of the io crate's single `it` test
binary, so `--test psd_recovery_generated` names no target. The comment now
runs `--test it psd_recovery_generated::write_psds_for_manual_gui_test`.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-23 00:28:19 +02:00
David MannandClaude Opus 5.5 ea2acdeea5 Merge fix/history-options (#3535, with origin/main 98de85c64) into feat/history-snapshot-options
engine chrono now comes from the workspace (with clock); the form dialog uses main's form_keys; the History panel's follow key uses doc_id; cs keeps main's New Snapshot row.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 00:27:10 +02:00
David MannandClaude Opus 5.5 c88691c0b8 Address CodeRabbit review: CMYK ink paths convert colours through the document profile (#3356)
Two places turned an RGB or Lab colour into ink with the built-in coated
CMYK instead of the document's embedded profile: the exact ink path's
tiles (render_tile runs on rayon workers, which never inherit a caller's
with_cmyk_space scope), e.g. a solid fill picked in RGB, and the split
path's stand-ins (fill and effect colours, converted on the calling thread
outside any scope). Both now enter cmyk_space(doc). A test with a synthetic
uncoated profile checks a solid fill and a Color Overlay get the profile's
inks; each half fails on its own without its fix.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-23 00:26:54 +02:00
Davit MatchakhelidzeandClaude Opus 5.5 1321f8a0b3 Move fonts, samples and casing to follow-up PRs
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YMTAbGNRxnMEzRvYnQGphF
2026-10-23 02:26:12 +04:00
Davit Matchakhelidze b7d7de8173 Merge main into ka-language 2026-10-23 02:25:56 +04:00
David MannandClaude Opus 5.5 b54ab8ff30 Address CodeRabbit review: bridge-mode doc_replace_smart_object refuses index (#8150)
The bridge forwards Replace Contents to the app, which runs it on its
active document, so a given `index` was silently dropped and could replace
another document's contents. It is now refused before anything reaches the
app, as bridge previews and saves already do; documented in the schema and
control-protocol.md. A fake-app test checks the indexed call never arrives.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-23 00:25:18 +02:00
David MannandClaude Opus 5.5 4604cfc4bb Address CodeRabbit review: doc.replaceSmartObject restores the active document (#8150)
`index` targets one call (#7025): replace_smart_object now runs through
on_doc like place and the data-set methods, so the previously active
document is active again on success, on error and on the trusted-local path.
The index test covers a successful and a failing indexed replace.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-23 00:24:13 +02:00
David Mann 982303524a Merge origin/main into fix/5692-tsl-off-blend 2026-10-23 00:12:30 +02:00
David MannandClaude Opus 5.5 30d3db752b Merge origin/main into fix/history-options
Main's keep-clean revision bump (#6865) now also applies to rollback; Turkish History terms follow main's Geçmiş.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 00:07:59 +02:00
David Mann c16f899467 Merge origin/main into fix/6544-lut-format-roundtrip
# Conflicts:
#	crates/format/tests/it/roundtrip.rs
2026-10-23 00:06:48 +02:00
David MannandClaude Opus 5.5 beb50a43d3 Allowlist main's Color panel RGB sliders in panel-commands; regenerate scorecard
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 00:06:24 +02:00
David Mann 32281291ae Merge origin/main into feat/auto-219-8-panel-command-check
# Conflicts:
#	docs/scorecard.md
#	xtask/src/main.rs
2026-10-23 00:04:23 +02:00
David MannandClaude Opus 5.5 5ee010a70f Regenerate scorecard after merging main: 19 of 176 preferences do nothing
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 00:01:13 +02:00
David Mann bc8973098e Merge origin/main into feat/ui-217-4-columns-unit
# Conflicts:
#	docs/gaps.md
#	docs/scorecard.md
#	docs/ui-parity.md
2026-10-23 00:00:55 +02:00
David MannandClaude Opus 5.5 1541134b6f Adapt History snapshots to main: doc_id in the follow spot, one cs New Snapshot entry
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 00:00:13 +02:00
eiketre bd74b7fef9 Merge upstream main into fix/multilayer-transform-handles 2026-10-22 23:57:50 +02:00
SimoneRecchia 812aea6807 Merge remote-tracking branch 'upstream/main' into claude/busy-ptolemy-02a3az
# Conflicts:
#	docs/ui-parity.md
2026-10-22 21:56:39 +00:00
David Mann 3ab8055f03 Merge origin/main into fix/snapshot-followups
# Conflicts:
#	docs/ui-parity.md
2026-10-22 23:52:03 +02:00
Finn NewickandClaude Opus 5.5 17f5c041d8 feat(actions): import recorded Camera Raw Filter steps as filter.cameraRaw
`Adobe Camera Raw Filter` steps in .atn files imported as
actions.photoshopStep placeholders, so many retouching actions stopped at
them. They now import as filter.cameraRaw, with the Basic, tone curve,
point curve, colour mixer, colour grading, detail, grain and vignette
settings, using the descriptor keys of 62 recorded steps and the verified
PSD Smart Filter mapping. Steps that use settings the command lacks
(Calibration, non-Custom white balance, active neutral-only controls)
stay Photoshop steps rather than replaying a different look. Export
stays refused: the written step's version keys are unverified.

Part of #6745

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 22:50:19 +01:00
David Mann 1efa06b715 Integration: merge main (c36e46c38 #8680, #8668, #6705)
# Conflicts:
#	docs/ui-parity.md
2026-10-22 23:47:54 +02:00
David Mann 4db1674b01 Merge PR #8556: perf(oil-paint): drop the libm floor/round calls from the LIC gathers, same pixels (1.23x) (author's own rounding fix since review; the batch keeps our equivalent fix-up 249eae743) 2026-10-22 23:42:34 +02:00
David Mann 104fea5c1b Merge PR #6055: Color panel: Photoshop's panel-menu modes, the same in every theme (#6000) (author's update since review: main merge; batch resolution kept) 2026-10-22 23:41:06 +02:00
David Mann f4f305ea64 Merge PR #5815: perf(doc): share the XMP packet, Duotone PSD data and unsupported adjustment bytes between snapshots (author's update since review: main merge; batch resolution kept) 2026-10-22 23:41:04 +02:00
David Mann 71284b908c Merge PR #8547: perf(gpu): layer pages that just miss the budget borrow the effect-map share, P60/P61 10× faster on integrated GPUs (author's update since review: main merge; batch resolution kept) 2026-10-22 23:41:01 +02:00
SimoneandLucenx9 98de85c64e fix(raster): prevent overflow in strided row sampling (#8668)
Keep scan coordinates and tile boundaries in i64 so valid reads at the final tile and large strides do not overflow. Bound each run by the remaining output and return the surface default beyond the i32 coordinate range. Add differential regressions across all sample depths and missing/present tiles.

Co-authored-by: Lucenx9 <185146821+Lucenx9@users.noreply.github.com>
2026-10-22 17:40:47 -04:00
David MannandClaude Opus 5.5 ae8809c029 Integration: Levels gamma just above 1 no longer turns black into NaN (#5143)
levels_gamma's shadow toe: for gamma ~1.003..1.03 the join point u1 is a
tiny positive f32 whose u1^2.2 underflows to 0, so b = inf and the toe
gives inf*0 = NaN at u = 0 (any 8/16-bit Levels channel at black). The
toe vanishes as gamma -> 1, so the power curve is its limit: use it when
b is not finite. Found by cmyk random_documents_match_the_reference
(proptest, unseeded; the shrunk case is kept in proptest-regressions);
the bug is on main since #5143, not from this batch.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-22 23:40:21 +02:00
David MannandClaude Opus 5.5 07bb7c2522 Integration: enable Generator in the Image Assets artboard tests (#8254)
#5598 made File > Generate > Image Assets require Preferences > Plug-ins >
Generator, so #8254's two artboard tests got Disabled. Enable it first,
as #5598's own test does.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-22 23:40:21 +02:00
David Mann 450b832a4c Merge PR #6254: Selection: ⇧ mid-drag locks a selection-tool move to the axis (#6231) 2026-10-22 23:40:21 +02:00
David Mann ca73fb4724 Merge PR #6966: perf(canvas): skip occluded checker on CPU textures 2026-10-22 23:40:20 +02:00
David Mann adace9a86f Integration: #8254 second fix-up (an empty artboard asset is refused, as in Photoshop's Generator) 2026-10-22 23:40:20 +02:00
David Mann 3623a8b6c8 Merge PR #7021: Eyedropper: a large sampling ring that reads on any colour (#6973) 2026-10-22 23:40:20 +02:00
David Mann d4a5be2980 Integration: #5878 third fix-up (a deliberate change in this instance beats another instance's migration) 2026-10-22 23:40:20 +02:00
David Mann 2bfc24d9f8 Merge PR #8180: fix(actions): strict .atn export keeps Apply Image's flat source fields (#7197) 2026-10-22 23:40:20 +02:00
David Mann 7ecac105c2 Merge PR #8556: perf(oil-paint): drop the libm floor/round calls from the LIC gathers, same pixels (1.23x) 2026-10-22 23:40:19 +02:00
David Mann 159728aaa0 Merge PR #8118: GPU compositor: build its pipelines in parallel; DX12 startup 13.2 s -> 7.3 s (part of #6419) 2026-10-22 23:40:19 +02:00
David Mann a79d8cb9f6 Merge PR #5937: fix(compose): prevent outside stroke from bleeding into opaque character interior (#5861) 2026-10-22 23:40:19 +02:00
David Mann 7c9d6ac344 Merge PR #8150: fix(automation): doc.replaceSmartObject replaces Smart Object contents from the read root (#8061) 2026-10-22 23:40:19 +02:00
David Mann 18124238f7 Merge PR #8502: fix(actions): accept Photoshop stringID blend modes (#8454) 2026-10-22 23:40:19 +02:00
David Mann 8d23a06eae Merge PR #6094: Fix legacy PSD point-text placement after font resolution 2026-10-22 23:40:19 +02:00
David Mann 09eef59e90 Integration: #5878 second fix-up (two instances keep each other's Shift tool switch choice) 2026-10-22 23:40:18 +02:00
David Mann c436f61d53 Merge PR #7202: fix(atn): import a recorded Save As with its destination (#7102) 2026-10-22 23:40:18 +02:00
David Mann ee85da2ffd Merge PR #8527: fix(atn): export Black & White adjustment layers with Photoshop's BanW class (#8481) 2026-10-22 23:40:17 +02:00
David Mann 9ee6c407b6 Merge PR #8254: Image Assets: optionally keep a transparent artboard's full size 2026-10-22 23:40:16 +02:00
David Mann a23c29b53a Merge PR #5878: Preferences: old settings files take Shift-to-switch-tools on (#5647) 2026-10-22 23:40:16 +02:00
David Mann 79ab013961 Merge PR #8496: fix(ui-egui): expand layer visibility eye hitbox and render sunken well (#8467) 2026-10-22 23:40:16 +02:00
David Mann b1e4c9b1f9 Merge PR #6041: Raw: charge the retained tile intermediates together (#4959) 2026-10-22 23:40:15 +02:00