Commit Graph
11425 Commits
Author SHA1 Message Date
David MannandClaude Opus 5.5 87a9e65dfa Preferences: the Generator checkbox reads Enable Generator, as in Photoshop (#9392)
Preferences > Plug-ins derived the label from the key generatorEnabled
("Generator enabled"); Photoshop says "Enable Generator", which our own
Image Assets error already asks for. Override the label in humanize and
rename the catalog row in the 20 catalogs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 10:59:45 +01:00
David MannandClaude Opus 5.5 f9e2bc3d4a Tests: the Color Wheel fit test bounds the wheel by the scroll area, not the group edge (#9394)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 10:57:51 +01:00
Federico Olivares ec0b23d9c6 Merge commit 'refs/tmp/pr-9104' into integration/parity-batch-2 2026-10-25 06:54:36 -03:00
Federico Olivares 70644b49bd Merge remote-tracking branch 'origin/main' into integration/parity-batch-2 2026-10-25 06:54:34 -03:00
David MannandClaude Opus 5.5 8fa82ebe5c Color panel: the Color Wheel fits the panel at its default height (#9394)
The wheel's height subtracted an estimate of the HSB slider rows (3 x ROW_H)
that is lower than the rows really drawn, and was floored at 80 pt, so at the
Color group's default height it ran past the bottom and the panel scrolled.
Measure what the rows used and floor at 28 pt, as the slider modes' ramp.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 10:53:30 +01:00
highperfocused 34b4a91fb7 fix(ui): a reset-to-bounds crop commit stays a no-op (#6561)
The crop menu's Reset makes the full-bounds frame a real pending one, so
Commit ran image.crop: a "Crop" history step, and with Delete Cropped
Pixels on, layer pixels outside the canvas were trimmed. Track the reset
frame separately and commit it as a no-op while it still matches the
document bounds (unless it was turned or W x H x Resolution resamples
it), as the untouched default frame already did.
2026-10-25 10:52:56 +01:00
Leel WasanathaandClaude Opus 5.5 6cbcd89f0c Pen: carry on a shape's or vector mask's open path, and show the continue pointer (#9356)
A Pen press on an endpoint of an open path carried it on only for the Work Path or a saved path
(#6593). In Shape mode the press started a new shape layer, and on a targeted vector mask a new
subpath, so a pen shape could not be continued once drawing stopped. Now the selected shape
layer's path (Shape mode) and the targeted vector mask resume like the Work Path, and the commit
updates the same layer in one History step (shape.edit / layer.vectorMask.edit).

Nothing showed that the endpoints can be clicked, either: the Pen now shows Photoshop's
continue-path pointer (the cross with a slash) over an endpoint it would carry on from.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016NgLQVizswqgNnzBv1taRD
2026-10-25 09:50:47 +00:00
David MannandClaude Opus 5.5 a4bb2d9046 Address CodeRabbit review: a click-sized Perspective Crop press doesn't auto-scroll
A new-box press held past egui's click time and slipped a point or two past
the canvas edge counted as a drag for auto-scroll, while the release still
classifies it as a corner-placing click; the scroll then moved the pointer's
document position and turned the click into a box. `dragging` now uses the
same click test as the release (`is_click`).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 10:43:32 +01:00
David MannandClaude Opus 5.5 e22699bb9f Actions: save and read the Lab Lightness channel as Lght (#9384)
Photoshop names a Lab document's Lightness channel Chnl.Lght and rejects
Chnl.Lmnc ("luminance") for Levels, Curves and Apply Image steps. Write
Lght, read Lght, and keep reading the Lmnc that earlier PhotoCraft wrote.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 10:40:03 +01:00
Khawar Zamman Wani 373ae2f573 End font hover previews with the text editing session 2026-10-25 15:08:33 +05:30
Khawar Zamman Wani a6f093ef8d Use current IME cancellation and preserve pending font axes 2026-10-25 15:04:08 +05:30
David Mann acd7e07252 Merge PR #4573: Interface: Animation Effects follows the system setting, or is on or off
Conflicts with #5547 (Animated Zoom) resolved in wheel_nav.rs, canvas.rs and
panels.rs: the Navigator and canvas pass both Animated Zoom and
!animations_off; with Animation Effects off, the sideways part of an
animated wheel zoom pans by the frame's own events folded by their
modifiers (#4573's unsmoothed scroll) instead of the plain-event raw.x,
so Ctrl + wheel still pans sideways there. #4573's modifier test runs
with Animated Zoom off and on.
2026-10-25 10:30:00 +01:00
David Mann bc0354db5d Merge PR #5547: fix(zoom): Restore smooth wheel zoom
# Conflicts:
#	crates/ui-egui/src/canvas.rs
#	crates/ui-egui/src/wheel_nav.rs
2026-10-25 10:25:30 +01:00
Khawar Zamman Wani 82d23db96b Fix mixed-font editing, caret font changes and focused text commit 2026-10-25 14:53:55 +05:30
David MannandClaude Opus 5.5 d73c91133b Integration: merge main, resolve conflicts (#1610)
Translation catalogs keep main's strings plus the Art History Brush ones
(fr: main already has Area; hi: added the brush strings). docs/scorecard.md
regenerated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 10:19:42 +01:00
David Mann b712de488d Merge PR #5504: Mode dropdowns for Clone Stamp, Pattern Stamp, History Brush, Healing and Paint Bucket
# Conflicts:
#	crates/ui-egui/src/blend_keys.rs
#	crates/ui-egui/src/distort_ui.rs
#	crates/ui-egui/src/panels.rs
#	docs/ui-parity.md
2026-10-25 10:18:08 +01:00
David Mann 7f62500ae6 Merge remote-tracking branch 'origin/main' into HEAD 2026-10-25 10:17:38 +01:00
David Mann ed401d5321 Merge PR #5478: Blend mode keys: Shift+Alt+letter picks a mode, as in Photoshop
# Conflicts:
#	docs/ui-parity.md
2026-10-25 10:15:19 +01:00
David Mann e6cf04cf42 Merge PR #7873: perf(photomerge): track multiband timing and peak memory
# Conflicts:
#	docs/scorecard.md
#	perf/budgets.toml
2026-10-25 10:15:10 +01:00
David Mann d5e56b03e1 Merge PR #7218: Brush: large tips rasterize, accumulate and composite in parallel 2026-10-25 10:14:11 +01:00
David Mann 42b17b1836 Merge PR #6923: perf(camera-raw): develop the preview's per-pixel stages on the GPU (#6916) 2026-10-25 10:14:10 +01:00
David Mann 055d9eaa14 Merge remote-tracking branch 'origin/main' into fix/crop-drag-autoscroll 2026-10-25 10:08:27 +01:00
Khawar Zamman Wani 37f7140f62 chore: restart CI for PR #8536 2026-10-25 13:50:51 +05:30
Vlad Grankovsky 87d178e4ab channels: verify selection visibility and capture default views 2026-10-25 09:16:45 +01:00
mroxso 950bc7c63d Merge branch 'storytold:main' into main 2026-10-25 08:04:40 +00:00
Vlad Grankovsky 039c5dec7a docs: record fused channel benchmarks and public-domain captures 2026-10-25 09:03:59 +01:00
Vlad Grankovsky aeff534492 channels: bound scalar scratch work to selected regions 2026-10-25 09:02:16 +01:00
Vlad Grankovsky 9d81a15fd2 channels: fuse native tone edits and protect filter replay previews 2026-10-25 08:51:19 +01:00
Hector VillarrealandClaude Opus 5.5 c5f77cf37a fix(ui): Bevel & Emboss Highlight and Shadow Mode are separate dropdowns (#9368)
Every blend-mode dropdown in the Layer Style dialog took the id
`fx-blend-<effect>`, so Bevel & Emboss's two (Highlight Mode and Shadow
Mode) shared one: the Shadow Mode list opened over the other and a pick
changed the Highlight Mode. Photoshop keeps them independent. The id now
includes the parameter, as the other effect dropdowns already do.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 01:48:53 -06:00
Khawar Zamman Wani b3f6e4e95b Keep unmatched font searches compact and readable 2026-10-25 13:12:45 +05:30
aiongg 3d4729e53d Panels: window.panel.dock with group or column docks the whole group
The return to where a panel floated from applies to a single panel; with
group or column true the command docks the panel's group or column as
craft-ui does.
2026-10-25 07:28:14 +00:00
aiongg 9258857660 Panels: keep a workspace saved by a newer version
A docking workspace whose version is above what craft-ui reads loads as
the default layout. The preferences and New Workspace save it unchanged
in its place until the layout changes or Reset Workspace runs, as
craft-ui's workspace docs ask.
2026-10-25 07:25:41 +00:00
aiongg 369cee0c54 Panels: keys held in a panel window count as released once it loses the keyboard
A panel window forwards no releases once the main window or no window of
the app has the keyboard (the app was switched away with Space held), or
once one of its widgets takes keyboard focus. Keys it forwarded count as
held only while it has the keyboard and none of its widgets has focus.
Forwarded keys run no shortcuts while the screen color picker is open,
as the main window's don't.
2026-10-25 07:22:33 +00:00
aiongg 5e6586f4b8 Panels: save a panel window's place once the OS stops moving it
A move or resize by the OS title bar or edges changes a panel window's
place each frame with no button down in the app's windows, which wrote
the preferences at frame rate. The layout is saved once the places keep
still for a frame.
2026-10-25 07:20:14 +00:00
aiongg 57596a3bc4 Panels: menu keys typed in a panel window's text field go to the field
On macOS the menu bar takes key equivalents such as Cmd+C, V, X, Z and A
before the key window sees them, and reports them into the main window's
input, where they ran on the document even while a text field in a
floating panel's own window had focus. Each panel window notes its text
focus as it draws; while the one with the keyboard has a focused field,
the menu's key presses go to that window's next input instead, with
copy, cut and paste rewritten for the field as in the main window.
2026-10-25 07:18:45 +00:00
aiongg c5f129bc5b Panels: the Studio Properties card stays over the canvas after a reload
craft-ui saves window ids of native windows only, so a reloaded card got
a fresh id and opened as an OS window. Loading a workspace gives the
first in-window floating window of only Properties-group panels the
card's id again.
2026-10-25 07:12:18 +00:00
Khawar Zamman Wani 1ffc4f2bd6 fix(ui-egui): translate refused Pen draft status messages 2026-10-25 12:34:06 +05:30
Khawar Zamman Wani 7996987dfd Make font-family names directly editable with keyboard and preview regressions 2026-10-25 12:27:07 +05:30
aiongg eda4c24d0a Panels: Layers goes down to its native group's smallest height
Its limit follows the other groups' rule (the native minimum less the tab strip). The Curves and Navigator tests keep their original window sizes.
2026-10-25 06:55:48 +00:00
aiongg 09c3954697 Panels: floating panels open in their own OS windows on the desktop
The desktop build enables craft-ui's native-windows feature; the web build
keeps floating panels in the page. Every floating window gets its own OS
window (Ctrl/Cmd-drag, Float Panel, a drop that floats, restored layouts),
except the Studio themes' Properties card, which stays over the canvas.
Wayland keeps floating windows in the main window by craft-ui's rule.

- window.panel.window {panel, native?} runs as craft-ui's command; the web
  refuses it, and so does the Studio card.
- Keys a panel window forwards run PhotoCraft's shortcuts in the same
  frame, clipboard events included; keys held there count as held.
- While a dialog or other modal is open, the panel windows take no input.
- Files dropped on a panel window open as documents.
- Ctrl+click is a secondary click in panel windows on macOS too.
- The canvas paints no tool cursor while another of the app's windows has
  the pointer.
2026-10-25 06:55:48 +00:00
aiongg c84221c8a5 Panels: port the dock tests to the craft-ui dock
Tests read panel places from craft-ui's hit rects and the recorded panel
bodies, and drive tabs and dividers through their hit rects. Tests of
gestures craft-ui now owns and tests (splitter pushing, double-click
collapse, group drags by the strip, tab drags off the strip, the native
legacy-drag promotion, the native strip chevron) are gone; their
PhotoCraft outcomes (persisted tab order and heights, a reordered tab
moving the right panel) stay. The adjustment editors get a window tall
enough for a 560-point Properties group beside Layers' minimum.
2026-10-25 06:25:12 +00:00
aiongg c227685d44 Panels: lay out panel bodies and group heights as the native dock did
Panel bodies in the craft-ui dock take the native dock's card margins
and row spacing (none between rows in the Pro themes), lose the scroll
fade, and self-scrolling panels fill their group. Every Pro theme, the
light ones included, builds the Pro default layout. Groups go down to
the native minimum heights, tab strip included; Layers keeps room for
its controls. A divider drag pins the column's other open groups at the
heights they show, so groups still at their defaults don't jump. The
Auto-Collapse Iconic Panels preference reaches the dock.

Tests find panel bodies, tabs and groups through panel_docking::probe.
2026-10-25 06:25:12 +00:00
FartmanAndBurps 5c5a6888a9 Keep Work Path drag focus reconciliation on the primary canvas
Secondary document views must not cancel a primary-canvas gesture. Cover
secondary focus, genuine primary focus loss, and one-step move history.
2026-10-25 06:19:04 +00:00
Hector VillarrealandClaude Opus 5.5 41eb1de5cf Toolbar: Change Screen Mode is greyed out while Cycle is unavailable
CodeRabbit (review 5641807914, outside-diff, panels.rs:339-359): with no
document in Standard Screen Mode, Cycle is disabled but the toolbar
button stayed live; a click ran it anyway and sent Fullscreen(false)
for no change. The button now follows Cycle's enablement.

Test: screen_mode_button_is_inert_without_a_document.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 00:13:40 -06:00
highperfocused 35dc0d1bee style(ui): satisfy rustfmt for the color HUD 2026-10-25 07:08:28 +01:00
highperfocused 6da3d73771 style(ui): satisfy rustfmt in canvas_tool_menu 2026-10-25 07:07:21 +01:00
Hector VillarrealandClaude Opus 5.5 af57694c7a Screen mode: full screen commands are refused without a document
CodeRabbit (review 5641763378, outside-diff, view_cmds.rs:478-481): the
toolbar's Change Screen Mode list invoked the full screen commands
whatever their enablement, so with no document a click still sent a
full-screen viewport command before the per-frame fallback reverted it.
run now refuses view.screenMode.fullScreen / fullScreenWithMenuBar
without a document (any caller), and the list greys them out.

Test: full_screen_modes_need_a_document (the refused-without-a-document case).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-24 23:58:01 -06:00
skylartaylor 47d552dced M-egui037: reconcile current upstream modal and autosave changes 2026-10-25 06:55:03 +01:00
vngocvan 393645ab91 fix(export): preserve the original source profile 2026-10-25 12:43:51 +07:00
Hector VillarrealandClaude Opus 5.5 35db046d19 Screen mode: Cycle without a document goes straight back to Standard
CodeRabbit (discussion_r4369781534): with no document open in Full
Screen Mode With Menu Bar, Cycle (enabled so it can leave a full screen
mode) stepped on to Full Screen; only the per-frame fallback brought it
back. Without a document Cycle now selects Standard directly.

The toolbar long-press test (#4444) clicked Change Screen Mode with no
document and expected it to cycle into a full screen mode, which #9349
makes unavailable; it now opens a document first.

Test: full_screen_modes_need_a_document (the Cycle case).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-24 23:43:15 -06:00