Preferences > Plug-ins derived the label from the key generatorEnabled
("Generator enabled"); Photoshop says "Enable Generator", which our own
Image Assets error already asks for. Override the label in humanize and
rename the catalog row in the 20 catalogs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The wheel's height subtracted an estimate of the HSB slider rows (3 x ROW_H)
that is lower than the rows really drawn, and was floored at 80 pt, so at the
Color group's default height it ran past the bottom and the panel scrolled.
Measure what the rows used and floor at 28 pt, as the slider modes' ramp.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The crop menu's Reset makes the full-bounds frame a real pending one, so
Commit ran image.crop: a "Crop" history step, and with Delete Cropped
Pixels on, layer pixels outside the canvas were trimmed. Track the reset
frame separately and commit it as a no-op while it still matches the
document bounds (unless it was turned or W x H x Resolution resamples
it), as the untouched default frame already did.
A Pen press on an endpoint of an open path carried it on only for the Work Path or a saved path
(#6593). In Shape mode the press started a new shape layer, and on a targeted vector mask a new
subpath, so a pen shape could not be continued once drawing stopped. Now the selected shape
layer's path (Shape mode) and the targeted vector mask resume like the Work Path, and the commit
updates the same layer in one History step (shape.edit / layer.vectorMask.edit).
Nothing showed that the endpoints can be clicked, either: the Pen now shows Photoshop's
continue-path pointer (the cross with a slash) over an endpoint it would carry on from.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016NgLQVizswqgNnzBv1taRD
A new-box press held past egui's click time and slipped a point or two past
the canvas edge counted as a drag for auto-scroll, while the release still
classifies it as a corner-placing click; the scroll then moved the pointer's
document position and turned the click into a box. `dragging` now uses the
same click test as the release (`is_click`).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Photoshop names a Lab document's Lightness channel Chnl.Lght and rejects
Chnl.Lmnc ("luminance") for Levels, Curves and Apply Image steps. Write
Lght, read Lght, and keep reading the Lmnc that earlier PhotoCraft wrote.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Conflicts with #5547 (Animated Zoom) resolved in wheel_nav.rs, canvas.rs and
panels.rs: the Navigator and canvas pass both Animated Zoom and
!animations_off; with Animation Effects off, the sideways part of an
animated wheel zoom pans by the frame's own events folded by their
modifiers (#4573's unsmoothed scroll) instead of the plain-event raw.x,
so Ctrl + wheel still pans sideways there. #4573's modifier test runs
with Animated Zoom off and on.
Translation catalogs keep main's strings plus the Art History Brush ones
(fr: main already has Area; hi: added the brush strings). docs/scorecard.md
regenerated.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every blend-mode dropdown in the Layer Style dialog took the id
`fx-blend-<effect>`, so Bevel & Emboss's two (Highlight Mode and Shadow
Mode) shared one: the Shadow Mode list opened over the other and a pick
changed the Highlight Mode. Photoshop keeps them independent. The id now
includes the parameter, as the other effect dropdowns already do.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The return to where a panel floated from applies to a single panel; with
group or column true the command docks the panel's group or column as
craft-ui does.
A docking workspace whose version is above what craft-ui reads loads as
the default layout. The preferences and New Workspace save it unchanged
in its place until the layout changes or Reset Workspace runs, as
craft-ui's workspace docs ask.
A panel window forwards no releases once the main window or no window of
the app has the keyboard (the app was switched away with Space held), or
once one of its widgets takes keyboard focus. Keys it forwarded count as
held only while it has the keyboard and none of its widgets has focus.
Forwarded keys run no shortcuts while the screen color picker is open,
as the main window's don't.
A move or resize by the OS title bar or edges changes a panel window's
place each frame with no button down in the app's windows, which wrote
the preferences at frame rate. The layout is saved once the places keep
still for a frame.
On macOS the menu bar takes key equivalents such as Cmd+C, V, X, Z and A
before the key window sees them, and reports them into the main window's
input, where they ran on the document even while a text field in a
floating panel's own window had focus. Each panel window notes its text
focus as it draws; while the one with the keyboard has a focused field,
the menu's key presses go to that window's next input instead, with
copy, cut and paste rewritten for the field as in the main window.
craft-ui saves window ids of native windows only, so a reloaded card got
a fresh id and opened as an OS window. Loading a workspace gives the
first in-window floating window of only Properties-group panels the
card's id again.
The desktop build enables craft-ui's native-windows feature; the web build
keeps floating panels in the page. Every floating window gets its own OS
window (Ctrl/Cmd-drag, Float Panel, a drop that floats, restored layouts),
except the Studio themes' Properties card, which stays over the canvas.
Wayland keeps floating windows in the main window by craft-ui's rule.
- window.panel.window {panel, native?} runs as craft-ui's command; the web
refuses it, and so does the Studio card.
- Keys a panel window forwards run PhotoCraft's shortcuts in the same
frame, clipboard events included; keys held there count as held.
- While a dialog or other modal is open, the panel windows take no input.
- Files dropped on a panel window open as documents.
- Ctrl+click is a secondary click in panel windows on macOS too.
- The canvas paints no tool cursor while another of the app's windows has
the pointer.
Tests read panel places from craft-ui's hit rects and the recorded panel
bodies, and drive tabs and dividers through their hit rects. Tests of
gestures craft-ui now owns and tests (splitter pushing, double-click
collapse, group drags by the strip, tab drags off the strip, the native
legacy-drag promotion, the native strip chevron) are gone; their
PhotoCraft outcomes (persisted tab order and heights, a reordered tab
moving the right panel) stay. The adjustment editors get a window tall
enough for a 560-point Properties group beside Layers' minimum.
Panel bodies in the craft-ui dock take the native dock's card margins
and row spacing (none between rows in the Pro themes), lose the scroll
fade, and self-scrolling panels fill their group. Every Pro theme, the
light ones included, builds the Pro default layout. Groups go down to
the native minimum heights, tab strip included; Layers keeps room for
its controls. A divider drag pins the column's other open groups at the
heights they show, so groups still at their defaults don't jump. The
Auto-Collapse Iconic Panels preference reaches the dock.
Tests find panel bodies, tabs and groups through panel_docking::probe.
CodeRabbit (review 5641807914, outside-diff, panels.rs:339-359): with no
document in Standard Screen Mode, Cycle is disabled but the toolbar
button stayed live; a click ran it anyway and sent Fullscreen(false)
for no change. The button now follows Cycle's enablement.
Test: screen_mode_button_is_inert_without_a_document.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CodeRabbit (review 5641763378, outside-diff, view_cmds.rs:478-481): the
toolbar's Change Screen Mode list invoked the full screen commands
whatever their enablement, so with no document a click still sent a
full-screen viewport command before the per-frame fallback reverted it.
run now refuses view.screenMode.fullScreen / fullScreenWithMenuBar
without a document (any caller), and the list greys them out.
Test: full_screen_modes_need_a_document (the refused-without-a-document case).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CodeRabbit (discussion_r4369781534): with no document open in Full
Screen Mode With Menu Bar, Cycle (enabled so it can leave a full screen
mode) stepped on to Full Screen; only the per-frame fallback brought it
back. Without a document Cycle now selects Standard directly.
The toolbar long-press test (#4444) clicked Change Screen Mode with no
document and expected it to cycle into a full screen mode, which #9349
makes unavailable; it now opens a document first.
Test: full_screen_modes_need_a_document (the Cycle case).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>