Commit Graph
11425 Commits
Author SHA1 Message Date
Don Omondi e53f822032 Retry SVG saves that change during a read without reporting an error
When the working file changed between settling and reading, the watcher
sent "The SVG is still being saved" to the UI as an error. Treat that
result as a retry: clear the pending stamp so the new save settles again,
and send nothing. Other read errors are still reported once.

Tests cover the retry, single reporting of other errors, queue
backpressure and receiver drop, and a stress run of atomic replacements
that must deliver only complete saves ending with the final one.
2026-10-27 14:29:53 +03:00
Luisandbommerts 314c58aebe Color Lookup: test the LUT folder menu through the real dialog
Opens the dialog, clicks the folder entry in the dropdown, confirms, and checks
the applied pixels and Undo/Redo; also checks that .3dl and .look files are
listed.

Co-authored-by: bommerts <44821497+bommerts@users.noreply.github.com>
2026-10-27 12:24:58 +01:00
mahefanante 87d4098cbd Fix: apple gpu 2026-10-27 10:41:07 +00:00
Luis fcfabd4878 Color Lookup: keep a picked LUT folder file clearable after it leaves the folder
A file picked from the LUT folder is remembered in a private __folderLut field,
so the menu keeps showing it even once a later scan no longer lists it, and
picking another entry still clears file instead of sending a missing path to
the command.
2026-10-27 11:37:57 +01:00
Vlad Grankovsky 8ca3410a54 Merge origin/main into codex/multi-channel-editing
Integrate main 7ac7b8b10 with selection morphology and cropped feather-mask optimizations. Preserve both progress-document histories.
2026-10-27 11:31:28 +01:00
x-labb e8b906f5d9 fix(ui): Free Transform keeps plain layers over the moving one under a blend or adjustment layer (#9387)
The preview draws the layers over the moving layer on top of it again, but
the search for them stopped at the first layer that isn't plain (an
adjustment, a blend mode), so every layer under that one, including plain
Normal layers over the moving layer, stayed under the box and the moving
layer was drawn over them. A PSD usually has such a layer somewhere on top.

Pass over layers that can't be drawn alone instead of stopping, so the plain
layers around them still cover the moving layer. An adjustment layer over
covering layers stays in the document under the box and is composited with
them too, so they keep its adjustment. Layers with a blend mode still stay
under the box, and the moving layer is not adjusted or blended by what is
over it in the preview.
2026-10-27 11:10:41 +01:00
Luis-0508 3fa692a082 contributors: add Luis-0508 2026-10-27 10:45:37 +01:00
Khawar Zamman Wani f4742dd8aa test: update copy-on-write document selection 2026-10-27 15:13:46 +05:30
Luis-0508 e0cc12d403 Color Lookup: list the LUT folder in Image > Adjustments (#9754)
The Image > Adjustments > Color Lookup dialog is built from the command
schema, whose lut choices are the built-in looks only. The LUT folder
(Preferences > File Handling) was scanned for the adjustment layer's
Properties menu but not for this dialog.

The dialog now reuses the same cached background folder scan and lists
the folder's files after the built-ins. A picked file is passed to the
command as `file` with `lut: none`; choosing another entry afterwards
clears that file again.
2026-10-27 10:41:40 +01:00
Don Omondi dadc7ff2ca Format smart object test imports 2026-10-27 12:19:01 +03:00
Khawar Zamman Wani d1d9780ce8 test: import selection surface types 2026-10-27 14:47:25 +05:30
Brennan StehlingandClaude Opus 5.5 517eb6f2e4 Render path: a software adapter records its startup reason though it runs the GPU canvas (#9328)
set_wgpu builds the GPU canvas on a software adapter, so startup returned on app.gpu before it
recorded CpuReason::SoftwareAdapter, and the status bar and perf.renderPath left it out. The
software-adapter check no longer needs the window to be without a GPU canvas; CPU mode still
does, and a hardware adapter records no reason. Retry GPU's rebuilt canvas checks it again.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 02:10:01 -07:00
Brennan StehlingandClaude Opus 5.5 b0688ee9a3 Render path: the status bar names a non-memory reason, and perf.gpuFallback follows the active document (#9328)
A reason other than the memory budget (a flipped view, Advanced Blending…)
now shows "CPU Rendering" even while the measured layer fit is over the
budget. perf.gpu_fallback is set in one place from the active document's
reason, also each frame after a switch of document, so a refresh of an
arranged cell or another window can't make it disagree with
perf.renderPath's current. The control protocol says a history entry's doc
is the changed document's id, or 0 for every document.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 02:07:25 -07:00
Brennan Stehling ae043f50a0 Render path: the adjustment preview's CPU-proxy reason has its own slot (#9328)
A clipped or Blend If adjustment preview runs on the CPU proxy. Its reason
lives in a slot of its own, separate from the canvas's per-document reasons
and the app-wide reason, so closing or retargeting the dialog ends only the
preview's entry and can never report the canvas back on the GPU.
2026-10-27 02:07:25 -07:00
Brennan StehlingandClaude Opus 5.5 63b718a0b3 Docs: perf.renderPath in the control protocol and the development guide (#9328)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 02:07:25 -07:00
Brennan StehlingandClaude Opus 5.5 dfdfb50339 Render path: one place records why a view left the GPU, typed, logged once per change and shown in the status bar (#9328)
render_path::note is the single entry point for every GPU exit (over budget, canvas too large,
compositor build failure, device loss, unsupported layers, clipped adjustment preview, flipped
view, software adapter or CPU mode at startup). It replaces the four direct writes of
perf.gpu_fallback and the three ad-hoc log lines, stops the over-budget log from repeating after
each brush dab, gives the over-budget reason its numbers, and records the exits that were silent.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-27 02:07:25 -07:00
Don Omondi 285770532b Merge main into embedded vector save-back
Resolve conflicts with the engine's cmd/ module move and the per-crate
integration test binaries. Run a selected VectorCraft.app bundle directly
(identified by bundle id) and reject nested gzip in bounded SVG parsing.
2026-10-27 11:59:56 +03:00
rus152andClaude Opus 5.5 6de1d47ac9 Layers panel: Convert to Shape and Create Work Path on type layers
The Layers panel context menu of a type layer offers Create Work Path
and Convert to Shape after Rasterize Type, in Photoshop's order. Both
run the existing type.createWorkPath and type.convertToShape commands.
The multi-selection menu is unchanged (one Rasterize item).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-27 12:45:07 +04:00
Khawar Zamman Wani 6daf9731f1 test(curves): use current egui ID constructor 2026-10-27 14:12:06 +05:30
Khawar Zamman Wani a8c992da50 test(curves): keep polyline tests after editor implementation 2026-10-27 14:03:36 +05:30
Khawar Zamman Wani 77ddfaca64 perf(curves): sample graph directly and cache channel polylines 2026-10-27 13:59:41 +05:30
Khawar Zamman Wani ffd9ec70c5 fix(selection): ignore off-canvas remnants when deselecting 2026-10-27 13:58:29 +05:30
PerchAnton 8bb0a5e674 Merge main and preserve automation root alias tests in extracted module 2026-10-27 10:27:26 +02:00
Khawar Zamman Wani 9722d16909 perf(selection): retain direct Replace path and tighten validation 2026-10-27 13:19:08 +05:30
Khawar Zamman Wani 34af1d8e66 fix(engine): convert Bitmap images in bands 2026-10-27 13:18:39 +05:30
mahefanante 779424dade Fix: selection de tracé autre que celle active sans shortcut modifié 2026-10-27 07:37:21 +00:00
Khawar Zamman Wani 8324e278a1 perf(selection): combine GRAY8 masks directly in tiles 2026-10-27 12:42:18 +05:30
dotCooCoo 92b4e9b9de Cancel pending link scans when closing a document
Discard background scan results when a document closes so they cannot change the missing-link state after the same document reopens.
2026-10-27 00:11:47 -07:00
Khawar Zamman Wani 32e166b720 perf(selection): scope Color Range sampling to active bounds 2026-10-27 12:37:05 +05:30
mahefanante 0c951ffdb5 Fix: selection de tracé autre que celle active 2026-10-27 07:02:21 +00:00
jacabusandClaude Sonnet 4.6 e4be1a3cda feat(atn): gradientLayer import and Blnd blend-if support
Fixes two engine gaps identified in ARTCRAFT-PC-2026-001:

1. gradientLayer in make_from / set_from (Spotlight, Vignette — BLOCKED → PASS)
   - Add gradientLayer arm in make_from contentLayer branch: maps to
     layer.newFillLayer.gradient + gradient.fill.set (two steps via steps())
   - Add gradientLayer arm in set_from contentLayer branch: maps to gradient.fill.set
   - Both use existing commands; no new commands or data models required
   - New helpers: gradient_layer_params, gradient_layer_set_params,
     gradient_color_stops, gradient_transparency_stops, GRADIENT_STYLES

2. Blnd (blend-if) in set_from for (Some("Lyr"), _) (Highlights/Midtones/Shadows — PARTIAL → PASS)
   - Read Blnd list from T descriptor; map each entry via CHANNELS table
   - Emit layer.setProps {"blendIf": [...]} step; layer.setProps already
     accepts blendIf at layer_menu_cmds.rs:461 — importer-only change
   - SrcB/Srcl/SrcW/Srcm → thisLayer; DstB/Dstl/DstW/Dstt → underlying
     (field mapping verified by fixture test 2026-10-27)

All changes confined to crates/engine/src/atn_cmds.rs.
No new commands. No new data models. No engine changes.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-10-27 17:52:25 +11:00
Khawar Zamman Wani 761c46c56e perf(selection): combine marquee additions and subtractions sparsely 2026-10-27 12:15:33 +05:30
dotCooCoo f3afeaaf54 Refresh the open Print dialog after spooler contention ends
Retry printer enumeration after a busy result and restore the available printer controls without reopening the dialog. Cover opening and drawing the dialog while the spooler is held, then drawing it after release.
2026-10-26 23:39:59 -07:00
dotCooCoo e670397fe0 Keep uncached printer listings responsive while the spooler is busy
Return an empty or unsupported result when the spooler lock is held and no matching cached printer list exists. Preserve the source-specific cache and cover empty and mismatched caches with regression tests.

Merge current main and move the Print dialog changes into its extracted modules.
2026-10-26 23:30:52 -07:00
Khawar Zamman Wani 67172a9d08 Merge origin/main into fix/6501-multi-layer-free-transform 2026-10-27 11:57:10 +05:30
Khawar Zamman Wani ec1ca061ef Merge origin/main into fix/8169-huge-tiff-open 2026-10-27 11:56:24 +05:30
Khawar Zamman Wani 26d0b9c41c Merge origin/main into select-mask-workspace 2026-10-27 11:55:36 +05:30
dotCooCoo 8073571ad9 Clean up Smart Object filter test fixtures
Keep the temporary directory handle alive in both fixture users so each
directory is removed when its test finishes.
2026-10-26 22:58:30 -07:00
Khawar Zamman Wani dfcca03911 Type insertion style: keep the pending caret font across Backspace and Delete 2026-10-27 11:17:59 +05:30
dotCooCoo 9ee59ff493 Keep Artboard filtering safe for deeply nested groups
Traverse artboard descendants with an explicit stack. Cover 16,384 nested
groups on a 128 KiB thread stack and retain selection-based filtering.
Merge main and move the control test into the extracted test module.
2026-10-26 22:38:45 -07:00
Khawar Zamman Wani 243ecf4ce2 test(selection): use the grayscale pixel format at each depth 2026-10-27 11:01:59 +05:30
Khawar Zamman Wani e65f25fbeb perf(selection): crop Smooth and Feather command masks 2026-10-27 10:56:00 +05:30
dotCooCoo 8dd05a03bd Merge main into the Smart Object layer filter
Keep the Smart Object filter and missing-link state handling in the extracted
engine and UI modules. Retain the Histogram control documentation.
2026-10-26 22:17:11 -07:00
aiongg 7ac7b8b106 refactor(selection): take the feather reach from the blur (#9802)
The feather's ⌈3σ⌉ truncation radius was written out in the blur and again in two engine callers: the windowed marquee and lasso feather (#9794) and the canvas-edge padding of Select › Modify › Feather. selection::feather_reach returns it from the blur's own σ rules, and both callers use it, so a change to the blur's reach can't leave them behind. Output is unchanged; a test pins that the feather leaves everything past its reach at zero.
2026-10-27 01:07:05 -04:00
aiongg 805ed134e4 Merge pull request #9697 from wanikhawar/perf/selection-morphology
Expand, Contract and Border: crop to the selection, up to 40× faster on small selections
2026-10-27 00:56:40 -04:00
aiongg a27436adcb Merge main into perf/selection-morphology
Resolves the move of crates/engine/src/selection_cmds.rs to cmd/selection_cmds.rs: the two hunks apply at the new path, and modify_window.rs with its tests moves under cmd/selection_cmds/.
2026-10-27 04:27:45 +00:00
Khawar Zamman Wani f15c93ce73 Merge origin/main into pen-path-operations 2026-10-27 09:49:45 +05:30
Khawar Zamman Wani ba43eb3ea5 Merge origin/main into save-for-web-webp 2026-10-27 09:44:59 +05:30
Khawar Zamman Wani 55b8df82fc perf(selection): window marquee and lasso feather masks (#9794)
* perf: window marquee and lasso feather masks to drawn bounds

* perf: benchmark small feathered tool selections on a 24 MP canvas
2026-10-27 00:12:47 -04:00
Khawar Zamman Wani 2c2faad9ae Merge origin/main into fix/6501-multi-layer-free-transform 2026-10-27 09:42:36 +05:30