Commit Graph
11425 Commits
Author SHA1 Message Date
David MannandClaude Opus 5.5 fda46b391d Address CodeRabbit review: Match Zoom and Match Location report the camera's rotation
They copy no rotation, so the crop's turn isn't left out of their result; only Match Rotation
and Match All report the crop-adjusted value they copy.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 17:36:55 +01:00
David Mann ea4231fa43 Merge remote-tracking branch 'origin/main' into HEAD 2026-10-29 17:27:31 +01:00
David MannandClaude Opus 5.5 b309b27844 Address CodeRabbit review: the crop box's H, P and I refuse Alt too
egui's `matches_logically(Modifiers::NONE)` ignores Alt as well as Shift, so Alt+H, Alt+P and
Alt+I toggled Show Cropped Area, Classic Mode and Front Image; they are now left for later
handlers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 17:27:22 +01:00
David MannandClaude Opus 5.5 7a1d2dfd4c Tests: image.crop rounds fractional rectangle sizes like its other pixel params
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 17:27:14 +01:00
David Mann cc2d0b83e9 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	docs/ui-parity.md
2026-10-29 17:23:11 +01:00
David Mann 1d0d0db258 Merge remote-tracking branch 'origin/main' into HEAD 2026-10-29 17:21:32 +01:00
David MannandClaude Opus 5.5 cf9a7254d5 Address CodeRabbit review: budget the image between bicubic passes
A bicubic shrink of both axes stores the image between its two passes
with one axis still at its old size, larger than the result. The hidden
pixel budget now checks the largest rectangle of each surface's pass plan
(algo::resample::largest_resize_rect), masks, channels and the selection
with their Bilinear filter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 17:20:25 +01:00
David Mann 9cc6ff2470 Merge remote-tracking branch 'origin/main' into HEAD 2026-10-29 17:19:39 +01:00
David MannandClaude Opus 5.5 ec49d0b582 Address CodeRabbit review: end a crop drag before the frame sees a tool switch
The canvas ends the gesture before `ensure_frame` (which dropped the untouched default frame
under the box being drawn, and the Hand never reached `tool_event`), keeping the pen eraser
exception. A press inside the default frame that never moves is no edit, so leaving still drops
a selection-derived default frame.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 17:19:25 +01:00
aiongg c645d5fcc9 Merge pull request #8896 from wanikhawar/select-mask-workspace
Select and Mask: Photoshop's full-window workspace (#7069, #8148)
2026-10-29 12:15:14 -04:00
aiongg 2231233af9 Merge pull request #6590 from wanikhawar/fix/6501-multi-layer-free-transform
Free Transform moves every selected layer (#6501, #3384, #6096)
2026-10-29 12:14:01 -04:00
aiongg 3bcff338c5 Merge pull request #6421 from wanikhawar/save-for-web-webp
Save for Web: WebP, lossy at its Quality or lossless (part of #6391, #2415)
2026-10-29 12:12:47 -04:00
Khawar Zamman Wani 82096cff3a perf(retouch): avoid duplicate rasterization while drawing (#9532)
* perf(retouch): generate live dabs without unused coverage

* fix(ui): box live stroke variants after retouch state reduction
2026-10-29 12:12:33 -04:00
Khawar Zamman Wani 539f5bd58f perf(algo): row-parallel local_sharpen with fast-path protect_detail (#5426) (#9651)
* perf(algo): row-parallel local_sharpen with fast-path protect_detail (#5426)

Refs #5426. Follow-up to #5499.

Cause:
While #5499 parallelized local_blur and the per-dab mix in DabTool::Focus,
local_sharpen in crates/algo/src/retouch.rs remained single-threaded.
In addition, protect_detail redundantly evaluated coordinate clamping
and strided memory lookups across 8 neighbors inside the per-channel
inner loop for every pixel in the dab. On large brush sizes (e.g. 1000–2500 px),
strokes took seconds and stalled the application.

Change:
- Process local_sharpen window rows in parallel with Rayon across threads,
  with wasm32 serial fallback matching local_blur.
- Hoist protect_detail 3x3 neighborhood offset calculations outside the
  channel loop.
- Fast-path interior pixels (x > 0 && x + 1 < w && y > 0 && y + 1 < h)
  with direct stride offsets, skipping boundary clamping entirely for >99.9%
  of pixels in large brush dabs.
- Add retouch_sharpen_exact integration test verifying bit-for-bit parity
  against the frozen scalar implementation across layouts, edges, and channels.

* bench(engine): add bench_sharpen_tool example
2026-10-29 12:11:22 -04:00
David MannandClaude Opus 5.5 cd01064dc2 Address CodeRabbit review: cost pattern filters at resvg's scale-only tile transform
resvg renders a pattern's root under Transform::from_scale(get_scale()) of
the path transform times patternTransform, so a skewed patternTransform
with slim full-affine bounds drew a much larger filter region than the
estimate charged (1.06e9 vs about 1.9e11 reads).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 17:10:41 +01:00
Khawar Zamman Wani 6c6cfc243a perf(stack): cache bounded entropy terms across pixels (#9622)
* perf(stack): cache bounded entropy terms across pixels

* test(stack): iterate entropy terms directly for Clippy

* ci: rerun checks
2026-10-29 12:10:12 -04:00
David MannandClaude Opus 5.5 b69f56de4d Scorecard: regenerate after merging main (#3634)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 17:09:17 +01:00
David Mann b15b5d0775 Merge remote-tracking branch 'origin/main' into HEAD 2026-10-29 17:07:07 +01:00
David Mann 6144925b65 Merge fix/snapshot-followups (#6088, with origin/main 66ac154d68) into feat/history-snapshot-options 2026-10-29 17:06:45 +01:00
David Mann dd1af3b43a Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/engine/src/lib.rs
#	crates/engine/src/session/documents.rs
#	crates/engine/src/session/execute.rs
#	crates/engine/src/session/layers.rs
#	crates/ui-egui/src/dialogs/history_options_ui.rs
#	crates/ui-egui/src/history_options_ui.rs
#	crates/ui-egui/src/i18n/cs.tsv
#	crates/ui-egui/src/i18n/de.tsv
#	crates/ui-egui/src/i18n/ko.tsv
#	crates/ui-egui/src/i18n/vi.tsv
#	crates/ui-egui/src/i18n/zh-hans.tsv
#	crates/ui-egui/src/i18n/zh-hant.tsv
#	crates/ui-egui/src/menus/invoke.rs
#	crates/ui-egui/src/panels/history_options_ui.rs
#	crates/ui-egui/src/text/served_fonts.rs
#	docs/scorecard.md
#	docs/ui-parity.md
2026-10-29 17:06:45 +01:00
David Mann b14a913c16 Merge remote-tracking branch 'fork/fix/5495-dropdown-height' into HEAD
# Conflicts:
#	crates/ui-egui/src/panels/options_bar.rs
#	crates/ui-egui/src/widgets.rs
#	crates/ui-egui/src/widgets/dropdown.rs
#	crates/ui-egui/src/widgets/tests.rs
2026-10-29 17:03:48 +01:00
David Mann 79868babc3 Merge remote-tracking branch 'origin/main' into HEAD 2026-10-29 17:03:35 +01:00
David Mann 3d657fb347 Merge remote-tracking branch 'origin/main' into HEAD 2026-10-29 17:03:10 +01:00
David MannandClaude Opus 5.5 75bc29f6c5 Tests: the Move marquee test reads the slanted ant edges main's device-pixel ants draw
Main's #7530 draws marching ants as a pixel mesh plus white base segments for slanted edges, so the
rotated Move-tool marquee is no longer one white closed path.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 17:02:09 +01:00
David MannandClaude Opus 5.5 0dfbbbf1a9 Crop: the click guard skips the snap on release again
An earlier merge (f35107a8ea, snap_ui.rs moved into canvas/) applied the
guard's hunk to the Move branch, whose context lines match the Up branch's.
A click has no Move, so its release still snapped the frame and the test
a_click_on_the_frame_or_a_handle_never_snaps_it failed. The guard is back
on Up, where a release at the press point leaves the frame alone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 17:01:52 +01:00
David Mann c3390ca05d Merge fix/snapshot-followups (#6088) into feat/history-snapshot-options
# Conflicts:
#	crates/engine/src/cmd/type_cmds/tests.rs
#	crates/engine/src/session/layers.rs
2026-10-29 17:01:29 +01:00
Khawar Zamman Wani 42870a6851 TIFF: account for ancestor cgroup swap limits 2026-10-29 21:26:31 +05:30
David Mann 5803f13dc0 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/engine/src/session/layers.rs
#	crates/ui-egui/src/text/served_fonts.rs
2026-10-29 16:53:38 +01:00
David Mann 81feb006ba Merge remote-tracking branch 'origin/main' into HEAD 2026-10-29 16:52:56 +01:00
David Mann d1af5a2867 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/ui-egui/src/canvas.rs
2026-10-29 16:50:35 +01:00
David Mann d389b88b59 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/ui-egui/src/dialogs/adjust_editors/gradient_map.rs
#	crates/ui-egui/src/tools/crop_presets.rs
#	crates/ui-egui/src/tools/type_tool/options_bar.rs
#	crates/ui-egui/src/widgets/dropdown.rs
2026-10-29 16:50:14 +01:00
David MannandClaude Opus 5.5 77339962cc xtask: panel-commands allowlist follows main's panels/ split; lexer helpers keep clippy's complexity limit
Main moved crates/ui-egui/src/panels.rs into panels/*.rs, so the color_field entry now names
panels/color.rs (scorecard note too), and main's cognitive_complexity deny split lex()'s block
comment and string skipping into helpers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 16:49:12 +01:00
David Mann 5dd023f949 Merge remote-tracking branch 'origin/main' into HEAD 2026-10-29 16:45:03 +01:00
David Mann 57bcbfaba9 Merge remote-tracking branch 'origin/main' into HEAD 2026-10-29 16:44:46 +01:00
David Mann 55d0532fb7 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/ui-egui/src/canvas.rs
2026-10-29 16:41:55 +01:00
David Mann afacb057f7 Merge origin/main into pr-8571-fixup
Conflicts: svg.rs (main's bufread inflate and shared render helper, kept
with the PR's bounded raster path), psd_import.rs (the PR's vector
preview moved into main's smart_content), menus/invoke.rs (the SVG
intercept moved into main's split invoke_unguarded), rendering.rs and
the ui-egui import lists (main's explicit imports), Cargo.lock, docs
status lines (unions).
2026-10-29 16:38:24 +01:00
Khawar Zamman Wani 66ac154d68 perf(algo): select median stack samples without full sorting (#9628) 2026-10-29 11:36:34 -04:00
Khawar Zamman Wani 6b2ad6b620 Reduce Noise: reuse guide statistics with bit-identical output (#9639)
* perf(algo): reuse Reduce Noise guide statistics

* fix(algo): use fixed-size chunks for guide statistics

* Reduce Noise: test that the caller routes the cleaned luma guide and both chroma planes

Review follow-up: compares reduce_noise's output (Lab, so planes pass through) with the
independent guided filters run in order.

* test(algo): assert bit-identical output in Reduce Noise routing test
2026-10-29 11:35:24 -04:00
Khawar Zamman Wani 991ef9907b fix(actions): allow no-op Arrange steps during playback (#8457) 2026-10-29 11:34:13 -04:00
David Mann 010ab858e7 Merge PR #7716: Add Pattern Fill option to Layer Panel Footer 2026-10-29 16:26:56 +01:00
David MannandClaude Opus 5.5 72a7caf04a Integration: path.addToSelection/subtractFromSelection name document paths, not files (#8015)
Their params doc mentions path.toSelection, so the automation filesystem-path
classifier test flagged them; they take a document path name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 16:14:58 +01:00
3968e24cf0 Integration: the empty-layer check honours the default pixel and video (#7716)
`is_empty_pixel_layer` took any layer without stored tiles for empty, so a
layer opaque only through its default pixel (as KRA imports it,
`Surface::with_default`) or a blank video layer became the Pattern Fill
(and the Stamp Visible target) instead of getting one above. It now
needs a transparent default pixel (alpha only: a mode or profile
conversion gives an empty layer's default pixel other colour bytes) and
no video.

Co-authored-by: Hodd <32705043+hodd1444@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 16:12:49 +01:00
David Mann b4a5ddf2e1 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/ui-egui/src/control/dispatch.rs
2026-10-29 15:53:09 +01:00
David Mann 0e72c418da Merge remote-tracking branch 'origin/main' into pr-7716-fixup
# Conflicts:
#	crates/engine/src/cmd/pattern_cmds.rs
#	crates/ui-egui/src/panels.rs
2026-10-29 15:45:55 +01:00
David Mann cf66eea4c9 Merge PR #8015: Added advanced selections keyboard shortcuts 2026-10-29 15:45:22 +01:00
David Mann 601f2ed7f9 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/ui-egui/src/i18n.rs
#	crates/ui-egui/src/i18n/LICENSE-translations.txt
#	crates/ui-egui/src/i18n/live_tests.rs
#	crates/ui-egui/src/i18n/system.rs
#	docs/localization-parity.md
2026-10-29 15:41:15 +01:00
David Mann 28b093387f Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/engine/src/cmd/layer_multi_cmds/moves.rs
2026-10-29 15:40:24 +01:00
David Mann b87c27dba3 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/ui-egui/src/tools/crop_ui.rs
2026-10-29 15:40:03 +01:00
David Mann 5564f60bec Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/ui-egui/src/panels/options_bar.rs
2026-10-29 15:38:49 +01:00
c53409b451 Integration: Ctrl+Shift/Alt+Enter take the path being drawn, as Ctrl+Enter (#8015)
The new keys went straight to the engine with the Paths-panel path name
injected in PhotocraftApp::run, skipping the route Ctrl+Enter takes
(vector_ui::path_to_selection). So a Pen path still being drawn was not
finished and used: Pen, three clicks, Ctrl+Shift+Enter combined the old
work path (or failed with "no work path") and left the Pen path open,
and the loaded path stayed selected. Both ids now go through the same
route with the mode forced to add/subtract, and the injection is gone.

Also removes crates/ui-egui/src/vector_cmds.rs, an uncompiled byte-for-
byte copy of the old engine file, and makes the add test check that both
areas end up selected.

Co-authored-by: mahefanante <42338306+mahefanante@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-29 15:31:26 +01:00