Commit Graph
11425 Commits
Author SHA1 Message Date
yoriswind d35d966bed Preserve small transform handles and projected edge points 2026-11-03 20:36:06 -08:00
yoriswind 814c2baf93 test(crop): cover turning grid through canvas paint 2026-11-03 20:31:43 -08:00
NaufalDzz 92e40f9dad Layers panel: applying a filter deselects the layers it hides (#10879)
When the filter is applied or its criteria change while it filters, the
selected layers it no longer lists are deselected, as in Photoshop: through
select.deselectLayers when none stays listed, otherwise the listed ones stay
selected and one of them becomes the active layer. Turning the filter off
changes nothing, and a layer selected later while it is filtered out stays
selected. The criteria last seen are kept in egui memory, so a change made
through ui.set {layerFilter} is handled too.

Fixes #10879
2026-11-04 11:30:01 +07:00
yoriswind 8038f78059 Align ATN export tests with lossless native command preservation 2026-11-03 20:06:44 -08:00
yoriswind c09886c9b2 Resolve strict lint in the Actions library integration 2026-11-03 20:06:44 -08:00
yoriswind 9efa1735ee Select an older text layer in recorded path playback tests 2026-11-03 20:05:36 -08:00
yoriswind 7a999cad6e Apply paused action invariants across preference and spelling paths 2026-11-03 20:02:52 -08:00
yoriswind 280ddd2a7d Match each committed layer to the rotation preview 2026-11-03 20:02:32 -08:00
yoriswind 85ecb52b2b Use the painted crop frame for visible guide geometry 2026-11-03 20:01:11 -08:00
yoriswind 98369cfcf0 Remove the unused Gradient integration test import 2026-11-03 19:57:59 -08:00
NaufalDzz 10876cb20d feat(atn): load and save Blend If and Gradient Fill layers
Blend If in a recorded layer Set loads as layer.layerStyle.blendingOptions
and plays (it was dropped without a word). The Blending Options dialog's
Set (opacity, fill, mode, Blend If, Advanced) stays one step and saves back
as one Set; with other keys those go through layer.setProps.

Gradient Fill Make and Set load as layer.newFillLayer.gradient and
gradient.fill.set with stops, transparency, midpoints, scale, offset,
dither and align. Midpoint k is the Mdpn of stop k + 1, as the PSD reader
reads it. A loaded step saves back as its recorded descriptor until it is
edited; a Noise gradient, smoothness below 100 %, a non-classic
interpolation or a transparency midpoint stay Photoshop steps.

Fixes #10771
2026-11-04 10:54:58 +07:00
yoriswind f135134eb3 Accept recorded Gradient descriptor classes and cover boundaries 2026-11-03 19:52:22 -08:00
yoriswind 49575e3a81 Keep invalid points outside Move transform control activation 2026-11-03 19:51:50 -08:00
yoriswind 1f6dd500d9 Merge commit '37a01ca8746c121170644a07968d11263ef64407' into codex/10986-batch14-main 2026-11-03 19:50:30 -08:00
yoriswind 4edd0914b0 Exercise unopened Move edge controls through native dispatch 2026-11-03 19:49:56 -08:00
yoriswind 28b53ac6eb Check recorded work paths against the active layer glyphs 2026-11-03 19:46:47 -08:00
yoriswind d68c29b74a Generate crop turning guides for the visible frame extent 2026-11-03 19:40:31 -08:00
yoriswind 211efca709 Keep paused action policy and spelling receivers bound 2026-11-03 19:39:45 -08:00
yoriswind a6613b260c Exercise preserved Type Path descriptors during playback 2026-11-03 19:39:13 -08:00
yoriswind 5e1e4b8502 Keep the transform controls point constructor test-only 2026-11-03 19:36:59 -08:00
yoriswind 6eb625ccbf Orient transform rotate arrows by quad winding 2026-11-03 19:35:45 -08:00
yoriswind 2974772936 Map supported classic Gradient action recordings 2026-11-03 19:32:28 -08:00
yoriswind 16b24885e6 Support recorded Type Create Work Path actions 2026-11-03 19:28:31 -08:00
yoriswind 9fe868fb67 Merge remote-tracking branch 'origin/main' into codex/move-controls-pointer-11105 2026-11-03 19:27:35 -08:00
yoriswind 9b3febb11c Keep control-channel transform activation inside the canvas 2026-11-03 19:25:04 -08:00
yoriswind aafe62fa91 Show a centred crop grid while turning 2026-11-03 19:22:53 -08:00
yoriswind d630efdce2 Use whole-edge transform handles and consistent rotate cursors 2026-11-03 19:22:40 -08:00
yoriswind 6d247886a7 Test ATN layer style playback in both history modes 2026-11-03 19:22:21 -08:00
NaufalDzz 38bf95795d Merge origin/main into the Blend If and gradient layer actions work
main moved atn_cmds.rs to crates/engine/src/cmd/atn_cmds/; the mapping is ported there in the next commit.
2026-11-04 10:04:24 +07:00
yoriswind cc0781c031 Describe the implemented ATN library in editor documentation 2026-11-03 18:56:13 -08:00
yoriswind 84ff13327d Share recording projection between Classic and editor drafts 2026-11-03 18:56:13 -08:00
NaufalDzz a28aa21828 fix(transform): refuse the Background among several layers and apply the box on a selection change
Free Transform of several selected layers left the Background out
without a word, where Photoshop refuses with its locked-layer alert. And
with the box open, taking a layer out of the selection (or adding one)
without changing the active layer left the box open, still moving the
layers it started with.

- targets_of keeps the Background; edit.transform's selection default
  refuses with `layer "Background" is locked`, and Ctrl+T / Edit ›
  Transform show the same alert as a position-locked layer. An explicit
  `layers` list and the Background alone keep today's behaviour.
- Move › Show Transform Controls shows no box for that selection either.
- Any change to the selected layers while a layer box is open applies
  the box to the layers it moves, and doesn't open it again.

Fixes #11101
2026-11-04 09:51:52 +07:00
yoriswind 771e0ebae1 Test grouped ATN saves without flattening the library 2026-11-03 18:23:43 -08:00
Dylan M. Taylor 37a01ca874 format: bound blob inflation by the load's remaining budget; browser budgets (#10984)
LoadFetch::blob_bounded decompressed a new blob up to max_blob_bytes
and only then charged it against max_total_bytes. Successful blobs are
retained, so several distinct, highly compressible blobs each allocated
a full max_blob_bytes before the total was checked. A new blob may now
inflate only to what the total budget has left.

The browser build loaded native documents with the desktop defaults
(1 GiB a blob, 16 GiB in all), far beyond a wasm32 instance's 4 GiB of
linear memory that the editor also uses. On wasm32 the defaults are now
512 MiB a blob and 1 GiB in all.
2026-11-03 20:55:42 -05:00
Dylan M. Taylor 3225307e57 codecs: admit animated GIF screens, sparse RLE BMPs and icon PNG profiles (#10979)
* codecs: admit animated GIF screens, sparse RLE BMPs and icon PNG profiles

- Animated GIF decoding (decode_gif_frames) skipped the logical-screen
  plausibility check the first-frame decode applies, although the
  backend initializes the whole screen before reading a frame. Both now
  share gif_plausible().
- RLE BMPs skipped the file-size plausibility check entirely, so a
  header-only file could make the decoder allocate and clear a
  multi-gigabyte canvas. Like a GIF's screen, 256 MiB of canvas is now
  free of data and the rest must be backed by the file.
- The image crate's ICO decoder opens an embedded PNG with no limits,
  and png inflates an iCCP profile while the decoder is built. Icon
  PNG profiles are now inflated into a sink first and refused past
  255 x 65519 bytes (or max_alloc), with a 64 MiB total across entries.

* address review: visit each ICO profile chunk offset once
2026-11-03 20:54:58 -05:00
yoriswind 15cfdc8398 Preserve paused action authorization and history boundaries 2026-11-03 17:54:45 -08:00
yoriswind 5a1a06a4df Correct Actions row helper visibility and document archive spans 2026-11-03 17:52:35 -08:00
yoriswind 5f48c9c371 Handle egui texture deltas in transform control tests 2026-11-03 17:52:09 -08:00
Dylan M. Taylor d82e166494 codecs: charge dropped PNG text against the metadata budget (#10980)
* codecs: charge dropped PNG text against the metadata budget

read_text_metadata debited the shared text allowance only for text it
kept. A compressed iTXt chunk that inflated up to the whole remaining
allowance and then failed UTF-8 validation (or hit a corrupt or
truncated stream) was dropped without being charged, so every further
such chunk could repeat the same inflation. bounded_text now reports
the bytes it produced and the caller charges them whether or not the
text is kept.

* codecs: charge the output a failing text decompress wrote

* address review: charge Latin-1 zTXt error batch at UTF-8 length
2026-11-03 20:51:19 -05:00
Dylan M. Taylor 20f92ee405 codecs: leave Extended XMP fragments out of zune-jpeg's header parse (#10981)
* codecs: leave Extended XMP fragments out of zune-jpeg's header parse

zune-jpeg 0.5 keeps every Extended XMP APP1 fragment until its GUID's
set is complete, and re-sorts and re-checks the whole pending list
after every marker it parses. A file with many small, consistent but
incomplete fragments (or a few followed by many other markers) costs
quadratic time before any pixel is decoded.

Nothing in PhotoCraft reads zune's reassembled Extended XMP (metadata
comes from scan_metadata over the original bytes), so the decoder now
hands zune a copy without those segments when a file has any. Files
without Extended XMP are passed through unchanged.

* codecs: reserve only the bytes kept after dropping Extended XMP segments
2026-11-03 20:50:58 -05:00
Dylan M. Taylor 4c33a7b8f2 raw: keep at most 64 GainMap opcodes from one list (#11023)
Development applies every gain map to every pixel it covers, so a list
of thousands of maps multiplied the work of an otherwise admissible
image. Cap them like MapPolynomial; the rest are named as not applied.
2026-11-03 20:50:37 -05:00
David Mann 14cb2197ba Merge PR #11207: contributors: set names for vangel76 2026-11-04 02:45:35 +01:00
8701903f9b Fix-up for #9182: build jobs carry their vertex entry point, and the test rules out a shared vs
The build now takes each job's vertex entry name from build_jobs, the vertex
module is generated from the same jobs, and build_jobs_share_no_shader also
checks that compose.wgsl has no vertex entry point. Before, the test checked
the job plan on its own and still passed if the build went back to one shared
vs (verified: re-adding vs to compose.wgsl now fails the test).

Co-Authored-By: FinnNk <FinnNk@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-04 02:38:48 +01:00
Dylan M. Taylor 87f0bb3942 raw: refuse JPEG XL tiles with compressed metadata boxes or splines (#11039)
jxl-oxide inflates Brotli-compressed auxiliary boxes (Exif, XMP) into
storage its allocation tracker doesn't see while it reads a container,
and samples spline geometry into an untracked vector with no bound on
the sample count. A raw tile needs neither: refuse a container holding a
brob box before reading it, and a codestream whose frames draw splines
before rendering.
2026-11-03 20:37:49 -05:00
Dylan M. Taylor c004e38e75 raw: decode a tile range once when several tiles share it (#11041)
read_plane decoded every segment separately, even when a file pointed
every tile at the same bytes. Each lossless JPEG decode rebuilds its
Huffman tables and each result is retained until assembly, so one small
range repeated across many tiles multiplied header work and memory by
the tile count.

Decode each distinct (offset, length, geometry) once and scatter the
shared samples into every tile that names it.
2026-11-03 20:37:28 -05:00
Dylan M. Taylor 06bedca787 raw: refuse lossy DNG tiles that carry Extended XMP (#11042)
* raw: refuse lossy DNG tiles that carry Extended XMP

zune-jpeg keeps every Extended XMP fragment until its set is complete
and re-sorts and re-checks all pending fragments after each marker, so a
lossy (compression 34892) tile of many small incomplete fragments costs
quadratic time before a pixel is decoded. A raw tile has no metadata:
refuse one with an Extended XMP APP1 segment before parsing it.

* address review: bound Extended XMP identifier to APP1 payload
2026-11-03 20:37:07 -05:00
David Mann f805540d0a Merge PR #9182: fix(gpu): build compositor pipelines without sharing FXC shader blobs across threads (#9173) 2026-11-04 02:35:01 +01:00
Dylan M. Taylor 4367131008 raw: check retone's pixel count with checked multiplication (#11043)
retone compared the buffer length with an unchecked w * h. In a release
build a product that wraps passed the check for a tiny buffer, and the
banded passes then ran over the original, huge height.
2026-11-03 20:31:35 -05:00
NaufalDzz 78b3fd0225 feat(transform): hide the reference point behind a Toggle Reference Point checkbox
Free Transform showed and grabbed the reference point at the box centre, so a press there moved the pivot instead of the content. As in Photoshop, the reference point is now hidden by default and a Toggle Reference Point checkbox before the 3x3 grid in the options bar shows it again. While it is off the centre moves the content, the grid is dimmed, and Alt-click still sets a new reference point.

Fixes #11098
2026-11-04 08:31:30 +07:00
Dylan M. Taylor f960a65eb3 ipp: resume the reply's header search where the last read stopped (#11049)
read_response searched every byte read so far for the blank line after
each read, so a server trickling a 16 MiB reply in tiny fragments made
the client rescan it once per fragment. Resume the search three bytes
before the previous end.
2026-11-03 20:31:14 -05:00