Commit Graph
11425 Commits
Author SHA1 Message Date
David Mann 0739ff48c5 Merge remote-tracking branch 'origin/main' into fix/4017-huge-new-document
# Conflicts:
#	crates/ui-egui/src/gpu_canvas.rs
#	docs/scorecard.md
#	perf/budgets.toml
2026-10-17 01:07:37 +02:00
Marco Arnulfo db46713c2c Unsaved-changes prompt: the default answer takes keyboard focus, so arrows and Enter work (part of #6441) (#6466) 2026-10-16 17:03:15 -06:00
Jason Xiang 06ad07ab9b fix(io): color-manage grayscale WebP exports (#5875) 2026-10-16 17:02:54 -06:00
Jason Xiang f61ed26e14 fix(io): honor version-aware OpenRaster group isolation (#5872) 2026-10-16 17:02:23 -06:00
Jason Xiang 840edc311c fix(io): preserve linear grayscale profiles for selected EXR parts (#5867) 2026-10-16 17:01:52 -06:00
Jason Xiang 462adeadd2 test(io): cover mixed-region CMYK TIFF composites (#5588) 2026-10-16 17:01:10 -06:00
xsvm 8fe2c74f58 perf(testkit): sample RSS from /proc/self/statm, not smaps, on Linux (#5399)
memory-stats reads /proc/self/smaps by default on Linux: every sample formats and parses one
block per mapping while holding the mmap lock. The benches' RssSampler polls it every 2 ms, so
on a profile of bevel_bench --size 4000x3000 the rss-sampler thread was ~22% of all samples
(smaps_account 14.7%, smaps_pte_entry 6.3%), contending with the measured threads.

Enable the crate's always_use_statm feature: one short read of the kernel's RSS counters, the
same number VmRSS reports. The measured code is unchanged; only the harness overhead goes.
2026-10-16 17:00:43 -06:00
wwew 93f6376c5e docs: write product name as PhotoCraft in package descriptions and comments (#5615) 2026-10-16 16:59:41 -06:00
wwew e33384c9ba docs: write product name as PhotoCraft in crate module docs (#5455) 2026-10-16 16:58:50 -06:00
PerchenkoAnton f360cb0b4a fix(engine): give artboard exports unique indexed filenames (#6655) 2026-10-16 16:57:33 -06:00
wwew 651647fdf6 docs(cli): write product name as PhotoCraft in USAGE and description (#5449) 2026-10-16 16:56:48 -06:00
David Mann f754b7e7ea Merge remote-tracking branch 'origin/main' into fix/psd-size-encoded 2026-10-17 00:44:51 +02:00
David Mann 97dd2648ef Merge remote-tracking branch 'origin/main' into fix/psd-size-encoded
# Conflicts:
#	crates/psd/src/file.rs
2026-10-17 00:44:51 +02:00
Jason Xiang f1c45b887e fix(codecs): respect PAM ENDHDR line boundaries (#5874) 2026-10-16 16:38:54 -06:00
Marco Arnulfo 6a7fc88c79 Crop tool: custom ratios keep three decimals, 1.414 : 1 no longer becomes 1.4 : 1 (fixes #6487) (#6503) 2026-10-16 16:38:35 -06:00
Marco Arnulfo 97f50b4714 Pen: the path in progress stays visible while panning with Space (fixes #6592) (#6625) 2026-10-16 16:38:11 -06:00
Diego Chagas ad6463b50f Paragraph text: a word wider than the box breaks at the box edge (#6694) (#6696)
parley's default overflow wrap only breaks at UAX #14 opportunities, so
a word longer than the paragraph box ran out past its edge and resizing
the box changed nothing. Paragraph text now sets OverflowWrap::BreakWord,
so such a word wraps at the box edge as Photoshop does; a space or hyphen
still wins over a mid-word break, a box that fits the word lays out as
before, and point text is untouched.
2026-10-16 16:37:45 -06:00
Korg1ch 3c75db7a80 fix(linux): avoid duplicate AppImage desktop launcher when managed by AM / AppMan (#6392) (#6394)
* fix(linux): avoid duplicate AppImage desktop launcher when managed by AM / AppMan (#6392)

* test(linux): cover AM / AppMan launcher detection in AppRun smoke test (#6392)
2026-10-16 16:37:17 -06:00
midasmatterhorn 19227022ca Histogram: scale bar heights linearly to the tallest bin, not sorted.get(250) (#6638) 2026-10-16 16:36:58 -06:00
rudrakshagarwal4200-ai d24d25f5e7 Enhance fitImage tests for dimension constraints
Added tests for handling zero or negative dimensions in fitImage.
2026-10-17 04:01:18 +05:30
rudrakshagarwal4200-ai d0ea5f23cb Change fit_image to use size_param for dimensions
Updated fit_image function to use size_param for width and height.
2026-10-17 03:59:34 +05:30
MarekSpodBiedry 10fc2a3839 Hue/Saturation: hue tracks and spectrum bars use full-strength sRGB hues, one shared hue_color (#6540) 2026-10-17 00:27:42 +02:00
Nicolas Falesy 54a4782849 perf(camera-raw): Shadows/Highlights 1.9× faster, bit for bit the same (#5964) (#6247)
The local Laplacian filter behind Shadows and Highlights builds a whole
pyramid per reference value (up to 96). Three costs dominated it:

- blur_step called mirror() (an integer remainder) for every tap of every
  pixel; the source rows are now found once per row and columns mirror only
  within two pixels of an edge.
- up() blurred a zero-stuffed plane, three samples in four zero; it now adds
  only the nonzero taps, in the same order.
- the small pyramid levels were split into one-row rayon tasks, costing more
  in scheduling than the rows; planes under 32K samples run on one thread.

The output is bit for bit the same: a new test checks blur_step and up
against the plain versions on odd, even, tiny and parallel-sized planes.
2026-10-16 16:26:19 -06:00
David MannandClaude Opus 5.5 c354a25a6b Type: paragraph box handles are picked at the unsnapped press (#6819)
With View > Snap on, the canvas snapped the Type tool's press (a point
gesture) before the tool's handle hit test, with the edited text's own
glyph bounds and centre lines among the targets. The snapped press could
leave the 6 pt handle grab area, so the press placed the caret or
committed the edit instead of resizing the box.

- The Type tools pick the box handle or glyph at the raw press, as Free
  Transform already does.
- While editing, only a press on a box handle starts snapping, and the
  resize drag snaps to guides and other layers, not to the text being
  resized; caret drags are no longer snapped.

Canvas-level test drags all eight handles (at the handle and inside its
grab area) at 25-200 % zoom, 1x and 2x HiDPI, plain/scaled/rotated layer.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-17 00:19:26 +02:00
MarekSpodBiedry 4c730d3889 Object Finder: hovering with an empty active layer shows the status-bar hint (#6549) 2026-10-17 00:10:17 +02:00
MarekSpodBiedry 156b27d65b Object Selection: enclosed background gaps stay unselected, only object-like holes fill (#6556) 2026-10-17 00:06:54 +02:00
MarekSpodBiedry 76f19e6e2e Title bar: only the primary button starts a window drag (#6729) 2026-10-17 00:06:32 +02:00
MarekSpodBiedry 6511eed63d Actions: Shift-click layer select in .atn imports as range select and exports back (#6784) 2026-10-17 00:03:31 +02:00
David MannandClaude Opus 5.5 89339396ff Droplets: carry the actions that Conditional steps call (#6804)
called_actions only followed actions.play steps, so a droplet whose action
used actions.conditional saved neither branch and failed with "no action
named ..." when run standalone. It now also queues the then/else targets.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-16 23:42:36 +02:00
David MannandClaude Opus 5.5 1338d78b45 Transform: drop a fill layer's cached render when its frame changes (#6808)
Free Transform and Warp moved a fill layer's linked masks (and so the frame its
gradient is laid out in) but kept the cached render, which the compositor draws
as-is while the Fill is unchanged. Drop the cache in apply_transform and
warp_layer, as transform_layer_geometry and Perspective Crop already do.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-16 23:42:34 +02:00
Higgs32584andClaude Opus 5.5 cd75fa78ef PSD/PSB: a 16/32-bit file's "Transparency" channel stays the merged transparency on re-save (#4654)
Photoshop's 16-bit PSBs can mark the merged transparency only by naming it
"Transparency" in the alpha channel names (positive Lr16 layer count, no Mt16).
The importer read it as a user alpha channel, and the next save wrote a second
one. merged_has_alpha now also accepts that name when the layers sit in a
global Lr16/Lr32 block and the names cover every extra channel.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-16 17:38:42 -04:00
D-monizedandClaude Opus 5.5 d067466a6b Faux Bold: thicken the outline instead of stamping eight copies
Faux bold drew each glyph at eight offsets (3.6% of the size) and merged them.
At large sizes the copies didn't join on corners and stroke ends: stair-step
notches (46 px offsets at 1278 pt). The glyph outline is now thickened before
drawing, each point moved outward along its corner's bisector and capped by its
shorter edge (as FreeType's FT_Outline_EmboldenXY), so curves stay curves and
corners stay square at any size, with the same weight. Faux italic and scaling
still apply after. Each bold glyph is drawn once instead of eight times.

New tests: a 600 pt bold "l" keeps square corners (the old stamping cut them
away), a bold "O" curves as smoothly as the regular one, and unit tests for the
thickening (windings, counters, curves, degenerate outlines, sharp corners).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-16 15:36:54 -06:00
D-monizedandClaude Opus 5.5 bed6d0931c Font menu: no empty strip beside the list after the window moves the menu
The menu kept the list's left edge and its own right edge as screen positions
from the previous frame. When the window's edge pushed the popup (after a
minimize and restore, or from the Character panel near the right edge), those
went stale, the search row padded out to the old position and widened the menu,
which was pushed further left, settling 214 px wider than its lists. They are
now kept relative to the menu's left edge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-16 15:36:54 -06:00
Higgs32584andClaude Opus 5.5 257f0a0d31 GPU canvas: a layer that doesn't fit GPU memory evicts and retries instead of breaking the GPU (#6563)
Compositor::sync created each pc_compose_layer page texture with a bare
create_texture: nothing checked the new bytes against the resident budget
(eviction ran only after each cell) and an Out of Memory error went
uncaptured, invalidating every later texture in the pass.

Now least recently used pages are evicted to admit the new page's bytes
before creating it; creation runs in error scopes (first_error) on native,
and on Out of Memory every page the current cell doesn't use is dropped and
creation is retried once. If it still fails the refresh returns
Unsupported(OVER_BUDGET) so that refresh draws on the CPU and the next one
tries the GPU again; the captured error no longer reaches the health
callbacks. The LRU admission logic is a pure function with a unit test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-16 17:34:59 -04:00
Ahmed Tammam 549b4387b1 docs(contributors): add Gotix-eg to people.toml 2026-10-17 00:34:36 +03:00
David MannandClaude Opus 5.5 3afb0b1283 PSD: layered TIFF byte-order conversion swaps every smart filter section (#6802)
Tx::filter_effects converted only the first u64-length section of FEid/FXid and copied the rest as stored, so a second smart object's section kept the source byte order and FilterEffects::parse lost the whole block.
It now mirrors FilterEffects::parse: one section per smart object, each with its 4-byte padding, until only trailing zero padding remains.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-16 23:33:20 +02:00
Higgs32584andClaude Opus 5.5 606b2dadba Actions: a Deselect step with nothing selected plays on instead of stopping (#6744)
Photoshop treats Deselect with no selection as a silent no-op, so imported
.atn actions that start with Deselect stopped at step 1 here.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-16 17:26:04 -04:00
nrq6993-a11yandCursor 2e8d20ca9c Fix rustfmt on snap_ui smart-target assignment.
CI Format step failed on a line break rustc-fmt does not want.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-10-17 00:24:53 +03:00
David MannandClaude Opus 5.5 8c6412bbb2 Plug-ins: running a filter plug-in respects layer locks (#6770)
plugin.run wrote into raster and smart object layers without checking
locks. It now refuses layers with locked pixels or Lock All like the
built-in filters, and with Lock Transparency it keeps the layer's alpha
(as built-in filters do, via filters::keep_alpha).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-16 23:20:35 +02:00
David MannandClaude Opus 5.5 ec83a1117f Presets: refuse renaming a group to a name another group has (#6768)
renameGroup in the shared preset group editor renamed without checking
that the new name was free, so two groups could share a name and a later
replace import of that name removed both. It now refuses like the
Swatches sibling; renaming a group to its own name stays fine.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-16 23:20:35 +02:00
David MannandClaude Opus 5.5 0fc5660f60 Image Size: a gradient fill's centre offset stays a fraction of the frame (#6778)
map_fill multiplied the offset by the full linear part of the canvas transform, so Image Size
(and Perspective Crop) scaled it: 200% moved a 25% offset to 50%. Each axis of the linear part
is now normalised, so scale drops out while flips and 90° turns still mirror and turn it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-16 23:19:40 +02:00
David MannandClaude Opus 5.5 031ab7d5b2 Apply Image: write into the targeted layer mask (#6780)
With the layer mask targeted, apply_image took the layer branch and fetched the
layer's pixel surface with the target dropped, so the mask stayed unchanged and the
pixels were overwritten. A mask target now goes through the single-plane path and
is written back over the canvas, keeping the mask's default outside it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-16 23:18:53 +02:00
Ian Swope 9b6a85824d Mesh warp: tiles encoded in parallel and in-bounds taps read directly, about twice as fast with identical pixels 2026-10-16 16:13:44 -05:00
David MannandClaude Opus 5.5 9ac2c08875 Actions: renaming an action updates the Conditional steps that call it (#6772)
actions.rename only rewrote the "action" param of actions.play steps, so an
actions.conditional step whose "then"/"else" named the renamed action failed
with "no action named ..." on the next play. The rename loop now also rewrites
matching then/else branches, in saved actions and the pending recording.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-16 23:02:33 +02:00
David MannandClaude Opus 5.5 af5e77b150 Auto-Align: warp layer masks as masks, keeping what lies outside revealed (#6776)
Auto-Align warped a moving layer's mask with the colour warp (warp_placed), which
returns a grey + alpha surface defaulting to 0, so a reveal-all mask hid everything
outside its painted area. Masks now go through warp_gray (planar placements) or
warp_mesh_gray (cylindrical/spherical), keeping one channel and the mask's default.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-16 23:01:14 +02:00
Ahmed Tammam 9248830772 fix(layer-style): drop preview throttle and keep atomic Blend If Alt-split handle feathering
- Remove preview throttle in canvas::display_doc to eliminate stale composite caching and missing repaints

- Keep atomic Blend If Alt-split feathering behavior and its verified test suite in layer_style.rs
2026-10-16 23:58:17 +03:00
Finn NewickandClaude Opus 5.5 df023c803a feat(ui): System Info shows the graphics card's own memory
The card's memory caps the GPU budgets (#5234), so a huge canvas can fall
back to the CPU on a card with little of it. System Info (Help and
Preferences › Performance) now lists "Graphics memory" after the driver
when the card reports one; integrated GPUs, which share system memory,
show no such line. Translated in all 20 catalogues.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-16 21:52:22 +01:00
David MannandClaude Opus 5.5 8fc26b29de Merge main into feat/auto-219-8-panel-command-check
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-16 22:51:37 +02:00
David MannandClaude Opus 5.5 bdf44ab18c PSD: read colours stored as HSB (#6774)
color_from_desc had no HSBC arm, so HSB descriptor colours fell through to the
RGB fallback and came back None: solid fills vanished, strokes and effects went
black. Convert HSBC (hue in degrees, saturation/brightness 0..100) with the
existing channel_map::hsb_to_rgb, now pub(crate).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-16 22:51:32 +02:00
David MannandClaude Opus 5.5 ab81052308 Fit Image: a width or height of 0 leaves that side unconstrained (#6766)
fit_image read width/height with f64_param and clamped to 1, so a 0 or
negative side (dialogs send 0 for an empty field) became a 1 px box and
shrank the document to 1x1. It now uses size_param like the rest of
file_cmds.rs, so such a side falls back to the document's own size.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-16 22:49:38 +02:00