Commit Graph
11425 Commits
Author SHA1 Message Date
David Mann 3549195cf4 Merge origin/main into fix/match-zoom-clamp 2026-10-17 16:59:57 +02:00
David Mann 3d1f76a367 Merge origin/main into fix/headless-index-keeps-active-doc 2026-10-17 16:59:54 +02:00
David Mann b18b64c039 Merge origin/main into fix/headless-save-quality 2026-10-17 16:59:51 +02:00
David Mann 05c431317f Merge origin/main into fix/actions-delete-drops-fkey 2026-10-17 16:59:43 +02:00
David Mann 33d6b06693 Merge origin/main into fix/crop-target-size-samplers 2026-10-17 16:59:41 +02:00
David Mann f8c7955699 Merge origin/main into fix/artboards-to-files-marks 2026-10-17 16:59:38 +02:00
David Mann 45ad14fbac Merge origin/main into fix/timeline-setprops-work-area 2026-10-17 16:59:35 +02:00
David Mann 1193ebed08 Merge origin/main into fix/shortcut-set-keeps-action-fkeys 2026-10-17 16:59:33 +02:00
David Mann dd9e44706a Merge origin/main into fix/multichannel-channel-target 2026-10-17 16:59:30 +02:00
David MannandClaude Opus 5.5 a32b588ae6 Crop / Canvas Size: extending keeps the Background's hidden pixels (#7086)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 16:58:36 +02:00
dotCooCooandbrandongunderson 45e15036bf Presets: the damaged-set test also covers Export As presets
a_damaged_preset_set_keeps_the_other_sets (#5602) checks that one
damaged set in the preferences file does not discard the others. It
left out export_presets, which #5344 added and #6906 put back into
load_presets_json, and recent_documents.

The test now saves an Export As preset and checks that it survives each
damaged set, recent_documents included. It also damages export_presets
and documents on their own, and gives a null set beside the Export As
presets. This is brandongunderson's change to the test in #6479,
unchanged.

Co-authored-by: brandongunderson <22452783+brandongunderson@users.noreply.github.com>
2026-10-17 07:57:59 -07:00
Khawar Zamman WaniandClaude Opus 5.5 cd82af164f Merge origin/main into field-wheel-5473
Picks up the build fixes on main (#6906, #7053).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 20:23:14 +05:30
dotCooCoo 274d7c0a36 Merge main into fix/mixer-brush-clean-and-load 2026-10-17 07:47:04 -07:00
dotCooCoo 4c43ab3ffe Merge main into fix/save-added-extension-asks-before-replacing 2026-10-17 07:47:04 -07:00
Khawar Zamman WaniandClaude Opus 5.5 bfc37773a8 test(engine): Straighten Layer turns every selected layer, as in Photoshop
Straighten's non-crop branch runs `edit.transform` without a layer, so since Free Transform takes
the selected layers it turns all of them. That matches Photoshop ("only the selected layer(s) will
straighten"); the test pins it, with one history step and one Undo, and checks that an
unselected layer stays put.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 20:16:27 +05:30
David MannandClaude Opus 5.5 cb5b1f8e9e Crop: in default mode, box Undo/Redo keeps the box in place (#7088)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 16:45:16 +02:00
nrq6993-a11yandCursor 0c7c533553 Fix rustfmt on baked gradient overlay reopen test.
CI Format step failed on multi-line s.execute in layer_style.rs.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-10-17 17:44:03 +03:00
ebosido444-ai fcd337e1fc perf(text): rasterize a type layer's pixels on all cores, bit for bit the same
A type render spends most of its time after the glyphs are drawn: composing each
colour's coverage over the premultiplied accumulator, dividing it back to straight
colour, and converting the tile bytes. All three are per pixel - no pixel reads a
slot another wrote - so they ran one after another on one core for no reason.

Measured on a 3.75 MP paragraph (4000 characters, 14 pt at 300 dpi, 1851 glyphs),
release, Windows 11, i5-10300H: rasterize 98.3-103.9 ms before, 60.3-61.8 ms after
(1.6-1.7x). Whole-render stage profile before: ink rect 4.1, draw 18.6-22.9, prefix
sum 7.0-8.1, composite 22.6-33.4, unpremultiply 11.2-14.0, write_region 23.8, prune
3.1 ms.

The glyph drawing, the winding prefix sum and the ink-rect pass stay on one thread:
the first two carry a running accumulator across pixels, and the band split that
would keep them bit-identical costs a second glyph traversal per band.

Native only (rayon, as the other crates): the web build keeps the serial loops.
2026-10-17 17:42:50 +03:00
David MannandClaude Opus 5.5 4fc492d2ca Actions: an imported Crop step in a unit other than pixels is not applied as pixels (#7084)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 16:40:40 +02:00
David MannandClaude Opus 5.5 8574f8d809 Merge to HDR Pro and merged duplicates: the Background layer is a real Background (#7078)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 16:39:44 +02:00
Hamza Naveed efa1edd079 algo: gate the recorded-hash test's helpers with the test (#7053)
`blocks` and `fnv` exist only for `harris_and_describe_hashes_recorded_from_the
_serial_code`, which is `#[cfg(all(target_os = "linux", target_arch =
"x86_64"))]` because the hashes it compares against go through the platform's
hypot / ln / cos / atan2 / sin_cos. Everywhere else the test is compiled out and
the two helpers are left unused, so `-D warnings` fails on `dead_code`:

    error: function `blocks` is never used   crates/algo/src/features.rs:704
    error: function `fnv` is never used      crates/algo/src/features.rs:708

They now carry the same cfg as the only thing that calls them.

CI's matrix is ubuntu-latest and windows-latest and runs clippy on both, so this
fails the Windows leg as much as a local run on macOS: `target_os = "linux"` is
false for both.
2026-10-17 08:39:15 -06:00
Josephand00xJ0 351149f0df Fix the build: restore export_presets in load_presets_json (#5344 x #5616) (#6906)
#5344 added the export_presets field to Persisted; #5616 rewrote load_presets_json to read each set with take() and its Persisted initializer lacked the new field, so main stopped compiling (E0063 at presets/mod.rs:180). Read export_presets the same way as the other sets; the existing load step and round-trip test cover it.

Co-authored-by: 00xJ0 <56056764+00xJ0@users.noreply.github.com>
2026-10-17 08:32:54 -06:00
abc2cbandClaude Opus 5.5 2430664dd3 Smart Filters: note under Mode when Dissolve is selected
Dissolve in Smart Filter blending follows the inherited color-blending path
without per-pixel coverage sampling (docs/smart-filters.md). Show a short faint
note under the Mode control in Blending Options when Dissolve is chosen, so the
limitation is visible where the mode is picked. No behaviour change.

The note is added to all 20 catalogs. The test renders the dialog body for
every layer blend mode and checks that only Dissolve paints the note.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 17:20:39 +03:00
abc2cbandClaude Opus 5.5 d685aa1484 Fill layers: pin the preference-off precedence for selection and explicit path
With "Use Default Masks on Fill Layers" off, only the default reveal-all mask
goes away. Cover that contract directly for Solid Color, Gradient and Pattern
Fill: no selection and no path gives no mask; an active selection still
becomes the raster layer mask (revealing inside, hiding outside); an explicit
vector path still becomes the vector mask, with or without a selection, and no
raster mask is added next to it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 17:19:18 +03:00
Khawar Zamman Wani d182b2de15 Merge remote-tracking branch 'origin/main' into field-wheel-5473
# Conflicts:
#	crates/ui-egui/src/widgets.rs
#	docs/ui-parity.md
2026-10-17 19:44:20 +05:30
Khawar Zamman WaniandClaude Opus 5.5 87e8e5977c fix(engine): restore export_presets in load_presets_json (#5344 x #5616)
main stopped compiling when #5616 rebuilt Persisted field by field without
the export_presets field #5344 added. Same one-line fix as #6906, so it
merges cleanly whichever lands first.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 19:19:16 +05:30
David MannandClaude Opus 5.5 0b1953c494 Crop: W x H x Resolution follows the Point/Pica Size preference (#7038)
The crop tool's W x H x Resolution mode converted points and picas at a
fixed 72 pt/in, while Image Size, Canvas Size (#5757), the rulers, Info
and the shape dialog use Preferences > Units & Rulers > Point/Pica Size.
With Traditional (72.27), W "72 pt" x H "1 in" at 300 ppi cropped to
300 x 300 instead of 299 x 300.

target() and ratio() now take the points per inch, and the callers
(commit_params, preset_ratio, fit_frame) pass the preference.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 15:45:51 +02:00
David MannandClaude Opus 5.5 b2f9c45c6a Match Zoom: matched views stay within each document's zoom range (#7036)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 15:45:34 +02:00
David MannandClaude Opus 5.5 758ad4db44 Crop: the turn readout never shows -0.0° or -180.0° (#7040)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 15:45:13 +02:00
David MannandClaude Opus 5.5 cb185320ed Conditional Mode Change: "gray" as a single source mode matches Grayscale (#7042)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 15:44:56 +02:00
David MannandClaude Opus 5.5 7ebaa94a82 Render Video: GIF frame delay follows timelines under 1 fps (#7045)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 15:44:43 +02:00
David MannandClaude Opus 5.5 01a58e8f6f Layer Style: gradient overlay and stroke scale stay within 10-150 % (#7047)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 15:44:42 +02:00
Khawar Zamman Wani fadeb802ef Merge remote-tracking branch 'origin/main' into fix/5571-group-layers-collapsed 2026-10-17 19:13:45 +05:30
David MannandClaude Opus 5.5 1bb3542b99 Lens Correction: smart filters keep the exact focal length (#7029)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 15:42:14 +02:00
David MannandClaude Opus 5.5 276d830e7c Transform Selection: an unknown reference point is an error (#7027)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 15:40:09 +02:00
vangel76andClaude Opus 5.5 f71b5a96fe Lasso: test that Alt-clicking the last corner of a small shape keeps it open (#6578)
The Alt-click branch of the Lasso uses polygon_close_reach too; this test
Alt-clicks the four corners of a 6x6 square at 100 %, checks the outline
stays open, then closes it on the first point and checks the square.
It fails with the fixed 8-point reach.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 15:39:33 +02:00
Khawar Zamman WaniandClaude Opus 5.5 6bda896ad0 test(algo): gate the Linux-only hash test's helpers to Linux x86_64
`blocks` and `fnv` are only used by the harris/describe hash test, which runs
on Linux x86_64 only, so on Windows they were dead code and `-D warnings`
failed the build.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 19:08:27 +05:30
David MannandClaude Opus 5.5 e1c119200b Automation: place and layer/data-set export by index keep the active document (#7025)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 15:37:18 +02:00
David MannandClaude Opus 5.5 c6ea59461f Automation: doc.save rejects a bad quality instead of ignoring or clamping it (#7023)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 15:36:02 +02:00
nrq6993-a11yandCursor 1c760a93b5 Fix Layer Style dialog reloading baked gradient overlay endpoints.
Fixes storytold/photocraft#7031: classic/PSD multi-stop overlays no longer show factory black-to-white when reopened.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-10-17 16:29:17 +03:00
abc2cb 193e86a66f Merge branch 'feat/layers-panel-photoshop-options' into codex/layers-subrow-scaling-20261012 2026-10-17 16:25:38 +03:00
abc2cb a6b5208aad Merge branch 'feat/layers-panel-photoshop-options' into codex/fill-mask-preview-20261012 2026-10-17 16:25:38 +03:00
abc2cbandClaude Opus 5.5 85760b1c36 PSD Wave smart filters: keep more than 64 generators verbatim
The Wave renderer clamps the generator count to 64 (the command allows up
to 999), but a Photoshop Wave with Scale 100% mapped to filter.distort.wave
whatever its Number of Generators. A file with 332 generators opened as a
supported, editable Wave and, once its cached pixels were re-rendered,
drew 64.

Treat it like a scaled Wave: a Wave with fewer than 1 or more than 64
generators stays Photoshop's, descriptor kept verbatim and written back
unchanged. The limit is photocraft_algo::MAX_WAVE_GENERATORS, which the
renderer now clamps to as well, so the two cannot drift.

Tests: the 332-generator Wave stays unsupported and round-trips its
descriptor; a new boundary test maps 1 and 64 generators and keeps 65, 999,
0 and -1 verbatim.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 16:24:48 +03:00
abc2cbandClaude Opus 5.5 e727c3dcf8 Layers panel reorder preview: share move_to's structural move, clipping groups included
The hover preview (preview_move) re-implemented the layer removal and
insertion but skipped the rest of move_to: the clip-group rules
(clip_group::Before/settle), the Background copy rules (unlocked copy)
and the Background-stays-at-the-bottom check. So the preview showed
different clipping than the drop commits, e.g. B C1* C2* U with U dropped
above C1 committed B C1* U* C2* but previewed U unclipped, and moving a
clipping base away left its layers clipped in the preview.

Factor the document-only part of move_to into apply_move and call it from
both, so they cannot drift. A drop move_to would refuse (Background off
the bottom, groups nested too deep) now has no preview either.

Tests compare preview and committed documents (stack order, clip flags and
the flattened composite) for clip-group drops, a base moved away or up
into its own group, option-drag copies, a Background copy, and refused
Background drops.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 16:17:37 +03:00
abc2cbandClaude Opus 5.5 2197040799 Filter preview: main's view-capped factor follows the whole smart filter stack
The merge with main kept both factor lines in ensure_filter_preview, and the
second (main's filter_preview_factor, #6351) shadowed smart_preview_factor, so
a smart filter edit was sized by the edited command alone again. The shared
filter_preview_factor now starts from smart_preview_factor, which falls back to
preview_factor for ordinary filters, and caps that by the view as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 16:17:36 +03:00
David MannandClaude Opus 5.5 000fec6f59 Keyboard Shortcuts: switching sets keeps action function keys (#7004)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 15:12:43 +02:00
David MannandClaude Opus 5.5 30505e3b53 Crop: Color Samplers scale with a W x H crop (#7012)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 15:12:30 +02:00
David MannandClaude Opus 5.5 fd2c10bba8 Artboards to Files: paths, notes, slices and marks move with the board (#7010)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 15:12:17 +02:00
David MannandClaude Opus 5.5 361a1bf22e Channels: Multichannel conversion keeps the targeted channel (#7002)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 15:12:14 +02:00
David MannandClaude Opus 5.5 99c6fb4ce7 Timeline: a longer duration moves a work area that reached the old end (#7006)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 15:10:46 +02:00