Commit Graph
2574 Commits
Author SHA1 Message Date
David Mann b2269e3bdb Merge PR #7690: perf(codecs): Avoid redundant PNG filter passes 2026-10-19 16:51:43 +02:00
David Mann 8e54897d43 Merge PR #7022: perf(text): rasterize a type layer's pixels on all cores, bit for bit the same 2026-10-19 16:51:41 +02:00
David Mann 284ee60705 Merge PR #5976: PSD: keep guide resources 1092/1097 only while they match the guides (#5966) 2026-10-19 16:51:27 +02:00
Rene Leonhardt f64a143c55 perf(format): drop unhelpful Zstandard workspace reuse 2026-10-19 13:43:20 +02:00
Rene Leonhardt 4d50e31efd perf(codecs): stop PNG candidates at the winning cost 2026-10-19 13:43:19 +02:00
Rene Leonhardt f1ba4854d0 docs(perf): record end-to-end workspace results 2026-10-19 13:15:12 +02:00
Rene Leonhardt b5b5776a30 perf(io): remove the PSD export inlining hint 2026-10-19 13:15:06 +02:00
Rene Leonhardt 78a9982eec perf(raster): share contiguous region reads 2026-10-19 13:15:06 +02:00
Rene Leonhardt 6b1aa81561 docs(perf): measure PNG filtering on real images 2026-10-19 13:15:05 +02:00
Rene Leonhardt a37198d4fa docs(perf): record real image deflate tradeoffs 2026-10-19 13:14:37 +02:00
funkvay-star 5a779498bd Merge remote-tracking branch 'upstream/main' into feat/levels-reset-clipping
# Conflicts:
#	crates/ui-egui/src/lib.rs
2026-10-19 14:34:58 +04:00
Rene Leonhardt 02a63c94c2 perf(format): Reuse Rust Zstandard workspaces
Keep fresh compression for partial blocks and verify independent frames against the previous encoder. Record the isolated allocation-reuse effect.
2026-10-19 11:31:59 +02:00
Rene Leonhardt 76a6405f9b perf(io): Interleave PSD pixels in the final buffer
Remove intermediate band buffers while retaining byte-for-byte equivalence with the previous path at every sample depth.
2026-10-19 11:31:59 +02:00
Rene Leonhardt f6e7fc3c2a perf(raster): Avoid redundant default pixel work
Preserve default sample bits while skipping absent zero tiles and redundant default-pixel copies. Add the previous read path as the oracle.
2026-10-19 11:31:59 +02:00
Rene Leonhardt 850bf9fdaa perf(codecs): Avoid redundant PNG filter passes
Keep the previous filter path as an exact byte oracle and measure the filter kernel independently of compression.
2026-10-19 11:31:59 +02:00
Rene Leonhardt 4776d20b7a perf(compression): Use zlib-rs with runtime detection
Isolate the workspace backend choice and verify PNG, PSD and complete native-format decoding. Record standalone timing and compressed-size tradeoffs.
2026-10-19 11:31:58 +02:00
Khawar Zamman WaniandClaude Opus 5.5 b56b163c88 docs: regenerate the scorecard after merging main
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 14:39:52 +05:30
Khawar Zamman Wani 77650501e8 Merge remote-tracking branch 'origin/main' into feat/6000-color-panel-modes
# Conflicts:
#	crates/ui-egui/src/dock.rs
#	docs/gaps.md
#	docs/scorecard.md
2026-10-19 14:31:04 +05:30
Khawar Zamman WaniandClaude Opus 5.5 6a0f6c4ce1 Merge origin/main into fix/marching-ants-device-pixels
canvas.rs: the ants moved to crate::ants here; main's clippy::nonminimal_bool rewrite of
the finite/clip guard (f8cd3e79) is applied there instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 14:26:40 +05:30
Khawar Zamman Wani 79955f290c Merge remote-tracking branch 'origin/main' into save-for-web-webp
# Conflicts:
#	crates/engine/src/web_cmds.rs
2026-10-19 14:24:51 +05:30
Khawar Zamman Wani 206864e750 Merge remote-tracking branch 'origin/main' into fix/6501-multi-layer-free-transform
# Conflicts:
#	docs/gaps.md
2026-10-19 14:24:39 +05:30
denstu473 2d23eee9ed Merge upstream main and resolve gap documentation conflict 2026-10-19 08:11:44 +02:00
Khawar Zamman WaniandClaude Opus 5.5 750c67e20e Pen: Path Operations menu, as in Photoshop (#1397)
The Pen, Freeform Pen and Curvature Pen options bar gets Photoshop's Path
Operations button: New Layer (Shape mode), Combine Shapes, Subtract Front
Shape, Intersect Shape Areas, Exclude Overlapping Shapes and Merge Shape
Components. In Shape mode a new path is added to the selected shape layer
with the chosen operation, so a hole can be cut in a shape (#7533); in Path
mode the operation applies to the subpath added to a targeted vector mask,
the selected path or the Work Path.

- engine: path.mergeShapeComponents for work, saved and layer paths, sharing
  bake_path with the shape-layer command
- control/MCP: ui.set penMode and penPathOp
- original path-op icons, tooltip translated in every catalog

Closes #1397. Closes #7533.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 11:30:53 +05:30
PanPDX 54b6b0dbc0 Merge remote-tracking branch 'upstream/main' into area-type
# Conflicts:
#	crates/ui-egui/src/type_tool.rs
#	docs/gaps.md
#	docs/scorecard.md
#	docs/target-app-parity.md
2026-10-18 22:41:59 -07:00
Ratul Paul 8ec5f2c400 Merge upstream main and refresh UI scale review documentation
Preserve upstream contributor and gap updates alongside the UI scale
presets. Regenerate the scorecard from merged sources, retaining the
upstream text-menu progress and the expanded preset note.

Validated with full locked engine/UI tests (5,208 passed, 32 ignored),
fmt, Clippy, layers, wasm, scorecard generation/check and panic_hunt.
2026-10-19 10:12:32 +06:00
hogawish 88d7edcb02 fix(canvas): retain legacy checker in Pattern Preview 2026-10-19 12:35:27 +09:00
Diego Chagas f2a487b088 Flatpak: a second launch hands its files to the running PhotoCraft over a Unix socket (#1540)
#3755's hand-off listens on a loopback port, and every `flatpak run` gets
its own network namespace, so inside the sandbox the second launch could
never reach the first and opened a separate window. When FLATPAK_ID and
XDG_RUNTIME_DIR are set the primary now listens on
$XDG_RUNTIME_DIR/app/<app id>/instance.sock (0600), a directory every
sandbox of the app shares, and records "socket" instead of "port" in
instance.json. The lock, token, client cap, deadlines and reply are
unchanged; a crashed primary's socket file is unlinked under the lock,
and shutdown removes the socket.
2026-10-19 00:19:00 -03:00
jonathanwxh-cellandClaude Opus 5.5 2cca4faba0 Play .atn steps that switch to another open document
Photoshop records a switch to another open document as a `select` of
`Dcmn` by offset (-1 previous, 1 next). Import it as
`document.activate {"offset": n}`, the tab that many places from the
active one, and save it back as the same reference. Past the first or
last tab is refused rather than wrapped (#7103).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 10:22:57 +08:00
Gustavo Ziger e14dda9dc8 Merge main into feat/zoom-animation-566 2026-10-18 22:52:16 -03:00
00xJ0 9e83b41f45 control-protocol: CPU rendering lasts the session only after a device loss (#6897 review) 2026-10-18 17:01:19 -07:00
Davit MatchakhelidzeandClaude Opus 5.5 0adb5a2a23 docs(i18n): fix Georgian row count and language list in localization-parity
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YMTAbGNRxnMEzRvYnQGphF
2026-10-19 03:40:12 +04:00
Brian TorresandClaude Sonnet 5.5 bad6c62c80 Raw: list the Nikon ColorSpace tag in the clean-room sources and bump the gaps status line (#5987)
The README's clean-room section names every maker-note tag the crate reads and
where it is documented; 0x001E is added, and the code comment now names
ExifTool's Nikon tag documentation as its source.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rj8vs4QyUES3uwgX6SuGGh
2026-10-18 16:37:23 -07:00
Brian TorresandClaude Sonnet 5.5 8d0c579f02 Raw: a Nikon maker note's ColorSpace sets the preview colour space (#5987)
embedded_preview_color_space only read the EXIF ColorSpace, but Nikon bodies
write none: they say Adobe RGB only in the maker note (tag 0x001E: 1 sRGB,
2 Adobe RGB). A Nikon NEF with Adobe RGB selected had its JPEG preview read as
sRGB by the colour fit.

When the EXIF does not state a colour space, the Nikon maker note's is used
(the EXIF still wins, a DNG still states nothing, other makers' maker notes
are not read). The maker-note locator in tiffep.rs is shared. A packed Nikon
NEF with the tag joins the hostile-input seeds, and rawinfo prints the stated
colour space.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rj8vs4QyUES3uwgX6SuGGh
2026-10-18 16:36:16 -07:00
jonathnwxh c1ddf258e4 Merge upstream while preserving CSH and clipboard gap updates 2026-10-19 07:31:47 +08:00
Stepan Pavlenko a9870e6364 Merge remote-tracking branch 'upstream/main' into i18n/ru-dynamic-labels
# Conflicts:
#	crates/ui-egui/src/i18n/ru.tsv
#	docs/gaps.md
2026-10-19 02:19:03 +03:00
Elvis33LE e2adb18165 fix(psd): render constant noise gradient fills 2026-10-19 01:05:13 +02:00
skylar taylor-barrick 4d4de45305 Merge pull request #7206 from skylartaylor/save-replace-metadata
Save: keep the replaced file's metadata
2026-10-18 16:48:40 -06:00
Hector VillarrealandClaude Opus 5.5 df94c0442b Move tool: moving several layers carries the selection with them (#7538)
With several layers selected their selected pixels can't float, so the Move
tool moves the layers whole; the marquee stayed behind. Photoshop moves it with
them: the ants follow the drag, and the layers and selection land in one Move
step.

- Engine: `layer.translate` takes `"selection": true` to move the selection by
  the same offset in the same step.
- UI: the Move tool passes it when several layers are selected and there is a
  selection, and the ants follow the drag live.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 16:32:21 -06:00
c6fd71241d docs: add user docs in docs/user (#3951)
* docs: add user docs for PhotoCraft

Adds docs/user/ (published at getartcraft.com/docs/photocraft), the docs
check and publish workflows (copied from craft-launcher), and a User docs
rule in AGENTS.md. Checker: 0 error(s), 0 warning(s).

Source notes per page:
- index.md: README (intro, status, Crafting Apps table), website
  crafting-apps.ts photocraft entry, links.rs (Discord, issues), menus.rs
  (Help > Report an Issue).
- getting-started/index.md: menus.rs and menu_catalog.rs labels, panels.rs
  (Layers, Properties, History), dialogs.rs (Create button).
- getting-started/install.md: README Downloads and Get started sections,
  gh release view v0.7.0 asset list, craft-launcher catalog.rs (lists
  PhotoCraft).
- guides/open-and-save-files.md: apps/photocraft/src/services.rs (open and
  save filters), README Formats and PSD sections, docs/file-format-parity.md.
- guides/adjust-colors-with-adjustment-layers.md: menu_catalog.rs, panels.rs
  (footer button, adjustment list), lib.rs (Properties shows new layer).
- guides/select-and-mask.md: menu_catalog.rs Select and Layer Mask menus,
  state.rs tool names, retouch_ui.rs (Select Subject button and message).
- guides/add-and-style-text.md: state.rs (Horizontal Type Tool, T),
  type_tool.rs, menu_catalog.rs Layer Style and Type menus, dialogs.rs.
- guides/export-an-image.md: export_dialog.rs (labels, formats, options).
- troubleshooting/taskbar-turns-black.md: issues 3550, 3864, 3430, 3144,
  PR 3308 (git: not an ancestor of v0.7.0), prefs_ui.rs (System title bar).
- troubleshooting/text-moves-when-editing.md: issues 3795, 1317, PR 3819
  (open).
- troubleshooting/get-help.md: menus.rs, links.rs, gpu_status.rs (System
  Info content).
- faq/*: README (status, license badge, offline, formats), LICENSE-MIT and
  LICENSE-APACHE, docs/file-format-parity.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(user): apply final review fixes

Part 1: verified = latest release tag policy in docs/user/AGENTS.md; released-pages sentence in root AGENTS.md. Part 4 items 1-9: remove x86 row and TGA resolution, formats, new photocraft-does-not-start page, mask label, taskbar workaround, wording, Affinity read-only, index.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(user): use the standard section title

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(user): describe PhotoCraft 0.7.0 startup behaviour

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(user): tighten PhotoCraft startup wording

Drop the unsourced "slower" claim for CPU mode and give the exact
Preferences path on Windows and macOS.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs: pin the docs checker to a commit and its SHA-256

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs: drop the docs workflows until the checker is on artcraft-services main

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs: re-verify against 0.8.2

- taskbar and PSD text pages: both fixes ship in 0.8.2; tell users to
  update and drop the "not in a release yet" wording and workarounds
- does not start: 0.8.2 fixes the Intel Iris Pro/Monterey Device(Lost)
  case; OpenCore Legacy Patcher Macs still have no fix
- install: Windows 10 or later, 32-bit Windows builds, RISC-V deb/rpm,
  Wayland paste and XWayland notice
- open and save: Krita and Paint.NET filters, Krita/PCX/FITS formats,
  save progress, JPEG/WebP encoding kept on Save
- export: TGA Resolution, multi-layer Export As and Quick Export
- text: Shift-click starts new text over existing type
- CLAUDE.md is now a regular file pointing to AGENTS.md
- verified: 0.8.2 on every page

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Drop the root AGENTS.md docs rule; keep the PR to docs/user/

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(user): drop the stale missing-tools count from the Photoshop FAQ

Re-verified the page against v0.9.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Fabio Lussi <198260595+itrycodinganditsbad@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 16:15:53 -06:00
Brian TandClaude Opus 5.5 ca69059dd0 Edit: Copy with no selection keeps fill and adjustment layers (#2344) (#7497)
Copy refused fill and adjustment layers ("the active layer has no
pixels"). With no pixel selection they are now taken whole, like smart
objects, type, shape and group layers, and Paste recreates them in this
or another document. An adjustment layer's clip spans the canvas, so
paste placement and the OS-clipboard mirror stay consistent.

Scorecard UI-217-23 note, gaps.md G9 and target-app-parity.md updated;
the row stays partial (a single pixel layer still copies pixels only).

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 17:23:26 -04:00
Nguyễn Minh Long 72a3423a7e Preferences: Enable Gestures off ignores touch-screen pinch and twist (#204) (#7478)
Edit > Preferences > Enhanced Controls > Enable Gestures (enhancedControls.touchGestures)
was saved but read by nothing, so it was hidden from the dialog. Now, with it off, two
fingers on a touch screen no longer zoom the canvas or the Navigator, nor turn the view.
The mouse and trackpad behave as before, including a trackpad pinch or Rotate event that
arrives while fingers rest on the screen.

- wheel_nav: pinch_factor() drops egui's multi-touch zoom when gestures are off and keeps
  the trackpad's own Event::Zoom (Windows' folded Ctrl + wheel pinch included);
  read_with() takes the preference.
- rotate_view: trackpad_delta() only falls back to the multi-touch rotation while gestures
  are on; Rotate events always count.
- canvas, Navigator: pass the preference through.
- prefs: touchGestures leaves HIDDEN_UNTIL_IMPLEMENTED, so the dialog shows it.
- Tests: synthetic two-finger pinch and twist, on and off, and the trackpad events with
  gestures off.
- docs/scorecard.md regenerated: settings that do nothing 26 -> 25 of 168.
2026-10-18 17:23:21 -04:00
Marco Arnulfo 8736098d38 Curves: Cmd/Ctrl-click on the image adds a point at the pixel's tone (#7473)
* Curves: Cmd/Ctrl-click on the image adds a point at the pixel's tone (part of #7325)

With Image > Adjustments > Curves open, a Cmd-click (Ctrl-click off the Mac) on
the image adds a point to the channel shown in the dialog, at the pixel's tone
and at the curve's current output there; Shift adds one point on each of Red,
Green and Blue. Only the press adds, an armed eyedropper still wins, and the
control channel's ui.pointer does the same with command: true.

* Curves: Cmd/Ctrl-click adds the point with the Hand tool too; Space and middle button still pan

The Hand tool took the Cmd-click press for a pan, so no point was added; the
press now counts before the Hand. On the control channel, ui.pointer with
space or the middle button pans as the mouse does instead of adding a point.

* Curves: the Cmd/Ctrl-click point's comment says where the curve can still change
2026-10-18 17:23:16 -04:00
JulienandClaude Opus 5.5 bbfeae98e4 Type: right-click on committed text opens the type layer menu (#7324) (#7430)
* Type: right-click on committed text opens the type layer menu (#7324)

With the Type tool, a right-click only opened a menu while text was being
edited; over committed type nothing opened. The menu was keyed on the edit
session alone (`editing_text`).

Over committed type, a Type tool (not a Type Mask tool) now opens
TYPE_LAYER_MENU: the type edit menu's layer rows, without the edit rows
(Undo, Cut, Copy, Paste, Select All), which would act on the document, and
without Faux Bold/Italic, which act on the characters being edited. Type
outside the selected layers becomes the target first, as a click with the
Type tool makes it. The control channel's right button takes the same path.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Type layer menu: the clicked type becomes the active layer in a multiselection (#7324)

The structural rows (Rasterize Type, Convert to Shape, Create Work Path, the
paragraph/point conversions) act on the active layer. When the right-clicked
type was already selected but another selected type layer was active, they
acted on that other layer. Make the clicked type the active layer while
keeping the selection (layer_multi_cmds::set_selection), so the formatting
rows still act on every selected type layer. Found by CodeRabbit on #7430.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 17:23:05 -04:00
Hector VillarrealandClaude Opus 5.5 cb85f77f5a Move tool: moving pixels again leaves no faint outline behind (#7538)
The shrunk selection took the moved pixels' alpha as its coverage, so
anti-aliased edges were only partly selected. Once the move was dropped
(changing layers, say), moving them again lifted a × a of each edge pixel and
left a × (1 − a) behind: up to 25 %, a faint outline where the shape had been.

The selection now keeps its own strength wherever the layer has pixels, so a
later move lifts edge pixels whole. Tested at 8, 16 and 32 bit: nothing is left
behind and the shape's total alpha is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 15:20:43 -06:00
Hector VillarrealandClaude Opus 5.5 5c7ca36f07 Move tool: transform controls and snapping frame the moved pixels too (#7538)
After a drag of selected pixels, Show Transform Controls still framed the
selection they were cut with, shifted by the drag, while the ants hugged the
pixels. Photoshop frames the pixels.

- The box frames a floating piece's outline (`transform_controls_rect`).
- Snapping starts before the press cuts the pixels, so the cut now retargets
  the move's box to their outline (`snap_ui::follow_cut`), for the Move tool
  and a selection tool's Cmd-drag. This replaces an estimate from the layer's
  bounds, which failed when the layer held other shapes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 15:20:43 -06:00
Hector VillarrealandClaude Opus 5.5 987753e76e Move tool: moving selected pixels shrinks the selection to them, as in Photoshop (#7538)
A marquee drawn loosely around an object on a transparent layer kept its
rectangle when the Move tool dragged the pixels. Photoshop shrinks the
marching ants to the pixels being moved as the drag starts: the selection
times the layer's transparency.

- Engine: the floating piece keeps its outline (`CutParts::outline`, the
  piece's alpha), and `select.drop` makes it the new selection. A mask,
  which has no transparency, and an empty piece keep the selection's shape.
- Canvas: a floating piece's ants follow that outline during the drag.
- Snapping and the move box use the moved pixels' bounds.

Tests at 8, 16 and 32 bit, Alt-drag copies, soft selections over
half-transparent pixels, the Background, a mask target and an empty piece.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 15:20:43 -06:00
skylar taylor-barrick 915779b948 Merge storytold/main into save-replace-metadata
No textual conflicts, but the merge did not compile. main's 589941a5 added a
second AtomicFs test impl using copy_permissions, while this branch renames that
trait method to copy_metadata. Git merged both cleanly because they sit in
different parts of the file, giving a tree whose trait and impl disagree:
E0407, E0046 and E0599 in photocraft-format's lib test. That one error is what
failed all four CI jobs.

main's new impl is renamed to copy_metadata to match.

Verified with --features heif, which is what CI builds with and what I had
previously failed to pass locally: clippy --workspace --all-targets --locked
--features heif -- -D warnings is clean, and the workspace tests pass.
2026-10-18 15:12:41 -06:00
Finn Newick 9e0d59576b Merge remote-tracking branch 'origin/main' into fix/bundle-save-lock 2026-10-18 22:01:04 +01:00
Finn NewickandClaude Opus 5.5 3c24fec507 fix(tiff): leave alpha channels to #7415, keep the tiffCompression option
#7415 writes and reads every TIFF alpha and spot channel with Photoshop's
channel resources, so this branch's single-alpha-channel handling would
only make the two rework the same decode and encode paths. The codec,
io, test and doc changes for it go back to main's versions; the
tiffCompression save parameter, the CLI --tiff-compression flag and their
test stay, and the format-parity TIFF row names the option.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 21:57:49 +01:00
Gustavo Ziger 1334534e10 Merge main into feat/zoom-animation-566 2026-10-18 17:49:07 -03:00