Commit Graph
2574 Commits
Author SHA1 Message Date
David MannandClaude Opus 5.5 f79a169651 Integration: one Actions row and the batch's event total in the file format parity page
The doc merge left five Actions rows that disagreed (version 12 unsupported vs read; 120 vs
127 events). Found by CodeRabbit on #10776.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 16:42:36 +01:00
Khawar Zamman Wani 582a285b5d fix: enforce scoped PSD memory admission and complete retry integration 2026-11-02 19:01:15 +05:30
David MannandClaude Opus 5.5 8caea149c1 Integration: regenerate docs/atn.md for the batch (144 supported events, settings each PR keeps)
Supported table read from the batch's events.rs. The PRs' own sections (settings and command
options retained, Render defaults, steps kept disabled) are kept; the known-gaps tables that
#10702 and #10704 close are gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 13:03:44 +01:00
Khawar Zamman Wani bcc060180f feat(io,engine,ui): adaptive PSD/PSB memory budget and interactive confirmation
- Distinguish available physical RAM from swap and commit headroom
- Adaptive soft and hard import thresholds with native fallback
- Interactive preflight confirmation modal before pixel decoding
- Headless and command parameters for explicit high-memory approval
- One-shot source-bound validation rejecting altered sources or degraded RAM
- Process-wide serialized decode gate with reentrancy support
- Documentation and synthetic regression test coverage
2026-11-02 17:11:03 +05:30
Trevor BrownandClaude Fable 5.1 dab1280b1b Layer Style: a drag on the image moves a Gradient Overlay (#10763)
With the dialog on a Gradient Overlay page, a drag on the image moves the gradient's centre (params.offset, a fraction of the layer's bounds) by the pointer's movement over the layer's size, as a drag moves a shadow. Tests in layer_style and gradient_overlay.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-02 05:57:36 -05:00
ljkxandClaude Opus 5.5 2d30a2b669 Gradient stops: the release frame decides drag-off; review fixes (#10742)
The Gradient Editor/Properties strip and Layer Style's Gradient Overlay
ramp ignored the release frame. When the last pointer move came in the
same frame as the release, the stop stayed in the state the previous
frame left it in. A stop flicked off the bar was kept, and one brought
back onto the bar at release was deleted. Both now apply the same
drag-off rule on that frame, as Gradient Map and the shape strip
already did.

The editor strip also counted opacity stops from its preview, which
already leaves a dragged-off stop out. So while an opacity stop was off
the bar, the preview flipped between deleting and moving it every
frame. It now counts the committed stops, like colour stops.

Tests: a quick release off the bar and back onto it (both editors);
colour stops dragged up and opacity stops dragged down are kept; a
cancelled Gradient Map drag adds no history step. The parity row names
Gradient Map's control "Remove stop".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 09:37:01 +01:00
ljkxandClaude Opus 5.5 dec95112a0 Remove gradient stops dragged off the bar in every stop editor (#10742)
Dragging a colour stop down, or an opacity stop up, by about a marker's
height off the gradient bar now removes it on release in every stop
editor, as in Photoshop's Gradient Editor. At least two stops of that
kind always stay. While the stop is off the bar the ramp and the
preview show it gone, and dragging it back onto the bar cancels.

The Gradient Editor, Properties and shape gradient strips already did
this. Gradient Map had no drag-off at all, and Layer Style's Gradient
Overlay only deleted after about 44 pt and showed nothing until
release. All four now share stop_dragged_off() in gradient_ui.rs
(26 pt past the bar edge, by kind). Gradient Map and Gradient Overlay
take the stop out live and put it back if it returns.

Adds harness tests for drag-off removal, the two-stop minimum,
opacity stops dragged up and drag-back cancel, and updates
docs/ui-parity.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 08:53:33 +01:00
ljkxandClaude Opus 5.5 1e71659736 Filter preview locator: let an open Crop drag finish under the dialog
ui.pointer's locator only stepped aside for a tool gesture in app.drag. The
Crop tool keeps its frame and Straighten drags in app.crop, so one begun
before a filter dialog opened lost its moves and release to the locator
and stayed open. Treat those as tool gestures too, with a test. The parity
row now scopes "never reaches the tool" to gestures the locator starts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 08:49:52 +01:00
Fabio Lissi b82a354718 Preserve explicit action sources and replay named spelling edits 2026-11-02 00:43:44 -06:00
Fabio Lissi 3191b89064 Preserve styled text and explicit layers in action replay 2026-11-02 00:25:07 -06:00
Fabio Lissi 85cb54025c Guard Batch outputs and preserve partial results 2026-11-01 23:56:10 -06:00
Fabio Lissi 03799b62bc Keep recorded layer targets portable across documents 2026-11-01 23:54:42 -06:00
yoriswind 1dfc6bfa34 Clarify the supported Batch RAW opening subset 2026-11-01 21:30:49 -08:00
yoriswind 4fc3b9ee83 Use supported saved RAW settings for noninteractive Batch opening 2026-11-01 21:29:19 -08:00
yoriswind d898e46030 Apply Batch profile policy without losing import diagnostics 2026-11-01 21:25:16 -08:00
Fabio Lissi 4eba6bd2e9 Merge current main and complete Batch automation options 2026-11-01 23:04:19 -06:00
Fabio Lissi 21c0444559 Merge current main and preserve portable action recording 2026-11-01 23:01:23 -06:00
yoriswind d656c0f6e1 Replay Batch Override Open with scoped input bindings 2026-11-01 21:00:59 -08:00
yoriswind a347e69ac7 Support same-source Batch Save and Close 2026-11-01 20:14:27 -08:00
yoriswind 60dba86c22 Report unsupported files in recorded Batch folders 2026-11-01 19:40:11 -08:00
yoriswind f3e5c63383 Clarify Batch error policies and measured Custom settings 2026-11-01 19:29:58 -08:00
ljkxandClaude Opus 5.5 93381b4b23 Merge remote-tracking branch 'origin/main' into feat/photo-filter-last-settings
Conflicts: adjust_dialog.rs body() keeps main's captured target and curve_mode_for_fields, then the once-per-opening Photo Filter mode reset; tests.rs keeps both sides' new tests; docs/ui-parity.md keeps main's status line with the #9879 entry prepended (dated 2026-11-02) and both sides' rows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 04:27:11 +01:00
yoriswind c60fc81fc3 Stop recorded parents after Batch file failures 2026-11-01 19:17:33 -08:00
ljkxandClaude Opus 5.5 0bdd9d67d6 Merge remote-tracking branch 'origin/main' into feat/smart-sharpen-canvas-preview
Conflicts: canvas.rs imports keep main's alt_picks and this PR's preview_locator_cursor;
handle_dialog_canvas_input merged cleanly. docs/ui-parity.md keeps main's status line with
this PR's entry prepended and both sides' rows; the PR's change-log row is redated 2026-11-02.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 04:08:17 +01:00
yoriswind 6e2ae5f82b Honor recorded Batch Stop For Errors policy 2026-11-01 19:03:44 -08:00
yoriswind 3746a341e4 Preserve implicit white Artboard backgrounds in actions 2026-11-01 18:34:08 -08:00
dotCooCoo 67bdb204da Merge main into feat/equalize-entire-image 2026-11-01 18:25:41 -08:00
David Mann 79a2a4e15f Merge PR #10632: Actions: map all 47 Filter Gallery effects (#10592)
With our fix-up 023e2662d7 on top of the author's head. Conflicts resolved item by item (Rust), docs as unions.
2026-11-02 03:18:45 +01:00
ljkx ec5a2bcaed Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	docs/file-format-parity.md
2026-11-02 03:17:35 +01:00
ljkx 2d3b27f00a Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	docs/ui-parity.md
2026-11-02 03:16:51 +01:00
David Mann 520a996b30 Merge PR #10630: Actions: map Photoshop's Split Channels, Merge Spot Channel, Trap and Match Color steps (#10609)
With our fix-up a299bf9f6c on top of the author's head. Conflicts resolved item by item (Rust), docs as unions.
2026-11-02 03:15:28 +01:00
David Mann 496d9f3623 Merge PR #10618: Map Stylize and Pixelate action events
With our fix-up 52cc86351b on top of the author's head. Conflicts resolved item by item (Rust), docs as unions; docs/atn.md regenerated at the end.
2026-11-02 03:10:21 +01:00
David Mann 5d6041c1cd Merge PR #10628: Map selection, clipboard and layer-operation ATN events
With our fix-up 0e41091687 on top of the author's head. Conflicts resolved item by item (Rust), docs as unions; docs/atn.md regenerated at the end.
2026-11-02 02:55:08 +01:00
David Mann 4f899196cb Merge PR #10702: Actions: preserve settings in mapped ATN events
With our fix-up 78cf0cf91f on top of the author's head. Conflicts resolved item by item (Rust), docs as unions; docs/atn.md regenerated at the end.
2026-11-02 02:55:02 +01:00
0e41091687 Integration: Group F steps recorded by the reference application map (#10628)
The Group F loader only mapped descriptors with an empty name and class
`null`, and nested shapes with an empty name. The reference application
names every step descriptor after the localized step (plus NUL), uses
the event code as its class and names nested shapes too, so every real
recorded Add To / Fade / Merge Layers ... step stayed a kept step and
never played (e.g. `addTo` with name "Add To\0", class `AddT` and a
nested `Rctn` named "\0"). The header is no longer checked; the shape
is matched by class only; key, order and enum checks stay strict.

IntW, Dstr and MrgL were registered with the string IDs
`interfaceWhite`, `distort` and none; the real ones are
`intersectWith`, `distribute` and `mergeLayers`, so steps written with
them stayed kept.

Co-authored-by: yoriswind <164435053+yoriswind@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 02:50:33 +01:00
yoriswind 7b0d68c8e3 Fix Artboard action round trips and singleton links 2026-11-01 17:48:22 -08:00
David Mann d570b77abb Merge PR #10753: Support recorded layer, document and layer comp references
With our fix-up ea4112a4ce on top of the author's head 686f08c884. docs/atn.md kept from the batch (regenerated at the end); development.md and parity doc rows as unions.
2026-11-02 02:40:55 +01:00
yoriswind 8650391c05 Extend recorded Batch naming and preserve its image format
Add all measured naming components, nested starting serial, compatibility flags, complete-step refusal for unknown settings and exact descriptor retention. Keep literal text and extension placement separate from image encoding, and preserve the legacy native template, save snapshots and output protections. Reuse only the serial-letter helper from #4579 by @FabioLissi at 720a1e4b9c, with Adobe's independent letter counter. Unsupported Batch routing and Alias forms remain explicit gaps; combined validation is pending.
2026-11-01 17:18:38 -08:00
David Mann 48b0e221cd Merge PR #10627: Actions: map Photoshop's newer-feature steps (Oil Paint, Smart Sharpen, Focus Area, Sky, Remove Background) (#10610)
With our fix-up 6ab24508d8 on top of the author's head 8988b6bfd0. Conflicts resolved: import lists as unions (bare_from/bare_to taken from steps_other, #10631), event table, tests and parity doc rows as unions.
2026-11-02 02:16:45 +01:00
David Mann 5bc852379a Merge PR #10743: Read Photoshop Actions version 12 descriptors
With our fix-up 1f524c378b on top of the author's head 713aa92ba5. Resolved with main: the version check sits in main's parse_layout (it merged cleanly); doc comments combined; atn_contract no longer expects version 12 to be refused and pins that an empty version 12 set parses; one ATTRIBUTION row for all ATN fixtures; the fixture README states which files were encoded how; development.md no longer counts the fixtures.
2026-11-02 02:13:56 +01:00
6ab24508d8 Integration: .atn Oil Paint/Smart Sharpen clamp on import, Smart Sharpen maps the Gaussian form (#10627)
Out-of-range Oil Paint and Smart Sharpen settings kept the step as a
Photoshop step; the reference application clamps them when the step
plays, so the import now clamps (stylization 10.5 -> 10, Amnt 500.5 % ->
500, Rds 0.05 px -> 0.1). Export still refuses out-of-range params.

Oil Paint's light direction (LghD) had no range: LghD 500 mapped and
saved back as 500. It now clamps to the command's -180..180 on import
(500 -> 180) and export refuses {"angle": 181}.

Smart Sharpen mapped the legacy Lens Blur form, which the command's
Gaussian sharpen does not play, and wrote every step as legacy Lens
Blur. It now follows the PSD smart-filter mapping (photocraft-io
smart_map): only useLegacy false + blur GsnB maps (noiseReduction ->
reduceNoise); the reference default (useLegacy true, lensBlur), Motion
Blur and legacy steps stay Photoshop steps; export writes useLegacy
false, Amnt, Rds, noiseReduction, blur GsnB.

Co-authored-by: hectorviov <1501713+hectorviov@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 02:13:01 +01:00
yoriswind bf63a6639f Integrate recorded Custom and Fibers filter mappings
Adapt only Custom from #10631 by @hectorviov at 4ed3f5b591 and Fibers from #10620 at 33ee38b431. Retain the measured ranges and whole unsupported descriptors without importing unrelated filters. Source and fixtures only; combined validation remains.
2026-11-01 17:05:28 -08:00
David Mann cafaabcf04 Merge PR #10631: Actions: map Photoshop's De-Interlace, NTSC, HSB/HSL, Custom, Average and matting steps (#10607)
With our fix-up 632a62b554 on top of the author's head 4ed3f5b591. Conflicts resolved as unions (module list, event table, tests, parity doc rows).
2026-11-02 02:03:24 +01:00
David Mann 2d332d3ba5 Merge PR #10629: Actions: map Photoshop's Distort filter steps (Pinch, Polar Coordinates, Spherize, Twirl, Wave, ZigZag) (#10605)
With our fix-up 363e0f5e89 on top of the author's head 244082fb2c. Conflicts with main resolved as unions (new tests next to main's; parity doc revision rows).
2026-11-02 02:02:03 +01:00
yoriswind c78b84a1cd Port CSH import backend while retaining recorded shape IDs
Port the ten backend, automation and test paths from #5493 by
@jonathanwxh-cell, pinned at 43920ab780.
Keep its original CSH codec, bounded preset reader and protection tests.
The prerequisite's UI, translation and parity-document changes are excluded.

Adapt ShapePreset construction to retain the exact source identifier. Empty
identifiers remain anonymous presets; repeated identifiers resolve when their
geometry is identical and refuse resolution when it conflicts. Add one
import-to-ATN Shape Blur regression and document the source attribution.

Original contribution: https://github.com/storytold/photocraft/pull/5493
Source-only integration; compilation and combined runtime validation remain.
2026-11-01 17:01:17 -08:00
yoriswind ed71465b89 Apply measured Artboard background settings without resizing 2026-11-01 16:58:20 -08:00
yoriswind 609d839607 Cover nonlinear 3DL shapers through action playback 2026-11-01 16:55:31 -08:00
David Mann 5a99af60d7 Merge PR #10620: Map Render filter steps in Photoshop actions 2026-11-02 01:54:44 +01:00
yoriswind 863597ba90 Merge remote-tracking branch 'origin/main' into codex/atn-missing-action-events 2026-11-01 16:53:50 -08:00
yoriswind d752b8a3a2 Add embedded LUT and custom shape action support 2026-11-01 16:46:48 -08:00